René's URL Explorer Experiment


Title: Preserve complete stopped responses and cancel unfinished tools by Sg312 · Pull Request #8259 · simstudioai/sim · GitHub

Open Graph Title: Preserve complete stopped responses and cancel unfinished tools by Sg312 · Pull Request #8259 · simstudioai/sim

X Title: Preserve complete stopped responses and cancel unfinished tools by Sg312 · Pull Request #8259 · simstudioai/sim

Description: Summary Stop could mistake a contiguous Redis prefix for the full response and persist it before the run owner flushed its tail. Replay now requires the actor's matching chat/run, a terminal run status, and contiguous events through the final completion event. Active, missing, mismatched, and incomplete runs defer to their canonical finalizer. Stopped responses also mark unfinished tools cancelled, including when a cancelled completion block already exists. This closes the persistence findings from #8257 while retaining its identifiers-only Stop request and queued-edit protection. Type of Change Bug fix New feature Breaking change Documentation Other Testing 178 Stop, queued-send, persistence, abort, and authorization regressions passed before adding two explicit immutable tool-cancellation cases; all 56 persistence tests passed after those additions. App type checking, Biome, and API validation audit pass. Regression cases cover an 11 MiB response, unfinished contiguous replay, mismatched or active runs before any Redis read, and cancelled tools after reload. Browser automation is unavailable because its runtime exits during initialization. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary Stop could mistake a contiguous Redis prefix for the full response and persist it before the run owner flushed its tail. Replay now requires the actor's matching chat/run, a terminal ru...

X Description: Summary Stop could mistake a contiguous Redis prefix for the full response and persist it before the run owner flushed its tail. Replay now requires the actor's matching chat/run, a termina...

Opengraph URL: https://github.com/simstudioai/sim/pull/8259

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:a0e68768-6f47-4754-856b-287b1a1bd2b4
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id81FE:1C9B42:1751B9:20A286:6AFB784C
html-safe-nonce9acf3f85c2d522709328dcf34495ff785cbe484c26653b5ca2a6fbe32b993c74
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MUZFOjFDOUI0MjoxNzUxQjk6MjBBMjg2OjZBRkI3ODRDIiwidmlzaXRvcl9pZCI6IjI3OTU4MTgxNTQzNTYwNzg2NjgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacee7523b796b4c9942457e425e2d04beebe711c14d0392df7b8f047b5f6b536dc
hovercard-subject-tagpull_request:4630266990
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/8259/files
twitter:imagehttps://avatars.githubusercontent.com/u/33737564?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/33737564?s=400&v=4
og:image:altSummary Stop could mistake a contiguous Redis prefix for the full response and persist it before the run owner flushed its tail. Replay now requires the actor's matching chat/run, a terminal ru...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None0e29e7974fdda2feeaf5c891efd4b23b0734b23480232b62c7bdef13f40b5b48
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2e8872b770cc4d5d0cc1f2026afab747a268e2ce
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/8259/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F8259%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F8259%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/8259/files
Reloadhttps://github.com/simstudioai/sim/pull/8259/files
Reloadhttps://github.com/simstudioai/sim/pull/8259/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests201 (201)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
Sg312https://github.com/Sg312
staginghttps://github.com/simstudioai/sim/tree/staging
fix/staging-stop-terminal-replayhttps://github.com/simstudioai/sim/tree/fix/staging-stop-terminal-replay
Conversation 6 https://github.com/simstudioai/sim/pull/8259
Commits 1 https://github.com/simstudioai/sim/pull/8259/commits
Checks 33 https://github.com/simstudioai/sim/pull/8259/checks
Files changed https://github.com/simstudioai/sim/pull/8259/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8259/files
Preserve complete stopped responses and cancel unfinished tools https://github.com/simstudioai/sim/pull/8259/files#top
Show all changes 1 commit https://github.com/simstudioai/sim/pull/8259/files
d5b26f4 Finalize stopped replay only after the owned stream completes Sg312 Sep 24, 2026 https://github.com/simstudioai/sim/pull/8259/commits/d5b26f4ef635c039b1b1e2925cead5d16519f616
Clear filters https://github.com/simstudioai/sim/pull/8259/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8259/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8259/files
route.test.ts https://github.com/simstudioai/sim/pull/8259/files#diff-25e56b901bed20865fca2905d8f251f4f0d1c4bbc17c46f173fbab128d2779bf
route.ts https://github.com/simstudioai/sim/pull/8259/files#diff-00ba96719244515f66d008445653a56f0fd77d63ef904626ec44054e81502e82
persisted-message.test.ts https://github.com/simstudioai/sim/pull/8259/files#diff-239f9d0985dfc739b3e9e7ec56af1f316a2048eade672168c0c69eb518a7b9e9
persisted-message.ts https://github.com/simstudioai/sim/pull/8259/files#diff-1faeecc19a448ec1a06d94e9f15173be80eef721479b80608fa0b961eff2b280
terminal-state.test.ts https://github.com/simstudioai/sim/pull/8259/files#diff-d6d907c25f5980af308fbe11415f486e963ce624a0afeb08292caf6bfa9417ff
terminal-state.ts https://github.com/simstudioai/sim/pull/8259/files#diff-bb3f035fc585c61b1d6f21f39aa13b20b2ca2e4054a804850414a5e1f6258a74
apps/sim/app/api/copilot/chat/stop/route.test.tshttps://github.com/simstudioai/sim/pull/8259/files#diff-25e56b901bed20865fca2905d8f251f4f0d1c4bbc17c46f173fbab128d2779bf
View file https://github.com/simstudioai/sim/blob/d5b26f4ef635c039b1b1e2925cead5d16519f616/apps/sim/app/api/copilot/chat/stop/route.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8259/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8259/files#diff-25e56b901bed20865fca2905d8f251f4f0d1c4bbc17c46f173fbab128d2779bf
https://github.com/simstudioai/sim/pull/8259/files#diff-25e56b901bed20865fca2905d8f251f4f0d1c4bbc17c46f173fbab128d2779bf
https://github.com/simstudioai/sim/pull/8259/files#diff-25e56b901bed20865fca2905d8f251f4f0d1c4bbc17c46f173fbab128d2779bf
https://github.com/simstudioai/sim/pull/8259/files#diff-25e56b901bed20865fca2905d8f251f4f0d1c4bbc17c46f173fbab128d2779bf
https://github.com/simstudioai/sim/pull/8259/files#diff-25e56b901bed20865fca2905d8f251f4f0d1c4bbc17c46f173fbab128d2779bf
https://github.com/simstudioai/sim/pull/8259/files#diff-25e56b901bed20865fca2905d8f251f4f0d1c4bbc17c46f173fbab128d2779bf
https://github.com/simstudioai/sim/pull/8259/files#diff-25e56b901bed20865fca2905d8f251f4f0d1c4bbc17c46f173fbab128d2779bf
apps/sim/app/api/copilot/chat/stop/route.tshttps://github.com/simstudioai/sim/pull/8259/files#diff-00ba96719244515f66d008445653a56f0fd77d63ef904626ec44054e81502e82
View file https://github.com/simstudioai/sim/blob/d5b26f4ef635c039b1b1e2925cead5d16519f616/apps/sim/app/api/copilot/chat/stop/route.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8259/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8259/files#diff-00ba96719244515f66d008445653a56f0fd77d63ef904626ec44054e81502e82
https://github.com/simstudioai/sim/pull/8259/files#diff-00ba96719244515f66d008445653a56f0fd77d63ef904626ec44054e81502e82
apps/sim/lib/mothership/chat/persisted-message.test.tshttps://github.com/simstudioai/sim/pull/8259/files#diff-239f9d0985dfc739b3e9e7ec56af1f316a2048eade672168c0c69eb518a7b9e9
View file https://github.com/simstudioai/sim/blob/d5b26f4ef635c039b1b1e2925cead5d16519f616/apps/sim/lib/mothership/chat/persisted-message.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8259/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8259/files#diff-239f9d0985dfc739b3e9e7ec56af1f316a2048eade672168c0c69eb518a7b9e9
greptile-appshttps://github.com/apps/greptile-apps
Sep 24, 2026https://github.com/simstudioai/sim/pull/8259/files#r4097804660
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://github.com/simstudioai/sim/pull/8259/files
sourcehttps://github.com/simstudioai/sim/blob/main/.cursor/rules/sim-imports.mdc
Please reload this pagehttps://github.com/simstudioai/sim/pull/8259/files
https://github.com/simstudioai/sim/pull/8259/files#diff-239f9d0985dfc739b3e9e7ec56af1f316a2048eade672168c0c69eb518a7b9e9
apps/sim/lib/mothership/chat/persisted-message.tshttps://github.com/simstudioai/sim/pull/8259/files#diff-1faeecc19a448ec1a06d94e9f15173be80eef721479b80608fa0b961eff2b280
View file https://github.com/simstudioai/sim/blob/d5b26f4ef635c039b1b1e2925cead5d16519f616/apps/sim/lib/mothership/chat/persisted-message.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8259/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8259/files#diff-1faeecc19a448ec1a06d94e9f15173be80eef721479b80608fa0b961eff2b280
greptile-appshttps://github.com/apps/greptile-apps
Sep 24, 2026https://github.com/simstudioai/sim/pull/8259/files#r4097787787
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://github.com/simstudioai/sim/pull/8259/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8259/files
greptile-appshttps://github.com/apps/greptile-apps
Sep 24, 2026https://github.com/simstudioai/sim/pull/8259/files#r4097804652
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://github.com/simstudioai/sim/pull/8259/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8259/files
https://github.com/simstudioai/sim/pull/8259/files#diff-1faeecc19a448ec1a06d94e9f15173be80eef721479b80608fa0b961eff2b280
https://github.com/simstudioai/sim/pull/8259/files#diff-1faeecc19a448ec1a06d94e9f15173be80eef721479b80608fa0b961eff2b280
apps/sim/lib/mothership/chat/terminal-state.test.tshttps://github.com/simstudioai/sim/pull/8259/files#diff-d6d907c25f5980af308fbe11415f486e963ce624a0afeb08292caf6bfa9417ff
View file https://github.com/simstudioai/sim/blob/d5b26f4ef635c039b1b1e2925cead5d16519f616/apps/sim/lib/mothership/chat/terminal-state.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8259/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8259/files#diff-d6d907c25f5980af308fbe11415f486e963ce624a0afeb08292caf6bfa9417ff
https://github.com/simstudioai/sim/pull/8259/files#diff-d6d907c25f5980af308fbe11415f486e963ce624a0afeb08292caf6bfa9417ff
https://github.com/simstudioai/sim/pull/8259/files#diff-d6d907c25f5980af308fbe11415f486e963ce624a0afeb08292caf6bfa9417ff
https://github.com/simstudioai/sim/pull/8259/files#diff-d6d907c25f5980af308fbe11415f486e963ce624a0afeb08292caf6bfa9417ff
apps/sim/lib/mothership/chat/terminal-state.tshttps://github.com/simstudioai/sim/pull/8259/files#diff-bb3f035fc585c61b1d6f21f39aa13b20b2ca2e4054a804850414a5e1f6258a74
View file https://github.com/simstudioai/sim/blob/d5b26f4ef635c039b1b1e2925cead5d16519f616/apps/sim/lib/mothership/chat/terminal-state.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8259/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8259/files#diff-bb3f035fc585c61b1d6f21f39aa13b20b2ca2e4054a804850414a5e1f6258a74
https://github.com/simstudioai/sim/pull/8259/files#diff-bb3f035fc585c61b1d6f21f39aa13b20b2ca2e4054a804850414a5e1f6258a74
greptile-appshttps://github.com/apps/greptile-apps
Sep 24, 2026https://github.com/simstudioai/sim/pull/8259/files#r4097787798
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://github.com/simstudioai/sim/pull/8259/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8259/files
https://github.com/simstudioai/sim/pull/8259/files#diff-bb3f035fc585c61b1d6f21f39aa13b20b2ca2e4054a804850414a5e1f6258a74
https://github.com/simstudioai/sim/pull/8259/files#diff-bb3f035fc585c61b1d6f21f39aa13b20b2ca2e4054a804850414a5e1f6258a74
https://github.com/simstudioai/sim/pull/8259/files#diff-bb3f035fc585c61b1d6f21f39aa13b20b2ca2e4054a804850414a5e1f6258a74
Please reload this pagehttps://github.com/simstudioai/sim/pull/8259/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.