René's URL Explorer Experiment


Title: fix(file-search): recover dispatch claims abandoned between commit and enqueue by icecrasher321 · Pull Request #8209 · simstudioai/sim · GitHub

Open Graph Title: fix(file-search): recover dispatch claims abandoned between commit and enqueue by icecrasher321 · Pull Request #8209 · simstudioai/sim

X Title: fix(file-search): recover dispatch claims abandoned between commit and enqueue by icecrasher321 · Pull Request #8209 · simstudioai/sim

Description: Summary Dispatch claims commit before Trigger.dev accepts their runs. A dispatcher that stopped in between, for example killed at its 60-second limit while PostgreSQL was still committing (a commit wait is not bounded by statement_timeout), left claims that no run would finish, and they held their workspace's two slots until the six-hour stale reaper. Each claim now carries handoff_expires_at (additive nullable column, PostgreSQL clock), set to twice the dispatcher's maximum duration when claimed and cleared once a run is known to exist: Trigger.dev accepted the batch, or the worker began the build. The next dispatch releases a claim whose deadline lapsed and claims the file again under a new token; the existing token fencing turns any late or duplicate run into a no-op. The handoff write runs in a bounded transaction and skips rows another transaction holds, so it cannot stall runs beginning their build or deadlock with bulk file changes; a failed write is only logged and never releases claims. Claims released for a lapsed deadline are logged and counted in the dispatch result, and a run that no longer owns its revision logs it. NULL means no pending handoff, so legacy claims and claims from the still-deployed dispatcher keep the six-hour window across the migrate → app → Trigger promotion order. In-process dispatch (no Trigger.dev) still clears the deadline when it schedules work in memory, so a restart there keeps the six-hour window; the README says so. Kept in the dispatcher rather than the transactional outbox: the dispatcher already reconciles these claims every minute, and an outbox event would add a second record with its own retry and dead-letter lifecycle to keep in step with the claim. Type of Change Bug fix Testing 192 file-search unit tests; 72 PostgreSQL 17 integration tests under TZ=America/Los_Angeles (one optional benchmark skipped), covering release after the deadline, enqueued claims kept through the stale window, a token-fenced handoff write, a locked claim skipped instead of waited on, and a failed handoff write keeping its claims. 12 mutants of the fix (reaper predicate, token filter, lock waiting, deadline units, counts, worker completion) each fail a test. End-to-end on PostgreSQL 17: stalled commits with an unreachable synchronous standby and killed the dispatcher client mid-commit. Without the fix the workspace stayed frozen past two minutes; with it, the first dispatch after the deadline re-dispatched the files. Full lint, app type check, all 47 audits, block-registry check, docs-manifest check, check:migrations origin/staging, and check:api-validation. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary Dispatch claims commit before Trigger.dev accepts their runs. A dispatcher that stopped in between, for example killed at its 60-second limit while PostgreSQL was still committing (a commi...

X Description: Summary Dispatch claims commit before Trigger.dev accepts their runs. A dispatcher that stopped in between, for example killed at its 60-second limit while PostgreSQL was still committing (a commi...

Opengraph URL: https://github.com/simstudioai/sim/pull/8209

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:7b01660b-7ada-65ae-5193-d316e065e43b
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA388:23CE74:15B598A:1DBABCF:6AFB79CD
html-safe-nonce6b4c121f04ee73e42193b2c2a6500f2082d8824a0ca864626f120b9e7ee3a67a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMzg4OjIzQ0U3NDoxNUI1OThBOjFEQkFCQ0Y6NkFGQjc5Q0QiLCJ2aXNpdG9yX2lkIjoiMjc4MzcxNDk1Nzk5MDc4NzUzNCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmaca7b52e24baf2c6389a00fd6082e02bd8ae84fbc90ad8376de4de6656c6e5bb76
hovercard-subject-tagpull_request:4617692955
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/8209/files
twitter:imagehttps://avatars.githubusercontent.com/u/17950982?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/17950982?s=400&v=4
og:image:altSummary Dispatch claims commit before Trigger.dev accepts their runs. A dispatcher that stopped in between, for example killed at its 60-second limit while PostgreSQL was still committing (a commi...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None0e29e7974fdda2feeaf5c891efd4b23b0734b23480232b62c7bdef13f40b5b48
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2e8872b770cc4d5d0cc1f2026afab747a268e2ce
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/8209/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F8209%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F8209%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/8209/files
Reloadhttps://github.com/simstudioai/sim/pull/8209/files
Reloadhttps://github.com/simstudioai/sim/pull/8209/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests202 (202)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
icecrasher321https://github.com/icecrasher321
staginghttps://github.com/simstudioai/sim/tree/staging
fix/file-search-dispatch-handoffhttps://github.com/simstudioai/sim/tree/fix/file-search-dispatch-handoff
Conversation 5 https://github.com/simstudioai/sim/pull/8209
Commits 3 https://github.com/simstudioai/sim/pull/8209/commits
Checks 33 https://github.com/simstudioai/sim/pull/8209/checks
Files changed https://github.com/simstudioai/sim/pull/8209/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8209/files
fix(file-search): recover dispatch claims abandoned between commit and enqueue https://github.com/simstudioai/sim/pull/8209/files#top
Show all changes 3 commits https://github.com/simstudioai/sim/pull/8209/files
0356a29 fix(file-search): recover dispatch claims abandoned between commit an… Sep 23, 2026 https://github.com/simstudioai/sim/pull/8209/commits/0356a296a15254998341f33ce4a3b686d1e83d4c
f257770 Merge staging into fix/file-search-dispatch-handoff Sep 24, 2026 https://github.com/simstudioai/sim/pull/8209/commits/f25777045cd20e74f444240e8ace0e3390923b20
2d91ec9 chore(db): format dispatch handoff migration snapshot Sep 24, 2026 https://github.com/simstudioai/sim/pull/8209/commits/2d91ec9964ad0fc0d6ccb876b8877fca826eb944
Clear filters https://github.com/simstudioai/sim/pull/8209/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8209/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8209/files
README.md https://github.com/simstudioai/sim/pull/8209/files#diff-625b017042a1d9a671673d8b7077f6f7e4513b30970b08b008bf9fb670f641c4
chunks.integration.ts https://github.com/simstudioai/sim/pull/8209/files#diff-1fad4c2aca071eb8a4b477c529687858aacdd570efedc2dca4180d0c7a18cb78
constants.ts https://github.com/simstudioai/sim/pull/8209/files#diff-25abdafbc319ad195e37055eeebf63e23f0a8d6294ed87fbb6726afb3496a9eb
dispatcher.integration.ts https://github.com/simstudioai/sim/pull/8209/files#diff-5f580fffd39ddd529ae710b571e855f28636a56713b8d9f1889d03127d070e02
dispatcher.test.ts https://github.com/simstudioai/sim/pull/8209/files#diff-f060ecaedf726b5340b840b2f369d59b82ad3ec45f72019d8a956e6f168fe88b
dispatcher.ts https://github.com/simstudioai/sim/pull/8209/files#diff-6683656d968a1a183bf327531c469e9b0b8eea626f303f8482a0504340be2d1d
index-state.ts https://github.com/simstudioai/sim/pull/8209/files#diff-1fc4408f29d8c373126b9cbfd29d6e8e33a65830fa6f497662476876a0c68066
indexing.test.ts https://github.com/simstudioai/sim/pull/8209/files#diff-c249013d04ffb4863b1d681bc0fe515b63b44d6e86e16132c190da22d25aef42
indexing.ts https://github.com/simstudioai/sim/pull/8209/files#diff-73f6acb47b67368aff1036891dee7569337b858f789f18a8d98a59eea79154f1
0382_workspace_file_search_dispatch_handoff.sql https://github.com/simstudioai/sim/pull/8209/files#diff-03afc6c5e13b159a6b2371e22bd88a32e13a5a597c80c31aa9acd90b405fcca3
0382_snapshot.json https://github.com/simstudioai/sim/pull/8209/files#diff-809491301eb478554318634ce88ed328965ed27e2ef2f66dc30290ccb3efefb9
_journal.json https://github.com/simstudioai/sim/pull/8209/files#diff-37150cc65ad16ee6fbc5fa318fc096be7730e16d63eaf863e3df5521b7030649
schema.ts https://github.com/simstudioai/sim/pull/8209/files#diff-9a959e2ce3cb4c86957bbae021d06eae364f7b0cb18964f5873bab53220af928
schema.mock.ts https://github.com/simstudioai/sim/pull/8209/files#diff-3b648ee44a059e5fc069169fdfd7c32c89200a3e79b5d0dc25227d3470da73af
apps/sim/lib/workspace-files/search/README.mdhttps://github.com/simstudioai/sim/pull/8209/files#diff-625b017042a1d9a671673d8b7077f6f7e4513b30970b08b008bf9fb670f641c4
View file https://github.com/simstudioai/sim/blob/2d91ec9964ad0fc0d6ccb876b8877fca826eb944/apps/sim/lib/workspace-files/search/README.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8209/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8209/files#diff-625b017042a1d9a671673d8b7077f6f7e4513b30970b08b008bf9fb670f641c4
https://github.com/simstudioai/sim/pull/8209/files#diff-625b017042a1d9a671673d8b7077f6f7e4513b30970b08b008bf9fb670f641c4
apps/sim/lib/workspace-files/search/chunks.integration.tshttps://github.com/simstudioai/sim/pull/8209/files#diff-1fad4c2aca071eb8a4b477c529687858aacdd570efedc2dca4180d0c7a18cb78
View file https://github.com/simstudioai/sim/blob/2d91ec9964ad0fc0d6ccb876b8877fca826eb944/apps/sim/lib/workspace-files/search/chunks.integration.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8209/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8209/files#diff-1fad4c2aca071eb8a4b477c529687858aacdd570efedc2dca4180d0c7a18cb78
https://github.com/simstudioai/sim/pull/8209/files#diff-1fad4c2aca071eb8a4b477c529687858aacdd570efedc2dca4180d0c7a18cb78
https://github.com/simstudioai/sim/pull/8209/files#diff-1fad4c2aca071eb8a4b477c529687858aacdd570efedc2dca4180d0c7a18cb78
https://github.com/simstudioai/sim/pull/8209/files#diff-1fad4c2aca071eb8a4b477c529687858aacdd570efedc2dca4180d0c7a18cb78
https://github.com/simstudioai/sim/pull/8209/files#diff-1fad4c2aca071eb8a4b477c529687858aacdd570efedc2dca4180d0c7a18cb78
https://github.com/simstudioai/sim/pull/8209/files#diff-1fad4c2aca071eb8a4b477c529687858aacdd570efedc2dca4180d0c7a18cb78
apps/sim/lib/workspace-files/search/constants.tshttps://github.com/simstudioai/sim/pull/8209/files#diff-25abdafbc319ad195e37055eeebf63e23f0a8d6294ed87fbb6726afb3496a9eb
View file https://github.com/simstudioai/sim/blob/2d91ec9964ad0fc0d6ccb876b8877fca826eb944/apps/sim/lib/workspace-files/search/constants.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8209/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8209/files#diff-25abdafbc319ad195e37055eeebf63e23f0a8d6294ed87fbb6726afb3496a9eb
https://github.com/simstudioai/sim/pull/8209/files#diff-25abdafbc319ad195e37055eeebf63e23f0a8d6294ed87fbb6726afb3496a9eb
apps/sim/lib/workspace-files/search/dispatcher.integration.tshttps://github.com/simstudioai/sim/pull/8209/files#diff-5f580fffd39ddd529ae710b571e855f28636a56713b8d9f1889d03127d070e02
View file https://github.com/simstudioai/sim/blob/2d91ec9964ad0fc0d6ccb876b8877fca826eb944/apps/sim/lib/workspace-files/search/dispatcher.integration.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8209/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8209/files#diff-5f580fffd39ddd529ae710b571e855f28636a56713b8d9f1889d03127d070e02
https://github.com/simstudioai/sim/pull/8209/files#diff-5f580fffd39ddd529ae710b571e855f28636a56713b8d9f1889d03127d070e02
https://github.com/simstudioai/sim/pull/8209/files#diff-5f580fffd39ddd529ae710b571e855f28636a56713b8d9f1889d03127d070e02
https://github.com/simstudioai/sim/pull/8209/files#diff-5f580fffd39ddd529ae710b571e855f28636a56713b8d9f1889d03127d070e02
https://github.com/simstudioai/sim/pull/8209/files#diff-5f580fffd39ddd529ae710b571e855f28636a56713b8d9f1889d03127d070e02
https://github.com/simstudioai/sim/pull/8209/files#diff-5f580fffd39ddd529ae710b571e855f28636a56713b8d9f1889d03127d070e02
https://github.com/simstudioai/sim/pull/8209/files#diff-5f580fffd39ddd529ae710b571e855f28636a56713b8d9f1889d03127d070e02
https://github.com/simstudioai/sim/pull/8209/files#diff-5f580fffd39ddd529ae710b571e855f28636a56713b8d9f1889d03127d070e02
Please reload this pagehttps://github.com/simstudioai/sim/pull/8209/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8209/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.