Title: improvement(ui): use standard knowledge tag icon size by BillLeoutsakosvl346 · Pull Request #8136 · simstudioai/sim · GitHub
Open Graph Title: improvement(ui): use standard knowledge tag icon size by BillLeoutsakosvl346 · Pull Request #8136 · simstudioai/sim
X Title: improvement(ui): use standard knowledge tag icon size by BillLeoutsakosvl346 · Pull Request #8136 · simstudioai/sim
Description: Summary Use the existing Button size="icon" for knowledge tag removal, replacing local size-4 p-0 overrides. Preserve labels, callbacks, keyboard guards, propagation handling and the destructive muted variant. The hit area grows from 16px to 20px; the 12px glyph stays unchanged. Standard corners become 4px and stroke becomes 1.25px. Resting gray and red hover color remain unchanged. Tag rows grow from 37px to 38px. Validation Workspace types, lint, import/API audits, registry and generated-document checks pass; the complete EMCN suite passes. Full scanner removes both targeted findings (926 → 924 total findings); the actual-parent diff checker reports zero introduced findings. No policy or suppression changes. Browser checks cover before/after light/dark, destructive hover, long-label fit and removal by click/Enter/Space without row activation. Screenshots use labelled fixtures rendering the actual product component and consumer event guards; no live tag deletion was performed. Comparison images are attached below. Final full-source scan removes all 2 targeted findings; actual-parent diff checker reports zero new findings. No linter changes or suppressions. Before/after screenshots include labelled actual-component fixtures and documented end-to-end limitations. Full build/test CI passed on 853707cf6be4177075582285b148937e0da521ad.
Open Graph Description: Summary Use the existing Button size="icon" for knowledge tag removal, replacing local size-4 p-0 overrides. Preserve labels, callbacks, keyboard guards, propagation handling and the dest...
X Description: Summary Use the existing Button size="icon" for knowledge tag removal, replacing local size-4 p-0 overrides. Preserve labels, callbacks, keyboard guards, propagation handling and ...
Opengraph URL: https://github.com/simstudioai/sim/pull/8136
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:96c0be6d-9eb8-7cfc-7d37-ab14d84733b6 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E41A:37E613:11896FF:182F6F7:6AFB6F4F |
| html-safe-nonce | 1560e4321d18e78d4b51dae72175bc5f9e040beba3586c03b4cf245a5e5d9802 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNDFBOjM3RTYxMzoxMTg5NkZGOjE4MkY2Rjc6NkFGQjZGNEYiLCJ2aXNpdG9yX2lkIjoiNTUxNTgwMDQxMjk2OTIwMTQ4NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | fd188ef03046862cd54c04140140ed5ffe6d9360cd17d2b0895164ac0440700c |
| hovercard-subject-tag | pull_request:4600240996 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/8136/files |
| twitter:image | https://avatars.githubusercontent.com/u/157128530?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/157128530?s=400&v=4 |
| og:image:alt | Summary Use the existing Button size="icon" for knowledge tag removal, replacing local size-4 p-0 overrides. Preserve labels, callbacks, keyboard guards, propagation handling and the dest... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | cca289ecd54650fcf3c0b037a58b97186dee2cc4406819d87fab93728fd83700 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/simstudioai/sim git https://github.com/simstudioai/sim.git |
| octolytics-dimension-user_id | 199344406 |
| octolytics-dimension-user_login | simstudioai |
| octolytics-dimension-repository_id | 912559512 |
| octolytics-dimension-repository_nwo | simstudioai/sim |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 912559512 |
| octolytics-dimension-repository_network_root_nwo | simstudioai/sim |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 88808b1fae5ab8a526a73e7ce5542a10eb9d6971 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width