René's URL Explorer Experiment


Title: fix(files): stop promising immutable caching for documents compiled against other files by waleedlatif1 · Pull Request #8129 · simstudioai/sim · GitHub

Open Graph Title: fix(files): stop promising immutable caching for documents compiled against other files by waleedlatif1 · Pull Request #8129 · simstudioai/sim

X Title: fix(files): stop promising immutable caching for documents compiled against other files by waleedlatif1 · Pull Request #8129 · simstudioai/sim

Description: Summary A versioned serve URL (?v=) was always answered with a one-year immutable Cache-Control. That is right for a stored source — a content write rotates the storage key, so a given key's bytes never change — but wrong for a response resolved against OTHER files: a document compiled against the files it references, or a sim page inlining its images, is re-resolved on every request Those bytes change when a referenced file changes, while this file's key and updatedAt stay put — so the URL is unchanged and the browser keeps serving a stale render until the document itself is edited Cacheability is now a required property every resolver branch declares, so a branch added later cannot inherit the cacheable default by saying nothing Those responses can't be given a cache lifetime instead, so to keep revalidation cheap authorized serves now carry an ETag and answer 304 to a matching If-None-Match — the focus refetch costs a conditional request instead of the whole file. Matching is weak, per RFC 9110 Corrects three comments claiming generated docs are edited in place under the same storage key. That stopped being true in #5545 (2026-07-13), which made every content write allocate a new key — the caching rule was reasoned from the stale claim Notes The digest is deliberately not in createFileResponse: it costs a pass over the buffer (up to the 100MB transfer ceiling) and an immutable response is never revalidated, so it would pay that pass and never collect. Public assets and the assistant-image path are unchanged Serving unchanged bytes still does the same server-side work (source read, referenced-file metadata, artifact lookup); the 304 saves the transfer. Deriving the validator before fetching the artifact would save that lookup too, and is left as a follow-up Type of Change Bug fix Testing Route tests cover both cache lifetimes; unit tests cover the validator, the 304, weak matching, list and wildcard matching, and validator uniqueness. Each new test was verified to fail against the previous behavior, and the required-cacheability gate was verified to fail the build when a branch omits it. apps/sim type-check, lint, 47 audits, docs-manifest check, and 340 tests across the files, workspace-files hook, and copilot doc suites pass. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary A versioned serve URL (?v=<updatedAt>) was always answered with a one-year immutable Cache-Control. That is right for a stored source — a content write rotates the storage key, so a ...

X Description: Summary A versioned serve URL (?v=&lt;updatedAt&gt;) was always answered with a one-year immutable Cache-Control. That is right for a stored source — a content write rotates the storage ke...

Opengraph URL: https://github.com/simstudioai/sim/pull/8129

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:bb868b7e-f9fb-c33a-38a4-3e835ebaac98
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8522:2FF5E0:DFB225:132B422:6AFB5D55
html-safe-nonce31ae595e207e7b53219426165989f779b332ffe4939b7732d3a2c4a7ef6f7724
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NTIyOjJGRjVFMDpERkIyMjU6MTMyQjQyMjo2QUZCNUQ1NSIsInZpc2l0b3JfaWQiOiIzMDI1NzA2NjY5NzE2NDk1NzAxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacc8b563e0ce8c532f9f1d85e70285bd3591a7eb8472f2ad3aaa75eacc956a9624
hovercard-subject-tagpull_request:4599016572
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/8129/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary A versioned serve URL (?v=<updatedAt>) was always answered with a one-year immutable Cache-Control. That is right for a stored source — a content write rotates the storage key, so a ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneea33d13c96d0ff66bd8fa906b193d2213536b78cb06b0c50a4632c58b1418f94
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release59ef97164c52cf59bd10558ddec9c4f482763988
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/8129/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F8129%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F8129%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/8129/files
Reloadhttps://github.com/simstudioai/sim/pull/8129/files
Reloadhttps://github.com/simstudioai/sim/pull/8129/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/serve-immutable-cache-referenced-docshttps://github.com/simstudioai/sim/tree/fix/serve-immutable-cache-referenced-docs
Conversation 17 https://github.com/simstudioai/sim/pull/8129
Commits 5 https://github.com/simstudioai/sim/pull/8129/commits
Checks 33 https://github.com/simstudioai/sim/pull/8129/checks
Files changed https://github.com/simstudioai/sim/pull/8129/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8129/files
fix(files): stop promising immutable caching for documents compiled against other files https://github.com/simstudioai/sim/pull/8129/files#top
Show all changes 5 commits https://github.com/simstudioai/sim/pull/8129/files
b9e26ae fix(files): stop promising immutable caching for documents compiled a… waleedlatif1 Sep 22, 2026 https://github.com/simstudioai/sim/pull/8129/commits/b9e26aeb85377cd532fc5328722635acc3d1beb7
53fad9d improvement(files): make serve cacheability a declared, required prop… waleedlatif1 Sep 22, 2026 https://github.com/simstudioai/sim/pull/8129/commits/53fad9d59c9d89879f9f77ca52833cd70c03aa60
6ff2969 improvement(files): answer a file revalidation with 304 instead of th… waleedlatif1 Sep 22, 2026 https://github.com/simstudioai/sim/pull/8129/commits/6ff296974c19ab96531e6ccf849470abaea38dff
9f5b711 fix(files): report a reference dependency from the isolated-VM compil… waleedlatif1 Sep 22, 2026 https://github.com/simstudioai/sim/pull/8129/commits/9f5b7112effe79206caf43ceca566994618b8152
c666075 improvement(files): compute a validator only where a response can be … waleedlatif1 Sep 22, 2026 https://github.com/simstudioai/sim/pull/8129/commits/c6660759986948ebb101a521b8fa43d2eb7878b3
Clear filters https://github.com/simstudioai/sim/pull/8129/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8129/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8129/files
route.test.ts https://github.com/simstudioai/sim/pull/8129/files#diff-aaa040f5cf2c4f4a89280a9560728fcb6c688e410ee0f6945faee6a913a8634f
route.ts https://github.com/simstudioai/sim/pull/8129/files#diff-2e1bb2cb6d37718fb0edc1164a1eea09d303379d4717f3844d00ac38e92d8ae9
utils.test.ts https://github.com/simstudioai/sim/pull/8129/files#diff-6d3d9f4cede114958223d59e0bd2f46e4d7a377fb33f2faa288113f9a8f33089
utils.ts https://github.com/simstudioai/sim/pull/8129/files#diff-cf0dbd7a02f4ac25fd4c864b014708c1d978d75efe972fae5ffcb021be58a9d3
workspace-files.ts https://github.com/simstudioai/sim/pull/8129/files#diff-29d9b6d312177176db7c67d2754eb013b3ee7dc842dbbdb481bed86f551d4f37
doc-compile.test.ts https://github.com/simstudioai/sim/pull/8129/files#diff-1351de746fcacb4198247f1f532df83a5135c527c4eb8fbc5cc377c833f84219
doc-compile.ts https://github.com/simstudioai/sim/pull/8129/files#diff-b744bbfdd06f81c703753596e7e7e90c15997083a6cadc23f0fc2031f6d63a70
doc-servable.test.ts https://github.com/simstudioai/sim/pull/8129/files#diff-f053c1d08e53539171c87f319fcd9671b674a48fee10f7233293cb7ed0de1081
apps/sim/app/api/files/serve/[...path]/route.test.tshttps://github.com/simstudioai/sim/pull/8129/files#diff-aaa040f5cf2c4f4a89280a9560728fcb6c688e410ee0f6945faee6a913a8634f
View file https://github.com/simstudioai/sim/blob/c6660759986948ebb101a521b8fa43d2eb7878b3/apps/sim/app/api/files/serve/%5B...path%5D/route.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8129/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8129/files#diff-aaa040f5cf2c4f4a89280a9560728fcb6c688e410ee0f6945faee6a913a8634f
https://github.com/simstudioai/sim/pull/8129/files#diff-aaa040f5cf2c4f4a89280a9560728fcb6c688e410ee0f6945faee6a913a8634f
https://github.com/simstudioai/sim/pull/8129/files#diff-aaa040f5cf2c4f4a89280a9560728fcb6c688e410ee0f6945faee6a913a8634f
https://github.com/simstudioai/sim/pull/8129/files#diff-aaa040f5cf2c4f4a89280a9560728fcb6c688e410ee0f6945faee6a913a8634f
https://github.com/simstudioai/sim/pull/8129/files#diff-aaa040f5cf2c4f4a89280a9560728fcb6c688e410ee0f6945faee6a913a8634f
https://github.com/simstudioai/sim/pull/8129/files#diff-aaa040f5cf2c4f4a89280a9560728fcb6c688e410ee0f6945faee6a913a8634f
https://github.com/simstudioai/sim/pull/8129/files#diff-aaa040f5cf2c4f4a89280a9560728fcb6c688e410ee0f6945faee6a913a8634f
https://github.com/simstudioai/sim/pull/8129/files#diff-aaa040f5cf2c4f4a89280a9560728fcb6c688e410ee0f6945faee6a913a8634f
https://github.com/simstudioai/sim/pull/8129/files#diff-aaa040f5cf2c4f4a89280a9560728fcb6c688e410ee0f6945faee6a913a8634f
https://github.com/simstudioai/sim/pull/8129/files#diff-aaa040f5cf2c4f4a89280a9560728fcb6c688e410ee0f6945faee6a913a8634f
apps/sim/app/api/files/serve/[...path]/route.tshttps://github.com/simstudioai/sim/pull/8129/files#diff-2e1bb2cb6d37718fb0edc1164a1eea09d303379d4717f3844d00ac38e92d8ae9
View file https://github.com/simstudioai/sim/blob/c6660759986948ebb101a521b8fa43d2eb7878b3/apps/sim/app/api/files/serve/%5B...path%5D/route.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8129/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8129/files#diff-2e1bb2cb6d37718fb0edc1164a1eea09d303379d4717f3844d00ac38e92d8ae9
https://github.com/simstudioai/sim/pull/8129/files#diff-2e1bb2cb6d37718fb0edc1164a1eea09d303379d4717f3844d00ac38e92d8ae9
https://github.com/simstudioai/sim/pull/8129/files#diff-2e1bb2cb6d37718fb0edc1164a1eea09d303379d4717f3844d00ac38e92d8ae9
https://github.com/simstudioai/sim/pull/8129/files#diff-2e1bb2cb6d37718fb0edc1164a1eea09d303379d4717f3844d00ac38e92d8ae9
https://github.com/simstudioai/sim/pull/8129/files#diff-2e1bb2cb6d37718fb0edc1164a1eea09d303379d4717f3844d00ac38e92d8ae9
https://github.com/simstudioai/sim/pull/8129/files#diff-2e1bb2cb6d37718fb0edc1164a1eea09d303379d4717f3844d00ac38e92d8ae9
https://github.com/simstudioai/sim/pull/8129/files#diff-2e1bb2cb6d37718fb0edc1164a1eea09d303379d4717f3844d00ac38e92d8ae9
https://github.com/simstudioai/sim/pull/8129/files#diff-2e1bb2cb6d37718fb0edc1164a1eea09d303379d4717f3844d00ac38e92d8ae9
https://github.com/simstudioai/sim/pull/8129/files#diff-2e1bb2cb6d37718fb0edc1164a1eea09d303379d4717f3844d00ac38e92d8ae9
https://github.com/simstudioai/sim/pull/8129/files#diff-2e1bb2cb6d37718fb0edc1164a1eea09d303379d4717f3844d00ac38e92d8ae9
https://github.com/simstudioai/sim/pull/8129/files#diff-2e1bb2cb6d37718fb0edc1164a1eea09d303379d4717f3844d00ac38e92d8ae9
https://github.com/simstudioai/sim/pull/8129/files#diff-2e1bb2cb6d37718fb0edc1164a1eea09d303379d4717f3844d00ac38e92d8ae9
https://github.com/simstudioai/sim/pull/8129/files#diff-2e1bb2cb6d37718fb0edc1164a1eea09d303379d4717f3844d00ac38e92d8ae9
https://github.com/simstudioai/sim/pull/8129/files#diff-2e1bb2cb6d37718fb0edc1164a1eea09d303379d4717f3844d00ac38e92d8ae9
https://github.com/simstudioai/sim/pull/8129/files#diff-2e1bb2cb6d37718fb0edc1164a1eea09d303379d4717f3844d00ac38e92d8ae9
https://github.com/simstudioai/sim/pull/8129/files#diff-2e1bb2cb6d37718fb0edc1164a1eea09d303379d4717f3844d00ac38e92d8ae9
https://github.com/simstudioai/sim/pull/8129/files#diff-2e1bb2cb6d37718fb0edc1164a1eea09d303379d4717f3844d00ac38e92d8ae9
https://github.com/simstudioai/sim/pull/8129/files#diff-2e1bb2cb6d37718fb0edc1164a1eea09d303379d4717f3844d00ac38e92d8ae9
https://github.com/simstudioai/sim/pull/8129/files#diff-2e1bb2cb6d37718fb0edc1164a1eea09d303379d4717f3844d00ac38e92d8ae9
Please reload this pagehttps://github.com/simstudioai/sim/pull/8129/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8129/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.