René's URL Explorer Experiment


Title: fix(workspace-files): keep the file-search claim on the ordered pending index instead of a hash join by waleedlatif1 · Pull Request #8128 · simstudioai/sim · GitHub

Open Graph Title: fix(workspace-files): keep the file-search claim on the ordered pending index instead of a hash join by waleedlatif1 · Pull Request #8128 · simstudioai/sim

X Title: fix(workspace-files): keep the file-search claim on the ordered pending index instead of a hash join by waleedlatif1 · Pull Request #8128 · simstudioai/sim

Description: Summary The file-search dispatcher's claim query joined workspace_files with an INNER JOIN; under FOR UPDATE (no parallel plans) the planner mis-estimates the timestamp equi-join and picks a hash join over every file and every pending revision of the workspace before the top-N sort, which exceeded the 10 s statement timeout for a workspace with a large backlog and failed the dispatch task with SQLSTATE 57014 The join is now a correlated LATERAL lookup with LIMIT 1, which cannot be flattened into a hash join, so the claim walks the ordered pending index and stops after the batch size: measured 4.6 s → 0.7 ms on the same workspace, same predicates and lock target Type of Change Bug fix Testing Added an integration test that captures the exact claim statement the dispatcher runs, pins the planner with SET LOCAL enable_nestloop = off (at fixture scale it already nests the join, so this reproduces production's choice), and asserts the LockRows subtree is fed by an index scan of workspace_file_search_revision_pending_idx with no sort over the backlog. Verified it fails against the old INNER JOIN spelling (LockRows -> Sort -> Hash Join) and passes with the LATERAL vitest run --mode integration lib/workspace-files/search/dispatcher.integration.ts against a local disposable PostgreSQL: 9 passed vitest run lib/workspace-files/search/dispatcher.test.ts lib/workspace-files/search/enqueue-dispatch.test.ts: 11 passed bun run type-check in apps/sim: clean bun run lint: clean bun run check:audits: every content audit passed (including check:api-validation:strict, check:sql-date-binding, check:utils, check:source-text); the only failures were audits that shell out to turbo/biome/tsc binaries missing from the isolated worktree, unrelated to this change Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary The file-search dispatcher's claim query joined workspace_files with an INNER JOIN; under FOR UPDATE (no parallel plans) the planner mis-estimates the timestamp equi-join and picks a h...

X Description: Summary The file-search dispatcher's claim query joined workspace_files with an INNER JOIN; under FOR UPDATE (no parallel plans) the planner mis-estimates the timestamp equi-join and picks...

Opengraph URL: https://github.com/simstudioai/sim/pull/8128

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:f0cb15e2-88ab-3e41-1772-5a3e69790a8b
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id812A:243FA5:1581999:1D5B57D:6AFB79E9
html-safe-nonced372f409e9f87002028049d4bc292b11c1cb9f8ab43b7f67d8dd148c45afe70e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MTJBOjI0M0ZBNToxNTgxOTk5OjFENUI1N0Q6NkFGQjc5RTkiLCJ2aXNpdG9yX2lkIjoiNzg5NjkyNTEyMzYxNTg4MTcwNSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac53df72fd0db586159a65714d957b974224b78da6a93e7fe18bf0f7ef626cd9ee
hovercard-subject-tagpull_request:4598836825
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/8128/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary The file-search dispatcher's claim query joined workspace_files with an INNER JOIN; under FOR UPDATE (no parallel plans) the planner mis-estimates the timestamp equi-join and picks a h...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneef32892d4269fb87b55e81cc4ba8d86e0f16aa28446ffbf46cba8be5179ab188
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasebc3703b4dcbe820d1284ef63c88b001c850be25e
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/8128/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F8128%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F8128%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/8128/files
Reloadhttps://github.com/simstudioai/sim/pull/8128/files
Reloadhttps://github.com/simstudioai/sim/pull/8128/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests202 (202)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/file-search-dispatch-claim-planhttps://github.com/simstudioai/sim/tree/fix/file-search-dispatch-claim-plan
Conversation 2 https://github.com/simstudioai/sim/pull/8128
Commits 1 https://github.com/simstudioai/sim/pull/8128/commits
Checks 33 https://github.com/simstudioai/sim/pull/8128/checks
Files changed https://github.com/simstudioai/sim/pull/8128/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8128/files
fix(workspace-files): keep the file-search claim on the ordered pending index instead of a hash join https://github.com/simstudioai/sim/pull/8128/files#top
Show all changes 1 commit https://github.com/simstudioai/sim/pull/8128/files
4f5514a fix(workspace-files): keep the file-search claim on the ordered pendi… waleedlatif1 Sep 22, 2026 https://github.com/simstudioai/sim/pull/8128/commits/4f5514a7ec333bd6c6c7d066c0552a2d66af4a1c
Clear filters https://github.com/simstudioai/sim/pull/8128/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8128/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8128/files
dispatcher.integration.ts https://github.com/simstudioai/sim/pull/8128/files#diff-5f580fffd39ddd529ae710b571e855f28636a56713b8d9f1889d03127d070e02
dispatcher.ts https://github.com/simstudioai/sim/pull/8128/files#diff-6683656d968a1a183bf327531c469e9b0b8eea626f303f8482a0504340be2d1d
apps/sim/lib/workspace-files/search/dispatcher.integration.tshttps://github.com/simstudioai/sim/pull/8128/files#diff-5f580fffd39ddd529ae710b571e855f28636a56713b8d9f1889d03127d070e02
View file https://github.com/simstudioai/sim/blob/4f5514a7ec333bd6c6c7d066c0552a2d66af4a1c/apps/sim/lib/workspace-files/search/dispatcher.integration.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8128/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8128/files#diff-5f580fffd39ddd529ae710b571e855f28636a56713b8d9f1889d03127d070e02
https://github.com/simstudioai/sim/pull/8128/files#diff-5f580fffd39ddd529ae710b571e855f28636a56713b8d9f1889d03127d070e02
https://github.com/simstudioai/sim/pull/8128/files#diff-5f580fffd39ddd529ae710b571e855f28636a56713b8d9f1889d03127d070e02
https://github.com/simstudioai/sim/pull/8128/files#diff-5f580fffd39ddd529ae710b571e855f28636a56713b8d9f1889d03127d070e02
apps/sim/lib/workspace-files/search/dispatcher.tshttps://github.com/simstudioai/sim/pull/8128/files#diff-6683656d968a1a183bf327531c469e9b0b8eea626f303f8482a0504340be2d1d
View file https://github.com/simstudioai/sim/blob/4f5514a7ec333bd6c6c7d066c0552a2d66af4a1c/apps/sim/lib/workspace-files/search/dispatcher.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8128/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8128/files#diff-6683656d968a1a183bf327531c469e9b0b8eea626f303f8482a0504340be2d1d
https://github.com/simstudioai/sim/pull/8128/files#diff-6683656d968a1a183bf327531c469e9b0b8eea626f303f8482a0504340be2d1d
https://github.com/simstudioai/sim/pull/8128/files#diff-6683656d968a1a183bf327531c469e9b0b8eea626f303f8482a0504340be2d1d
https://github.com/simstudioai/sim/pull/8128/files#diff-6683656d968a1a183bf327531c469e9b0b8eea626f303f8482a0504340be2d1d
Please reload this pagehttps://github.com/simstudioai/sim/pull/8128/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.