René's URL Explorer Experiment


Title: improvement(copilot): refuse approval-gated tools on the in-band lane by waleedlatif1 · Pull Request #8044 · simstudioai/sim · GitHub

Open Graph Title: improvement(copilot): refuse approval-gated tools on the in-band lane by waleedlatif1 · Pull Request #8044 · simstudioai/sim

X Title: improvement(copilot): refuse approval-gated tools on the in-band lane by waleedlatif1 · Pull Request #8044 · simstudioai/sim

Description: Summary Copilot's tool-approval gate is scaffolding today — COPILOT_TOOL_PERMISSIONS_ENABLED is off by default, so nothing is gated on any lane. This changes no behavior while it stays off. The gate is built only on the dispatch lane, which holds a call against a streaming context and a decision row, then deliberately declines to dispatch anything the mothership marks in-band. Those calls run via POST /api/copilot/tools/execute, which has neither a context nor a waiter — so enabling the flag would gate the foreground and leave background lanes ungated. A gate that looks enforced but is not is worse than no gate. Adds toolRequiresApprovalLane next to toolCallNeedsApproval so the covered tool set is defined once, and refuses a gated tool at the in-band route before it runs. Refuses rather than blocks: a background lane must never hang on a prompt with no row behind it. The mothership takes the checkpoint lane, where the gate lives. The check deliberately ignores the stored auto-allow list. An auto-allowed tool sent to the checkpoint lane is admitted there without prompting anyone, so reading it here would add a database read to every in-band call to reach the same place by a longer route. Records on the flag itself that the gate is a property of the lane, not only of the tool, since that doc comment is what gets read before enabling it. Type of Change Bug fix Testing New tests: the in-band route refuses a gated tool without executing it when permissions are enabled; an ungated tool still runs; a gated tool runs unchanged while permissions are disabled (pinning that this ships inert). Unit tests for toolRequiresApprovalLane across flag/catalog combinations. Verified the refusal test fails when the guard is removed. vitest run app/api/copilot lib/copilot — 2642 passed, 3 skipped tsc --noEmit clean, bun run lint clean, check:audits 47/47, docs-manifest:check in sync, and the workflow's inline env-flag audit passes (env-flags.ts changed) Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary Copilot's tool-approval gate is scaffolding today — COPILOT_TOOL_PERMISSIONS_ENABLED is off by default, so nothing is gated on any lane. This changes no behavior while it stays off. Th...

X Description: Summary Copilot's tool-approval gate is scaffolding today — COPILOT_TOOL_PERMISSIONS_ENABLED is off by default, so nothing is gated on any lane. This changes no behavior while it stays off...

Opengraph URL: https://github.com/simstudioai/sim/pull/8044

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:1ecfdf30-9310-48b7-90ec-33effa0cbac8
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAE10:14467D:885585:BFEDAA:6AFB6F5F
html-safe-nonce839ef480c4aa916e7352b744975c519337fe8c62760f7c4d892f6726a0790f81
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRTEwOjE0NDY3RDo4ODU1ODU6QkZFREFBOjZBRkI2RjVGIiwidmlzaXRvcl9pZCI6IjI2MzU3OTExMzg5NDU3MjQyNTUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacdaf203948eb1881366b1a10a96701bf04bd7ddb46c9cb6b2351c1737558d7bcf
hovercard-subject-tagpull_request:4581359215
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/8044/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary Copilot's tool-approval gate is scaffolding today — COPILOT_TOOL_PERMISSIONS_ENABLED is off by default, so nothing is gated on any lane. This changes no behavior while it stays off. Th...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecca289ecd54650fcf3c0b037a58b97186dee2cc4406819d87fab93728fd83700
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release88808b1fae5ab8a526a73e7ce5542a10eb9d6971
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/8044/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F8044%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F8044%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/8044/files
Reloadhttps://github.com/simstudioai/sim/pull/8044/files
Reloadhttps://github.com/simstudioai/sim/pull/8044/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests198 (198)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
sec/copilot-inband-approval-guardhttps://github.com/simstudioai/sim/tree/sec/copilot-inband-approval-guard
Conversation 12 https://github.com/simstudioai/sim/pull/8044
Commits 2 https://github.com/simstudioai/sim/pull/8044/commits
Checks 33 https://github.com/simstudioai/sim/pull/8044/checks
Files changed https://github.com/simstudioai/sim/pull/8044/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8044/files
improvement(copilot): refuse approval-gated tools on the in-band lane https://github.com/simstudioai/sim/pull/8044/files#top
Show all changes 2 commits https://github.com/simstudioai/sim/pull/8044/files
87e6419 improvement(copilot): refuse approval-gated tools on the in-band lane waleedlatif1 Sep 20, 2026 https://github.com/simstudioai/sim/pull/8044/commits/87e64192cc488f0c06b916bd4c23c1795760abd4
2986e56 improvement(copilot): move the approval-lane predicate beside the too… waleedlatif1 Sep 20, 2026 https://github.com/simstudioai/sim/pull/8044/commits/2986e56365bcc6d1d6b1c3fb216aa8e9f7fb40cc
Clear filters https://github.com/simstudioai/sim/pull/8044/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8044/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8044/files
route.test.ts https://github.com/simstudioai/sim/pull/8044/files#diff-9d1d04a4f240d4d5b43348f654f1f75b9a90bf4e5a41bcda209b2ae70507d4e4
route.ts https://github.com/simstudioai/sim/pull/8044/files#diff-5e74357601221a722cea3b22961f55e2c7d786f2f2f137a54892d37a8d2eb397
permission.ts https://github.com/simstudioai/sim/pull/8044/files#diff-3782414d45e60f6fec7ea29b68a22f49b6e80f56ea7a7422dfa2ec1042984c18
index.ts https://github.com/simstudioai/sim/pull/8044/files#diff-6491b40e205635ed4e80885b281add2b2c4aeed2f338feae635277cf8db6248f
router.test.ts https://github.com/simstudioai/sim/pull/8044/files#diff-af9bf22ebb12c7427158db8627787f21ee06c8db130c1f5416877623e5cab41a
router.ts https://github.com/simstudioai/sim/pull/8044/files#diff-944424d1b2eb9ec102d46194adf0d33f8c63381b9fc41efd40d5b395da403ffa
env-flags.ts https://github.com/simstudioai/sim/pull/8044/files#diff-38137f5948bf96f0793885f9d45e5ec1297c519b23392dbe94986eb6eeff234c
apps/sim/app/api/copilot/tools/execute/route.test.tshttps://github.com/simstudioai/sim/pull/8044/files#diff-9d1d04a4f240d4d5b43348f654f1f75b9a90bf4e5a41bcda209b2ae70507d4e4
View file https://github.com/simstudioai/sim/blob/2986e56365bcc6d1d6b1c3fb216aa8e9f7fb40cc/apps/sim/app/api/copilot/tools/execute/route.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8044/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8044/files#diff-9d1d04a4f240d4d5b43348f654f1f75b9a90bf4e5a41bcda209b2ae70507d4e4
https://github.com/simstudioai/sim/pull/8044/files#diff-9d1d04a4f240d4d5b43348f654f1f75b9a90bf4e5a41bcda209b2ae70507d4e4
https://github.com/simstudioai/sim/pull/8044/files#diff-9d1d04a4f240d4d5b43348f654f1f75b9a90bf4e5a41bcda209b2ae70507d4e4
https://github.com/simstudioai/sim/pull/8044/files#diff-9d1d04a4f240d4d5b43348f654f1f75b9a90bf4e5a41bcda209b2ae70507d4e4
https://github.com/simstudioai/sim/pull/8044/files#diff-9d1d04a4f240d4d5b43348f654f1f75b9a90bf4e5a41bcda209b2ae70507d4e4
https://github.com/simstudioai/sim/pull/8044/files#diff-9d1d04a4f240d4d5b43348f654f1f75b9a90bf4e5a41bcda209b2ae70507d4e4
https://github.com/simstudioai/sim/pull/8044/files#diff-9d1d04a4f240d4d5b43348f654f1f75b9a90bf4e5a41bcda209b2ae70507d4e4
apps/sim/app/api/copilot/tools/execute/route.tshttps://github.com/simstudioai/sim/pull/8044/files#diff-5e74357601221a722cea3b22961f55e2c7d786f2f2f137a54892d37a8d2eb397
View file https://github.com/simstudioai/sim/blob/2986e56365bcc6d1d6b1c3fb216aa8e9f7fb40cc/apps/sim/app/api/copilot/tools/execute/route.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8044/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8044/files#diff-5e74357601221a722cea3b22961f55e2c7d786f2f2f137a54892d37a8d2eb397
https://github.com/simstudioai/sim/pull/8044/files#diff-5e74357601221a722cea3b22961f55e2c7d786f2f2f137a54892d37a8d2eb397
https://github.com/simstudioai/sim/pull/8044/files#diff-5e74357601221a722cea3b22961f55e2c7d786f2f2f137a54892d37a8d2eb397
Please reload this pagehttps://github.com/simstudioai/sim/pull/8044/files
https://github.com/simstudioai/sim/pull/8044/files#diff-5e74357601221a722cea3b22961f55e2c7d786f2f2f137a54892d37a8d2eb397
apps/sim/lib/copilot/request/tools/permission.tshttps://github.com/simstudioai/sim/pull/8044/files#diff-3782414d45e60f6fec7ea29b68a22f49b6e80f56ea7a7422dfa2ec1042984c18
View file https://github.com/simstudioai/sim/blob/2986e56365bcc6d1d6b1c3fb216aa8e9f7fb40cc/apps/sim/lib/copilot/request/tools/permission.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8044/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8044/files#diff-3782414d45e60f6fec7ea29b68a22f49b6e80f56ea7a7422dfa2ec1042984c18
https://github.com/simstudioai/sim/pull/8044/files#diff-3782414d45e60f6fec7ea29b68a22f49b6e80f56ea7a7422dfa2ec1042984c18
apps/sim/lib/copilot/tool-executor/index.tshttps://github.com/simstudioai/sim/pull/8044/files#diff-6491b40e205635ed4e80885b281add2b2c4aeed2f338feae635277cf8db6248f
View file https://github.com/simstudioai/sim/blob/2986e56365bcc6d1d6b1c3fb216aa8e9f7fb40cc/apps/sim/lib/copilot/tool-executor/index.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8044/{{ revealButtonHref }}
apps/sim/lib/copilot/tool-executor/router.test.tshttps://github.com/simstudioai/sim/pull/8044/files#diff-af9bf22ebb12c7427158db8627787f21ee06c8db130c1f5416877623e5cab41a
View file https://github.com/simstudioai/sim/blob/2986e56365bcc6d1d6b1c3fb216aa8e9f7fb40cc/apps/sim/lib/copilot/tool-executor/router.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8044/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8044/files#diff-af9bf22ebb12c7427158db8627787f21ee06c8db130c1f5416877623e5cab41a
https://github.com/simstudioai/sim/pull/8044/files#diff-af9bf22ebb12c7427158db8627787f21ee06c8db130c1f5416877623e5cab41a
https://github.com/simstudioai/sim/pull/8044/files#diff-af9bf22ebb12c7427158db8627787f21ee06c8db130c1f5416877623e5cab41a
https://github.com/simstudioai/sim/pull/8044/files#diff-af9bf22ebb12c7427158db8627787f21ee06c8db130c1f5416877623e5cab41a
apps/sim/lib/copilot/tool-executor/router.tshttps://github.com/simstudioai/sim/pull/8044/files#diff-944424d1b2eb9ec102d46194adf0d33f8c63381b9fc41efd40d5b395da403ffa
View file https://github.com/simstudioai/sim/blob/2986e56365bcc6d1d6b1c3fb216aa8e9f7fb40cc/apps/sim/lib/copilot/tool-executor/router.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8044/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8044/files#diff-944424d1b2eb9ec102d46194adf0d33f8c63381b9fc41efd40d5b395da403ffa
apps/sim/lib/core/config/env-flags.tshttps://github.com/simstudioai/sim/pull/8044/files#diff-38137f5948bf96f0793885f9d45e5ec1297c519b23392dbe94986eb6eeff234c
View file https://github.com/simstudioai/sim/blob/2986e56365bcc6d1d6b1c3fb216aa8e9f7fb40cc/apps/sim/lib/core/config/env-flags.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8044/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8044/files#diff-38137f5948bf96f0793885f9d45e5ec1297c519b23392dbe94986eb6eeff234c
https://github.com/simstudioai/sim/pull/8044/files#diff-38137f5948bf96f0793885f9d45e5ec1297c519b23392dbe94986eb6eeff234c
Please reload this pagehttps://github.com/simstudioai/sim/pull/8044/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.