René's URL Explorer Experiment


Title: fix(copilot): stop returning generate_api_key plaintext on the in-band tool route by waleedlatif1 · Pull Request #8042 · simstudioai/sim · GitHub

Open Graph Title: fix(copilot): stop returning generate_api_key plaintext on the in-band tool route by waleedlatif1 · Pull Request #8042 · simstudioai/sim

X Title: fix(copilot): stop returning generate_api_key plaintext on the in-band tool route by waleedlatif1 · Pull Request #8042 · simstudioai/sim

Description: Summary Copilot tool results reach the model over two lanes, but the model-facing projection was applied on only one. The resume lane runs results through getToolCallTerminalData, which reduces generate_api_key to its status message; the in-band route (POST /api/copilot/tools/execute) returned the handler output verbatim, so the freshly minted plaintext workspace API key crossed to the model and into the turn transcript. The egress projection could not cover this. Its registry is a catalog of pre-existing environment and credential secrets, built once per turn, so a key minted mid-turn is invisible to it. Apply toolResultForModel at the route so both lanes return the same model-facing projection. It is an identity for every tool except generate_api_key. Behavioral note: on the in-band lane the browser's only copy of the key arrived via the relayed tool result, so the sim_key chip now renders masked there. Redacting at the shared projection instead is not an option — the main lane's client carve-out reads that same projected output, so it would break the chip everywhere. Type of Change Bug fix Testing Added regression tests on the in-band route: generate_api_key returns only the status message and no key field; a non-generate_api_key result carrying a key field is untouched; a failed call passes its error through. Verified the new test fails when the fix is reverted. vitest run app/api/copilot lib/copilot — 2636 passed, 3 skipped tsc --noEmit clean, bun run lint clean, check:audits 47/47 passing, docs-manifest:check in sync Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary Copilot tool results reach the model over two lanes, but the model-facing projection was applied on only one. The resume lane runs results through getToolCallTerminalData, which reduces ge...

X Description: Summary Copilot tool results reach the model over two lanes, but the model-facing projection was applied on only one. The resume lane runs results through getToolCallTerminalData, which reduces ge...

Opengraph URL: https://github.com/simstudioai/sim/pull/8042

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:df6b6de1-46a3-2ef0-5acb-6247d702c7d1
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA910:38C411:37CABD:4E2987:6AFB573D
html-safe-noncef12c9b125d8099f9fd83fec277024989a9c2be84720a5d99dc441d7c053f189b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBOTEwOjM4QzQxMTozN0NBQkQ6NEUyOTg3OjZBRkI1NzNEIiwidmlzaXRvcl9pZCI6IjM1OTI0NjgwNzU5MDA1MjQzNDkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac342cb6fd92cd73848a43f7e74d259bb1710e7d890d5115b9ba6d65acce24ca85
hovercard-subject-tagpull_request:4581264180
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/8042/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary Copilot tool results reach the model over two lanes, but the model-facing projection was applied on only one. The resume lane runs results through getToolCallTerminalData, which reduces ge...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None7122bb414b542dba14d71a3f0b9f6fd2abce715b9f5912d082800563e6c806d1
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasecbf66c024bb6d10e6955baa7413c54cf13a201bb
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/8042/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F8042%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F8042%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/8042/files
Reloadhttps://github.com/simstudioai/sim/pull/8042/files
Reloadhttps://github.com/simstudioai/sim/pull/8042/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
sec/copilot-genapikey-redactionhttps://github.com/simstudioai/sim/tree/sec/copilot-genapikey-redaction
Conversation 2 https://github.com/simstudioai/sim/pull/8042
Commits 1 https://github.com/simstudioai/sim/pull/8042/commits
Checks 33 https://github.com/simstudioai/sim/pull/8042/checks
Files changed https://github.com/simstudioai/sim/pull/8042/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8042/files
fix(copilot): stop returning generate_api_key plaintext on the in-band tool route https://github.com/simstudioai/sim/pull/8042/files#top
Show all changes 1 commit https://github.com/simstudioai/sim/pull/8042/files
d7ada53 fix(copilot): stop returning generate_api_key plaintext on the in-ban… waleedlatif1 Sep 19, 2026 https://github.com/simstudioai/sim/pull/8042/commits/d7ada534b93055d717330d4c4a33966704168895
Clear filters https://github.com/simstudioai/sim/pull/8042/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8042/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8042/files
route.test.ts https://github.com/simstudioai/sim/pull/8042/files#diff-9d1d04a4f240d4d5b43348f654f1f75b9a90bf4e5a41bcda209b2ae70507d4e4
route.ts https://github.com/simstudioai/sim/pull/8042/files#diff-5e74357601221a722cea3b22961f55e2c7d786f2f2f137a54892d37a8d2eb397
apps/sim/app/api/copilot/tools/execute/route.test.tshttps://github.com/simstudioai/sim/pull/8042/files#diff-9d1d04a4f240d4d5b43348f654f1f75b9a90bf4e5a41bcda209b2ae70507d4e4
View file https://github.com/simstudioai/sim/blob/d7ada534b93055d717330d4c4a33966704168895/apps/sim/app/api/copilot/tools/execute/route.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8042/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8042/files#diff-9d1d04a4f240d4d5b43348f654f1f75b9a90bf4e5a41bcda209b2ae70507d4e4
apps/sim/app/api/copilot/tools/execute/route.tshttps://github.com/simstudioai/sim/pull/8042/files#diff-5e74357601221a722cea3b22961f55e2c7d786f2f2f137a54892d37a8d2eb397
View file https://github.com/simstudioai/sim/blob/d7ada534b93055d717330d4c4a33966704168895/apps/sim/app/api/copilot/tools/execute/route.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8042/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8042/files#diff-5e74357601221a722cea3b22961f55e2c7d786f2f2f137a54892d37a8d2eb397
https://github.com/simstudioai/sim/pull/8042/files#diff-5e74357601221a722cea3b22961f55e2c7d786f2f2f137a54892d37a8d2eb397
https://github.com/simstudioai/sim/pull/8042/files#diff-5e74357601221a722cea3b22961f55e2c7d786f2f2f137a54892d37a8d2eb397
https://github.com/simstudioai/sim/pull/8042/files#diff-5e74357601221a722cea3b22961f55e2c7d786f2f2f137a54892d37a8d2eb397
Please reload this pagehttps://github.com/simstudioai/sim/pull/8042/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.