René's URL Explorer Experiment


Title: fix(realtime): validate cursor and selection presence payloads by waleedlatif1 · Pull Request #8041 · simstudioai/sim · GitHub

Open Graph Title: fix(realtime): validate cursor and selection presence payloads by waleedlatif1 · Pull Request #8041 · simstudioai/sim

X Title: fix(realtime): validate cursor and selection presence payloads by waleedlatif1 · Pull Request #8041 · simstudioai/sim

Description: Summary cursor-update and selection-update stored whatever object a client sent into the shared room presence hash and rebroadcast it to every peer, with no shape or size check. An authenticated user with read access to any workflow could park a multi-megabyte blob (bounded only by the 8 MiB Socket.IO frame ceiling) in shared Redis on every socket they opened, and have the server fan it out on every later presence broadcast. Both payloads are now rebuilt from a fixed field set before they reach room state or any broadcast, so unexpected keys can't ride along. This mirrors normalizeCellSelection in the table presence handler, which already guards the sibling path — the workflow path was the unguarded one. Added a defensive per-field length cap in updateUserActivity so future presence-bearing events inherit the bound. At 4096 it sits ~8x above the largest legitimate payload, so it never trims real presence. Marked UserPresence.cursor nullable. The client already sends cursor: null to clear, and that null is genuinely stored — the type just didn't say so, which only type-checked before because the handler destructured an untyped payload. Type of Change Bug fix Testing New presence.test.ts covers both handlers: well-formed payloads, cleared cursor, unexpected-key stripping, and malformed/oversized rejection. Verified the tests can fail — reverting the handler turns 15 of the 20 red, while the 5 behavior-preservation cases stay green either way. Full realtime suite passes (408 tests, 18 files). bunx turbo run type-check green across all 26 tasks; bun run lint and all 47 audits pass. No wire-format change, so old and new pods interoperate during a rolling deploy — normalized payloads are a subset of what the previous handler accepted. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary cursor-update and selection-update stored whatever object a client sent into the shared room presence hash and rebroadcast it to every peer, with no shape or size check. An authenticated u...

X Description: Summary cursor-update and selection-update stored whatever object a client sent into the shared room presence hash and rebroadcast it to every peer, with no shape or size check. An authenticated u...

Opengraph URL: https://github.com/simstudioai/sim/pull/8041

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:ba23f6a9-f371-cc6d-c6e1-9feb555a5c2c
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9428:6449C:121CC60:18E4405:6AFB6F34
html-safe-noncee078ed325f7de0c55f7b384134fc271ac79a10926386011d44cbd90eae67dd7f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NDI4OjY0NDlDOjEyMUNDNjA6MThFNDQwNTo2QUZCNkYzNCIsInZpc2l0b3JfaWQiOiIyMjIyNjUyMjM0Njc0MTcxNzAwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacdb29833302cc0662f7e6ca569b8e7aeafc156d7bc38edb08a7d50edc2bc4250a
hovercard-subject-tagpull_request:4581120519
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/8041/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary cursor-update and selection-update stored whatever object a client sent into the shared room presence hash and rebroadcast it to every peer, with no shape or size check. An authenticated u...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecca289ecd54650fcf3c0b037a58b97186dee2cc4406819d87fab93728fd83700
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release88808b1fae5ab8a526a73e7ce5542a10eb9d6971
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/8041/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F8041%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F8041%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/8041/files
Reloadhttps://github.com/simstudioai/sim/pull/8041/files
Reloadhttps://github.com/simstudioai/sim/pull/8041/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests198 (198)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
audit/presence-validationhttps://github.com/simstudioai/sim/tree/audit/presence-validation
Conversation 11 https://github.com/simstudioai/sim/pull/8041
Commits 2 https://github.com/simstudioai/sim/pull/8041/commits
Checks 33 https://github.com/simstudioai/sim/pull/8041/checks
Files changed https://github.com/simstudioai/sim/pull/8041/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8041/files
fix(realtime): validate cursor and selection presence payloads https://github.com/simstudioai/sim/pull/8041/files#top
Show all changes 2 commits https://github.com/simstudioai/sim/pull/8041/files
cf80252 fix(realtime): validate cursor and selection presence payloads waleedlatif1 Sep 19, 2026 https://github.com/simstudioai/sim/pull/8041/commits/cf802521835cfca8e20685886aec6dcbaade9154
e2c57db fix(realtime): measure presence field cap in utf-8 bytes waleedlatif1 Sep 19, 2026 https://github.com/simstudioai/sim/pull/8041/commits/e2c57dbaaa97aae25fb440bc392012009a5ae1b7
Clear filters https://github.com/simstudioai/sim/pull/8041/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8041/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8041/files
presence.test.ts https://github.com/simstudioai/sim/pull/8041/files#diff-c314e4b7a9eb3d84c976d3e51c0f04dfea9b1d72663e6eb2ce437c2f8d130b33
presence.ts https://github.com/simstudioai/sim/pull/8041/files#diff-7f6f3cb60307562a33b98e52c624ce9b13e4a90d9cbe9418bcf612165297d38e
redis-manager.ts https://github.com/simstudioai/sim/pull/8041/files#diff-2b2899aa21a13f2664744c7a87b257a22ab9c68b8a29422f0c733af16ee9b897
types.ts https://github.com/simstudioai/sim/pull/8041/files#diff-731dbe0d0091b1ff63c25da26d7f6c0444b9666dcb619d8b31bda8208bea7882
apps/realtime/src/handlers/presence.test.tshttps://github.com/simstudioai/sim/pull/8041/files#diff-c314e4b7a9eb3d84c976d3e51c0f04dfea9b1d72663e6eb2ce437c2f8d130b33
View file https://github.com/simstudioai/sim/blob/e2c57dbaaa97aae25fb440bc392012009a5ae1b7/apps/realtime/src/handlers/presence.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8041/{{ revealButtonHref }}
apps/realtime/src/handlers/presence.tshttps://github.com/simstudioai/sim/pull/8041/files#diff-7f6f3cb60307562a33b98e52c624ce9b13e4a90d9cbe9418bcf612165297d38e
View file https://github.com/simstudioai/sim/blob/e2c57dbaaa97aae25fb440bc392012009a5ae1b7/apps/realtime/src/handlers/presence.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8041/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8041/files#diff-7f6f3cb60307562a33b98e52c624ce9b13e4a90d9cbe9418bcf612165297d38e
https://github.com/simstudioai/sim/pull/8041/files#diff-7f6f3cb60307562a33b98e52c624ce9b13e4a90d9cbe9418bcf612165297d38e
apps/realtime/src/rooms/redis-manager.tshttps://github.com/simstudioai/sim/pull/8041/files#diff-2b2899aa21a13f2664744c7a87b257a22ab9c68b8a29422f0c733af16ee9b897
View file https://github.com/simstudioai/sim/blob/e2c57dbaaa97aae25fb440bc392012009a5ae1b7/apps/realtime/src/rooms/redis-manager.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8041/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8041/files#diff-2b2899aa21a13f2664744c7a87b257a22ab9c68b8a29422f0c733af16ee9b897
https://github.com/simstudioai/sim/pull/8041/files#diff-2b2899aa21a13f2664744c7a87b257a22ab9c68b8a29422f0c733af16ee9b897
https://github.com/simstudioai/sim/pull/8041/files#diff-2b2899aa21a13f2664744c7a87b257a22ab9c68b8a29422f0c733af16ee9b897
https://github.com/simstudioai/sim/pull/8041/files#diff-2b2899aa21a13f2664744c7a87b257a22ab9c68b8a29422f0c733af16ee9b897
apps/realtime/src/rooms/types.tshttps://github.com/simstudioai/sim/pull/8041/files#diff-731dbe0d0091b1ff63c25da26d7f6c0444b9666dcb619d8b31bda8208bea7882
View file https://github.com/simstudioai/sim/blob/e2c57dbaaa97aae25fb440bc392012009a5ae1b7/apps/realtime/src/rooms/types.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8041/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8041/files#diff-731dbe0d0091b1ff63c25da26d7f6c0444b9666dcb619d8b31bda8208bea7882
https://github.com/simstudioai/sim/pull/8041/files#diff-731dbe0d0091b1ff63c25da26d7f6c0444b9666dcb619d8b31bda8208bea7882
Please reload this pagehttps://github.com/simstudioai/sim/pull/8041/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.