René's URL Explorer Experiment


Title: improvement(knowledge): cache admitted usage checks on the search path by waleedlatif1 · Pull Request #7989 · simstudioai/sim · GitHub

Open Graph Title: improvement(knowledge): cache admitted usage checks on the search path by waleedlatif1 · Pull Request #7989 · simstudioai/sim

X Title: improvement(knowledge): cache admitted usage checks on the search path by waleedlatif1 · Pull Request #7989 · simstudioai/sim

Description: Summary Every knowledge search ran checkAttributedUsageLimits, which sums the payer's usage_log rows for the whole billing period. For a large organization that is a scan of over a million rows per search, usage_admission sat at a median of ~378ms per search, and the sum is one of the top database consumers overall Knowledge search (including org-wide Sim Search) now calls checkSearchUsageLimits, which serves a cached admission for up to 60s and always re-reads a refusal. Staleness only fails open: a payer who crosses their limit can keep searching for at most a minute, and a payer who raises their limit or upgrades is never held behind a cached block The search path never stores a refusal, so a fail-closed ledger error (which comes back as exceeded) can't be cached from search, and a refusal read by search never reaches ingestion. A read that throws writes nothing. coalesceLocally collapses concurrent misses and bounds a hung read at its settle deadline; the cache is an LRUCache capped at 10k entries Merged the existing ingestion gate into the same module (ingestion-usage-gate.ts → usage-gate-cache.ts): one key, one LRU, one coalescer, two entry points. checkIngestionUsageLimits behaves as before (serves cached refusals too); search serves only cached admissions, so it never sees a refusal ingestion cached The key now also includes the payer subscription (id, plan, status, seats), so a plan change reads fresh on both paths. It still excludes workspaceId, which the check never reads, so every workspace of one payer shares an entry Workflow execution admission, uploads, v1 /api/v1/knowledge/search (its own inline gate, not the search use case), and every other caller keep the fresh read. No invalidator: usage and limit changes land in other processes, so the TTL is the real bound Type of Change Improvement Testing New cases for the search entry point: reuse across workspaces, refusal re-read, never serving an ingestion-cached refusal, never storing a refusal for ingestion, failed read not cached. Verified they fail with the refusal guard removed Knowledge, billing, internal, and MCP suites pass (600 files / 7,187 tests); type-check, lint, check:audits (47), and check:api-validation pass Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary Every knowledge search ran checkAttributedUsageLimits, which sums the payer's usage_log rows for the whole billing period. For a large organization that is a scan of over a million row...

X Description: Summary Every knowledge search ran checkAttributedUsageLimits, which sums the payer's usage_log rows for the whole billing period. For a large organization that is a scan of over a million...

Opengraph URL: https://github.com/simstudioai/sim/pull/7989

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:34954e41-5d09-df7c-518d-15591a770bd3
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDB32:223A5F:1247E60:1920D0B:6AFB6F3C
html-safe-nonce36b3005ada9b64c725a380be66eac8e4e6aeb325beb794d782ceb21b2626ae18
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQjMyOjIyM0E1RjoxMjQ3RTYwOjE5MjBEMEI6NkFGQjZGM0MiLCJ2aXNpdG9yX2lkIjoiNTc3NzIyNTM0NDE3NTc5NjAyOCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac38a268b364e927587c4b91dac3e940c631b147df8e718a3547eb60671a07a53e
hovercard-subject-tagpull_request:4573945873
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/7989/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary Every knowledge search ran checkAttributedUsageLimits, which sums the payer's usage_log rows for the whole billing period. For a large organization that is a scan of over a million row...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecca289ecd54650fcf3c0b037a58b97186dee2cc4406819d87fab93728fd83700
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release88808b1fae5ab8a526a73e7ce5542a10eb9d6971
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/7989/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F7989%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F7989%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/7989/files
Reloadhttps://github.com/simstudioai/sim/pull/7989/files
Reloadhttps://github.com/simstudioai/sim/pull/7989/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests198 (198)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
improvement/search-usage-gate-cachehttps://github.com/simstudioai/sim/tree/improvement/search-usage-gate-cache
Conversation 16 https://github.com/simstudioai/sim/pull/7989
Commits 3 https://github.com/simstudioai/sim/pull/7989/commits
Checks 33 https://github.com/simstudioai/sim/pull/7989/checks
Files changed https://github.com/simstudioai/sim/pull/7989/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/7989/files
improvement(knowledge): cache admitted usage checks on the search path https://github.com/simstudioai/sim/pull/7989/files#top
Show all changes 3 commits https://github.com/simstudioai/sim/pull/7989/files
569afa2 improvement(knowledge): cache admitted usage checks on the search path waleedlatif1 Sep 18, 2026 https://github.com/simstudioai/sim/pull/7989/commits/569afa23c55ce8254001e442742e7404bb60cd66
9d6e7e7 fix(knowledge): keep search-path refusals out of the shared usage gat… waleedlatif1 Sep 18, 2026 https://github.com/simstudioai/sim/pull/7989/commits/9d6e7e772f8fa2c5acad25da85d3046d89746263
f59978f fix(knowledge): key the usage gate cache by billing period source waleedlatif1 Sep 18, 2026 https://github.com/simstudioai/sim/pull/7989/commits/f59978fc7bd336091d225b3a35f42ce98df0056d
Clear filters https://github.com/simstudioai/sim/pull/7989/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/7989/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/7989/files
route.provenance.test.ts https://github.com/simstudioai/sim/pull/7989/files#diff-630fba1349acab836a3919a6d81cb94484c212424bdb6b2f9390cc787c8836d5
ingestion-usage-gate.ts https://github.com/simstudioai/sim/pull/7989/files#diff-ee57083ba95334a347f929ac7161cc2cf1962fa0078449cdcfc7dd416133ff3d
usage-gate-cache.test.ts https://github.com/simstudioai/sim/pull/7989/files#diff-899ac9a0a5722a3775ecc8f52ed1953a2d15b99734d9ec0587eabad5d9c5b47b
usage-gate-cache.ts https://github.com/simstudioai/sim/pull/7989/files#diff-0833b1190f65cc31d32eae15d009bce6a0dfadbb2f3c80cad27fc99ef89edb51
search.test.ts https://github.com/simstudioai/sim/pull/7989/files#diff-c537ffb68efc080de7b2966157c993c5d2a2b2d52ff7eae0024dee04cdf0266f
search.ts https://github.com/simstudioai/sim/pull/7989/files#diff-6d92dc3a4dd3235b5c805a3ef81a2a271e98cc2632caf3274d8a1ac938644934
document-indexing-usage.test.ts https://github.com/simstudioai/sim/pull/7989/files#diff-ff4ae625d37edbdfb8ea953b69b76e91faa6761157ff50400a5242c5ef120577
document-processing-source.test.ts https://github.com/simstudioai/sim/pull/7989/files#diff-5b6e93417c23c69dd607283ad630cf19fce90751f3480053378e133760b97633
service.ts https://github.com/simstudioai/sim/pull/7989/files#diff-12adff6ec055d413ec20f1debed4ca207b994d23df6de9aa4ef79bf47f2857b2
apps/sim/app/api/v2/knowledge/search/route.provenance.test.tshttps://github.com/simstudioai/sim/pull/7989/files#diff-630fba1349acab836a3919a6d81cb94484c212424bdb6b2f9390cc787c8836d5
View file https://github.com/simstudioai/sim/blob/f59978fc7bd336091d225b3a35f42ce98df0056d/apps/sim/app/api/v2/knowledge/search/route.provenance.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/7989/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/7989/files#diff-630fba1349acab836a3919a6d81cb94484c212424bdb6b2f9390cc787c8836d5
https://github.com/simstudioai/sim/pull/7989/files#diff-630fba1349acab836a3919a6d81cb94484c212424bdb6b2f9390cc787c8836d5
apps/sim/lib/billing/core/ingestion-usage-gate.tshttps://github.com/simstudioai/sim/pull/7989/files#diff-ee57083ba95334a347f929ac7161cc2cf1962fa0078449cdcfc7dd416133ff3d
View file https://github.com/simstudioai/sim/blob/2d8782437ea864077fc2130d3e107d0d209ae8a7/apps/sim/lib/billing/core/ingestion-usage-gate.ts
Open in desktop https://desktop.github.com
Please reload this pagehttps://github.com/simstudioai/sim/pull/7989/files
...billing/core/ingestion-usage-gate.test.ts → ...lib/billing/core/usage-gate-cache.test.tshttps://github.com/simstudioai/sim/pull/7989/files#diff-899ac9a0a5722a3775ecc8f52ed1953a2d15b99734d9ec0587eabad5d9c5b47b
View file https://github.com/simstudioai/sim/blob/f59978fc7bd336091d225b3a35f42ce98df0056d/apps/sim/lib/billing/core/usage-gate-cache.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/7989/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/7989/files#diff-899ac9a0a5722a3775ecc8f52ed1953a2d15b99734d9ec0587eabad5d9c5b47b
https://github.com/simstudioai/sim/pull/7989/files#diff-899ac9a0a5722a3775ecc8f52ed1953a2d15b99734d9ec0587eabad5d9c5b47b
https://github.com/simstudioai/sim/pull/7989/files#diff-899ac9a0a5722a3775ecc8f52ed1953a2d15b99734d9ec0587eabad5d9c5b47b
https://github.com/simstudioai/sim/pull/7989/files#diff-899ac9a0a5722a3775ecc8f52ed1953a2d15b99734d9ec0587eabad5d9c5b47b
https://github.com/simstudioai/sim/pull/7989/files#diff-899ac9a0a5722a3775ecc8f52ed1953a2d15b99734d9ec0587eabad5d9c5b47b
https://github.com/simstudioai/sim/pull/7989/files#diff-899ac9a0a5722a3775ecc8f52ed1953a2d15b99734d9ec0587eabad5d9c5b47b
apps/sim/lib/billing/core/usage-gate-cache.tshttps://github.com/simstudioai/sim/pull/7989/files#diff-0833b1190f65cc31d32eae15d009bce6a0dfadbb2f3c80cad27fc99ef89edb51
View file https://github.com/simstudioai/sim/blob/f59978fc7bd336091d225b3a35f42ce98df0056d/apps/sim/lib/billing/core/usage-gate-cache.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/7989/{{ revealButtonHref }}
Please reload this pagehttps://github.com/simstudioai/sim/pull/7989/files
apps/sim/lib/knowledge/application/search.test.tshttps://github.com/simstudioai/sim/pull/7989/files#diff-c537ffb68efc080de7b2966157c993c5d2a2b2d52ff7eae0024dee04cdf0266f
View file https://github.com/simstudioai/sim/blob/f59978fc7bd336091d225b3a35f42ce98df0056d/apps/sim/lib/knowledge/application/search.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/7989/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/7989/files#diff-c537ffb68efc080de7b2966157c993c5d2a2b2d52ff7eae0024dee04cdf0266f
https://github.com/simstudioai/sim/pull/7989/files#diff-c537ffb68efc080de7b2966157c993c5d2a2b2d52ff7eae0024dee04cdf0266f
apps/sim/lib/knowledge/application/search.tshttps://github.com/simstudioai/sim/pull/7989/files#diff-6d92dc3a4dd3235b5c805a3ef81a2a271e98cc2632caf3274d8a1ac938644934
View file https://github.com/simstudioai/sim/blob/f59978fc7bd336091d225b3a35f42ce98df0056d/apps/sim/lib/knowledge/application/search.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/7989/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/7989/files#diff-6d92dc3a4dd3235b5c805a3ef81a2a271e98cc2632caf3274d8a1ac938644934
https://github.com/simstudioai/sim/pull/7989/files#diff-6d92dc3a4dd3235b5c805a3ef81a2a271e98cc2632caf3274d8a1ac938644934
https://github.com/simstudioai/sim/pull/7989/files#diff-6d92dc3a4dd3235b5c805a3ef81a2a271e98cc2632caf3274d8a1ac938644934
Please reload this pagehttps://github.com/simstudioai/sim/pull/7989/files
https://github.com/simstudioai/sim/pull/7989/files#diff-6d92dc3a4dd3235b5c805a3ef81a2a271e98cc2632caf3274d8a1ac938644934
apps/sim/lib/knowledge/documents/document-indexing-usage.test.tshttps://github.com/simstudioai/sim/pull/7989/files#diff-ff4ae625d37edbdfb8ea953b69b76e91faa6761157ff50400a5242c5ef120577
View file https://github.com/simstudioai/sim/blob/f59978fc7bd336091d225b3a35f42ce98df0056d/apps/sim/lib/knowledge/documents/document-indexing-usage.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/7989/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/7989/files#diff-ff4ae625d37edbdfb8ea953b69b76e91faa6761157ff50400a5242c5ef120577
https://github.com/simstudioai/sim/pull/7989/files#diff-ff4ae625d37edbdfb8ea953b69b76e91faa6761157ff50400a5242c5ef120577
apps/sim/lib/knowledge/documents/document-processing-source.test.tshttps://github.com/simstudioai/sim/pull/7989/files#diff-5b6e93417c23c69dd607283ad630cf19fce90751f3480053378e133760b97633
View file https://github.com/simstudioai/sim/blob/f59978fc7bd336091d225b3a35f42ce98df0056d/apps/sim/lib/knowledge/documents/document-processing-source.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/7989/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/7989/files#diff-5b6e93417c23c69dd607283ad630cf19fce90751f3480053378e133760b97633
https://github.com/simstudioai/sim/pull/7989/files#diff-5b6e93417c23c69dd607283ad630cf19fce90751f3480053378e133760b97633
https://github.com/simstudioai/sim/pull/7989/files#diff-5b6e93417c23c69dd607283ad630cf19fce90751f3480053378e133760b97633
https://github.com/simstudioai/sim/pull/7989/files#diff-5b6e93417c23c69dd607283ad630cf19fce90751f3480053378e133760b97633
apps/sim/lib/knowledge/documents/service.tshttps://github.com/simstudioai/sim/pull/7989/files#diff-12adff6ec055d413ec20f1debed4ca207b994d23df6de9aa4ef79bf47f2857b2
View file https://github.com/simstudioai/sim/blob/f59978fc7bd336091d225b3a35f42ce98df0056d/apps/sim/lib/knowledge/documents/service.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/7989/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/7989/files#diff-12adff6ec055d413ec20f1debed4ca207b994d23df6de9aa4ef79bf47f2857b2
https://github.com/simstudioai/sim/pull/7989/files#diff-12adff6ec055d413ec20f1debed4ca207b994d23df6de9aa4ef79bf47f2857b2
Please reload this pagehttps://github.com/simstudioai/sim/pull/7989/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.