René's URL Explorer Experiment


Title: refactor(emcn): share filled stop icon across chat controls by BillLeoutsakosvl346 · Pull Request #7977 · simstudioai/sim · GitHub

Open Graph Title: refactor(emcn): share filled stop icon across chat controls by BillLeoutsakosvl346 · Pull Request #7977 · simstudioai/sim

X Title: refactor(emcn): share filled stop icon across chat controls by BillLeoutsakosvl346 · Pull Request #7977 · simstudioai/sim

Description: Public chat, organization chat, and workspace chat each implemented the same filled stop icon inline. Add one StopFilled icon to EMCN and use it at all three call sites, preserving the original SVG geometry, caller classes, accessible button names, and stop handlers. Follows #7975. That PR merged before this branch was prepared, so this branch starts at its merge commit and targets staging directly. The product changes are the shared icon, its barrel export, and the three consumer updates. CI also exposed an existing race in the desktop terminal-selection test: its fixture read the buffer after a fixed 30 ms delay, before xterm necessarily finished parsing. Replace the delay with the completion callback of a trailing empty write. The fixture now waits for all preceding writes without changing its assertions or desktop runtime code. Validation: Full external category audit: duplicate-artwork findings reduced from 3 to 0; no missing-button-name findings remain. Final committed-diff linter: zero introduced usage violations. Its two expected system-change notices identify the new central icon and barrel export; source equivalence was checked for both. The new icon's generic SVG props spread produces the same control-presence uncertainty as other reusable icons; all three consumers pass only their existing classes. Source equivalence check: expanding StopFilled recreates the original SVG and all non-import component syntax at all three call sites, including size, light/dark fill classes, conditions, and handlers. All 36 existing composer, user-input, and chat-streaming tests pass. All 1,657 desktop tests across 71 files pass after the CI test correction; desktop type checking and the changed test's Biome check pass. App and EMCN type checks, scoped Biome checks, API validation, and git diff --check pass. The landing-page demo retains its copy under the existing landing exclusion. The external linter, verification scripts, reports, and dependency installation are not part of this PR.

Open Graph Description: Public chat, organization chat, and workspace chat each implemented the same filled stop icon inline. Add one StopFilled icon to EMCN and use it at all three call sites, preserving the original SVG...

X Description: Public chat, organization chat, and workspace chat each implemented the same filled stop icon inline. Add one StopFilled icon to EMCN and use it at all three call sites, preserving the original SVG...

Opengraph URL: https://github.com/simstudioai/sim/pull/7977

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:ea0454f6-95af-0739-0ef7-6f36b7e41b18
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD392:3BD2EB:9F0F15:E06D0C:6AFB7577
html-safe-nonce5415e624d2ce0fb8f2cb4271aeada81c673368ae927ac2ac1b01dea4aafb2e4d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMzkyOjNCRDJFQjo5RjBGMTU6RTA2RDBDOjZBRkI3NTc3IiwidmlzaXRvcl9pZCI6IjQyMzQxMTcyOTEwNDA3NDEwMyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacdb39e6291d15d726e09fc457ef56c032c65b7fe369d44e431316951823d2c1a8
hovercard-subject-tagpull_request:4572328528
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/7977/files
twitter:imagehttps://avatars.githubusercontent.com/u/157128530?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/157128530?s=400&v=4
og:image:altPublic chat, organization chat, and workspace chat each implemented the same filled stop icon inline. Add one StopFilled icon to EMCN and use it at all three call sites, preserving the original SVG...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None0e29e7974fdda2feeaf5c891efd4b23b0734b23480232b62c7bdef13f40b5b48
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2e8872b770cc4d5d0cc1f2026afab747a268e2ce
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/7977/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F7977%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F7977%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/7977/files
Reloadhttps://github.com/simstudioai/sim/pull/7977/files
Reloadhttps://github.com/simstudioai/sim/pull/7977/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests201 (201)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
codex/control-fix-shared-stop-iconhttps://github.com/simstudioai/sim/tree/codex/control-fix-shared-stop-icon
Conversation 2 https://github.com/simstudioai/sim/pull/7977
Commits 2 https://github.com/simstudioai/sim/pull/7977/commits
Checks 35 https://github.com/simstudioai/sim/pull/7977/checks
Files changed https://github.com/simstudioai/sim/pull/7977/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/7977/files
refactor(emcn): share filled stop icon across chat controls https://github.com/simstudioai/sim/pull/7977/files#top
Show all changes 2 commits https://github.com/simstudioai/sim/pull/7977/files
b3e8d8e refactor(emcn): share filled stop icon across chat controls Sep 18, 2026 https://github.com/simstudioai/sim/pull/7977/commits/b3e8d8e8b4dc1f59e475b8bed595c3c331fea00f
09670d4 test(desktop): wait for terminal writes to finish Sep 18, 2026 https://github.com/simstudioai/sim/pull/7977/commits/09670d4cd34344ed500a80793328ee9b854d58a5
Clear filters https://github.com/simstudioai/sim/pull/7977/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/7977/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/7977/files
selection.test.ts https://github.com/simstudioai/sim/pull/7977/files#diff-f9ab643fa1a70ddb3f48687c5087bbb52c4e378f79483912c14ee3b3313fee6c
input.tsx https://github.com/simstudioai/sim/pull/7977/files#diff-82a6e576ff6d0c1847a3667f363fe6b3b7718a75ebf2d4527403727b1afded6a
composer.tsx https://github.com/simstudioai/sim/pull/7977/files#diff-58d7a76460984ce9a5d225ebe458dfe070fcc2aad74adbaf116513c244cc5343
send-button.tsx https://github.com/simstudioai/sim/pull/7977/files#diff-3d39495853cd2882ae024dbde34b7d802a107255de61e0b8cc364cb6102506e8
index.ts https://github.com/simstudioai/sim/pull/7977/files#diff-ae94dc79bebfec2cd2987e06c43d732ab35ed14f46df866c640e6f236623fc06
stop-filled.tsx https://github.com/simstudioai/sim/pull/7977/files#diff-c1bdab6603f80218e86e602e57442170d3273cd15a6347789a39d9466aa65d16
apps/desktop/src/main/terminal/selection.test.tshttps://github.com/simstudioai/sim/pull/7977/files#diff-f9ab643fa1a70ddb3f48687c5087bbb52c4e378f79483912c14ee3b3313fee6c
View file https://github.com/simstudioai/sim/blob/09670d4cd34344ed500a80793328ee9b854d58a5/apps/desktop/src/main/terminal/selection.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/7977/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/7977/files#diff-f9ab643fa1a70ddb3f48687c5087bbb52c4e378f79483912c14ee3b3313fee6c
https://github.com/simstudioai/sim/pull/7977/files#diff-f9ab643fa1a70ddb3f48687c5087bbb52c4e378f79483912c14ee3b3313fee6c
apps/sim/app/(interfaces)/chat/components/input/input.tsxhttps://github.com/simstudioai/sim/pull/7977/files#diff-82a6e576ff6d0c1847a3667f363fe6b3b7718a75ebf2d4527403727b1afded6a
View file https://github.com/simstudioai/sim/blob/09670d4cd34344ed500a80793328ee9b854d58a5/apps/sim/app/(interfaces)/chat/components/input/input.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/7977/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/7977/files#diff-82a6e576ff6d0c1847a3667f363fe6b3b7718a75ebf2d4527403727b1afded6a
https://github.com/simstudioai/sim/pull/7977/files#diff-82a6e576ff6d0c1847a3667f363fe6b3b7718a75ebf2d4527403727b1afded6a
https://github.com/simstudioai/sim/pull/7977/files#diff-82a6e576ff6d0c1847a3667f363fe6b3b7718a75ebf2d4527403727b1afded6a
https://github.com/simstudioai/sim/pull/7977/files#diff-82a6e576ff6d0c1847a3667f363fe6b3b7718a75ebf2d4527403727b1afded6a
apps/sim/app/o/[organizationId]/home/components/composer/composer.tsxhttps://github.com/simstudioai/sim/pull/7977/files#diff-58d7a76460984ce9a5d225ebe458dfe070fcc2aad74adbaf116513c244cc5343
View file https://github.com/simstudioai/sim/blob/09670d4cd34344ed500a80793328ee9b854d58a5/apps/sim/app/o/%5BorganizationId%5D/home/components/composer/composer.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/7977/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/7977/files#diff-58d7a76460984ce9a5d225ebe458dfe070fcc2aad74adbaf116513c244cc5343
https://github.com/simstudioai/sim/pull/7977/files#diff-58d7a76460984ce9a5d225ebe458dfe070fcc2aad74adbaf116513c244cc5343
https://github.com/simstudioai/sim/pull/7977/files#diff-58d7a76460984ce9a5d225ebe458dfe070fcc2aad74adbaf116513c244cc5343
https://github.com/simstudioai/sim/pull/7977/files#diff-58d7a76460984ce9a5d225ebe458dfe070fcc2aad74adbaf116513c244cc5343
...workspace/[workspaceId]/home/components/user-input/components/send-button/send-button.tsxhttps://github.com/simstudioai/sim/pull/7977/files#diff-3d39495853cd2882ae024dbde34b7d802a107255de61e0b8cc364cb6102506e8
View file https://github.com/simstudioai/sim/blob/09670d4cd34344ed500a80793328ee9b854d58a5/apps/sim/app/workspace/%5BworkspaceId%5D/home/components/user-input/components/send-button/send-button.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/7977/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/7977/files#diff-3d39495853cd2882ae024dbde34b7d802a107255de61e0b8cc364cb6102506e8
https://github.com/simstudioai/sim/pull/7977/files#diff-3d39495853cd2882ae024dbde34b7d802a107255de61e0b8cc364cb6102506e8
https://github.com/simstudioai/sim/pull/7977/files#diff-3d39495853cd2882ae024dbde34b7d802a107255de61e0b8cc364cb6102506e8
packages/emcn/src/icons/index.tshttps://github.com/simstudioai/sim/pull/7977/files#diff-ae94dc79bebfec2cd2987e06c43d732ab35ed14f46df866c640e6f236623fc06
View file https://github.com/simstudioai/sim/blob/09670d4cd34344ed500a80793328ee9b854d58a5/packages/emcn/src/icons/index.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/7977/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/7977/files#diff-ae94dc79bebfec2cd2987e06c43d732ab35ed14f46df866c640e6f236623fc06
https://github.com/simstudioai/sim/pull/7977/files#diff-ae94dc79bebfec2cd2987e06c43d732ab35ed14f46df866c640e6f236623fc06
packages/emcn/src/icons/stop-filled.tsxhttps://github.com/simstudioai/sim/pull/7977/files#diff-c1bdab6603f80218e86e602e57442170d3273cd15a6347789a39d9466aa65d16
View file https://github.com/simstudioai/sim/blob/09670d4cd34344ed500a80793328ee9b854d58a5/packages/emcn/src/icons/stop-filled.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/7977/{{ revealButtonHref }}
Please reload this pagehttps://github.com/simstudioai/sim/pull/7977/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.