René's URL Explorer Experiment


Title: fix(knowledge): write external group membership as a diff by waleedlatif1 · Pull Request #7943 · simstudioai/sim · GitHub

Open Graph Title: fix(knowledge): write external group membership as a diff by waleedlatif1 · Pull Request #7943 · simstudioai/sim

X Title: fix(knowledge): write external group membership as a diff by waleedlatif1 · Pull Request #7943 · simstudioai/sim

Description: Summary Every directory sync deleted a group's entire external membership and reinserted it, whether or not anything had changed. That took the membership table to ~55M lifetime inserts and ~55M deletes against ~127k live rows — about 430x write amplification — holding it near 91% dead tuples across 2,447 autovacuum cycles, an order of magnitude more churn than any comparable table. That vacuum load competes for the same I/O as every other query on the instance. Membership is now written as a difference: read the group's current tokens, delete only what the enumeration no longer lists, insert only what it newly lists. An unchanged group writes nothing. The group row is locked before that read. The two callers fence on different leases — the directory lease and the connector sync lease — so neither excludes the other, and on the directory path the group upsert commits in a separate transaction, so its row lock is already released. Without the lock the removal set is computed against a snapshot a concurrent pass may have moved past, and a subject that pass inserted would survive an enumeration that never observed it: membership retained rather than revoked. The lock also closes the narrower window the blind delete already had between its delete and its commit. created_at on a member row now means first-observed rather than last-observed. No reader projects it, and the group's lastSyncedAt remains the freshness signal and is still written every pass. Also corrects the processing-queue TSDoc, which argued the per-tenant lane limits were sized rather than inherited, and cited a concurrency figure derived from an unsound measurement. Type of Change Bug fix Testing 3,150 tests pass across lib/knowledge and background; one pre-existing failure that needs DATABASE_URL bun run type-check clean, bun run lint clean, all 46 audits pass, docs manifest in sync Four tests cover it — unchanged group writes nothing, changed group writes only the delta, the group row is locked before the read, and the partial-sync case still writes the accessible group — each verified to fail when the fix is reverted Concurrency reasoning is from the lease and transaction structure, not an executed concurrent test; a Postgres integration test running two passes against one group would be the way to prove it empirically Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary Every directory sync deleted a group's entire external membership and reinserted it, whether or not anything had changed. That took the membership table to ~55M lifetime inserts and ~5...

X Description: Summary Every directory sync deleted a group's entire external membership and reinserted it, whether or not anything had changed. That took the membership table to ~55M lifetime inserts an...

Opengraph URL: https://github.com/simstudioai/sim/pull/7943

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:958365e9-7dc5-9de3-2590-2676a11eb258
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA106:1D6C4E:CCFAC:120413:6AFB758A
html-safe-nonce4439e84c22166c8dcaead3d5f131a0fd533e4c0abc55e416337439ea702d7b37
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMTA2OjFENkM0RTpDQ0ZBQzoxMjA0MTM6NkFGQjc1OEEiLCJ2aXNpdG9yX2lkIjoiMzUzMDM4MDg0MDQxODM3NTA1MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacd31775687ee005240c13434bc82a1f974663e545c72e8e033d74dd9cfae4d5f5
hovercard-subject-tagpull_request:4562893364
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/7943/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary Every directory sync deleted a group's entire external membership and reinserted it, whether or not anything had changed. That took the membership table to ~55M lifetime inserts and ~5...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None0e29e7974fdda2feeaf5c891efd4b23b0734b23480232b62c7bdef13f40b5b48
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2e8872b770cc4d5d0cc1f2026afab747a268e2ce
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/7943/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F7943%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F7943%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/7943/files
Reloadhttps://github.com/simstudioai/sim/pull/7943/files
Reloadhttps://github.com/simstudioai/sim/pull/7943/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests201 (201)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/external-group-membership-diffhttps://github.com/simstudioai/sim/tree/fix/external-group-membership-diff
Conversation 8 https://github.com/simstudioai/sim/pull/7943
Commits 2 https://github.com/simstudioai/sim/pull/7943/commits
Checks 33 https://github.com/simstudioai/sim/pull/7943/checks
Files changed https://github.com/simstudioai/sim/pull/7943/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/7943/files
fix(knowledge): write external group membership as a diff https://github.com/simstudioai/sim/pull/7943/files#top
Show all changes 2 commits https://github.com/simstudioai/sim/pull/7943/files
f828ac4 fix(knowledge): write external group membership as a diff waleedlatif1 Sep 17, 2026 https://github.com/simstudioai/sim/pull/7943/commits/f828ac45cc632376162f085026b8b5edbe8d013e
9f2e322 test(knowledge): assert the group lock precedes the membership read waleedlatif1 Sep 17, 2026 https://github.com/simstudioai/sim/pull/7943/commits/9f2e322237086c521a57736350e63015595f1a43
Clear filters https://github.com/simstudioai/sim/pull/7943/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/7943/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/7943/files
knowledge-processing.ts https://github.com/simstudioai/sim/pull/7943/files#diff-3f4102c851bc01170c71054100d270ba20a2d444e99d32cbf6450a1f0152138e
external-group-sync.test.ts https://github.com/simstudioai/sim/pull/7943/files#diff-47802eb751a970b756fca227679827a8755a99e065c0bd9cc79995af30045a7c
external-group-sync.ts https://github.com/simstudioai/sim/pull/7943/files#diff-a1b958a2ebf15709feabd85e3b9cafa1300742db2ed77ff9e592dd4747f02591
apps/sim/background/knowledge-processing.tshttps://github.com/simstudioai/sim/pull/7943/files#diff-3f4102c851bc01170c71054100d270ba20a2d444e99d32cbf6450a1f0152138e
View file https://github.com/simstudioai/sim/blob/9f2e322237086c521a57736350e63015595f1a43/apps/sim/background/knowledge-processing.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/7943/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/7943/files#diff-3f4102c851bc01170c71054100d270ba20a2d444e99d32cbf6450a1f0152138e
https://github.com/simstudioai/sim/pull/7943/files#diff-3f4102c851bc01170c71054100d270ba20a2d444e99d32cbf6450a1f0152138e
apps/sim/lib/knowledge/connectors/external-group-sync.test.tshttps://github.com/simstudioai/sim/pull/7943/files#diff-47802eb751a970b756fca227679827a8755a99e065c0bd9cc79995af30045a7c
View file https://github.com/simstudioai/sim/blob/9f2e322237086c521a57736350e63015595f1a43/apps/sim/lib/knowledge/connectors/external-group-sync.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/7943/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/7943/files#diff-47802eb751a970b756fca227679827a8755a99e065c0bd9cc79995af30045a7c
Please reload this pagehttps://github.com/simstudioai/sim/pull/7943/files
https://github.com/simstudioai/sim/pull/7943/files#diff-47802eb751a970b756fca227679827a8755a99e065c0bd9cc79995af30045a7c
https://github.com/simstudioai/sim/pull/7943/files#diff-47802eb751a970b756fca227679827a8755a99e065c0bd9cc79995af30045a7c
https://github.com/simstudioai/sim/pull/7943/files#diff-47802eb751a970b756fca227679827a8755a99e065c0bd9cc79995af30045a7c
apps/sim/lib/knowledge/connectors/external-group-sync.tshttps://github.com/simstudioai/sim/pull/7943/files#diff-a1b958a2ebf15709feabd85e3b9cafa1300742db2ed77ff9e592dd4747f02591
View file https://github.com/simstudioai/sim/blob/9f2e322237086c521a57736350e63015595f1a43/apps/sim/lib/knowledge/connectors/external-group-sync.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/7943/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/7943/files#diff-a1b958a2ebf15709feabd85e3b9cafa1300742db2ed77ff9e592dd4747f02591
https://github.com/simstudioai/sim/pull/7943/files#diff-a1b958a2ebf15709feabd85e3b9cafa1300742db2ed77ff9e592dd4747f02591
https://github.com/simstudioai/sim/pull/7943/files#diff-a1b958a2ebf15709feabd85e3b9cafa1300742db2ed77ff9e592dd4747f02591
Please reload this pagehttps://github.com/simstudioai/sim/pull/7943/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.