Title: fix(workflows): resolve finished resume runs on the run status endpoint by waleedlatif1 · Pull Request #7894 · simstudioai/sim · GitHub
Open Graph Title: fix(workflows): resolve finished resume runs on the run status endpoint by waleedlatif1 · Pull Request #7894 · simstudioai/sim
X Title: fix(workflows): resolve finished resume runs on the run status endpoint by waleedlatif1 · Pull Request #7894 · simstudioai/sim
Description: Summary A resume returns a new run ID and a statusUrl pointing at it, but the resume logs under the parent run's execution ID. The status read only matched that ID through a pending/claimed resume queue entry, so once the resume settled, GET /api/v2/workflows/{id}/runs/{runId} (and the v1 executions route) returned 404 forever readWorkflowExecutionStatus now looks up the resume entry at any status; when it has settled and there is no log row of its own, it reads the parent run and projects it under the resume's run ID The attempt keeps its own timings (claimedAt/queuedAt → completedAt); a completed attempt reports the run's state (completed, failed, or paused again with the next pause context), with no end time if a later resume is still running the run A failed attempt reports failed with the run's own error when the run failed, otherwise the entry's failureReason; it reports cancelled when the run was cancelled, and never exposes outputs or pause coordinates Viewer log projection still applies on top, as before Known limits, unchanged here: run files and resuming again are still keyed to the parent run ID, so files is empty and /resume on a resume run ID doesn't work Type of Change Bug fix Testing Added unit tests for completed, paused-again, still-running, failed, run-failed, cancelled, and missing-parent resume attempts; confirmed they fail without the fix vitest on execution-status, read-workflow-run, workflow-runs, the v1 executions route, and v2 workflow routes (307 passing) bun run type-check, bun run lint, bun run check:audits, docs-manifest:check passing Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)
Open Graph Description: Summary A resume returns a new run ID and a statusUrl pointing at it, but the resume logs under the parent run's execution ID. The status read only matched that ID through a pending/claimed re...
X Description: Summary A resume returns a new run ID and a statusUrl pointing at it, but the resume logs under the parent run's execution ID. The status read only matched that ID through a pending/claime...
Opengraph URL: https://github.com/simstudioai/sim/pull/7894
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:e9bad407-bb80-0f46-1052-38ebb5c87071 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | A40C:F138D:3F0D5A:57752B:6AFB3754 |
| html-safe-nonce | 335e1b68fffe2a463d923ea266b4324ad00df4fe341b1ca95b06ad2dfe686ff5 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNDBDOkYxMzhEOjNGMEQ1QTo1Nzc1MkI6NkFGQjM3NTQiLCJ2aXNpdG9yX2lkIjoiNjk0NjA3OTUzNjc3MzI4MTYyMCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | e34c5c0c11915a2953099de7a9e39e2f22450a743fc70873ee76e851ab8b2720 |
| hovercard-subject-tag | pull_request:4552730635 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/7894/files |
| twitter:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| og:image:alt | Summary A resume returns a new run ID and a statusUrl pointing at it, but the resume logs under the parent run's execution ID. The status read only matched that ID through a pending/claimed re... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 2169b0dfbef67ed6b128074a5ed45bb7d5d1859783b10178b09a7765ad5f3693 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/simstudioai/sim git https://github.com/simstudioai/sim.git |
| octolytics-dimension-user_id | 199344406 |
| octolytics-dimension-user_login | simstudioai |
| octolytics-dimension-repository_id | 912559512 |
| octolytics-dimension-repository_nwo | simstudioai/sim |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 912559512 |
| octolytics-dimension-repository_network_root_nwo | simstudioai/sim |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 3b4fc8df5ef1c6757e733a23e6b81b6725021823 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width