René's URL Explorer Experiment


Title: fix(credentials): clean up personal secrets in archived workspaces by icecrasher321 · Pull Request #7882 · simstudioai/sim · GitHub

Open Graph Title: fix(credentials): clean up personal secrets in archived workspaces by icecrasher321 · Pull Request #7882 · simstudioai/sim

X Title: fix(credentials): clean up personal secrets in archived workspaces by icecrasher321 · Pull Request #7882 · simstudioai/sim

Description: Summary Remove deleted personal-secret credential records across all workspaces, including archived workspaces and workspaces the user can no longer access. Reconcile against the current secret map under its lock, so delayed saves cannot remove records for newer secrets. Continue creating records only in active workspaces. Make the MCP discovery timeout test deterministic with a fake clock. Type of Change Bug fix Testing 102 tests across the credential and environment regression suites. 25 MCP client tests, including the discovery timeout regression. App type-check, repository lint, block-registry check, repository audits, and docs-manifest check. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary Remove deleted personal-secret credential records across all workspaces, including archived workspaces and workspaces the user can no longer access. Reconcile against the current secret ma...

X Description: Summary Remove deleted personal-secret credential records across all workspaces, including archived workspaces and workspaces the user can no longer access. Reconcile against the current secret ma...

Opengraph URL: https://github.com/simstudioai/sim/pull/7882

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:f09d731c-4337-91b6-c0c8-b16b3b32bd8d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE6CE:47529:410696:5CF9EF:6AFB3C91
html-safe-nonce51084492448532160cfb7b0c7239ee92246b7b80f1d73a6f1116787c848f627f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNkNFOjQ3NTI5OjQxMDY5Njo1Q0Y5RUY6NkFGQjNDOTEiLCJ2aXNpdG9yX2lkIjoiOTEyODg4ODk5NDQzMDEzOTUzOCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmace71a9d5695e46b868a31f8d4f108a73bbfb5e84d85f6531eca581767c6cf592d
hovercard-subject-tagpull_request:4550866110
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/7882/files
twitter:imagehttps://avatars.githubusercontent.com/u/17950982?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/17950982?s=400&v=4
og:image:altSummary Remove deleted personal-secret credential records across all workspaces, including archived workspaces and workspaces the user can no longer access. Reconcile against the current secret ma...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None2169b0dfbef67ed6b128074a5ed45bb7d5d1859783b10178b09a7765ad5f3693
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release3b4fc8df5ef1c6757e733a23e6b81b6725021823
ui-targetcanary-1
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/7882/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F7882%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F7882%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/7882/files
Reloadhttps://github.com/simstudioai/sim/pull/7882/files
Reloadhttps://github.com/simstudioai/sim/pull/7882/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests199 (199)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
icecrasher321https://github.com/icecrasher321
staginghttps://github.com/simstudioai/sim/tree/staging
codex/fix-personal-secret-cleanuphttps://github.com/simstudioai/sim/tree/codex/fix-personal-secret-cleanup
Conversation 5 https://github.com/simstudioai/sim/pull/7882
Commits 2 https://github.com/simstudioai/sim/pull/7882/commits
Checks 33 https://github.com/simstudioai/sim/pull/7882/checks
Files changed https://github.com/simstudioai/sim/pull/7882/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/7882/files
fix(credentials): clean up personal secrets in archived workspaces https://github.com/simstudioai/sim/pull/7882/files#top
Show all changes 2 commits https://github.com/simstudioai/sim/pull/7882/files
7b01cd8 fix(credentials): clean up personal secrets in archived workspaces Sep 16, 2026 https://github.com/simstudioai/sim/pull/7882/commits/7b01cd84a15d1a468dda1f084efb60bc5c92e870
e681bce fix(mcp): use a deterministic clock for discovery timeout test Sep 16, 2026 https://github.com/simstudioai/sim/pull/7882/commits/e681bce4899632a246345da2bb47b5c66b8bdc12
Clear filters https://github.com/simstudioai/sim/pull/7882/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/7882/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/7882/files
route.ts https://github.com/simstudioai/sim/pull/7882/files#diff-1205085c630483ac4cc07c5532fe2660cb274e9362214885b9f634e334a4fb09
environment.test.ts https://github.com/simstudioai/sim/pull/7882/files#diff-5633f2362c7aaaa6fe2b7d5e1a6babe0e1069dc97c1de527187e2fe0811bd452
environment.ts https://github.com/simstudioai/sim/pull/7882/files#diff-410fe6b2c7c0fdce4b2c736619f349af53cf8e7f7a227f0a7b1565283b7dde10
index.ts https://github.com/simstudioai/sim/pull/7882/files#diff-2fc2e4aa7edc1851a28264eadfca64761f021e141a2cfced411e9a506929c612
utils.ts https://github.com/simstudioai/sim/pull/7882/files#diff-aeda815ec30138a019eae8605afa0860a3c98f60a1b0b85c28e2709b478434d6
client.test.ts https://github.com/simstudioai/sim/pull/7882/files#diff-3c669f1cfdbdbd74ae67141932035c61beea21909c92d6e0b8ad9f26b569dcab
apps/sim/app/api/environment/route.tshttps://github.com/simstudioai/sim/pull/7882/files#diff-1205085c630483ac4cc07c5532fe2660cb274e9362214885b9f634e334a4fb09
View file https://github.com/simstudioai/sim/blob/e681bce4899632a246345da2bb47b5c66b8bdc12/apps/sim/app/api/environment/route.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/7882/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/7882/files#diff-1205085c630483ac4cc07c5532fe2660cb274e9362214885b9f634e334a4fb09
https://github.com/simstudioai/sim/pull/7882/files#diff-1205085c630483ac4cc07c5532fe2660cb274e9362214885b9f634e334a4fb09
https://github.com/simstudioai/sim/pull/7882/files#diff-1205085c630483ac4cc07c5532fe2660cb274e9362214885b9f634e334a4fb09
apps/sim/lib/credentials/environment.test.tshttps://github.com/simstudioai/sim/pull/7882/files#diff-5633f2362c7aaaa6fe2b7d5e1a6babe0e1069dc97c1de527187e2fe0811bd452
View file https://github.com/simstudioai/sim/blob/e681bce4899632a246345da2bb47b5c66b8bdc12/apps/sim/lib/credentials/environment.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/7882/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/7882/files#diff-5633f2362c7aaaa6fe2b7d5e1a6babe0e1069dc97c1de527187e2fe0811bd452
https://github.com/simstudioai/sim/pull/7882/files#diff-5633f2362c7aaaa6fe2b7d5e1a6babe0e1069dc97c1de527187e2fe0811bd452
https://github.com/simstudioai/sim/pull/7882/files#diff-5633f2362c7aaaa6fe2b7d5e1a6babe0e1069dc97c1de527187e2fe0811bd452
https://github.com/simstudioai/sim/pull/7882/files#diff-5633f2362c7aaaa6fe2b7d5e1a6babe0e1069dc97c1de527187e2fe0811bd452
https://github.com/simstudioai/sim/pull/7882/files#diff-5633f2362c7aaaa6fe2b7d5e1a6babe0e1069dc97c1de527187e2fe0811bd452
apps/sim/lib/credentials/environment.tshttps://github.com/simstudioai/sim/pull/7882/files#diff-410fe6b2c7c0fdce4b2c736619f349af53cf8e7f7a227f0a7b1565283b7dde10
View file https://github.com/simstudioai/sim/blob/e681bce4899632a246345da2bb47b5c66b8bdc12/apps/sim/lib/credentials/environment.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/7882/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/7882/files#diff-410fe6b2c7c0fdce4b2c736619f349af53cf8e7f7a227f0a7b1565283b7dde10
https://github.com/simstudioai/sim/pull/7882/files#diff-410fe6b2c7c0fdce4b2c736619f349af53cf8e7f7a227f0a7b1565283b7dde10
https://github.com/simstudioai/sim/pull/7882/files#diff-410fe6b2c7c0fdce4b2c736619f349af53cf8e7f7a227f0a7b1565283b7dde10
https://github.com/simstudioai/sim/pull/7882/files#diff-410fe6b2c7c0fdce4b2c736619f349af53cf8e7f7a227f0a7b1565283b7dde10
https://github.com/simstudioai/sim/pull/7882/files#diff-410fe6b2c7c0fdce4b2c736619f349af53cf8e7f7a227f0a7b1565283b7dde10
apps/sim/lib/credentials/orchestration/index.tshttps://github.com/simstudioai/sim/pull/7882/files#diff-2fc2e4aa7edc1851a28264eadfca64761f021e141a2cfced411e9a506929c612
View file https://github.com/simstudioai/sim/blob/e681bce4899632a246345da2bb47b5c66b8bdc12/apps/sim/lib/credentials/orchestration/index.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/7882/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/7882/files#diff-2fc2e4aa7edc1851a28264eadfca64761f021e141a2cfced411e9a506929c612
https://github.com/simstudioai/sim/pull/7882/files#diff-2fc2e4aa7edc1851a28264eadfca64761f021e141a2cfced411e9a506929c612
Please reload this pagehttps://github.com/simstudioai/sim/pull/7882/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/7882/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.