René's URL Explorer Experiment


Title: fix(cleanup): preserve log rows when file deletion fails by TheodoreSpeaks · Pull Request #7869 · simstudioai/sim · GitHub

Open Graph Title: fix(cleanup): preserve log rows when file deletion fails by TheodoreSpeaks · Pull Request #7869 · simstudioai/sim

X Title: fix(cleanup): preserve log rows when file deletion fails by TheodoreSpeaks · Pull Request #7869 · simstudioai/sim

Description: Summary Preserve the current log batch when bounded cleanup encounters a storage or file-metadata deletion failure. Check inside onBatch before the log DELETE, so a later manual run can retry the retained rows. Follow-up to #7842. Keep selected rows charged against the existing budget and stop before processing another log. The production change moves one check. Type of Change Bug fix Testing Added regressions using the real batch-delete helper with mocked storage and database calls: thrown storage errors, partial storage failures, metadata errors, subsequent manual retries, and successful deletion order. All three failure cases reproduce on the previous code. 14 focused tests passed; application type-check, lint, 46 repository audits, block-registry audit, and docs-manifest check passed. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary Preserve the current log batch when bounded cleanup encounters a storage or file-metadata deletion failure. Check inside onBatch before the log DELETE, so a later manual run can retry the ...

X Description: Summary Preserve the current log batch when bounded cleanup encounters a storage or file-metadata deletion failure. Check inside onBatch before the log DELETE, so a later manual run can retry the ...

Opengraph URL: https://github.com/simstudioai/sim/pull/7869

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:4c3876e7-549b-ab58-4b45-46953a1b3391
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC6DA:71DFA:3782DE:4EE413:6AFB39CE
html-safe-nonceed26f881c79b5abbb1657fc786e0bf70fe5a7c70c9ddaf08371be56efd8c61f1
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNkRBOjcxREZBOjM3ODJERTo0RUU0MTM6NkFGQjM5Q0UiLCJ2aXNpdG9yX2lkIjoiODk4MzI0NzYzNjk3MDI4OTYxNCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac26c3cdafcd99559f4dab6a2f60c7ef28c61f35415db938013d52196312f95af4
hovercard-subject-tagpull_request:4542537932
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/7869/files
twitter:imagehttps://avatars.githubusercontent.com/u/19564703?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/19564703?s=400&v=4
og:image:altSummary Preserve the current log batch when bounded cleanup encounters a storage or file-metadata deletion failure. Check inside onBatch before the log DELETE, so a later manual run can retry the ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None2169b0dfbef67ed6b128074a5ed45bb7d5d1859783b10178b09a7765ad5f3693
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release3b4fc8df5ef1c6757e733a23e6b81b6725021823
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/7869/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F7869%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F7869%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/7869/files
Reloadhttps://github.com/simstudioai/sim/pull/7869/files
Reloadhttps://github.com/simstudioai/sim/pull/7869/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests199 (199)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
TheodoreSpeakshttps://github.com/TheodoreSpeaks
staginghttps://github.com/simstudioai/sim/tree/staging
fix/cleanup-preserve-failed-file-logshttps://github.com/simstudioai/sim/tree/fix/cleanup-preserve-failed-file-logs
Conversation 9 https://github.com/simstudioai/sim/pull/7869
Commits 1 https://github.com/simstudioai/sim/pull/7869/commits
Checks 32 https://github.com/simstudioai/sim/pull/7869/checks
Files changed https://github.com/simstudioai/sim/pull/7869/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/7869/files
fix(cleanup): preserve log rows when file deletion fails https://github.com/simstudioai/sim/pull/7869/files#top
Show all changes 1 commit https://github.com/simstudioai/sim/pull/7869/files
fe1ab9c fix(cleanup): preserve log rows when file deletion fails TheodoreSpeaks Sep 15, 2026 https://github.com/simstudioai/sim/pull/7869/commits/fe1ab9c3f62ccf882ff86407a55004da7ddd37b4
Clear filters https://github.com/simstudioai/sim/pull/7869/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/7869/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/7869/files
cleanup-logs-files.test.ts https://github.com/simstudioai/sim/pull/7869/files#diff-2cbb8cedf700fc3d3f641d5f081afabdd93eb7f1d8daea0618c64da5f20bdc6e
cleanup-logs.ts https://github.com/simstudioai/sim/pull/7869/files#diff-5aa920679fbd8b67e6e550268dd0c6d9031297895cf596a415e6317d97d83be8
apps/sim/background/cleanup-logs-files.test.tshttps://github.com/simstudioai/sim/pull/7869/files#diff-2cbb8cedf700fc3d3f641d5f081afabdd93eb7f1d8daea0618c64da5f20bdc6e
View file https://github.com/simstudioai/sim/blob/fe1ab9c3f62ccf882ff86407a55004da7ddd37b4/apps/sim/background/cleanup-logs-files.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/7869/{{ revealButtonHref }}
Please reload this pagehttps://github.com/simstudioai/sim/pull/7869/files
apps/sim/background/cleanup-logs.tshttps://github.com/simstudioai/sim/pull/7869/files#diff-5aa920679fbd8b67e6e550268dd0c6d9031297895cf596a415e6317d97d83be8
View file https://github.com/simstudioai/sim/blob/fe1ab9c3f62ccf882ff86407a55004da7ddd37b4/apps/sim/background/cleanup-logs.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/7869/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/7869/files#diff-5aa920679fbd8b67e6e550268dd0c6d9031297895cf596a415e6317d97d83be8
https://github.com/simstudioai/sim/pull/7869/files#diff-5aa920679fbd8b67e6e550268dd0c6d9031297895cf596a415e6317d97d83be8
https://github.com/simstudioai/sim/pull/7869/files#diff-5aa920679fbd8b67e6e550268dd0c6d9031297895cf596a415e6317d97d83be8
https://github.com/simstudioai/sim/pull/7869/files#diff-5aa920679fbd8b67e6e550268dd0c6d9031297895cf596a415e6317d97d83be8
Please reload this pagehttps://github.com/simstudioai/sim/pull/7869/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.