René's URL Explorer Experiment


Title: fix(knowledge): remove connections with durable background cleanup by icecrasher321 · Pull Request #7854 · simstudioai/sim · GitHub

Open Graph Title: fix(knowledge): remove connections with durable background cleanup by icecrasher321 · Pull Request #7854 · simstudioai/sim

X Title: fix(knowledge): remove connections with durable background cleanup by icecrasher321 · Pull Request #7854 · simstudioai/sim

Description: Summary Return from connection removal after atomically disabling the source and saving a durable cleanup job. Hide its documents immediately and reject late indexing or sync writes. Drain documents, search chunks, member records, and sync history in bounded transactions, preserving storage cleanup intents and retry progress. Keep the existing document-retention behavior. Return all source detail views to Sources after successful removal, with navigation running before cache invalidation and surviving component unmounts. Type of Change Bug fix Testing Targeted Vitest coverage for removal, navigation, cache invalidation, document access, indexing, and tag cleanup. Disposable PostgreSQL integration tests cover 501 documents and 1,001 chunks, storage accounting, rollback, late sync rejection, storage cleanup, and concurrent source saves. Application type-check, repository lint, strict API validation, block registry checks, generated-artifact checks, and all repository audits passed. Static scaling review: indexed batches cap each transaction at 250 documents or 1,000 chunks/history/member rows, with up to four batches per invocation and resumable continuations. Cleanup uses the existing fair outbox scheduler. The foreground document count still scales with source size and has a statement timeout; this change does not establish production throughput benchmarks. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary Return from connection removal after atomically disabling the source and saving a durable cleanup job. Hide its documents immediately and reject late indexing or sync writes. Drain documen...

X Description: Summary Return from connection removal after atomically disabling the source and saving a durable cleanup job. Hide its documents immediately and reject late indexing or sync writes. Drain documen...

Opengraph URL: https://github.com/simstudioai/sim/pull/7854

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:549863eb-7504-b013-6142-07f54e8361fb
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9DE6:71C2F:1FA3F5:2BBDFB:6AFB3083
html-safe-nonce285547808b2de0b56972f48240d6719cf9be1d62294449842780b7d28e882f8d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5REU2OjcxQzJGOjFGQTNGNToyQkJERkI6NkFGQjMwODMiLCJ2aXNpdG9yX2lkIjoiNzAwNzEwMjkyNjAzNjA4NjkxNiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac4230a8aecff8fb7007b255f7b80cf9e96007d0bfb0b3a0f3151ace12a3ef7b82
hovercard-subject-tagpull_request:4540272355
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/7854/files
twitter:imagehttps://avatars.githubusercontent.com/u/17950982?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/17950982?s=400&v=4
og:image:altSummary Return from connection removal after atomically disabling the source and saving a durable cleanup job. Hide its documents immediately and reject late indexing or sync writes. Drain documen...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneefe184de15c1d8c1107a340cfc27bf7187b458dc07687ee1fa51f035148fb3d1
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasef567cf3af46b50a3211fb5dab569a9d6a7b58025
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/7854/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F7854%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F7854%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/7854/files
Reloadhttps://github.com/simstudioai/sim/pull/7854/files
Reloadhttps://github.com/simstudioai/sim/pull/7854/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests198 (198)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
icecrasher321https://github.com/icecrasher321
staginghttps://github.com/simstudioai/sim/tree/staging
codex/connection-removal-cleanuphttps://github.com/simstudioai/sim/tree/codex/connection-removal-cleanup
Conversation 2 https://github.com/simstudioai/sim/pull/7854
Commits 1 https://github.com/simstudioai/sim/pull/7854/commits
Checks 32 https://github.com/simstudioai/sim/pull/7854/checks
Files changed https://github.com/simstudioai/sim/pull/7854/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/7854/files
fix(knowledge): remove connections with durable background cleanup https://github.com/simstudioai/sim/pull/7854/files#top
Show all changes 1 commit https://github.com/simstudioai/sim/pull/7854/files
f02249a fix(knowledge): remove connections with durable background cleanup Sep 15, 2026 https://github.com/simstudioai/sim/pull/7854/commits/f02249a802b332f8a710f725642d8caee0bbb3d9
Clear filters https://github.com/simstudioai/sim/pull/7854/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/7854/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/7854/files
source-detail.test.tsx https://github.com/simstudioai/sim/pull/7854/files#diff-61c201981876a22255a310d85f793519c257b9ee8d744bd4a5f1ca079d911663
source-detail.tsx https://github.com/simstudioai/sim/pull/7854/files#diff-bfe7371260b0b3c969f27c00a2b01252c437271dc63af833bd3f14b0ca2a298d
connectors-section.test.tsx https://github.com/simstudioai/sim/pull/7854/files#diff-589fe7bae9fe856b0265388a8b424a759ffbad5d14b93b059441b9567a253c5b
use-connector-actions.ts https://github.com/simstudioai/sim/pull/7854/files#diff-59e19fdd8ee96ab1b60562d1e37886ba85bbf244ba53251a712464dcb04050b6
connectors-cache.test.tsx https://github.com/simstudioai/sim/pull/7854/files#diff-8e3f6daba93636000d2b9767be5c4e8c2067b909e6a5d65a3781367f79d10202
connectors.ts https://github.com/simstudioai/sim/pull/7854/files#diff-13f97cd6f6b052ac1fb420979601d978b4aee1a9e84b5dba8e12845057e8ddf2
storage-accounting.integration.ts https://github.com/simstudioai/sim/pull/7854/files#diff-47880688a2b029ee038f1b6bda34ec6cc1d336bebaad4c9bd980b11912fd82f2
predicate.test.ts https://github.com/simstudioai/sim/pull/7854/files#diff-cbeeaa5cc835fb1fedc629c869b2a5f952eb1c7343e44960b6a8dfe126660ff1
predicate.ts https://github.com/simstudioai/sim/pull/7854/files#diff-720ce8ebbff1c232b2a35c2b75ac2bb1983110156c6d866f4127172e619c4df3
types.ts https://github.com/simstudioai/sim/pull/7854/files#diff-0f604e212994706854c1cca95f0053e93387f0abd22def425bb32ec73bca62b5
deletion.md https://github.com/simstudioai/sim/pull/7854/files#diff-9cf42b59bbcab9c1c666cd23c49ebbeb59fa94a3467bc186d0ef393b5c354ca9
deletion.test.ts https://github.com/simstudioai/sim/pull/7854/files#diff-8441eec666e8970586e58da83a195ff50a56e622e9dd8d5d1fe6bd394d25ded7
deletion.ts https://github.com/simstudioai/sim/pull/7854/files#diff-d02521be19346090e00c94d1a38790e17d00e47060da90c0a65f27ed8eb2d09b
connector-lifecycle.ts https://github.com/simstudioai/sim/pull/7854/files#diff-7e829ada0f5d21fd7d206c3482f13d31695feb2209bae501b733b733d6c45725
processing-outbox-handler.ts https://github.com/simstudioai/sim/pull/7854/files#diff-203b2960e8aa7bea9c7d2ab11de41c9632fc6708e3621737f01decc6793346d4
service.ts https://github.com/simstudioai/sim/pull/7854/files#diff-12adff6ec055d413ec20f1debed4ca207b994d23df6de9aa4ef79bf47f2857b2
connectors.test.ts https://github.com/simstudioai/sim/pull/7854/files#diff-ad352d1373d2052001dc8af9e95b9f27467ea46cd5014040c43765b19b980955
connectors.ts https://github.com/simstudioai/sim/pull/7854/files#diff-50cb99189b1dc87df12d9b4f50a563206952b53de947873de00ad9f30ef59a25
service.test.ts https://github.com/simstudioai/sim/pull/7854/files#diff-6ab99007963a2c376955441371306a455d8efb669c82847e45df92c8f9d41858
service.ts https://github.com/simstudioai/sim/pull/7854/files#diff-4fdaff0349702c024b13f9efe5c76cfb3670292a7818fd9fe403ae789eae2632
...app/o/[organizationId]/settings/integrations/sources/[connectorId]/source-detail.test.tsxhttps://github.com/simstudioai/sim/pull/7854/files#diff-61c201981876a22255a310d85f793519c257b9ee8d744bd4a5f1ca079d911663
View file https://github.com/simstudioai/sim/blob/f02249a802b332f8a710f725642d8caee0bbb3d9/apps/sim/app/o/%5BorganizationId%5D/settings/integrations/sources/%5BconnectorId%5D/source-detail.test.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/7854/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/7854/files#diff-61c201981876a22255a310d85f793519c257b9ee8d744bd4a5f1ca079d911663
https://github.com/simstudioai/sim/pull/7854/files#diff-61c201981876a22255a310d85f793519c257b9ee8d744bd4a5f1ca079d911663
https://github.com/simstudioai/sim/pull/7854/files#diff-61c201981876a22255a310d85f793519c257b9ee8d744bd4a5f1ca079d911663
https://github.com/simstudioai/sim/pull/7854/files#diff-61c201981876a22255a310d85f793519c257b9ee8d744bd4a5f1ca079d911663
https://github.com/simstudioai/sim/pull/7854/files#diff-61c201981876a22255a310d85f793519c257b9ee8d744bd4a5f1ca079d911663
.../sim/app/o/[organizationId]/settings/integrations/sources/[connectorId]/source-detail.tsxhttps://github.com/simstudioai/sim/pull/7854/files#diff-bfe7371260b0b3c969f27c00a2b01252c437271dc63af833bd3f14b0ca2a298d
View file https://github.com/simstudioai/sim/blob/f02249a802b332f8a710f725642d8caee0bbb3d9/apps/sim/app/o/%5BorganizationId%5D/settings/integrations/sources/%5BconnectorId%5D/source-detail.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/7854/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/7854/files#diff-bfe7371260b0b3c969f27c00a2b01252c437271dc63af833bd3f14b0ca2a298d
https://github.com/simstudioai/sim/pull/7854/files#diff-bfe7371260b0b3c969f27c00a2b01252c437271dc63af833bd3f14b0ca2a298d
https://github.com/simstudioai/sim/pull/7854/files#diff-bfe7371260b0b3c969f27c00a2b01252c437271dc63af833bd3f14b0ca2a298d
https://github.com/simstudioai/sim/pull/7854/files#diff-bfe7371260b0b3c969f27c00a2b01252c437271dc63af833bd3f14b0ca2a298d
https://github.com/simstudioai/sim/pull/7854/files#diff-bfe7371260b0b3c969f27c00a2b01252c437271dc63af833bd3f14b0ca2a298d
https://github.com/simstudioai/sim/pull/7854/files#diff-bfe7371260b0b3c969f27c00a2b01252c437271dc63af833bd3f14b0ca2a298d
https://github.com/simstudioai/sim/pull/7854/files#diff-bfe7371260b0b3c969f27c00a2b01252c437271dc63af833bd3f14b0ca2a298d
https://github.com/simstudioai/sim/pull/7854/files#diff-bfe7371260b0b3c969f27c00a2b01252c437271dc63af833bd3f14b0ca2a298d
https://github.com/simstudioai/sim/pull/7854/files#diff-bfe7371260b0b3c969f27c00a2b01252c437271dc63af833bd3f14b0ca2a298d
https://github.com/simstudioai/sim/pull/7854/files#diff-bfe7371260b0b3c969f27c00a2b01252c437271dc63af833bd3f14b0ca2a298d
...ce/[workspaceId]/knowledge/[id]/components/connectors-section/connectors-section.test.tsxhttps://github.com/simstudioai/sim/pull/7854/files#diff-589fe7bae9fe856b0265388a8b424a759ffbad5d14b93b059441b9567a253c5b
View file https://github.com/simstudioai/sim/blob/f02249a802b332f8a710f725642d8caee0bbb3d9/apps/sim/app/workspace/%5BworkspaceId%5D/knowledge/%5Bid%5D/components/connectors-section/connectors-section.test.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/7854/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/7854/files#diff-589fe7bae9fe856b0265388a8b424a759ffbad5d14b93b059441b9567a253c5b
https://github.com/simstudioai/sim/pull/7854/files#diff-589fe7bae9fe856b0265388a8b424a759ffbad5d14b93b059441b9567a253c5b
https://github.com/simstudioai/sim/pull/7854/files#diff-589fe7bae9fe856b0265388a8b424a759ffbad5d14b93b059441b9567a253c5b
https://github.com/simstudioai/sim/pull/7854/files#diff-589fe7bae9fe856b0265388a8b424a759ffbad5d14b93b059441b9567a253c5b
https://github.com/simstudioai/sim/pull/7854/files#diff-589fe7bae9fe856b0265388a8b424a759ffbad5d14b93b059441b9567a253c5b
https://github.com/simstudioai/sim/pull/7854/files#diff-589fe7bae9fe856b0265388a8b424a759ffbad5d14b93b059441b9567a253c5b
...space/[workspaceId]/knowledge/[id]/components/connectors-section/use-connector-actions.tshttps://github.com/simstudioai/sim/pull/7854/files#diff-59e19fdd8ee96ab1b60562d1e37886ba85bbf244ba53251a712464dcb04050b6
View file https://github.com/simstudioai/sim/blob/f02249a802b332f8a710f725642d8caee0bbb3d9/apps/sim/app/workspace/%5BworkspaceId%5D/knowledge/%5Bid%5D/components/connectors-section/use-connector-actions.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/7854/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/7854/files#diff-59e19fdd8ee96ab1b60562d1e37886ba85bbf244ba53251a712464dcb04050b6
https://github.com/simstudioai/sim/pull/7854/files#diff-59e19fdd8ee96ab1b60562d1e37886ba85bbf244ba53251a712464dcb04050b6
https://github.com/simstudioai/sim/pull/7854/files#diff-59e19fdd8ee96ab1b60562d1e37886ba85bbf244ba53251a712464dcb04050b6
https://github.com/simstudioai/sim/pull/7854/files#diff-59e19fdd8ee96ab1b60562d1e37886ba85bbf244ba53251a712464dcb04050b6
apps/sim/hooks/queries/kb/connectors-cache.test.tsxhttps://github.com/simstudioai/sim/pull/7854/files#diff-8e3f6daba93636000d2b9767be5c4e8c2067b909e6a5d65a3781367f79d10202
View file https://github.com/simstudioai/sim/blob/f02249a802b332f8a710f725642d8caee0bbb3d9/apps/sim/hooks/queries/kb/connectors-cache.test.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/7854/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/7854/files#diff-8e3f6daba93636000d2b9767be5c4e8c2067b909e6a5d65a3781367f79d10202
https://github.com/simstudioai/sim/pull/7854/files#diff-8e3f6daba93636000d2b9767be5c4e8c2067b909e6a5d65a3781367f79d10202
apps/sim/hooks/queries/kb/connectors.tshttps://github.com/simstudioai/sim/pull/7854/files#diff-13f97cd6f6b052ac1fb420979601d978b4aee1a9e84b5dba8e12845057e8ddf2
View file https://github.com/simstudioai/sim/blob/f02249a802b332f8a710f725642d8caee0bbb3d9/apps/sim/hooks/queries/kb/connectors.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/7854/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/7854/files#diff-13f97cd6f6b052ac1fb420979601d978b4aee1a9e84b5dba8e12845057e8ddf2
https://github.com/simstudioai/sim/pull/7854/files#diff-13f97cd6f6b052ac1fb420979601d978b4aee1a9e84b5dba8e12845057e8ddf2
Please reload this pagehttps://github.com/simstudioai/sim/pull/7854/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/7854/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.