René's URL Explorer Experiment


Title: fix(tables): rework lock settings as Table Security and gate locked actions by j15z · Pull Request #7853 · simstudioai/sim · GitHub

Open Graph Title: fix(tables): rework lock settings as Table Security and gate locked actions by j15z · Pull Request #7853 · simstudioai/sim

X Title: fix(tables): rework lock settings as Table Security and gate locked actions by j15z · Pull Request #7853 · simstudioai/sim

Description: Summary Replaces Lock settings with a Table Security modal, and makes a denied action explain itself where the user meets it instead of failing on save or doing nothing at all. Table Security modal: Deny / Allow rows for Inserting Rows, Updating Rows, Deleting Rows, and Changing Table Schema. The rows map one-to-one onto the existing four lock flags — Deny is a set lock — so an unconfigured table opens on four Allows and every viewer sees the same state. No backend or migration change. Changing Table Schema denied: New column keeps a lock icon, is aria-disabled, and explains itself in a tooltip. Edit column, Insert column left/right, and Delete column are all disabled with tooltips. Clicking a column header opens the config panel read-only — values stay readable and selectable, the controls are inert, and Save carries the reason. Hide column is untouched: hiding a workflow output is a metadata change no lock covers. Updating Rows denied: Double-click and Enter/F2 still open the cell editor, read-only, so values can be selected and copied. Text and number inputs are read-only, date cells hide the calendar, and select options are disabled. The expanded text editor opens read-only with Save disabled and the reason on hover; its footer hint no longer advertises ↵ save. Clicking a checkbox cell raises the same notice the keyboard paths already did, instead of silently doing nothing. An empty cell that can't be edited opens nothing (also applies to users without edit access). Inserting Rows denied: New row keeps a lock icon and tooltip; Insert row above/below and Duplicate row are disabled. New rows through the Add Row form: a blank row doesn't work when updates are denied (typing into it is an update) or when any column is required (the server rejects an empty row). In either case New row, Shift+Enter, and Insert row above/below open the Add Row form at that position, and the form inserts the complete row in one request. Row form: Add mode with an optional insert position; Add Row and Update Row stay disabled until every required field has a value. Values are read and written by column id. Before this, Edit Row showed empty fields and saved under the column name on columns that have an id. Only touched fields are sent, and in edit mode only changed ones, so an untouched empty column is no longer written as null and a no-op save closes without a write. Checkboxes are the exception on insert: they always carry a concrete boolean. A rejected write renders once, inline. Row mutations take an opt-in suppressErrorToast; the cache self-heal on a 423 still runs. Date columns use one date-and-time picker, matching the grid. Copy: notices speak the modal's Allow/Deny vocabulary and name the row that denies the action; tooltip strings live in lock-copy rather than at each call site. ChipDatePicker: follows InsideModalContext like ChipDropdown (#7435 missed it), so its calendar is clickable inside modals, including the document tags modal. Single mode gains showTime and timeLabel. Reviewer notes: Rows added through the Add Row form aren't added to the grid's undo history. A disabled Save doesn't say which required field is empty; required fields are marked with *. A new TTL value picked in the Add Row form saves with a -00:00 offset while date columns use the viewer's local offset. Existing behavior, left as is. Two pre-existing server bugs surfaced while testing and are deliberately out of scope: the metadata endpoint can strip a workflow group's dependencies on a schema-locked table, and unique values and row caps can be exceeded by parallel inserts. Tracked separately. Type of Change Bug fix New feature Breaking change Documentation Other: ___________ Testing Unit tests for: Table Security modal: always renders the four rows, starts an unconfigured table on Allow, mirrors server locks with Deny as a set lock, saves denied actions as locks, and keeps the modal open with the draft intact when the save fails. Locked New column trigger: stays focusable, shows its tooltip, and opens no menu. Expanded cell editor: read-only with Save disabled and the reason on hover, footer hint drops ↵ save while blocked, and saves normally when allowed. Inline editors: read-only text input, and a read-only date input without the calendar. Row form: add mode inserts once under column ids and at a requested position, Save stays disabled until required fields have values, edit mode reads and saves by column id, a no-op edit writes nothing, an insert omits untouched columns but still sends checkboxes, and expiration date and time edits keep their offset. type-check and lint pass; 607 tests across tables/[tableId] and hooks/queries pass. Exercised in the running app against a local database: Read-only column panel (typing leaves the value unchanged), tooltips on the disabled column-menu rows, the checkbox-cell notice, the reworded on-open notice, the modal without its switch, and a unique-violation error appearing only inside the form. Server enforcement, called directly: every row, column, upsert, CSV import, and archive path returns 423 on a denied action and changes nothing; only admins can change locks (403 otherwise), and a write-only user sees no Table Security entry. A lock set in another tab reaches an open grid within ~2s over SSE, and submitting an already-open Add Row form is then refused by the server with the reason shown inline. Scale: a 105k-row table pages 1,000 rows in ~90ms, virtualizes to ~47 rendered rows while scrolling, and lock toggles take 14–19ms. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA) Screenshots/Videos Before: After: 🤖 Generated with Claude Code

Open Graph Description: Summary Replaces Lock settings with a Table Security modal, and makes a denied action explain itself where the user meets it instead of failing on save or doing nothing at all. Table Security moda...

X Description: Summary Replaces Lock settings with a Table Security modal, and makes a denied action explain itself where the user meets it instead of failing on save or doing nothing at all. Table Security moda...

Opengraph URL: https://github.com/simstudioai/sim/pull/7853

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:c2cbfc75-a4c4-9763-9d9a-05304b5fa8e0
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8668:138436:4F13B8:715A68:6AFB3C85
html-safe-nonce4c7ba94acc8781fd9fa6d2d51df00c4d4d13bf8288a36a92d05c900ee5bc4728
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NjY4OjEzODQzNjo0RjEzQjg6NzE1QTY4OjZBRkIzQzg1IiwidmlzaXRvcl9pZCI6IjU3ODg5NTY1MTQ3Njg4NjIzNDEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac51ab53f3064faf836901b2155515dbf80321d4f145850afd1977bf6fdd99c68b
hovercard-subject-tagpull_request:4539674641
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/7853/files
twitter:imagehttps://avatars.githubusercontent.com/u/96924014?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/96924014?s=400&v=4
og:image:altSummary Replaces Lock settings with a Table Security modal, and makes a denied action explain itself where the user meets it instead of failing on save or doing nothing at all. Table Security moda...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None2169b0dfbef67ed6b128074a5ed45bb7d5d1859783b10178b09a7765ad5f3693
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release3b4fc8df5ef1c6757e733a23e6b81b6725021823
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/7853/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F7853%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F7853%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/7853/files
Reloadhttps://github.com/simstudioai/sim/pull/7853/files
Reloadhttps://github.com/simstudioai/sim/pull/7853/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests199 (199)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
j15zhttps://github.com/j15z
staginghttps://github.com/simstudioai/sim/tree/staging
fix/row-locking-columns-bughttps://github.com/simstudioai/sim/tree/fix/row-locking-columns-bug
Conversation 11 https://github.com/simstudioai/sim/pull/7853
Commits 7 https://github.com/simstudioai/sim/pull/7853/commits
Checks 36 https://github.com/simstudioai/sim/pull/7853/checks
Files changed https://github.com/simstudioai/sim/pull/7853/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/7853/files
fix(tables): rework lock settings as Table Security and gate locked actions https://github.com/simstudioai/sim/pull/7853/files#top
Show all changes 7 commits https://github.com/simstudioai/sim/pull/7853/files
f911b7d fix(tables): block schema-locked column edits and rework lock setting… j15z Sep 15, 2026 https://github.com/simstudioai/sim/pull/7853/commits/f911b7d0059fa35a7b1f8951143d51f7cf9bd9fe
1dbc256 fix(tables): read-only cell editors and add-row form for update-locke… j15z Sep 15, 2026 https://github.com/simstudioai/sim/pull/7853/commits/1dbc256dfad85ea1638e1e77aec73d72ab1d6a43
fe76390 fix(tables): open the add-row form for required columns and gate Save… j15z Sep 15, 2026 https://github.com/simstudioai/sim/pull/7853/commits/fe76390bd7a73e389dfeeceb83432d78a0008def
9e80171 fix(tables): explain denied actions where the user meets them j15z Sep 15, 2026 https://github.com/simstudioai/sim/pull/7853/commits/9e8017159a9bcbdbeffc576618489a02fd079140
a555ae0 fix(tables): write only what the row form changed, and report failure… j15z Sep 15, 2026 https://github.com/simstudioai/sim/pull/7853/commits/a555ae00009164255e84cd4a09ca8152ca59deaa
f0efedb refactor(tables): drop the Table Security switch and its device-local… j15z Sep 15, 2026 https://github.com/simstudioai/sim/pull/7853/commits/f0efedb433ac21e5a6912e1a081c220023c07ac5
4e99e4c fix(tables): stage only the Table Security rows an admin moves j15z Sep 15, 2026 https://github.com/simstudioai/sim/pull/7853/commits/4e99e4c4f477d77661217c0df683b2601133e583
Clear filters https://github.com/simstudioai/sim/pull/7853/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/7853/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/7853/files
column-config-sidebar.tsx https://github.com/simstudioai/sim/pull/7853/files#diff-8a24c4a972a10a939213feae3b7af45f0e88bae9450414d39544d91dabc55617
column-dropdown.test.tsx https://github.com/simstudioai/sim/pull/7853/files#diff-a65d0e540637989b369d77f8677be55c1efb2e774a345562b52570a9303d632a
column-dropdown.tsx https://github.com/simstudioai/sim/pull/7853/files#diff-5574d2bf975721c096745a80f63afab202f4505b39edd977b18b48bded4930b5
context-menu.tsx https://github.com/simstudioai/sim/pull/7853/files#diff-a02c6ba9510d30cd146086b162347ce660bbb0b6fc60422ac9c15a546bdab4ec
lock-settings-modal.test.tsx https://github.com/simstudioai/sim/pull/7853/files#diff-6c33715cc6186103908961dbc9db5ea9ed267eb0b08782aae074d5623dd78320
lock-settings-modal.tsx https://github.com/simstudioai/sim/pull/7853/files#diff-616fc6897d8c7913d64f964f9c08ae1faad3eacee83d117e9afa8e6282ea9111
row-modal.test.tsx https://github.com/simstudioai/sim/pull/7853/files#diff-aa6ee345b22df305a938ce2b004ab0503cc63fb702c649b2b310c4203004d559
row-modal.tsx https://github.com/simstudioai/sim/pull/7853/files#diff-9986b620bc5f8be1944a82484bf46df8d123d4540fbfa93fbdf62354e42981af
cell-content.tsx https://github.com/simstudioai/sim/pull/7853/files#diff-692be98f9c221a1aac811accbd326f45972d2c29b40c2b90bf91eb4db00aa514
expanded-cell-popover.test.tsx https://github.com/simstudioai/sim/pull/7853/files#diff-258737dd1379caf429e447ca35ab7395ca0c1ff7c97c0804e9b7e292a7779424
expanded-cell-popover.tsx https://github.com/simstudioai/sim/pull/7853/files#diff-b5511af300b3ab6bc2a58a2238074f6059577eb71f0bc6bff6d3031221f39558
inline-editors.test.ts https://github.com/simstudioai/sim/pull/7853/files#diff-f0f1706b238e8afadb65d1d3d6274fafa497d0080221d8ee38270f25c19a86d5
inline-editors.tsx https://github.com/simstudioai/sim/pull/7853/files#diff-71977816ed06f4cfda658b1747bf82f9524669ee7e3145b5d3945f651415f440
data-row.tsx https://github.com/simstudioai/sim/pull/7853/files#diff-155cf6284924ef5ffefab01aeeac331ed062f9820ca686c1ac2b95466cbbed92
column-header-menu.tsx https://github.com/simstudioai/sim/pull/7853/files#diff-a45be6a7fd7c9d1594e1487563b125510959eb63dd7299d2f7cfbf331ff2b0e7
workflow-group-meta-cell.tsx https://github.com/simstudioai/sim/pull/7853/files#diff-bd1a8a30136bb79bf1b1a9eb640455c7757848a8e043eb0daec82c6464a679b7
table-grid.tsx https://github.com/simstudioai/sim/pull/7853/files#diff-264141b75a0ee2c4464df4bb6f5722cd982587470cf162e5aae9de04c84fbc0e
table-primitives.tsx https://github.com/simstudioai/sim/pull/7853/files#diff-2b70ae8ce0b528a066db05840f62bda1f407ac40a7715e6d60e44105b07f257b
lock-copy.ts https://github.com/simstudioai/sim/pull/7853/files#diff-23df79ddd62d338849707f472a35eb52f918d813d0c8a2831f030ab902cccb2a
table.tsx https://github.com/simstudioai/sim/pull/7853/files#diff-5a65d49f1fb75a42db9178db41caa5cb9bf776a547ab82822e99a13bd51a1669
types.ts https://github.com/simstudioai/sim/pull/7853/files#diff-5a4db015be564e662598b93200ae9fbba372e13bb50eb7b2b14814cd5670343a
tables.ts https://github.com/simstudioai/sim/pull/7853/files#diff-1d761ed5a7a2ed9ba4435d0f39c5f1f7ac13c177b301c401b38f5a6d731ac8cb
chip-date-picker.tsx https://github.com/simstudioai/sim/pull/7853/files#diff-0b4622e3ccc8409e1d9c7d3f622676bf28c3a45190853b1613206790cf30cf35
...[workspaceId]/tables/[tableId]/components/column-config-sidebar/column-config-sidebar.tsxhttps://github.com/simstudioai/sim/pull/7853/files#diff-8a24c4a972a10a939213feae3b7af45f0e88bae9450414d39544d91dabc55617
View file https://github.com/simstudioai/sim/blob/4e99e4c4f477d77661217c0df683b2601133e583/apps/sim/app/workspace/%5BworkspaceId%5D/tables/%5BtableId%5D/components/column-config-sidebar/column-config-sidebar.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/7853/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/7853/files#diff-8a24c4a972a10a939213feae3b7af45f0e88bae9450414d39544d91dabc55617
https://github.com/simstudioai/sim/pull/7853/files#diff-8a24c4a972a10a939213feae3b7af45f0e88bae9450414d39544d91dabc55617
https://github.com/simstudioai/sim/pull/7853/files#diff-8a24c4a972a10a939213feae3b7af45f0e88bae9450414d39544d91dabc55617
https://github.com/simstudioai/sim/pull/7853/files#diff-8a24c4a972a10a939213feae3b7af45f0e88bae9450414d39544d91dabc55617
https://github.com/simstudioai/sim/pull/7853/files#diff-8a24c4a972a10a939213feae3b7af45f0e88bae9450414d39544d91dabc55617
https://github.com/simstudioai/sim/pull/7853/files#diff-8a24c4a972a10a939213feae3b7af45f0e88bae9450414d39544d91dabc55617
https://github.com/simstudioai/sim/pull/7853/files#diff-8a24c4a972a10a939213feae3b7af45f0e88bae9450414d39544d91dabc55617
https://github.com/simstudioai/sim/pull/7853/files#diff-8a24c4a972a10a939213feae3b7af45f0e88bae9450414d39544d91dabc55617
https://github.com/simstudioai/sim/pull/7853/files#diff-8a24c4a972a10a939213feae3b7af45f0e88bae9450414d39544d91dabc55617
...kspace/[workspaceId]/tables/[tableId]/components/column-dropdown/column-dropdown.test.tsxhttps://github.com/simstudioai/sim/pull/7853/files#diff-a65d0e540637989b369d77f8677be55c1efb2e774a345562b52570a9303d632a
View file https://github.com/simstudioai/sim/blob/4e99e4c4f477d77661217c0df683b2601133e583/apps/sim/app/workspace/%5BworkspaceId%5D/tables/%5BtableId%5D/components/column-dropdown/column-dropdown.test.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/7853/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/7853/files#diff-a65d0e540637989b369d77f8677be55c1efb2e774a345562b52570a9303d632a
https://github.com/simstudioai/sim/pull/7853/files#diff-a65d0e540637989b369d77f8677be55c1efb2e774a345562b52570a9303d632a
https://github.com/simstudioai/sim/pull/7853/files#diff-a65d0e540637989b369d77f8677be55c1efb2e774a345562b52570a9303d632a
Please reload this pagehttps://github.com/simstudioai/sim/pull/7853/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/7853/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.