René's URL Explorer Experiment


Title: fix(executor): seed run-wide access key lists and scope exact-key cache grants by waleedlatif1 · Pull Request #7850 · simstudioai/sim · GitHub

Open Graph Title: fix(executor): seed run-wide access key lists and scope exact-key cache grants by waleedlatif1 · Pull Request #7850 · simstudioai/sim

X Title: fix(executor): seed run-wide access key lists and scope exact-key cache grants by waleedlatif1 · Pull Request #7850 · simstudioai/sim

Description: Summary Child executors started with no largeValueKeys / fileKeys lists, so the ??= [] append a block makes landed on its per-block context copy and was dropped. Seed both lists in createExecutionContext: top-level runs keep the lists they pass in, child executors get their own empty lists and never the parent's (an exact key is an access grant, so sharing would widen access across custom blocks) The sync large-value cache honored an exact key grant without checking the key's workspace and workflow, while the async storage check refuses a key from another workspace/workflow before looking at grants. Both now call one isGrantedLargeValueKey predicate Correct the executionFilesById TSDoc: the index is built per block from block states, not shared across the run Investigated making the execution file index run-scoped and did not: agent tool results already land in block outputs, so later blocks find those files, and a run-wide index would expose files from failed blocks and names recorded before output redaction Type of Change Bug fix Testing New tests: keys recorded on a block copy reach the run, passed-in lists are shared by reference, a granted key from the same workflow is served from cache, a granted key for another workspace/workflow or a scope without one is refused Verified the new tests fail against the old code Affected vitest suites, type-check, lint, check:audits all pass Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary Child executors started with no largeValueKeys / fileKeys lists, so the ??= [] append a block makes landed on its per-block context copy and was dropped. Seed both lists in createExecution...

X Description: Summary Child executors started with no largeValueKeys / fileKeys lists, so the ??= [] append a block makes landed on its per-block context copy and was dropped. Seed both lists in createExecution...

Opengraph URL: https://github.com/simstudioai/sim/pull/7850

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:9fe5ba2b-3be0-dfcf-dbf4-f008bb449342
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8D82:2DACD6:1D2EC:27E9C:6AFB64B9
html-safe-noncef45911b0c7c6ec9f1172c0bf603daafaeeea0d82006f755bb31537c22bbee87c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4RDgyOjJEQUNENjoxRDJFQzoyN0U5Qzo2QUZCNjRCOSIsInZpc2l0b3JfaWQiOiIzOTcyMDgyODMxOTg2NDg0NDA5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacb57fd78f77ba48525fbdaccd19d879918e6083667fa964d4b0265aa1d563c6af
hovercard-subject-tagpull_request:4532925991
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/7850/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary Child executors started with no largeValueKeys / fileKeys lists, so the ??= [] append a block makes landed on its per-block context copy and was dropped. Seed both lists in createExecution...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneea33d13c96d0ff66bd8fa906b193d2213536b78cb06b0c50a4632c58b1418f94
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release59ef97164c52cf59bd10558ddec9c4f482763988
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/7850/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F7850%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F7850%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/7850/files
Reloadhttps://github.com/simstudioai/sim/pull/7850/files
Reloadhttps://github.com/simstudioai/sim/pull/7850/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/execution-context-shared-statehttps://github.com/simstudioai/sim/tree/fix/execution-context-shared-state
Conversation 2 https://github.com/simstudioai/sim/pull/7850
Commits 1 https://github.com/simstudioai/sim/pull/7850/commits
Checks 32 https://github.com/simstudioai/sim/pull/7850/checks
Files changed https://github.com/simstudioai/sim/pull/7850/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/7850/files
fix(executor): seed run-wide access key lists and scope exact-key cache grants https://github.com/simstudioai/sim/pull/7850/files#top
Show all changes 1 commit https://github.com/simstudioai/sim/pull/7850/files
3ed1795 fix(executor): seed run-wide access key lists and scope exact-key cac… waleedlatif1 Sep 15, 2026 https://github.com/simstudioai/sim/pull/7850/commits/3ed1795e68ca71ebbd2d492a87e4dd2401bc6876
Clear filters https://github.com/simstudioai/sim/pull/7850/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/7850/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/7850/files
executor.test.ts https://github.com/simstudioai/sim/pull/7850/files#diff-566018bae9e15f4be75dbbd3a4b910753cb4053ff3c755d7897415d1a43d6f67
executor.ts https://github.com/simstudioai/sim/pull/7850/files#diff-749f8b453a93eaba5cab96f549bbc618400c2aead886a3444c868730c511dc1b
types.ts https://github.com/simstudioai/sim/pull/7850/files#diff-b266de0e8311cee15872078a12705439e0d9b58ab87b7685752a0b3ea60cd378
cache.test.ts https://github.com/simstudioai/sim/pull/7850/files#diff-de08fd02c7448f67d885d17e35ce4426242af43415c70280a7557d91d01f4531
cache.ts https://github.com/simstudioai/sim/pull/7850/files#diff-42e85cfef430ab900927ed39b89b6537e631bddc29e5a80cb2b7a80575b7d2d9
large-value-ref.ts https://github.com/simstudioai/sim/pull/7850/files#diff-f773081e362806f2cc2bb183262feac73faa0c2ae0950233c217cfcaf0d54231
materialization.server.ts https://github.com/simstudioai/sim/pull/7850/files#diff-a1e3fcedf46279b15241e2869d350e5e52854d3ea6423a9da53110e2fee7523f
apps/sim/executor/execution/executor.test.tshttps://github.com/simstudioai/sim/pull/7850/files#diff-566018bae9e15f4be75dbbd3a4b910753cb4053ff3c755d7897415d1a43d6f67
View file https://github.com/simstudioai/sim/blob/3ed1795e68ca71ebbd2d492a87e4dd2401bc6876/apps/sim/executor/execution/executor.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/7850/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/7850/files#diff-566018bae9e15f4be75dbbd3a4b910753cb4053ff3c755d7897415d1a43d6f67
https://github.com/simstudioai/sim/pull/7850/files#diff-566018bae9e15f4be75dbbd3a4b910753cb4053ff3c755d7897415d1a43d6f67
https://github.com/simstudioai/sim/pull/7850/files#diff-566018bae9e15f4be75dbbd3a4b910753cb4053ff3c755d7897415d1a43d6f67
https://github.com/simstudioai/sim/pull/7850/files#diff-566018bae9e15f4be75dbbd3a4b910753cb4053ff3c755d7897415d1a43d6f67
https://github.com/simstudioai/sim/pull/7850/files#diff-566018bae9e15f4be75dbbd3a4b910753cb4053ff3c755d7897415d1a43d6f67
https://github.com/simstudioai/sim/pull/7850/files#diff-566018bae9e15f4be75dbbd3a4b910753cb4053ff3c755d7897415d1a43d6f67
https://github.com/simstudioai/sim/pull/7850/files#diff-566018bae9e15f4be75dbbd3a4b910753cb4053ff3c755d7897415d1a43d6f67
apps/sim/executor/execution/executor.tshttps://github.com/simstudioai/sim/pull/7850/files#diff-749f8b453a93eaba5cab96f549bbc618400c2aead886a3444c868730c511dc1b
View file https://github.com/simstudioai/sim/blob/3ed1795e68ca71ebbd2d492a87e4dd2401bc6876/apps/sim/executor/execution/executor.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/7850/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/7850/files#diff-749f8b453a93eaba5cab96f549bbc618400c2aead886a3444c868730c511dc1b
https://github.com/simstudioai/sim/pull/7850/files#diff-749f8b453a93eaba5cab96f549bbc618400c2aead886a3444c868730c511dc1b
apps/sim/executor/types.tshttps://github.com/simstudioai/sim/pull/7850/files#diff-b266de0e8311cee15872078a12705439e0d9b58ab87b7685752a0b3ea60cd378
View file https://github.com/simstudioai/sim/blob/3ed1795e68ca71ebbd2d492a87e4dd2401bc6876/apps/sim/executor/types.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/7850/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/7850/files#diff-b266de0e8311cee15872078a12705439e0d9b58ab87b7685752a0b3ea60cd378
https://github.com/simstudioai/sim/pull/7850/files#diff-b266de0e8311cee15872078a12705439e0d9b58ab87b7685752a0b3ea60cd378
https://github.com/simstudioai/sim/pull/7850/files#diff-b266de0e8311cee15872078a12705439e0d9b58ab87b7685752a0b3ea60cd378
https://github.com/simstudioai/sim/pull/7850/files#diff-b266de0e8311cee15872078a12705439e0d9b58ab87b7685752a0b3ea60cd378
apps/sim/lib/execution/payloads/cache.test.tshttps://github.com/simstudioai/sim/pull/7850/files#diff-de08fd02c7448f67d885d17e35ce4426242af43415c70280a7557d91d01f4531
View file https://github.com/simstudioai/sim/blob/3ed1795e68ca71ebbd2d492a87e4dd2401bc6876/apps/sim/lib/execution/payloads/cache.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/7850/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/7850/files#diff-de08fd02c7448f67d885d17e35ce4426242af43415c70280a7557d91d01f4531
https://github.com/simstudioai/sim/pull/7850/files#diff-de08fd02c7448f67d885d17e35ce4426242af43415c70280a7557d91d01f4531
https://github.com/simstudioai/sim/pull/7850/files#diff-de08fd02c7448f67d885d17e35ce4426242af43415c70280a7557d91d01f4531
apps/sim/lib/execution/payloads/cache.tshttps://github.com/simstudioai/sim/pull/7850/files#diff-42e85cfef430ab900927ed39b89b6537e631bddc29e5a80cb2b7a80575b7d2d9
View file https://github.com/simstudioai/sim/blob/3ed1795e68ca71ebbd2d492a87e4dd2401bc6876/apps/sim/lib/execution/payloads/cache.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/7850/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/7850/files#diff-42e85cfef430ab900927ed39b89b6537e631bddc29e5a80cb2b7a80575b7d2d9
https://github.com/simstudioai/sim/pull/7850/files#diff-42e85cfef430ab900927ed39b89b6537e631bddc29e5a80cb2b7a80575b7d2d9
https://github.com/simstudioai/sim/pull/7850/files#diff-42e85cfef430ab900927ed39b89b6537e631bddc29e5a80cb2b7a80575b7d2d9
apps/sim/lib/execution/payloads/large-value-ref.tshttps://github.com/simstudioai/sim/pull/7850/files#diff-f773081e362806f2cc2bb183262feac73faa0c2ae0950233c217cfcaf0d54231
View file https://github.com/simstudioai/sim/blob/3ed1795e68ca71ebbd2d492a87e4dd2401bc6876/apps/sim/lib/execution/payloads/large-value-ref.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/7850/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/7850/files#diff-f773081e362806f2cc2bb183262feac73faa0c2ae0950233c217cfcaf0d54231
https://github.com/simstudioai/sim/pull/7850/files#diff-f773081e362806f2cc2bb183262feac73faa0c2ae0950233c217cfcaf0d54231
apps/sim/lib/execution/payloads/materialization.server.tshttps://github.com/simstudioai/sim/pull/7850/files#diff-a1e3fcedf46279b15241e2869d350e5e52854d3ea6423a9da53110e2fee7523f
View file https://github.com/simstudioai/sim/blob/3ed1795e68ca71ebbd2d492a87e4dd2401bc6876/apps/sim/lib/execution/payloads/materialization.server.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/7850/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/7850/files#diff-a1e3fcedf46279b15241e2869d350e5e52854d3ea6423a9da53110e2fee7523f
https://github.com/simstudioai/sim/pull/7850/files#diff-a1e3fcedf46279b15241e2869d350e5e52854d3ea6423a9da53110e2fee7523f
https://github.com/simstudioai/sim/pull/7850/files#diff-a1e3fcedf46279b15241e2869d350e5e52854d3ea6423a9da53110e2fee7523f
https://github.com/simstudioai/sim/pull/7850/files#diff-a1e3fcedf46279b15241e2869d350e5e52854d3ea6423a9da53110e2fee7523f
https://github.com/simstudioai/sim/pull/7850/files#diff-a1e3fcedf46279b15241e2869d350e5e52854d3ea6423a9da53110e2fee7523f
Please reload this pagehttps://github.com/simstudioai/sim/pull/7850/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.