Title: fix(knowledge): allow concurrent connector document saves by TheodoreSpeaks · Pull Request #7841 · simstudioai/sim · GitHub
Open Graph Title: fix(knowledge): allow concurrent connector document saves by TheodoreSpeaks · Pull Request #7841 · simstudioai/sim
X Title: fix(knowledge): allow concurrent connector document saves by TheodoreSpeaks · Pull Request #7841 · simstudioai/sim
Description: Summary Allow connector saves for different documents in one knowledge base to finalize concurrently by checking the active KB under FOR SHARE. Preserve soft-deletion exclusion, connector lease protection, document locks, and upload cleanup. Keep stronger guards on paths that update the KB itself. Type of Change Bug fix Testing 22 integration tests passed against isolated PostgreSQL 17.11, including 11 new concurrency tests covering all five guard callers, deletion ordering, same-document updates, lease reclaim, and embedding foreign-key locks. Confirmed the new concurrent-add test fails with the original exclusive guard. 36 focused unit tests and the Sim app type check passed. Repository lint, audits, block-registry check, and docs-manifest check passed. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)
Open Graph Description: Summary Allow connector saves for different documents in one knowledge base to finalize concurrently by checking the active KB under FOR SHARE. Preserve soft-deletion exclusion, connector lease pr...
X Description: Summary Allow connector saves for different documents in one knowledge base to finalize concurrently by checking the active KB under FOR SHARE. Preserve soft-deletion exclusion, connector lease pr...
Opengraph URL: https://github.com/simstudioai/sim/pull/7841
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:9b9005dc-0b10-6ad9-28c5-d246d1f21d5f |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E4B8:5A439:4DEF5B:6D5320:6AFB5DA2 |
| html-safe-nonce | b1c67c1888464bd2e21a7b2c27302756c02b7511e77587d336dd86223189d915 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNEI4OjVBNDM5OjRERUY1Qjo2RDUzMjA6NkFGQjVEQTIiLCJ2aXNpdG9yX2lkIjoiNTg1Njc2MjgyOTkxODEzMzY2NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 7a9a59af580b41021ec6a1e0401d1678e1e062d056b4c0074a0449e97c8377cc |
| hovercard-subject-tag | pull_request:4532490689 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/7841/files |
| twitter:image | https://avatars.githubusercontent.com/u/19564703?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/19564703?s=400&v=4 |
| og:image:alt | Summary Allow connector saves for different documents in one knowledge base to finalize concurrently by checking the active KB under FOR SHARE. Preserve soft-deletion exclusion, connector lease pr... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | ea33d13c96d0ff66bd8fa906b193d2213536b78cb06b0c50a4632c58b1418f94 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/simstudioai/sim git https://github.com/simstudioai/sim.git |
| octolytics-dimension-user_id | 199344406 |
| octolytics-dimension-user_login | simstudioai |
| octolytics-dimension-repository_id | 912559512 |
| octolytics-dimension-repository_nwo | simstudioai/sim |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 912559512 |
| octolytics-dimension-repository_network_root_nwo | simstudioai/sim |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 59ef97164c52cf59bd10558ddec9c4f482763988 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width