René's URL Explorer Experiment


Title: fix(knowledge): allow concurrent connector document saves by TheodoreSpeaks · Pull Request #7841 · simstudioai/sim · GitHub

Open Graph Title: fix(knowledge): allow concurrent connector document saves by TheodoreSpeaks · Pull Request #7841 · simstudioai/sim

X Title: fix(knowledge): allow concurrent connector document saves by TheodoreSpeaks · Pull Request #7841 · simstudioai/sim

Description: Summary Allow connector saves for different documents in one knowledge base to finalize concurrently by checking the active KB under FOR SHARE. Preserve soft-deletion exclusion, connector lease protection, document locks, and upload cleanup. Keep stronger guards on paths that update the KB itself. Type of Change Bug fix Testing 22 integration tests passed against isolated PostgreSQL 17.11, including 11 new concurrency tests covering all five guard callers, deletion ordering, same-document updates, lease reclaim, and embedding foreign-key locks. Confirmed the new concurrent-add test fails with the original exclusive guard. 36 focused unit tests and the Sim app type check passed. Repository lint, audits, block-registry check, and docs-manifest check passed. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary Allow connector saves for different documents in one knowledge base to finalize concurrently by checking the active KB under FOR SHARE. Preserve soft-deletion exclusion, connector lease pr...

X Description: Summary Allow connector saves for different documents in one knowledge base to finalize concurrently by checking the active KB under FOR SHARE. Preserve soft-deletion exclusion, connector lease pr...

Opengraph URL: https://github.com/simstudioai/sim/pull/7841

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:9b9005dc-0b10-6ad9-28c5-d246d1f21d5f
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE4B8:5A439:4DEF5B:6D5320:6AFB5DA2
html-safe-nonceb1c67c1888464bd2e21a7b2c27302756c02b7511e77587d336dd86223189d915
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNEI4OjVBNDM5OjRERUY1Qjo2RDUzMjA6NkFGQjVEQTIiLCJ2aXNpdG9yX2lkIjoiNTg1Njc2MjgyOTkxODEzMzY2NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac7a9a59af580b41021ec6a1e0401d1678e1e062d056b4c0074a0449e97c8377cc
hovercard-subject-tagpull_request:4532490689
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/7841/files
twitter:imagehttps://avatars.githubusercontent.com/u/19564703?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/19564703?s=400&v=4
og:image:altSummary Allow connector saves for different documents in one knowledge base to finalize concurrently by checking the active KB under FOR SHARE. Preserve soft-deletion exclusion, connector lease pr...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneea33d13c96d0ff66bd8fa906b193d2213536b78cb06b0c50a4632c58b1418f94
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release59ef97164c52cf59bd10558ddec9c4f482763988
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/7841/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F7841%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F7841%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/7841/files
Reloadhttps://github.com/simstudioai/sim/pull/7841/files
Reloadhttps://github.com/simstudioai/sim/pull/7841/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/kb-upload-row-lockhttps://github.com/simstudioai/sim/tree/fix/kb-upload-row-lock
Conversation 2 https://github.com/simstudioai/sim/pull/7841
Commits 1 https://github.com/simstudioai/sim/pull/7841/commits
Checks 32 https://github.com/simstudioai/sim/pull/7841/checks
Files changed https://github.com/simstudioai/sim/pull/7841/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/7841/files
fix(knowledge): allow concurrent connector document saves https://github.com/simstudioai/sim/pull/7841/files#top
Show all changes 1 commit https://github.com/simstudioai/sim/pull/7841/files
5659cda fix(knowledge): allow concurrent connector document saves TheodoreSpeaks Sep 15, 2026 https://github.com/simstudioai/sim/pull/7841/commits/5659cda41713db0fa8c233e82d2675da54721ded
Clear filters https://github.com/simstudioai/sim/pull/7841/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/7841/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/7841/files
connector-save-concurrency.integration.ts https://github.com/simstudioai/sim/pull/7841/files#diff-7c74f177c47fb8818a779c1dcb32e9ada5aa859f9f1c55212978183a20755708
sync-persistence.ts https://github.com/simstudioai/sim/pull/7841/files#diff-ebb4244cb03a8db47201961838942947833e406e54102d2519780d1043d531be
Please reload this pagehttps://github.com/simstudioai/sim/pull/7841/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/7841/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.