Title: fix(cli): read the telemetry token per call so tests don't depend on the publish job's env by waleedlatif1 · Pull Request #7822 · simstudioai/sim · GitHub
Open Graph Title: fix(cli): read the telemetry token per call so tests don't depend on the publish job's env by waleedlatif1 · Pull Request #7822 · simstudioai/sim
X Title: fix(cli): read the telemetry token per call so tests don't depend on the publish job's env by waleedlatif1 · Pull Request #7822 · simstudioai/sim
Description: Summary The CLI publish failed in its test step: sim telemetry status has a test asserting that a build without a reporting token reports nothing, and it read the token from the ambient environment. The publish job now sets the token for the whole job, so the test saw one and failed, and nothing was published The token is now read when builtInIngestTarget() is called instead of at module load. The reads stay literal process.env.SIM_CLI_TELEMETRY_* expressions, so the bundler still inlines them into the published build The telemetry command tests pin the token and opt-out variables, so they give the same result in any shell or CI job, and a new test covers the build-with-a-destination case This touches packages/sim-cli, so merging it runs the publish again Type of Change Bug fix Testing Reproduced the CI failure locally by running the suite with the publish job's env; it passes with and without that env after the change Confirmed the new pinning fails against the old module-level read Ran the publish job's sequence locally (tests, type-check, build, pack smoke, publish dry-run with its prepublishOnly rebuild): the shipped bundle has the token inlined, no raw env reads left, and sim telemetry status reports on bun run lint, check:audits, and docs-manifest:check pass Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)
Open Graph Description: Summary The CLI publish failed in its test step: sim telemetry status has a test asserting that a build without a reporting token reports nothing, and it read the token from the ambient environmen...
X Description: Summary The CLI publish failed in its test step: sim telemetry status has a test asserting that a build without a reporting token reports nothing, and it read the token from the ambient environmen...
Opengraph URL: https://github.com/simstudioai/sim/pull/7822
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:cfc6d13f-4a0b-a48e-0e08-1ce835853443 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | C528:3786FF:484DB5:67E795:6AFB3A5C |
| html-safe-nonce | dc358f4b5ee2d34c06bf6731d45fe1eb2e5153897718e2520812175e09607678 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNTI4OjM3ODZGRjo0ODREQjU6NjdFNzk1OjZBRkIzQTVDIiwidmlzaXRvcl9pZCI6IjQzODg5MzEwODA0NjgyNDkxODAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 1dfb9d368fa389e6b750f2b2defc6d55d9f7fa7a9a11f4cb7be712625e8a6fe0 |
| hovercard-subject-tag | pull_request:4531047359 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/7822/files |
| twitter:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| og:image:alt | Summary The CLI publish failed in its test step: sim telemetry status has a test asserting that a build without a reporting token reports nothing, and it read the token from the ambient environmen... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 2169b0dfbef67ed6b128074a5ed45bb7d5d1859783b10178b09a7765ad5f3693 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/simstudioai/sim git https://github.com/simstudioai/sim.git |
| octolytics-dimension-user_id | 199344406 |
| octolytics-dimension-user_login | simstudioai |
| octolytics-dimension-repository_id | 912559512 |
| octolytics-dimension-repository_nwo | simstudioai/sim |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 912559512 |
| octolytics-dimension-repository_network_root_nwo | simstudioai/sim |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 3b4fc8df5ef1c6757e733a23e6b81b6725021823 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width