René's URL Explorer Experiment


Title: fix(agent): keep nested tool basic/advanced modes attached to their tools by waleedlatif1 · Pull Request #7804 · simstudioai/sim · GitHub

Open Graph Title: fix(agent): keep nested tool basic/advanced modes attached to their tools by waleedlatif1 · Pull Request #7804 · simstudioai/sim

X Title: fix(agent): keep nested tool basic/advanced modes attached to their tools by waleedlatif1 · Pull Request #7804 · simstudioai/sim

Description: Summary Nested agent tool basic/advanced modes (e.g. Jira "Project" selector vs. manual) are keyed by tool array position in canonicalModes, so a reorder or removal has to move them with the tools API / Chat: the workflow edit engine replaced the tools array without reindexing modes, so reordering tools through POST /api/v2/workflows/{id}/operations swapped each tool's mode. It now reindexes after every batch that rewrites a tool list, matching tools by content (ignoring isExpanded), then by type so in-place param edits keep their modes. Removed tools' modes are dropped. Covers every tool-input field, not just tools Editor: a drag-reorder or removal was saved as two independent socket writes (replace-canonical-modes + subblock-update), so one could persist without the other and leave modes on the wrong tools. It is now one subblock-update-with-canonical-modes op, written in one transaction Queue coalesces the new op with pending updates to the same field. A value-only update never drops a pending op that carries modes replace-canonical-modes is no longer sent but still accepted and applied, so tabs loaded before this deploy keep working. A new client talking to a realtime server that hasn't rolled out yet gets a validation error (offline banner, no corruption) until the deploy completes Type of Change Bug fix Testing Unit tests for content-based reindexing (reorder, in-place edits, removal, new tools, type changes, duplicates, legacy keys) Engine tests through applyOperationsToWorkflowState (confirmed they fail without the fix) Realtime persistence (both fields in one update, locked block rejected without writing either), permissions, queue coalescing type-check (sim, realtime, realtime-protocol), lint, check:audits, block registry and docs manifest checks pass Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA) 🤖 Generated with Claude Code https://claude.ai/code/session_01WbCdLsJxoQ9gb41Pzfxo68

Open Graph Description: Summary Nested agent tool basic/advanced modes (e.g. Jira "Project" selector vs. manual) are keyed by tool array position in canonicalModes, so a reorder or removal has to move them with...

X Description: Summary Nested agent tool basic/advanced modes (e.g. Jira "Project" selector vs. manual) are keyed by tool array position in canonicalModes, so a reorder or removal has to move t...

Opengraph URL: https://github.com/simstudioai/sim/pull/7804

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:eb25d42c-fa54-c06f-f184-1bd69a09e33a
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE986:8CC91:15341E1:1C8C961:6AFB9F0D
html-safe-nonce82dcee267bf5e4a5375c3bb8404d710a122a0bd2e1f75bd9679b918be4b8fe7f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFOTg2OjhDQzkxOjE1MzQxRTE6MUM4Qzk2MTo2QUZCOUYwRCIsInZpc2l0b3JfaWQiOiIzNDM4MzU2NTM2MTI2ODQwNTg5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac56788c82e541db53014eb240d76ed40a65ce8f09411e361301db87ef1dc9d5d2
hovercard-subject-tagpull_request:4516854307
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/7804/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary Nested agent tool basic/advanced modes (e.g. Jira "Project" selector vs. manual) are keyed by tool array position in canonicalModes, so a reorder or removal has to move them with...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None3cefd19a936819d82cfb5279d50fb56fe79cb9ec30f0f807e04e89b0c58ffae1
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release606800bdb1b81d125fc845bdcc262c9fe063fc8f
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/7804/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F7804%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F7804%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/7804/files
Reloadhttps://github.com/simstudioai/sim/pull/7804/files
Reloadhttps://github.com/simstudioai/sim/pull/7804/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests199 (199)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/tool-canonical-modes-atomic-reorderhttps://github.com/simstudioai/sim/tree/fix/tool-canonical-modes-atomic-reorder
Conversation 20 https://github.com/simstudioai/sim/pull/7804
Commits 4 https://github.com/simstudioai/sim/pull/7804/commits
Checks 31 https://github.com/simstudioai/sim/pull/7804/checks
Files changed https://github.com/simstudioai/sim/pull/7804/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/7804/files
fix(agent): keep nested tool basic/advanced modes attached to their tools https://github.com/simstudioai/sim/pull/7804/files#top
Show all changes 4 commits https://github.com/simstudioai/sim/pull/7804/files
d2306ad fix(agent): keep nested tool basic/advanced modes attached to their t… waleedlatif1 Sep 13, 2026 https://github.com/simstudioai/sim/pull/7804/commits/d2306ad9cb0f673e847f630226e34c2908fb8ec2
112fa04 fix(realtime): reject locked-block tool updates and tighten new types waleedlatif1 Sep 13, 2026 https://github.com/simstudioai/sim/pull/7804/commits/112fa04e7371431fc59579e3112cf7471109a120
34fdb94 test(agent): drop redundant cast in tool mode reindex tests waleedlatif1 Sep 13, 2026 https://github.com/simstudioai/sim/pull/7804/commits/34fdb94aaeb6ef266c199cd25fca988ec9cd0c95
b46daae improvement(realtime): share the writable-block check across subblock… waleedlatif1 Sep 13, 2026 https://github.com/simstudioai/sim/pull/7804/commits/b46daaef67238e7898f9b13035148db9ba412a48
Clear filters https://github.com/simstudioai/sim/pull/7804/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/7804/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/7804/files
operations.test.ts https://github.com/simstudioai/sim/pull/7804/files#diff-7325da1e147963f0023dc5b719e09d029cc18731b15b417e2844162c9561443d
operations.ts https://github.com/simstudioai/sim/pull/7804/files#diff-e8428fa80ec5afb5442d2c399ae8dccd54ba450b45cbaae13a15c833911be725
permissions.test.ts https://github.com/simstudioai/sim/pull/7804/files#diff-df8569942debacaacf33092a1ceb70e82fe44eea791fdbf8ed591ad32c9776ac
permissions.ts https://github.com/simstudioai/sim/pull/7804/files#diff-fe5f280efeac435d7aad7d310560421ad87b21af62233547c3ec3ca19a5967d8
tool-input.tsx https://github.com/simstudioai/sim/pull/7804/files#diff-9d18e37ae3bc1e0d6e4ea27b679516985bafc2a806b5adbddd05f35599dc5044
use-collaborative-workflow.ts https://github.com/simstudioai/sim/pull/7804/files#diff-ccb80da85d47ecf517b42ec89718b19771184b32f2171a7705ddf236de89d46a
engine.ts https://github.com/simstudioai/sim/pull/7804/files#diff-edcfe5af5b1850957818b19d0fc5feff46cae6acc1ddbb2a85eeb1610ae37eba
operations.test.ts https://github.com/simstudioai/sim/pull/7804/files#diff-6bb2b130cdc72cb4252605227c02134b7c8d196515f6426379ca6d41a2d7f1cc
visibility.test.ts https://github.com/simstudioai/sim/pull/7804/files#diff-ab75b457b2ca285de17f01d599833e32090181030bdc30433779a7cd5fb60c92
visibility.ts https://github.com/simstudioai/sim/pull/7804/files#diff-cbbf86d19acdc23be631c1b3a7e5d455c699b1e5c1dea80bff0fe706e14fe61e
store.test.ts https://github.com/simstudioai/sim/pull/7804/files#diff-dd2589aa0801458c261718b39ad7d3b427c68e19c73dbe012f9e453878bf5c59
store.ts https://github.com/simstudioai/sim/pull/7804/files#diff-deabdc947da837b8e425aa8c41fa32621bf1be9860e7ddac2acafd6fc2968b39
constants.ts https://github.com/simstudioai/sim/pull/7804/files#diff-11869e01e71e8b8e1de1521f09a0cebe1a5a6c6cfc4358d8faf8674585aba649
schemas.ts https://github.com/simstudioai/sim/pull/7804/files#diff-3feb8202eabab90877fd4e0b2418e201080d3a125e6918be11f3b9916157495b
apps/realtime/src/database/operations.test.tshttps://github.com/simstudioai/sim/pull/7804/files#diff-7325da1e147963f0023dc5b719e09d029cc18731b15b417e2844162c9561443d
View file https://github.com/simstudioai/sim/blob/b46daaef67238e7898f9b13035148db9ba412a48/apps/realtime/src/database/operations.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/7804/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/7804/files#diff-7325da1e147963f0023dc5b719e09d029cc18731b15b417e2844162c9561443d
apps/realtime/src/database/operations.tshttps://github.com/simstudioai/sim/pull/7804/files#diff-e8428fa80ec5afb5442d2c399ae8dccd54ba450b45cbaae13a15c833911be725
View file https://github.com/simstudioai/sim/blob/b46daaef67238e7898f9b13035148db9ba412a48/apps/realtime/src/database/operations.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/7804/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/7804/files#diff-e8428fa80ec5afb5442d2c399ae8dccd54ba450b45cbaae13a15c833911be725
https://github.com/simstudioai/sim/pull/7804/files#diff-e8428fa80ec5afb5442d2c399ae8dccd54ba450b45cbaae13a15c833911be725
https://github.com/simstudioai/sim/pull/7804/files#diff-e8428fa80ec5afb5442d2c399ae8dccd54ba450b45cbaae13a15c833911be725
https://github.com/simstudioai/sim/pull/7804/files#diff-e8428fa80ec5afb5442d2c399ae8dccd54ba450b45cbaae13a15c833911be725
https://github.com/simstudioai/sim/pull/7804/files#diff-e8428fa80ec5afb5442d2c399ae8dccd54ba450b45cbaae13a15c833911be725
https://github.com/simstudioai/sim/pull/7804/files#diff-e8428fa80ec5afb5442d2c399ae8dccd54ba450b45cbaae13a15c833911be725
https://github.com/simstudioai/sim/pull/7804/files#diff-e8428fa80ec5afb5442d2c399ae8dccd54ba450b45cbaae13a15c833911be725
apps/realtime/src/middleware/permissions.test.tshttps://github.com/simstudioai/sim/pull/7804/files#diff-df8569942debacaacf33092a1ceb70e82fe44eea791fdbf8ed591ad32c9776ac
View file https://github.com/simstudioai/sim/blob/b46daaef67238e7898f9b13035148db9ba412a48/apps/realtime/src/middleware/permissions.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/7804/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/7804/files#diff-df8569942debacaacf33092a1ceb70e82fe44eea791fdbf8ed591ad32c9776ac
https://github.com/simstudioai/sim/pull/7804/files#diff-df8569942debacaacf33092a1ceb70e82fe44eea791fdbf8ed591ad32c9776ac
https://github.com/simstudioai/sim/pull/7804/files#diff-df8569942debacaacf33092a1ceb70e82fe44eea791fdbf8ed591ad32c9776ac
https://github.com/simstudioai/sim/pull/7804/files#diff-df8569942debacaacf33092a1ceb70e82fe44eea791fdbf8ed591ad32c9776ac
apps/realtime/src/middleware/permissions.tshttps://github.com/simstudioai/sim/pull/7804/files#diff-fe5f280efeac435d7aad7d310560421ad87b21af62233547c3ec3ca19a5967d8
View file https://github.com/simstudioai/sim/blob/b46daaef67238e7898f9b13035148db9ba412a48/apps/realtime/src/middleware/permissions.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/7804/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/7804/files#diff-fe5f280efeac435d7aad7d310560421ad87b21af62233547c3ec3ca19a5967d8
https://github.com/simstudioai/sim/pull/7804/files#diff-fe5f280efeac435d7aad7d310560421ad87b21af62233547c3ec3ca19a5967d8
...ponents/panel/components/editor/components/sub-block/components/tool-input/tool-input.tsxhttps://github.com/simstudioai/sim/pull/7804/files#diff-9d18e37ae3bc1e0d6e4ea27b679516985bafc2a806b5adbddd05f35599dc5044
View file https://github.com/simstudioai/sim/blob/b46daaef67238e7898f9b13035148db9ba412a48/apps/sim/app/workspace/%5BworkspaceId%5D/w/%5BworkflowId%5D/components/panel/components/editor/components/sub-block/components/tool-input/tool-input.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/7804/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/7804/files#diff-9d18e37ae3bc1e0d6e4ea27b679516985bafc2a806b5adbddd05f35599dc5044
https://github.com/simstudioai/sim/pull/7804/files#diff-9d18e37ae3bc1e0d6e4ea27b679516985bafc2a806b5adbddd05f35599dc5044
https://github.com/simstudioai/sim/pull/7804/files#diff-9d18e37ae3bc1e0d6e4ea27b679516985bafc2a806b5adbddd05f35599dc5044
https://github.com/simstudioai/sim/pull/7804/files#diff-9d18e37ae3bc1e0d6e4ea27b679516985bafc2a806b5adbddd05f35599dc5044
https://github.com/simstudioai/sim/pull/7804/files#diff-9d18e37ae3bc1e0d6e4ea27b679516985bafc2a806b5adbddd05f35599dc5044
https://github.com/simstudioai/sim/pull/7804/files#diff-9d18e37ae3bc1e0d6e4ea27b679516985bafc2a806b5adbddd05f35599dc5044
https://github.com/simstudioai/sim/pull/7804/files#diff-9d18e37ae3bc1e0d6e4ea27b679516985bafc2a806b5adbddd05f35599dc5044
https://github.com/simstudioai/sim/pull/7804/files#diff-9d18e37ae3bc1e0d6e4ea27b679516985bafc2a806b5adbddd05f35599dc5044
https://github.com/simstudioai/sim/pull/7804/files#diff-9d18e37ae3bc1e0d6e4ea27b679516985bafc2a806b5adbddd05f35599dc5044
https://github.com/simstudioai/sim/pull/7804/files#diff-9d18e37ae3bc1e0d6e4ea27b679516985bafc2a806b5adbddd05f35599dc5044
https://github.com/simstudioai/sim/pull/7804/files#diff-9d18e37ae3bc1e0d6e4ea27b679516985bafc2a806b5adbddd05f35599dc5044
https://github.com/simstudioai/sim/pull/7804/files#diff-9d18e37ae3bc1e0d6e4ea27b679516985bafc2a806b5adbddd05f35599dc5044
https://github.com/simstudioai/sim/pull/7804/files#diff-9d18e37ae3bc1e0d6e4ea27b679516985bafc2a806b5adbddd05f35599dc5044
https://github.com/simstudioai/sim/pull/7804/files#diff-9d18e37ae3bc1e0d6e4ea27b679516985bafc2a806b5adbddd05f35599dc5044
Please reload this pagehttps://github.com/simstudioai/sim/pull/7804/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/7804/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.