René's URL Explorer Experiment


Title: fix(mcp): always guard the MCP transport and validate on every managed connect by waleedlatif1 · Pull Request #7802 · simstudioai/sim · GitHub

Open Graph Title: fix(mcp): always guard the MCP transport and validate on every managed connect by waleedlatif1 · Pull Request #7802 · simstudioai/sim

X Title: fix(mcp): always guard the MCP transport and validate on every managed connect by waleedlatif1 · Pull Request #7802 · simstudioai/sim

Description: Summary McpClient always runs the transport on the SSRF-guarded fetch; it no longer falls back to the global fetch when no validated address is passed. A validated private address still pins, as before McpConnectionManager.connect validates the destination (validateMcpDomain + validateMcpServerSsrf) on every dial, reconnects included, instead of taking a caller-supplied resolvedIP Discovery only resolves env vars before handing off to the manager, so already-connected servers skip the DNS lookup Corrected the resolvedIP TSDoc and the client guard comment Type of Change Bug fix Testing New tests: client uses the guard with no address and pins a private one; manager validates before building a client, refuses without constructing one, and re-validates on reconnect. Confirmed they fail with the fix reverted lib/mcp + app/api/mcp suites pass (681), type-check, lint, check:audits, docs-manifest:check pass Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary McpClient always runs the transport on the SSRF-guarded fetch; it no longer falls back to the global fetch when no validated address is passed. A validated private address still pins, as b...

X Description: Summary McpClient always runs the transport on the SSRF-guarded fetch; it no longer falls back to the global fetch when no validated address is passed. A validated private address still pins, as b...

Opengraph URL: https://github.com/simstudioai/sim/pull/7802

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:a9b6b8ad-9372-7b1f-436b-eda61ff053b7
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA168:3E605:1C19B8:26AD65:6AFB8AE1
html-safe-nonce9cb98f50e977aa32810c27b78bc70bb9d693eb138c2454ee9db54996533b196d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMTY4OjNFNjA1OjFDMTlCODoyNkFENjU6NkFGQjhBRTEiLCJ2aXNpdG9yX2lkIjoiMTY0NTM0MzA2NzQxNjAwNTM0NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacefcf7da9bdfe7732c2995606ff3d95276731f3a8bbbd9a95e7b6de57a08da20a
hovercard-subject-tagpull_request:4516789528
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/7802/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary McpClient always runs the transport on the SSRF-guarded fetch; it no longer falls back to the global fetch when no validated address is passed. A validated private address still pins, as b...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None9694464143465782ecae2a97650b2a2b0708d5c31c74f41ee86da57e315e2735
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release05d967182208691fc7f2e6af52e82fa7fabf6bd5
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/7802/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F7802%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F7802%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/7802/files
Reloadhttps://github.com/simstudioai/sim/pull/7802/files
Reloadhttps://github.com/simstudioai/sim/pull/7802/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/mcp-transport-egress-guardhttps://github.com/simstudioai/sim/tree/fix/mcp-transport-egress-guard
Conversation 2 https://github.com/simstudioai/sim/pull/7802
Commits 1 https://github.com/simstudioai/sim/pull/7802/commits
Checks 32 https://github.com/simstudioai/sim/pull/7802/checks
Files changed https://github.com/simstudioai/sim/pull/7802/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/7802/files
fix(mcp): always guard the MCP transport and validate on every managed connect https://github.com/simstudioai/sim/pull/7802/files#top
Show all changes 1 commit https://github.com/simstudioai/sim/pull/7802/files
83876d1 fix(mcp): always guard the MCP transport and validate on every manage… waleedlatif1 Sep 13, 2026 https://github.com/simstudioai/sim/pull/7802/commits/83876d1eda90b43e3db17feb52ebd3745e1667a6
Clear filters https://github.com/simstudioai/sim/pull/7802/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/7802/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/7802/files
client.test.ts https://github.com/simstudioai/sim/pull/7802/files#diff-3c669f1cfdbdbd74ae67141932035c61beea21909c92d6e0b8ad9f26b569dcab
client.ts https://github.com/simstudioai/sim/pull/7802/files#diff-25cb24353597fac644145b37622d21ec7315282c29ccb1c4275f3ccb46441e1a
connection-manager.test.ts https://github.com/simstudioai/sim/pull/7802/files#diff-c02aa8f0d5686a801ab69b20102b866ae80b745265e279e620c84544c10fd527
connection-manager.ts https://github.com/simstudioai/sim/pull/7802/files#diff-c4c5382013f44bc01eced63f50ecfcb606b8671498f14bb3e27467c1a5b632a1
service.ts https://github.com/simstudioai/sim/pull/7802/files#diff-19f6b7bbc0682d9438560d27d332499a5f8e1e4d1bf8aeb68dde6f2431137355
types.ts https://github.com/simstudioai/sim/pull/7802/files#diff-e2500ed2ccd0ca3bc978e658046d3908d959b18e02308756df87eb46e311df44
apps/sim/lib/mcp/client.test.tshttps://github.com/simstudioai/sim/pull/7802/files#diff-3c669f1cfdbdbd74ae67141932035c61beea21909c92d6e0b8ad9f26b569dcab
View file https://github.com/simstudioai/sim/blob/83876d1eda90b43e3db17feb52ebd3745e1667a6/apps/sim/lib/mcp/client.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/7802/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/7802/files#diff-3c669f1cfdbdbd74ae67141932035c61beea21909c92d6e0b8ad9f26b569dcab
https://github.com/simstudioai/sim/pull/7802/files#diff-3c669f1cfdbdbd74ae67141932035c61beea21909c92d6e0b8ad9f26b569dcab
https://github.com/simstudioai/sim/pull/7802/files#diff-3c669f1cfdbdbd74ae67141932035c61beea21909c92d6e0b8ad9f26b569dcab
https://github.com/simstudioai/sim/pull/7802/files#diff-3c669f1cfdbdbd74ae67141932035c61beea21909c92d6e0b8ad9f26b569dcab
https://github.com/simstudioai/sim/pull/7802/files#diff-3c669f1cfdbdbd74ae67141932035c61beea21909c92d6e0b8ad9f26b569dcab
https://github.com/simstudioai/sim/pull/7802/files#diff-3c669f1cfdbdbd74ae67141932035c61beea21909c92d6e0b8ad9f26b569dcab
apps/sim/lib/mcp/client.tshttps://github.com/simstudioai/sim/pull/7802/files#diff-25cb24353597fac644145b37622d21ec7315282c29ccb1c4275f3ccb46441e1a
View file https://github.com/simstudioai/sim/blob/83876d1eda90b43e3db17feb52ebd3745e1667a6/apps/sim/lib/mcp/client.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/7802/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/7802/files#diff-25cb24353597fac644145b37622d21ec7315282c29ccb1c4275f3ccb46441e1a
https://github.com/simstudioai/sim/pull/7802/files#diff-25cb24353597fac644145b37622d21ec7315282c29ccb1c4275f3ccb46441e1a
https://github.com/simstudioai/sim/pull/7802/files#diff-25cb24353597fac644145b37622d21ec7315282c29ccb1c4275f3ccb46441e1a
apps/sim/lib/mcp/connection-manager.test.tshttps://github.com/simstudioai/sim/pull/7802/files#diff-c02aa8f0d5686a801ab69b20102b866ae80b745265e279e620c84544c10fd527
View file https://github.com/simstudioai/sim/blob/83876d1eda90b43e3db17feb52ebd3745e1667a6/apps/sim/lib/mcp/connection-manager.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/7802/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/7802/files#diff-c02aa8f0d5686a801ab69b20102b866ae80b745265e279e620c84544c10fd527
https://github.com/simstudioai/sim/pull/7802/files#diff-c02aa8f0d5686a801ab69b20102b866ae80b745265e279e620c84544c10fd527
https://github.com/simstudioai/sim/pull/7802/files#diff-c02aa8f0d5686a801ab69b20102b866ae80b745265e279e620c84544c10fd527
https://github.com/simstudioai/sim/pull/7802/files#diff-c02aa8f0d5686a801ab69b20102b866ae80b745265e279e620c84544c10fd527
https://github.com/simstudioai/sim/pull/7802/files#diff-c02aa8f0d5686a801ab69b20102b866ae80b745265e279e620c84544c10fd527
https://github.com/simstudioai/sim/pull/7802/files#diff-c02aa8f0d5686a801ab69b20102b866ae80b745265e279e620c84544c10fd527
apps/sim/lib/mcp/connection-manager.tshttps://github.com/simstudioai/sim/pull/7802/files#diff-c4c5382013f44bc01eced63f50ecfcb606b8671498f14bb3e27467c1a5b632a1
View file https://github.com/simstudioai/sim/blob/83876d1eda90b43e3db17feb52ebd3745e1667a6/apps/sim/lib/mcp/connection-manager.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/7802/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/7802/files#diff-c4c5382013f44bc01eced63f50ecfcb606b8671498f14bb3e27467c1a5b632a1
https://github.com/simstudioai/sim/pull/7802/files#diff-c4c5382013f44bc01eced63f50ecfcb606b8671498f14bb3e27467c1a5b632a1
https://github.com/simstudioai/sim/pull/7802/files#diff-c4c5382013f44bc01eced63f50ecfcb606b8671498f14bb3e27467c1a5b632a1
https://github.com/simstudioai/sim/pull/7802/files#diff-c4c5382013f44bc01eced63f50ecfcb606b8671498f14bb3e27467c1a5b632a1
https://github.com/simstudioai/sim/pull/7802/files#diff-c4c5382013f44bc01eced63f50ecfcb606b8671498f14bb3e27467c1a5b632a1
https://github.com/simstudioai/sim/pull/7802/files#diff-c4c5382013f44bc01eced63f50ecfcb606b8671498f14bb3e27467c1a5b632a1
apps/sim/lib/mcp/service.tshttps://github.com/simstudioai/sim/pull/7802/files#diff-19f6b7bbc0682d9438560d27d332499a5f8e1e4d1bf8aeb68dde6f2431137355
View file https://github.com/simstudioai/sim/blob/83876d1eda90b43e3db17feb52ebd3745e1667a6/apps/sim/lib/mcp/service.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/7802/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/7802/files#diff-19f6b7bbc0682d9438560d27d332499a5f8e1e4d1bf8aeb68dde6f2431137355
https://github.com/simstudioai/sim/pull/7802/files#diff-19f6b7bbc0682d9438560d27d332499a5f8e1e4d1bf8aeb68dde6f2431137355
apps/sim/lib/mcp/types.tshttps://github.com/simstudioai/sim/pull/7802/files#diff-e2500ed2ccd0ca3bc978e658046d3908d959b18e02308756df87eb46e311df44
View file https://github.com/simstudioai/sim/blob/83876d1eda90b43e3db17feb52ebd3745e1667a6/apps/sim/lib/mcp/types.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/7802/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/7802/files#diff-e2500ed2ccd0ca3bc978e658046d3908d959b18e02308756df87eb46e311df44
https://github.com/simstudioai/sim/pull/7802/files#diff-e2500ed2ccd0ca3bc978e658046d3908d959b18e02308756df87eb46e311df44
Please reload this pagehttps://github.com/simstudioai/sim/pull/7802/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.