René's URL Explorer Experiment


Title: fix(knowledge): count list documents once instead of per 400-base batch by waleedlatif1 · Pull Request #7759 · simstudioai/sim · GitHub

Open Graph Title: fix(knowledge): count list documents once instead of per 400-base batch by waleedlatif1 · Pull Request #7759 · simstudioai/sim

X Title: fix(knowledge): count list documents once instead of per 400-base batch by waleedlatif1 · Pull Request #7759 · simstudioai/sim

Description: Summary Staging alarm sim-staging-us-east-1-integ-failure (2026-09-10/11): integ-session-kb-document-lifecycle/archive-kb hits its 30 s client timeout on GET /api/knowledge?scope=archived. The request completes with 200 server-side but takes 90 to 122 s. Root cause. #7730 switched the knowledge base lists to pass a KnowledgeAccessProvider, which flipped readKnowledgeBaseRows onto a new path: the document join became sql\false`andreadKnowledgeBaseDocumentCountsran a count query plusknowledgeReadAccessBatches` candidate discovery per batch of 400 bases. The integ workspace holds 21,763 archived bases (fixtures archived since June, never purged), so one unpaged list became ~55 batches / 110+ sequential queries. Integ log shows archive-kb at 3 to 5 s until 11:02 UTC and 30 s timeouts from 11:29 UTC, 14 minutes after #7730 merged. Changes readKnowledgeBaseRows resolves the scope once and counts stored-ACL documents in the list's own join again, as before #7730. Only documents a live source (GitHub, Confluence) authorizes beyond the stored ACL are counted afterwards, once for the whole list. The supplement is bounded by the list filter for an unpaged list, or by the page's ids for a paged one, so it never scales with base count. KnowledgeAccessProvider gains an optional hasLiveSourceReaders(). knowledgeReadAccessBatches skips candidate discovery when it returns false: without a live-source credential getForConnectors returns the ordinary scope, so the discovered predicate is NOT ordinary AND ordinary and provably empty. This applies to every generator call site (documents, tags, files, connectors), not just the list. attachKnowledgeBaseConnectors uses the same two helpers for the single-base path. Semantics are unchanged: for a reader with live-source credentials, ordinary plus live counts sum exactly as #7730 intended; for everyone else the result is the pre-#7730 single query. Verification bun run type-check, bun run check:audits: pass. vitest run lib/knowledge app/api/knowledge app/api/files app/api/v1/knowledge app/api/v2/knowledge: 202 files, 3033 tests pass. New tests (unpaged list counts in one join + one discovery pass bounded by the filter; no discovery without live readers; generator short-circuit; provider reports readers) all fail with the fix reverted. Not done: the fixture graveyard itself. The remaining ~4 s on that endpoint is the 21k-row unpaged payload, which data retention will address. 🤖 Generated with Claude Code https://claude.ai/code/session_01Lm5mdDU9bi1vb4oAvPtbjn

Open Graph Description: Summary Staging alarm sim-staging-us-east-1-integ-failure (2026-09-10/11): integ-session-kb-document-lifecycle/archive-kb hits its 30 s client timeout on GET /api/knowledge?scope=archived. The requ...

X Description: Summary Staging alarm sim-staging-us-east-1-integ-failure (2026-09-10/11): integ-session-kb-document-lifecycle/archive-kb hits its 30 s client timeout on GET /api/knowledge?scope=archived. The requ...

Opengraph URL: https://github.com/simstudioai/sim/pull/7759

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:3a90477e-a635-38ec-5b86-79c56138af9b
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC08E:14B945:AA0649:EA48CF:6AFB525F
html-safe-nonce93b00d1b93ccca601178e8e00dad77118b7225f03bf83fd3ef3722d24bf18d40
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMDhFOjE0Qjk0NTpBQTA2NDk6RUE0OENGOjZBRkI1MjVGIiwidmlzaXRvcl9pZCI6Ijg3ODUwMzAyNjYyODUxNTA4MTUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac31332e1fb775f18f213fb9ef7583d2f80f7e2baa48d7153d1e0d93139b41d71e
hovercard-subject-tagpull_request:4501975873
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/7759/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary Staging alarm sim-staging-us-east-1-integ-failure (2026-09-10/11): integ-session-kb-document-lifecycle/archive-kb hits its 30 s client timeout on GET /api/knowledge?scope=archived. The requ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None7122bb414b542dba14d71a3f0b9f6fd2abce715b9f5912d082800563e6c806d1
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasecbf66c024bb6d10e6955baa7413c54cf13a201bb
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/7759/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F7759%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F7759%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/7759/files
Reloadhttps://github.com/simstudioai/sim/pull/7759/files
Reloadhttps://github.com/simstudioai/sim/pull/7759/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/knowledge-list-live-source-countshttps://github.com/simstudioai/sim/tree/fix/knowledge-list-live-source-counts
Conversation 2 https://github.com/simstudioai/sim/pull/7759
Commits 1 https://github.com/simstudioai/sim/pull/7759/commits
Checks 33 https://github.com/simstudioai/sim/pull/7759/checks
Files changed https://github.com/simstudioai/sim/pull/7759/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/7759/files
fix(knowledge): count list documents once instead of per 400-base batch https://github.com/simstudioai/sim/pull/7759/files#top
Show all changes 1 commit https://github.com/simstudioai/sim/pull/7759/files
f7949f3 fix(knowledge): count list documents once instead of per 400-base batch waleedlatif1 Sep 11, 2026 https://github.com/simstudioai/sim/pull/7759/commits/f7949f3c9f6d82bdda11c0f702afb95d77cda537
Clear filters https://github.com/simstudioai/sim/pull/7759/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/7759/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/7759/files
scope.test.ts https://github.com/simstudioai/sim/pull/7759/files#diff-b3379df623c8429eec8ba892a4f95f655a1f2d4f80f9e6e0a44ca35648403da7
scope.ts https://github.com/simstudioai/sim/pull/7759/files#diff-2fcb942f8e48c65c1a5cc234d3066b4fd8319ad65abd24581aaf8320d7f9ac22
types.ts https://github.com/simstudioai/sim/pull/7759/files#diff-0f604e212994706854c1cca95f0053e93387f0abd22def425bb32ec73bca62b5
read-access.test.ts https://github.com/simstudioai/sim/pull/7759/files#diff-8cbc2b0ac7dae7c2d71cd0df97379748063a850a2d36445d823b609a4079414d
read-access.ts https://github.com/simstudioai/sim/pull/7759/files#diff-f9c6d3a92438a7dae485f120026274fc87350340de1159b3daa1a90ea0a5d4ca
service.test.ts https://github.com/simstudioai/sim/pull/7759/files#diff-5856177786ea5bfaddee3756ec5ac692c1e3e97c332ec370f6c31f401649abb8
service.ts https://github.com/simstudioai/sim/pull/7759/files#diff-6978b26968fd05cf5c7635c366c8c806693b6145235f476627302fb402f32d18
apps/sim/lib/knowledge/access/scope.test.tshttps://github.com/simstudioai/sim/pull/7759/files#diff-b3379df623c8429eec8ba892a4f95f655a1f2d4f80f9e6e0a44ca35648403da7
View file https://github.com/simstudioai/sim/blob/f7949f3c9f6d82bdda11c0f702afb95d77cda537/apps/sim/lib/knowledge/access/scope.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/7759/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/7759/files#diff-b3379df623c8429eec8ba892a4f95f655a1f2d4f80f9e6e0a44ca35648403da7
https://github.com/simstudioai/sim/pull/7759/files#diff-b3379df623c8429eec8ba892a4f95f655a1f2d4f80f9e6e0a44ca35648403da7
apps/sim/lib/knowledge/access/scope.tshttps://github.com/simstudioai/sim/pull/7759/files#diff-2fcb942f8e48c65c1a5cc234d3066b4fd8319ad65abd24581aaf8320d7f9ac22
View file https://github.com/simstudioai/sim/blob/f7949f3c9f6d82bdda11c0f702afb95d77cda537/apps/sim/lib/knowledge/access/scope.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/7759/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/7759/files#diff-2fcb942f8e48c65c1a5cc234d3066b4fd8319ad65abd24581aaf8320d7f9ac22
https://github.com/simstudioai/sim/pull/7759/files#diff-2fcb942f8e48c65c1a5cc234d3066b4fd8319ad65abd24581aaf8320d7f9ac22
apps/sim/lib/knowledge/access/types.tshttps://github.com/simstudioai/sim/pull/7759/files#diff-0f604e212994706854c1cca95f0053e93387f0abd22def425bb32ec73bca62b5
View file https://github.com/simstudioai/sim/blob/f7949f3c9f6d82bdda11c0f702afb95d77cda537/apps/sim/lib/knowledge/access/types.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/7759/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/7759/files#diff-0f604e212994706854c1cca95f0053e93387f0abd22def425bb32ec73bca62b5
https://github.com/simstudioai/sim/pull/7759/files#diff-0f604e212994706854c1cca95f0053e93387f0abd22def425bb32ec73bca62b5
apps/sim/lib/knowledge/read-access.test.tshttps://github.com/simstudioai/sim/pull/7759/files#diff-8cbc2b0ac7dae7c2d71cd0df97379748063a850a2d36445d823b609a4079414d
View file https://github.com/simstudioai/sim/blob/f7949f3c9f6d82bdda11c0f702afb95d77cda537/apps/sim/lib/knowledge/read-access.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/7759/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/7759/files#diff-8cbc2b0ac7dae7c2d71cd0df97379748063a850a2d36445d823b609a4079414d
https://github.com/simstudioai/sim/pull/7759/files#diff-8cbc2b0ac7dae7c2d71cd0df97379748063a850a2d36445d823b609a4079414d
apps/sim/lib/knowledge/read-access.tshttps://github.com/simstudioai/sim/pull/7759/files#diff-f9c6d3a92438a7dae485f120026274fc87350340de1159b3daa1a90ea0a5d4ca
View file https://github.com/simstudioai/sim/blob/f7949f3c9f6d82bdda11c0f702afb95d77cda537/apps/sim/lib/knowledge/read-access.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/7759/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/7759/files#diff-f9c6d3a92438a7dae485f120026274fc87350340de1159b3daa1a90ea0a5d4ca
https://github.com/simstudioai/sim/pull/7759/files#diff-f9c6d3a92438a7dae485f120026274fc87350340de1159b3daa1a90ea0a5d4ca
apps/sim/lib/knowledge/service.test.tshttps://github.com/simstudioai/sim/pull/7759/files#diff-5856177786ea5bfaddee3756ec5ac692c1e3e97c332ec370f6c31f401649abb8
View file https://github.com/simstudioai/sim/blob/f7949f3c9f6d82bdda11c0f702afb95d77cda537/apps/sim/lib/knowledge/service.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/7759/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/7759/files#diff-5856177786ea5bfaddee3756ec5ac692c1e3e97c332ec370f6c31f401649abb8
https://github.com/simstudioai/sim/pull/7759/files#diff-5856177786ea5bfaddee3756ec5ac692c1e3e97c332ec370f6c31f401649abb8
https://github.com/simstudioai/sim/pull/7759/files#diff-5856177786ea5bfaddee3756ec5ac692c1e3e97c332ec370f6c31f401649abb8
https://github.com/simstudioai/sim/pull/7759/files#diff-5856177786ea5bfaddee3756ec5ac692c1e3e97c332ec370f6c31f401649abb8
apps/sim/lib/knowledge/service.tshttps://github.com/simstudioai/sim/pull/7759/files#diff-6978b26968fd05cf5c7635c366c8c806693b6145235f476627302fb402f32d18
View file https://github.com/simstudioai/sim/blob/f7949f3c9f6d82bdda11c0f702afb95d77cda537/apps/sim/lib/knowledge/service.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/7759/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/7759/files#diff-6978b26968fd05cf5c7635c366c8c806693b6145235f476627302fb402f32d18
https://github.com/simstudioai/sim/pull/7759/files#diff-6978b26968fd05cf5c7635c366c8c806693b6145235f476627302fb402f32d18
https://github.com/simstudioai/sim/pull/7759/files#diff-6978b26968fd05cf5c7635c366c8c806693b6145235f476627302fb402f32d18
https://github.com/simstudioai/sim/pull/7759/files#diff-6978b26968fd05cf5c7635c366c8c806693b6145235f476627302fb402f32d18
https://github.com/simstudioai/sim/pull/7759/files#diff-6978b26968fd05cf5c7635c366c8c806693b6145235f476627302fb402f32d18
https://github.com/simstudioai/sim/pull/7759/files#diff-6978b26968fd05cf5c7635c366c8c806693b6145235f476627302fb402f32d18
https://github.com/simstudioai/sim/pull/7759/files#diff-6978b26968fd05cf5c7635c366c8c806693b6145235f476627302fb402f32d18
https://github.com/simstudioai/sim/pull/7759/files#diff-6978b26968fd05cf5c7635c366c8c806693b6145235f476627302fb402f32d18
https://github.com/simstudioai/sim/pull/7759/files#diff-6978b26968fd05cf5c7635c366c8c806693b6145235f476627302fb402f32d18
Please reload this pagehttps://github.com/simstudioai/sim/pull/7759/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.