Title: test(comparisons): cover the split-table and prose-link rendering paths by waleedlatif1 · Pull Request #7561 · simstudioai/sim · GitHub
Open Graph Title: test(comparisons): cover the split-table and prose-link rendering paths by waleedlatif1 · Pull Request #7561 · simstudioai/sim
X Title: test(comparisons): cover the split-table and prose-link rendering paths by waleedlatif1 · Pull Request #7561 · simstudioai/sim
Description: Summary Follow-up to #7560, which shipped the seven-table comparison split without automated coverage. Greptile flagged it; the PR merged before the test landed. Six tests over the rendered markup, covering one profile that sets every optional prose field (dust) and one that sets none (n8n): table count and total fact-row count both derive from COMPARISON_SECTIONS, so a dropped fact group fails every section h2 id is asserted against its section's aria-labelledby each table's aria-label is asserted distinct per section the external prose link must carry target="_blank" rel="noopener noreferrer"; the internal one must carry neither lead answer and verdict assert present-when-supplied and absent-when-not Type of Change Test coverage Testing Every assertion was verified red against a deliberately mutated build before landing — restoring the shared aria-label, swapping ProseLink back to a bare anchor, and dropping a section from the render loop each turn the corresponding test red. Worth noting: the link assertion initially passed against the broken build, because matching on href alone hit a source-citation anchor elsewhere on the page pointing at the same URL. It now anchors on the link text. bun run lint, bun run check:audits (45 audits), and bun run type-check pass. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)
Open Graph Description: Summary Follow-up to #7560, which shipped the seven-table comparison split without automated coverage. Greptile flagged it; the PR merged before the test landed. Six tests over the rendered markup,...
X Description: Summary Follow-up to #7560, which shipped the seven-table comparison split without automated coverage. Greptile flagged it; the PR merged before the test landed. Six tests over the rendered markup,...
Opengraph URL: https://github.com/simstudioai/sim/pull/7561
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:f37b798a-1bc8-1246-4879-bc969e7128ab |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | A5EE:7C051:A93BDC:E9BC5D:6AFB5271 |
| html-safe-nonce | 8fbb5b38b4172fd851b785336524377c6b7815ad45a7c80f8d0118f23cf92340 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNUVFOjdDMDUxOkE5M0JEQzpFOUJDNUQ6NkFGQjUyNzEiLCJ2aXNpdG9yX2lkIjoiODc1NDI5NTE4Mzk2MjIzMTQwOSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 98e14f76a2aef2a191ff567b2420cc975f6f4e675a55830a721f3d64623715f2 |
| hovercard-subject-tag | pull_request:4455735700 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/7561/files |
| twitter:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| og:image:alt | Summary Follow-up to #7560, which shipped the seven-table comparison split without automated coverage. Greptile flagged it; the PR merged before the test landed. Six tests over the rendered markup,... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 7122bb414b542dba14d71a3f0b9f6fd2abce715b9f5912d082800563e6c806d1 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/simstudioai/sim git https://github.com/simstudioai/sim.git |
| octolytics-dimension-user_id | 199344406 |
| octolytics-dimension-user_login | simstudioai |
| octolytics-dimension-repository_id | 912559512 |
| octolytics-dimension-repository_nwo | simstudioai/sim |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 912559512 |
| octolytics-dimension-repository_network_root_nwo | simstudioai/sim |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | cbf66c024bb6d10e6955baa7413c54cf13a201bb |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width