René's URL Explorer Experiment


Title: fix(security): guard two OOXML paths that reached JSZip without a zip-bomb check by waleedlatif1 · Pull Request #7526 · simstudioai/sim · GitHub

Open Graph Title: fix(security): guard two OOXML paths that reached JSZip without a zip-bomb check by waleedlatif1 · Pull Request #7526 · simstudioai/sim

X Title: fix(security): guard two OOXML paths that reached JSZip without a zip-bomb check by waleedlatif1 · Pull Request #7526 · simstudioai/sim

Description: Summary extractDocxText rescues a parse failure by re-reading the package as a possibly-empty document. That rescue handed the buffer to JSZip with no size guard, and a zip bomb's rejection is exactly what routes it there — so the guard was the trigger for reading word/document.xml into a string uncapped. Now guarded like every other JSZip call site in the file, placed outside the catch so the rejection propagates instead of being read as "not empty". extractDocAssets handed an attacker-supplied .pptx/.docx straight to JSZip and inflated every */media/* entry into a retained Buffer. The only ceiling was on the compressed source, which DEFLATE's ~1000:1 ratio makes meaningless. Now applies the same shared guard the document parsers and extractDocumentStyle already apply. No new limits are introduced. Both call sites use the existing shared ceilings in ooxml-limits.ts, so a file rejected here is one Sim's text-extraction path (/api/v2/files//text) already rejects today — this removes an inconsistency rather than adding a restriction. The Word path provably has zero new rejection surface: isEmptyWordPackage is module-private and reached only after DocxParser.parseBuffer ran the identical guard on the identical buffer, so the new call can only throw where the parser already threw. Type of Change Bug fix Testing Two regression tests, each verified to fail without its fix and pass with it. Full apps/sim suite: 3,030 files / 41,965 tests passing. bun run lint, bun run type-check, bun run check:audits (45 audits), docs-manifest:check, and the block-registry audit all pass. Notes Follow-up worth considering (deliberately not in this PR): an audit rule asserting that server-side OOXML consumers call assertOoxmlArchiveWithinLimits. The invariant spans four decompression libraries (mammoth, SheetJS, officeparser, JSZip), so it can't be expressed as a wrapper — a lint-style check is the right shape, but it's ~150 lines of tooling that doesn't belong on a two-line security fix. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary extractDocxText rescues a parse failure by re-reading the package as a possibly-empty document. That rescue handed the buffer to JSZip with no size guard, and a zip bomb's rejection is...

X Description: Summary extractDocxText rescues a parse failure by re-reading the package as a possibly-empty document. That rescue handed the buffer to JSZip with no size guard, and a zip bomb's rejectio...

Opengraph URL: https://github.com/simstudioai/sim/pull/7526

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:680cd3f2-4647-922f-6b4c-cc1b9a64b9fd
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9EA6:1BC3DC:8D386B:C7D939:6AFB5134
html-safe-noncefc07556cfee0d250646f2e2b911871a815235746c5e2c604c8a7d4a34faa7f13
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RUE2OjFCQzNEQzo4RDM4NkI6QzdEOTM5OjZBRkI1MTM0IiwidmlzaXRvcl9pZCI6Ijk3MTA3MzM3Mjc3MzExMDA2OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac9e1724ede1da2b5af3a0e34092038f82e6fbd11acb5e848da50f1f05c5664906
hovercard-subject-tagpull_request:4452755100
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/7526/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary extractDocxText rescues a parse failure by re-reading the package as a possibly-empty document. That rescue handed the buffer to JSZip with no size guard, and a zip bomb's rejection is...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None7122bb414b542dba14d71a3f0b9f6fd2abce715b9f5912d082800563e6c806d1
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasecbf66c024bb6d10e6955baa7413c54cf13a201bb
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/7526/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F7526%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F7526%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/7526/files
Reloadhttps://github.com/simstudioai/sim/pull/7526/files
Reloadhttps://github.com/simstudioai/sim/pull/7526/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/ooxml-zip-bomb-guardshttps://github.com/simstudioai/sim/tree/fix/ooxml-zip-bomb-guards
Conversation 2 https://github.com/simstudioai/sim/pull/7526
Commits 1 https://github.com/simstudioai/sim/pull/7526/commits
Checks 31 https://github.com/simstudioai/sim/pull/7526/checks
Files changed https://github.com/simstudioai/sim/pull/7526/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/7526/files
fix(security): guard two OOXML paths that reached JSZip without a zip-bomb check https://github.com/simstudioai/sim/pull/7526/files#top
Show all changes 1 commit https://github.com/simstudioai/sim/pull/7526/files
795f35e fix(security): guard two OOXML paths that reached JSZip without a zip… waleedlatif1 Sep 5, 2026 https://github.com/simstudioai/sim/pull/7526/commits/795f35ea073c6acb65b548ff677cf4dabd2f533f
Clear filters https://github.com/simstudioai/sim/pull/7526/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/7526/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/7526/files
doc-asset-extract.test.ts https://github.com/simstudioai/sim/pull/7526/files#diff-89d1a804eeb129afcb69cd78a8fa93cb902511f332a69ad5453cbb374e50f658
doc-asset-extract.ts https://github.com/simstudioai/sim/pull/7526/files#diff-dd399773eaffe7bbc0d988e00504dd4e2438004f99fa92413c207a1869eb4bd9
document.server.test.ts https://github.com/simstudioai/sim/pull/7526/files#diff-eaeb0687fae356c5bf00ff12fafe02e7a24c220ae2e9f8ce970a10ab2daf7812
document.server.ts https://github.com/simstudioai/sim/pull/7526/files#diff-ee98041aa2731bc395818c04cba564e8249a1b266627e3bdbd8b181fb5c22e6b
apps/sim/lib/copilot/tools/server/files/doc-asset-extract.test.tshttps://github.com/simstudioai/sim/pull/7526/files#diff-89d1a804eeb129afcb69cd78a8fa93cb902511f332a69ad5453cbb374e50f658
View file https://github.com/simstudioai/sim/blob/795f35ea073c6acb65b548ff677cf4dabd2f533f/apps/sim/lib/copilot/tools/server/files/doc-asset-extract.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/7526/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/7526/files#diff-89d1a804eeb129afcb69cd78a8fa93cb902511f332a69ad5453cbb374e50f658
https://github.com/simstudioai/sim/pull/7526/files#diff-89d1a804eeb129afcb69cd78a8fa93cb902511f332a69ad5453cbb374e50f658
https://github.com/simstudioai/sim/pull/7526/files#diff-89d1a804eeb129afcb69cd78a8fa93cb902511f332a69ad5453cbb374e50f658
https://github.com/simstudioai/sim/pull/7526/files#diff-89d1a804eeb129afcb69cd78a8fa93cb902511f332a69ad5453cbb374e50f658
apps/sim/lib/copilot/tools/server/files/doc-asset-extract.tshttps://github.com/simstudioai/sim/pull/7526/files#diff-dd399773eaffe7bbc0d988e00504dd4e2438004f99fa92413c207a1869eb4bd9
View file https://github.com/simstudioai/sim/blob/795f35ea073c6acb65b548ff677cf4dabd2f533f/apps/sim/lib/copilot/tools/server/files/doc-asset-extract.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/7526/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/7526/files#diff-dd399773eaffe7bbc0d988e00504dd4e2438004f99fa92413c207a1869eb4bd9
https://github.com/simstudioai/sim/pull/7526/files#diff-dd399773eaffe7bbc0d988e00504dd4e2438004f99fa92413c207a1869eb4bd9
https://github.com/simstudioai/sim/pull/7526/files#diff-dd399773eaffe7bbc0d988e00504dd4e2438004f99fa92413c207a1869eb4bd9
apps/sim/lib/microsoft-word/document.server.test.tshttps://github.com/simstudioai/sim/pull/7526/files#diff-eaeb0687fae356c5bf00ff12fafe02e7a24c220ae2e9f8ce970a10ab2daf7812
View file https://github.com/simstudioai/sim/blob/795f35ea073c6acb65b548ff677cf4dabd2f533f/apps/sim/lib/microsoft-word/document.server.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/7526/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/7526/files#diff-eaeb0687fae356c5bf00ff12fafe02e7a24c220ae2e9f8ce970a10ab2daf7812
https://github.com/simstudioai/sim/pull/7526/files#diff-eaeb0687fae356c5bf00ff12fafe02e7a24c220ae2e9f8ce970a10ab2daf7812
https://github.com/simstudioai/sim/pull/7526/files#diff-eaeb0687fae356c5bf00ff12fafe02e7a24c220ae2e9f8ce970a10ab2daf7812
https://github.com/simstudioai/sim/pull/7526/files#diff-eaeb0687fae356c5bf00ff12fafe02e7a24c220ae2e9f8ce970a10ab2daf7812
apps/sim/lib/microsoft-word/document.server.tshttps://github.com/simstudioai/sim/pull/7526/files#diff-ee98041aa2731bc395818c04cba564e8249a1b266627e3bdbd8b181fb5c22e6b
View file https://github.com/simstudioai/sim/blob/795f35ea073c6acb65b548ff677cf4dabd2f533f/apps/sim/lib/microsoft-word/document.server.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/7526/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/7526/files#diff-ee98041aa2731bc395818c04cba564e8249a1b266627e3bdbd8b181fb5c22e6b
https://github.com/simstudioai/sim/pull/7526/files#diff-ee98041aa2731bc395818c04cba564e8249a1b266627e3bdbd8b181fb5c22e6b
Please reload this pagehttps://github.com/simstudioai/sim/pull/7526/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.