René's URL Explorer Experiment


Title: fix(knowledge): bound JSON/YAML chunker expansion by waleedlatif1 · Pull Request #7524 · simstudioai/sim · GitHub

Open Graph Title: fix(knowledge): bound JSON/YAML chunker expansion by waleedlatif1 · Pull Request #7524 · simstudioai/sim

X Title: fix(knowledge): bound JSON/YAML chunker expansion by waleedlatif1 · Pull Request #7524 · simstudioai/sim

Description: Summary JsonYamlChunker re-parsed and re-serialized document content with no expansion limit. ChunkBudget only counts emitted chunks, so every yaml.load / JSON.parse and the full-object JSON.stringify in chunkObject ran before it could fire — a small aliased YAML source expands to tens of MB of tree and string, and the same content was parsed twice because isStructuredData and chunkJsonYaml each parsed it. Measure the parsed value with the shared measureYamlExpansion guard (the same one yaml-parser.ts already uses) before anything materializes it, and skip parsing entirely when the source is already larger than the ceiling. Size the ceiling to the most text the chunker could ever emit (maxChunks × chunkSize), floored at 4MB and capped at what the YAML file parser itself permits — a document above that cannot be indexed whole by any chunker, so expanding it buys nothing, and everything that fits the budget chunks exactly as before. Replace isStructuredData + chunkJsonYaml with one chunkStructured entry point that parses once and returns null when the content is not structured (or would not fit), leaving chunker selection with the document processor. This removes a full parse and parsed-tree allocation per JSON/YAML document on the ingestion path. Type of Change Bug fix Testing Tested manually. Added chunker tests for the alias-expansion case and for never parsing an oversized source (verified both fail when the guard is removed). Full apps/sim suite passes (41,965 tests), plus bun run lint, bun run check:audits (45 audits), and bun run type-check. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary JsonYamlChunker re-parsed and re-serialized document content with no expansion limit. ChunkBudget only counts emitted chunks, so every yaml.load / JSON.parse and the full-object JSON.strin...

X Description: Summary JsonYamlChunker re-parsed and re-serialized document content with no expansion limit. ChunkBudget only counts emitted chunks, so every yaml.load / JSON.parse and the full-object JSON.strin...

Opengraph URL: https://github.com/simstudioai/sim/pull/7524

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:0809cb2f-d0b5-8ce1-4119-27265ed06d0c
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD838:B85F4:B4FB28:F8269C:6AFB517B
html-safe-nonce7d792de1a3ca4e7500ee675ffb7889ace2ecc1aa61578e83a80f73aa9cae683d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEODM4OkI4NUY0OkI0RkIyODpGODI2OUM6NkFGQjUxN0IiLCJ2aXNpdG9yX2lkIjoiMTcxMjU4NTcyODIzNzE5NTY0NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac7090f48a21a4e9eac8b70996c20dcb978e6b7bc30fe9678b59cbbace7e023eba
hovercard-subject-tagpull_request:4452676842
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/7524/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary JsonYamlChunker re-parsed and re-serialized document content with no expansion limit. ChunkBudget only counts emitted chunks, so every yaml.load / JSON.parse and the full-object JSON.strin...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None7122bb414b542dba14d71a3f0b9f6fd2abce715b9f5912d082800563e6c806d1
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasecbf66c024bb6d10e6955baa7413c54cf13a201bb
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/7524/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F7524%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F7524%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/7524/files
Reloadhttps://github.com/simstudioai/sim/pull/7524/files
Reloadhttps://github.com/simstudioai/sim/pull/7524/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/json-yaml-chunker-expansion-guardhttps://github.com/simstudioai/sim/tree/fix/json-yaml-chunker-expansion-guard
Conversation 13 https://github.com/simstudioai/sim/pull/7524
Commits 2 https://github.com/simstudioai/sim/pull/7524/commits
Checks 31 https://github.com/simstudioai/sim/pull/7524/checks
Files changed https://github.com/simstudioai/sim/pull/7524/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/7524/files
fix(knowledge): bound JSON/YAML chunker expansion https://github.com/simstudioai/sim/pull/7524/files#top
Show all changes 2 commits https://github.com/simstudioai/sim/pull/7524/files
aba6fe2 fix(knowledge): bound JSON/YAML chunker expansion waleedlatif1 Sep 5, 2026 https://github.com/simstudioai/sim/pull/7524/commits/aba6fe210b5793f69877ff73b44cb0ff4d7f849a
1e3e3eb fix(knowledge): allow proportionate expansion in the chunker guard waleedlatif1 Sep 5, 2026 https://github.com/simstudioai/sim/pull/7524/commits/1e3e3ebbf555d6f5a145bfe1cbba0ebc1bae0e0b
Clear filters https://github.com/simstudioai/sim/pull/7524/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/7524/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/7524/files
json-yaml-chunker.test.ts https://github.com/simstudioai/sim/pull/7524/files#diff-5a7b642e155f67d0b9fdc470a12a5ddb39574a63f2bc77d701dbd8af14b03c73
json-yaml-chunker.ts https://github.com/simstudioai/sim/pull/7524/files#diff-d48559e3b932828168d549e929266ed45803ec682ca11013609292f26b248db5
yaml-parser.ts https://github.com/simstudioai/sim/pull/7524/files#diff-3a83a6c108b30c7540788af186f14635f94cc58f8387c59cdea30724c820c37a
document-processor.ts https://github.com/simstudioai/sim/pull/7524/files#diff-caef18c7f5680f8ad0ec1e40b90e7635fe8f182b55d4fd20ef78fbe881f11205
apps/sim/lib/chunkers/json-yaml-chunker.test.tshttps://github.com/simstudioai/sim/pull/7524/files#diff-5a7b642e155f67d0b9fdc470a12a5ddb39574a63f2bc77d701dbd8af14b03c73
View file https://github.com/simstudioai/sim/blob/1e3e3ebbf555d6f5a145bfe1cbba0ebc1bae0e0b/apps/sim/lib/chunkers/json-yaml-chunker.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/7524/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/7524/files#diff-5a7b642e155f67d0b9fdc470a12a5ddb39574a63f2bc77d701dbd8af14b03c73
https://github.com/simstudioai/sim/pull/7524/files#diff-5a7b642e155f67d0b9fdc470a12a5ddb39574a63f2bc77d701dbd8af14b03c73
https://github.com/simstudioai/sim/pull/7524/files#diff-5a7b642e155f67d0b9fdc470a12a5ddb39574a63f2bc77d701dbd8af14b03c73
https://github.com/simstudioai/sim/pull/7524/files#diff-5a7b642e155f67d0b9fdc470a12a5ddb39574a63f2bc77d701dbd8af14b03c73
https://github.com/simstudioai/sim/pull/7524/files#diff-5a7b642e155f67d0b9fdc470a12a5ddb39574a63f2bc77d701dbd8af14b03c73
https://github.com/simstudioai/sim/pull/7524/files#diff-5a7b642e155f67d0b9fdc470a12a5ddb39574a63f2bc77d701dbd8af14b03c73
apps/sim/lib/chunkers/json-yaml-chunker.tshttps://github.com/simstudioai/sim/pull/7524/files#diff-d48559e3b932828168d549e929266ed45803ec682ca11013609292f26b248db5
View file https://github.com/simstudioai/sim/blob/1e3e3ebbf555d6f5a145bfe1cbba0ebc1bae0e0b/apps/sim/lib/chunkers/json-yaml-chunker.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/7524/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/7524/files#diff-d48559e3b932828168d549e929266ed45803ec682ca11013609292f26b248db5
https://github.com/simstudioai/sim/pull/7524/files#diff-d48559e3b932828168d549e929266ed45803ec682ca11013609292f26b248db5
Please reload this pagehttps://github.com/simstudioai/sim/pull/7524/files
https://github.com/simstudioai/sim/pull/7524/files#diff-d48559e3b932828168d549e929266ed45803ec682ca11013609292f26b248db5
https://github.com/simstudioai/sim/pull/7524/files#diff-d48559e3b932828168d549e929266ed45803ec682ca11013609292f26b248db5
https://github.com/simstudioai/sim/pull/7524/files#diff-d48559e3b932828168d549e929266ed45803ec682ca11013609292f26b248db5
https://github.com/simstudioai/sim/pull/7524/files#diff-d48559e3b932828168d549e929266ed45803ec682ca11013609292f26b248db5
https://github.com/simstudioai/sim/pull/7524/files#diff-d48559e3b932828168d549e929266ed45803ec682ca11013609292f26b248db5
apps/sim/lib/file-parsers/yaml-parser.tshttps://github.com/simstudioai/sim/pull/7524/files#diff-3a83a6c108b30c7540788af186f14635f94cc58f8387c59cdea30724c820c37a
View file https://github.com/simstudioai/sim/blob/1e3e3ebbf555d6f5a145bfe1cbba0ebc1bae0e0b/apps/sim/lib/file-parsers/yaml-parser.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/7524/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/7524/files#diff-3a83a6c108b30c7540788af186f14635f94cc58f8387c59cdea30724c820c37a
https://github.com/simstudioai/sim/pull/7524/files#diff-3a83a6c108b30c7540788af186f14635f94cc58f8387c59cdea30724c820c37a
apps/sim/lib/knowledge/documents/document-processor.tshttps://github.com/simstudioai/sim/pull/7524/files#diff-caef18c7f5680f8ad0ec1e40b90e7635fe8f182b55d4fd20ef78fbe881f11205
View file https://github.com/simstudioai/sim/blob/1e3e3ebbf555d6f5a145bfe1cbba0ebc1bae0e0b/apps/sim/lib/knowledge/documents/document-processor.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/7524/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/7524/files#diff-caef18c7f5680f8ad0ec1e40b90e7635fe8f182b55d4fd20ef78fbe881f11205
https://github.com/simstudioai/sim/pull/7524/files#diff-caef18c7f5680f8ad0ec1e40b90e7635fe8f182b55d4fd20ef78fbe881f11205
Please reload this pagehttps://github.com/simstudioai/sim/pull/7524/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.