Title: feat(oracle-fusion-sales): add Oracle Fusion Sales integration by BillLeoutsakosvl346 · Pull Request #7516 · simstudioai/sim · GitHub
Open Graph Title: feat(oracle-fusion-sales): add Oracle Fusion Sales integration by BillLeoutsakosvl346 · Pull Request #7516 · simstudioai/sim
X Title: feat(oracle-fusion-sales): add Oracle Fusion Sales integration by BillLeoutsakosvl346 · Pull Request #7516 · simstudioai/sim
Description: Summary Add Oracle Fusion Sales with 55 internal tools, a complete canvas block, 16 server selectors, eight templates, and six sourced workflow skills. Reuse the Oracle Fusion foundation (family: 'crm'), credential-authoritative destinations, and NetSuiteIcon. Stack on #7427, base feat/oracle-fusion-foundation, foundation SHA 29d3eeedfdbb9245fcc5aba8a3304b2d3e0d6bd0. Keep the Sales delta in one implementation commit so manual CI audits cover the complete integration. Product boundary Accounts, contacts, lead qualification/conversion, opportunities, tasks/appointments/call reports, sales resources, opportunity contacts/revenue/team, and activity assignees/contacts. No Fusion Service, Oracle B2C Service, triggers, connectors, new authentication infrastructure, dependencies, migrations, or CI changes. No foundation implementation changes or overrides. Design and documentation decisions CRM resource version 11.13.18.05; existing foundation sends REST-Framework-Version: 9. Resource writes use application/vnd.oracle.adf.resourceitem+json, actions use application/vnd.oracle.adf.action+json. Oracle quick start. Public numbers remain business strings; framework-8+ reserved-character encoding is applied in Sales path builders. Opaque keys come only from validated self links, never numeric business IDs or unverified @context.key. Framework behavior. IDs remain exact strings; documented numeric request IDs use the foundation exact-integer serializer after Sales validation. High-precision response decimals preserve the documented JSON-number/string wire representation; union-valued output metadata uses the existing type: 'json' convention. Activity CLOB descriptions/minutes are plain text under framework 9, despite legacy endpoint descriptions mentioning Base64. Framework behavior, activity table CLOB definitions. Outputs expose documented partial description/minute fields rather than inventing full-text output schemas. Assignment actions run configured Oracle assignment; update tools set explicit owners. Convert Lead uses the documented convertLeadToOpty result string, not guessed opportunity identifiers. Action HTTP success does not assert business success; callers inspect result. Lists fetch one page, default 50 and maximum 100, with hasMore/nextOffset. Duplicate matching has no documented pagination; reject more than 1,000 candidates before projection, without silent truncation. Reuse the existing service-account provider with API-key catalog classification. Credential-authoritative origin cannot be overridden by workflow inputs. No new OAuth client or minter. Selectors cover account/contact/opportunity business numbers and numeric relationship IDs, lead opaque/numeric IDs, activities, resource numbers/owner IDs, lead/activity statuses, business-unit-scoped opportunity statuses/methods, and method-scoped stages. Numeric opportunity detail uses documented PrimaryKey;OptyId=... instead of inheriting default OPEN/MYOPTIES/current-period scope. Lookup evidence: resources, standard lookups, opportunity statuses, sales methods, sales stages. Values remain tenant lookup codes, not example-label enums. Operation evidence matrix All IDs below have the public prefix oracle_fusion_sales_; paths are relative to /crmRestApi/resources/11.13.18.05/. Writable fields and response fields were checked separately against each operation schema and captured in Sales request validation/output declarations. Child paths supply their parent context. Oracle often labels success only “Default Response”; numeric success statuses are not invented. Delete pages specify No Content. Tool suffix Method and resource Required workflow inputs / constraints Documented success projection Evidence accept_lead POST leads/action/acceptLead key/path as shown result string Oracle add_activity_assignee POST activities/{ActivityNumber}/child/ActivityAssignee ownerId record Oracle add_activity_contact POST activities/{ActivityNumber}/child/ActivityContact contactId record Oracle add_opportunity_contact POST opportunities/{OptyNumber}/child/OpportunityContact contactId record Oracle add_opportunity_team_member POST opportunities/{OptyNumber}/child/OpportunityResource ownerId record Oracle assign_account POST accounts/action/runAssignment key/path as shown result string Oracle assign_lead POST leads/action/runAssignment key/path as shown result string Oracle assign_opportunity POST opportunities/action/assignOpportunity key/path as shown result string Oracle convert_lead POST leads/action/convertLeadToOpty key/path as shown result string Oracle create_account POST accounts organizationName record Oracle create_appointment POST activities subject, startDateTime, endDateTime record Oracle create_call_report POST activities subject, startDateTime, endDateTime record Oracle create_contact POST contacts key/path as shown record Oracle create_lead POST leads name record Oracle create_opportunity POST opportunities name record Oracle create_opportunity_revenue POST opportunities/{OptyNumber}/child/ChildRevenue key/path as shown record Oracle create_task POST activities subject record Oracle delete_account DELETE accounts/{PartyNumber} key/path as shown no content → deleted Oracle delete_activity DELETE activities/{ActivityNumber} key/path as shown no content → deleted Oracle delete_contact DELETE contacts/{PartyNumber} key/path as shown no content → deleted Oracle delete_lead DELETE leads/{leadsUniqID} key/path as shown no content → deleted Oracle delete_opportunity DELETE opportunities/{OptyNumber} key/path as shown no content → deleted Oracle delete_opportunity_revenue DELETE opportunities/{OptyNumber}/child/ChildRevenue/{ChildRevenueUniqID} key/path as shown no content → deleted Oracle find_duplicate_accounts POST accounts/action/findDuplicates key/path as shown result candidate maps → items, count Oracle find_duplicate_contacts POST contacts/action/findDuplicates key/path as shown result candidate maps → items, count Oracle get_account GET accounts/{PartyNumber} key/path as shown record Oracle get_activity GET activities/{ActivityNumber} key/path as shown record Oracle get_contact GET contacts/{PartyNumber} key/path as shown record Oracle get_lead GET leads/{leadsUniqID} key/path as shown record Oracle get_opportunity GET opportunities/{OptyNumber} key/path as shown record Oracle get_sales_resource GET resources/{PartyNumber} key/path as shown record Oracle list_accounts GET accounts bounded page; q/finder optional items + pagination Oracle list_activities GET activities bounded page; q/finder optional items + pagination Oracle list_activity_assignees GET activities/{ActivityNumber}/child/ActivityAssignee bounded page; q/finder optional items + pagination Oracle list_activity_contacts GET activities/{ActivityNumber}/child/ActivityContact bounded page; q/finder optional items + pagination Oracle list_contacts GET contacts bounded page; q/finder optional items + pagination Oracle list_leads GET leads bounded page; q/finder optional items + pagination Oracle list_opportunities GET opportunities bounded page; q/finder optional items + pagination Oracle list_opportunity_contacts GET opportunities/{OptyNumber}/child/OpportunityContact bounded page; q/finder optional items + pagination Oracle list_opportunity_revenue GET opportunities/{OptyNumber}/child/ChildRevenue bounded page; q/finder optional items + pagination Oracle list_opportunity_team GET opportunities/{OptyNumber}/child/OpportunityResource bounded page; q/finder optional items + pagination Oracle list_sales_resources GET resources bounded page; q/finder optional items + pagination Oracle reject_lead POST leads/action/rejectLead key/path as shown result string Oracle remove_activity_assignee DELETE activities/{ActivityNumber}/child/ActivityAssignee/{ActivityAssigneeUniqID} key/path as shown no content → deleted Oracle remove_activity_contact DELETE activities/{ActivityNumber}/child/ActivityContact/{ActivityContactUniqID} key/path as shown no content → deleted Oracle remove_opportunity_contact DELETE opportunities/{OptyNumber}/child/OpportunityContact/{OptyConId} key/path as shown no content → deleted Oracle remove_opportunity_team_member DELETE opportunities/{OptyNumber}/child/OpportunityResource/{OpportunityResourceUniqID} key/path as shown no content → deleted Oracle update_account PATCH accounts/{PartyNumber} key + at least one writable field record Oracle update_activity PATCH activities/{ActivityNumber} key + at least one writable field record Oracle update_contact PATCH contacts/{PartyNumber} key + at least one writable field record Oracle update_lead PATCH leads/{leadsUniqID} key + at least one writable field record Oracle update_opportunity PATCH opportunities/{OptyNumber} key + at least one writable field record Oracle update_opportunity_contact PATCH opportunities/{OptyNumber}/child/OpportunityContact/{OptyConId} key + at least one writable field record Oracle update_opportunity_revenue PATCH opportunities/{OptyNumber}/child/ChildRevenue/{ChildRevenueUniqID} key + at least one writable field record Oracle update_opportunity_team_member PATCH opportunities/{OptyNumber}/child/OpportunityResource/{OpportunityResourceUniqID} key + at least one writable field record Oracle Required-field and live-validation limits Account creation requires OrganizationName; contact creation requires first or last name. Address requirements depend on tenant profile settings. Account attributes, contact attributes. Opportunity currency/business-unit and several generated IDs/default owner fields are server-defaulted in documented create examples; do not require server-generated values solely because broad resource schemas mark them required. Opportunity attributes. Appointment/call-report start/end timestamps are required; tasks use the documented task variant. Revenue creation requires a product group or paired inventory-item/organization identifiers. Specific access and tenant setup remain prerequisites. No live Oracle tenant credentials were supplied. Documentation-backed mocked contract tests do not establish live role access, tenant customizations, assignment configuration, duplicate-match setup, or optional lookup availability. Oracle quick-start prerequisites require appropriate user roles and resource/data permissions. Optional missing/null response fields are projected as null. Direct tool updates can send documented null clears; empty canvas controls are omitted. Precedents and file scope CRM workflows and output property literals: apps/sim/blocks/blocks/salesforce.ts, apps/sim/tools/salesforce/types.ts, apps/sim/blocks/blocks/hubspot.ts. Every operation declaration follows the corresponding NetSuite internal-tool class: apps/sim/tools/netsuite/list_records.ts, get_record.ts, create_record.ts, update_record.ts, delete_record.ts, or execute_action.ts; barrel/types follow apps/sim/tools/netsuite/index.ts and types.ts. Shared factory structure follows the investigated Oracle SCM tools/oracle_fusion_scm/shared.ts; reusable output literals use the Salesforce precedent above. JSON-union output precedent: apps/sim/tools/rocketlane/types.ts. Internal handler/operations and integration test: apps/sim/lib/internal/netsuite/execute-tool.ts, apps/sim/lib/internal/netsuite/operations/, apps/sim/tools/netsuite/netsuite.test.ts. Domain validation: apps/sim/lib/internal/pipedrive/schema.ts. Split operation/projector/validation coverage follows the investigated Oracle HCM internal implementation/test organization. Block/icon and selectors: apps/sim/blocks/blocks/netsuite.ts, apps/sim/lib/selectors/server/providers/netsuite.ts and netsuite.test.ts. All shared-file changes are Sales registrations, selector context declarations/inventory counts, or generated entries. No standalone block test, Sales OAuth test, Sales HTTP API contract file, new SVG, shared helpers, or foundation changes. No new files outside the approved tree. Planned copilot-native tool-catalog-v1.ts/tool-schemas-v1.ts remain unchanged: mship-tools:generate consumes an external copilot catalog unrelated to these integration tools and that source checkout is unavailable. The attempted command failed before writing. No synthetic external catalog or generator fix was added. Type of Change New integration Testing Independent validate-integration/validate-selector/memory-load review was read-only and covered the combined foundation plus Sales. Sales-specific findings were corrected in this PR; no foundation blocker identified. Final independent source-review verdict: no unresolved Sales correctness findings; no foundation change requested. GitHub validation is tracked below as it finishes. Authored approved coverage for all 55 request mappings, action/delete response contracts, exact numeric IDs and opaque/public keys, validation-before-network, pagination, cancellation/errors, selector binding/detail/lookup behavior, block canonical mapping, and registration alignment. No local tests, builds, type checks, lint, formatters, or audits ran. The permitted artifact generators ran sequentially; service-account provider map stayed unchanged. The stack targets a branch not covered by normal PR CI. Validation runs through the existing manual workflow: gh workflow run test-build.yml --repo simstudioai/sim --ref investigate/oracle-fusion-sales-integration GitHub CI green for the latest head Greptile 5/5 for the latest revision Review threads resolved with explanations No foundation/shared infrastructure changes CI/review follow-up Initial manual CI run: https://github.com/simstudioai/sim/actions/runs/33947784869 — test shards 2 and 3 passed; lint failed on source style and the build identified a missing Sales service type registration. Those issues were corrected and the final remote run passes. No local tests, lint, formatter, build, or type checks were run. Necessary tree addition: [M] apps/sim/lib/oauth/types.ts, adding only oracle_fusion_sales to OAuthService. OAuthConfig.provider requires this union; Salesforce and Zoho Desk entries are the named precedent. This is a Sales registration, not foundation/auth infrastructure, and avoids a type assertion workaround. The independent reviewer confirmed the fix. Greptile's initial 4/5 request to use absolute barrel exports is addressed. GitGuardian's synthetic Base64 mocked fixture was replaced with the explicit test-token marker. No real credential was supplied. Final verification Head: 5d4bb3637052061110c9dfefff5b4ed9936f00b0. Foundation/HEAD~1: 29d3eeedfdbb9245fcc5aba8a3304b2d3e0d6bd0; #7427 remains the open parent PR. One Sales implementation commit, 88 files, mergeable against feat/oracle-fusion-foundation. GitHub CI: PASS — https://github.com/simstudioai/sim/actions/runs/33949072620 (exact head above). Lint, repository audits, docs manifest, all workspace type checks, all three test shards, application build, and schema/migration checks passed. All 150 Sales tests passed across the five approved integration test files. Greptile: 5/5 for the same head, review round 4. All review threads are resolved with explanations; GitGuardian and Vercel also pass. Cubic was neither requested nor used as a completion gate. Independent combined foundation-plus-Sales review: no unresolved Sales-specific correctness findings, no foundation blocker or requested foundation change. No local validation commands were run, and neither PR was merged. Reported shared issues (not changed here) Existing docs generator source parsing mishandles escaped quote descriptions (scripts/generate-docs.ts, around line 3127) and allows empty source-parsed outputs to replace useful generated metadata (around line 4015). Sales uses compatible literal declarations and unambiguous wording within its approved files; no generator changes were made. The application build emits the existing pdfjs-dist external-ESM warning in lib/pptx-renderer/utils; build still passes. No platform fix was bundled. Biome reports that the shared generated deployment integration catalog is above its configured 1 MiB file limit; this is informational and the job passes. No shared lint configuration change was made. The unavailable external copilot catalog and unchanged planned copilot-native generated files are described above; no external source was invented.
Open Graph Description: Summary Add Oracle Fusion Sales with 55 internal tools, a complete canvas block, 16 server selectors, eight templates, and six sourced workflow skills. Reuse the Oracle Fusion foundation (family: ...
X Description: Summary Add Oracle Fusion Sales with 55 internal tools, a complete canvas block, 16 server selectors, eight templates, and six sourced workflow skills. Reuse the Oracle Fusion foundation (family: ...
Opengraph URL: https://github.com/simstudioai/sim/pull/7516
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:9664f571-c65b-b6e9-100a-51c6ac796a6c |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | C3D8:3D53D8:E1CA0A:1350390:6AFB5C6D |
| html-safe-nonce | e11d2d4a6e68fc54f8847ad298c0517f378bee6ac92a11f1e18dcfcdb2e80239 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDM0Q4OjNENTNEODpFMUNBMEE6MTM1MDM5MDo2QUZCNUM2RCIsInZpc2l0b3JfaWQiOiIxMTMzMTM2MTY0MDI3MDYzNDA1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 72b878fbf148bdc67c0cf84e52b1d24fd3039c6caf2695b4320c8a26ff175432 |
| hovercard-subject-tag | pull_request:4448977785 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/7516/files |
| twitter:image | https://avatars.githubusercontent.com/u/157128530?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/157128530?s=400&v=4 |
| og:image:alt | Summary Add Oracle Fusion Sales with 55 internal tools, a complete canvas block, 16 server selectors, eight templates, and six sourced workflow skills. Reuse the Oracle Fusion foundation (family: ... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | ea33d13c96d0ff66bd8fa906b193d2213536b78cb06b0c50a4632c58b1418f94 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/simstudioai/sim git https://github.com/simstudioai/sim.git |
| octolytics-dimension-user_id | 199344406 |
| octolytics-dimension-user_login | simstudioai |
| octolytics-dimension-repository_id | 912559512 |
| octolytics-dimension-repository_nwo | simstudioai/sim |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 912559512 |
| octolytics-dimension-repository_network_root_nwo | simstudioai/sim |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 59ef97164c52cf59bd10558ddec9c4f482763988 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width