Title: chore(typescript): assert native TS7 per workspace and drop a dead install exemption by waleedlatif1 · Pull Request #7495 · simstudioai/sim · GitHub
Open Graph Title: chore(typescript): assert native TS7 per workspace and drop a dead install exemption by waleedlatif1 · Pull Request #7495 · simstudioai/sim
X Title: chore(typescript): assert native TS7 per workspace and drop a dead install exemption by waleedlatif1 · Pull Request #7495 · simstudioai/sim
Description: Summary Drop the dead @typescript/native-preview entry from the install age-gate allowlist Assert the native TypeScript 7 compiler in every workspace, not just the repo root The allowlist entry was dead bunfig.toml excluded @typescript/native-preview from minimumReleaseAge, on the grounds that it only publishes nightly builds and so can never satisfy an age gate. That was true of the package, but the repo does not depend on it: the root uses @typescript/native (an alias of typescript@^7.0.2), and native-preview appears in no package.json and no bun.lock entry — the only two mentions in the entire repo were the exclude and its own comment. An allowlist entry that names nothing still weakens the gate, because it is a standing exemption waiting for a package of that name to appear. Removed; bun install --frozen-lockfile still succeeds, which is what proves nothing was relying on it. The gate itself, and its 7-day window, are unchanged. The guard only covered the root check:native-typecheck exists because @typescript/typescript6 pulls in an alias of typescript@6 that ships its own tsc bin, and bin winners are picked by lexical sort rather than dependency depth — so a bare tsc silently drops to the ~10x slower JavaScript compiler unless @typescript/native sorts ahead of it. It asserted that on node_modules/.bin/tsc alone. But every workspace's type-check is a bare tsc --noEmit, which resolves through the nearest node_modules/.bin walking up from that package. All 29 reach the root bin today, so the root-only assertion happened to be sufficient — but a workspace that installed anything shipping its own tsc would get a local bin that shadows the root one, in exactly the same silent way, and the audit would still pass. The guard now resolves tsc per workspace the way each script would, and names the offending package and path when one disagrees. Verified by planting a stub reporting Version 6.0.2 in apps/sim/node_modules/.bin: the previous guard passed, this one fails with apps/sim: apps/sim/node_modules/.bin/tsc reports "Version 6.0.2". Why @typescript/typescript6 stays Worth recording, since removing it would dissolve the whole bin-shadowing problem. It cannot go: four audit scripts (check-pending-drop-tables, check-sql-date-binding, check-tool-request-boundary, check-egress-boundary) and apps/sim's Function-block runtime read the stable compiler API — createSourceFile, createScanner, forEachChild, SyntaxKind. typescript@7 exposes no equivalent from its root entry point (that is lib/version.cjs); its compiler API lives entirely under ./unstable/* subpaths. Moving five consumers — one of which transpiles user-supplied code in production — onto a surface the package itself labels unstable is not a trade worth making for a dependency cleanup. Type of Change Chore (tooling) Testing bun run check:native-typecheck passes across 29 workspaces, and fails as intended against a planted shadowing bin. bun install --frozen-lockfile succeeds with the allowlist entry removed; bun.lock is unchanged. Full suite, bun run check:audits, bunx turbo run type-check, bun run lint, bun run docs-manifest:check. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)
Open Graph Description: Summary Drop the dead @typescript/native-preview entry from the install age-gate allowlist Assert the native TypeScript 7 compiler in every workspace, not just the repo root The allowlist entry w...
X Description: Summary Drop the dead @typescript/native-preview entry from the install age-gate allowlist Assert the native TypeScript 7 compiler in every workspace, not just the repo root The allowlist entry w...
Opengraph URL: https://github.com/simstudioai/sim/pull/7495
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:349458e9-a0dd-1b77-9521-97f563aaf000 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | C420:EE197:B1956D:F35876:6AFB527C |
| html-safe-nonce | d4018d0a70dbd13480126d33b68e4ad95df78fb3bf2e73a473e64ead4f2e05c8 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNDIwOkVFMTk3OkIxOTU2RDpGMzU4NzY6NkFGQjUyN0MiLCJ2aXNpdG9yX2lkIjoiNTg2NjQyNTA5MzI4OTg5MDQyOCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 0a0f14b89c713ec5a865096622ef9bdabbe4dcf134371ebeb0d12ba0244c1c41 |
| hovercard-subject-tag | pull_request:4447779667 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/7495/files |
| twitter:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| og:image:alt | Summary Drop the dead @typescript/native-preview entry from the install age-gate allowlist Assert the native TypeScript 7 compiler in every workspace, not just the repo root The allowlist entry w... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 7122bb414b542dba14d71a3f0b9f6fd2abce715b9f5912d082800563e6c806d1 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/simstudioai/sim git https://github.com/simstudioai/sim.git |
| octolytics-dimension-user_id | 199344406 |
| octolytics-dimension-user_login | simstudioai |
| octolytics-dimension-repository_id | 912559512 |
| octolytics-dimension-repository_nwo | simstudioai/sim |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 912559512 |
| octolytics-dimension-repository_network_root_nwo | simstudioai/sim |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | cbf66c024bb6d10e6955baa7413c54cf13a201bb |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width