Title: docs(data-drains): describe the resolved feature, not the bare flag by waleedlatif1 · Pull Request #7475 · simstudioai/sim · GitHub
Open Graph Title: docs(data-drains): describe the resolved feature, not the bare flag by waleedlatif1 · Pull Request #7475 · simstudioai/sim
X Title: docs(data-drains): describe the resolved feature, not the bare flag by waleedlatif1 · Pull Request #7475 · simstudioai/sim
Description: Summary Fixes the Data drains self-hosted flag paragraph, raised on the v0.8.22 release PR (#7473). The finding holds up on both points. The bare flag is not what gates the feature. enterpriseFeatureEnabled resolves explicit ?? (ENTERPRISE_ENABLED || legacyDefault), and ENTERPRISE_FEATURE_LEGACY_DEFAULTS.dataDrains is false — so with DATA_DRAINS_ENABLED unset and ENTERPRISE_ENABLED set, data drains are on. The first sentence credited the bare variable and the second sentence then contradicted it. The paragraph now leads with the resolution, including that an explicit false always wins. The reason given for the public twin was wrong. Inside a workspace, WorkspaceHostProvider seeds the deployment shape from the server-resolved host context, useDeploymentShape() returns that seeded value, and the settings sidebar gates 'data-drains': features.dataDrains from it (components/settings/navigation.ts; settings/navigation.ts says so in a comment: "the sidebar applies deployment and entitlement visibility from the host context"). So the page follows the server whether or not the twin is set, and "set it so the browser's configuration matches the server's" misdescribed what the browser reads. The advice to set it stands, with the accurate reason: it backs browserFallbackShape() wherever nothing has seeded the shape, and it is what sim-setup doctor compares (packages/sim-setup/src/twins.ts). One qualification to the original finding: it proposed treating the twin as "doctor consistency only", which understates it — the twin is still the client fallback outside a seeded workspace, so the page says both roles rather than dropping one. Type of Change Bug fix (documentation accuracy) Testing bun run lint, bun run check:audits (45), and bun run docs-manifest:check all pass. Every claim was traced to source before rewriting: enterprise-entitlements.ts, env-flags.ts, deployment-shape.ts, workspace-host-provider.tsx, components/settings/navigation.ts, and sim-setup/src/twins.ts. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA) 🤖 Generated with Claude Code
Open Graph Description: Summary Fixes the Data drains self-hosted flag paragraph, raised on the v0.8.22 release PR (#7473). The finding holds up on both points. The bare flag is not what gates the feature. enterpriseFeatu...
X Description: Summary Fixes the Data drains self-hosted flag paragraph, raised on the v0.8.22 release PR (#7473). The finding holds up on both points. The bare flag is not what gates the feature. enterpriseFeatu...
Opengraph URL: https://github.com/simstudioai/sim/pull/7475
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:a766612c-b2d5-1180-12a5-2bdaf873a85c |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | BB42:C4B81:756AD3:A28E54:6AFB4546 |
| html-safe-nonce | d05f74c3b0b1daacd667b28fa63ade25f0736612fdf00ec3604f10a782a2cd8a |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQjQyOkM0QjgxOjc1NkFEMzpBMjhFNTQ6NkFGQjQ1NDYiLCJ2aXNpdG9yX2lkIjoiNjY4MzI1NDQxMTg2ODQ1NjI2MiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | ef0b90992c35d58439416c7d3c8b90e289ec688ea7e67a4c4cda5ea97804993b |
| hovercard-subject-tag | pull_request:4438942802 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/7475/files |
| twitter:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| og:image:alt | Summary Fixes the Data drains self-hosted flag paragraph, raised on the v0.8.22 release PR (#7473). The finding holds up on both points. The bare flag is not what gates the feature. enterpriseFeatu... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | d849b928f455c800985398e7f1b659425adb312a5fa14fba5d9a14e62e9fe5dd |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/simstudioai/sim git https://github.com/simstudioai/sim.git |
| octolytics-dimension-user_id | 199344406 |
| octolytics-dimension-user_login | simstudioai |
| octolytics-dimension-repository_id | 912559512 |
| octolytics-dimension-repository_nwo | simstudioai/sim |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 912559512 |
| octolytics-dimension-repository_network_root_nwo | simstudioai/sim |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | a6c2f87cbcb6414452377b4967858ed6a66f1109 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width