René's URL Explorer Experiment


Title: fix(settings): align the ee field rhythm with the canonical field by waleedlatif1 · Pull Request #7471 · simstudioai/sim · GitHub

Open Graph Title: fix(settings): align the ee field rhythm with the canonical field by waleedlatif1 · Pull Request #7471 · simstudioai/sim

X Title: fix(settings): align the ee field rhythm with the canonical field by waleedlatif1 · Pull Request #7471 · simstudioai/sim

Description: Summary Two settings inconsistencies found while auditing the credential-groups pages against the design-system rules. SettingRow now uses the canonical gap-[9px] between label and control, matching ChipModalField The credential group detail header no longer duplicates the group description that its own editable field shows Field rhythm .claude/rules/sim-styling.md pins the standalone labeled field to "flex flex-col gap-[9px], muted label, ChipInput/ChipTextarea control", which is what ChipModalField renders. SettingRow used gap-1.5 (6px), so every field on the ee/ settings pages sat 3px tighter than the same field inside a modal — visible against SettingsSection's own mt-[9px] divider rhythm on the same page. One class, 94 call sites across credential groups, SSO, data drains, access control, custom blocks, whitelabeling and verified domains. 85 of them are label → control (→ error), exactly ChipModalField's shape. The 9 that also pass a description keep it grouped between label and control, uniformly 9px on both sides rather than 6px. The label↔info-icon gap beside the label is a different measurement and is unchanged. Duplicated description The group detail passed description={credentialGroup?.description} to SettingsPanel, so the description rendered as the page subtitle while the same value sat in an editable ChipTextarea a few hundred pixels below. The two disagreed whenever the field was dirty — the header showed the persisted value, the field the draft — and the subtitle appeared only after the data loaded, shifting the body down. sim-settings-pages.md reserves title/description for a detail sub-view that needs a different heading, and says a page's header identity must stay stable while its data loads. Nothing is lost: the list row already renders the description as its subtitle and searches on it, and the Details tab still edits it. Considered and rejected An audit also flagged the three render-time throws in CredentialGroupAccess (workflows, allowedWorkflowIds, revision) for conversion to a SettingsEmptyState tone='error', on the grounds that the props are typed | null so the states are reachable. They are not reachable. Tracing the single caller against React Query 5.90.8: reaching those guards requires loadError falsy and isPending falsy, but isPending is access.isPending && !access.data, and RQ reports status: 'pending' whenever there is no data and no error — including a disabled query. Either access.data exists, in which case all three props are non-null, or the component has already returned. So they are invariant assertions, not error states, and they were left alone. Converting them would have removed the SettingsSectionError boundary's createLogger(...).error(...) report in exchange for a muted message — and on an access-control surface, "couldn't load workflow access" reads uncomfortably close to "no workflows have access." Type of Change Bug fix Testing Existing credential-groups, access-control and SSO suites pass — those are the surfaces the SettingRow change touches. Full suite, bun run check:audits, bunx turbo run type-check, bun run lint, bun run docs-manifest:check. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary Two settings inconsistencies found while auditing the credential-groups pages against the design-system rules. SettingRow now uses the canonical gap-[9px] between label and control, matchi...

X Description: Summary Two settings inconsistencies found while auditing the credential-groups pages against the design-system rules. SettingRow now uses the canonical gap-[9px] between label and control, matchi...

Opengraph URL: https://github.com/simstudioai/sim/pull/7471

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:2d540d41-e6dc-1691-5431-59e6a8fd95f7
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBDC8:267719:C377B1:10BFD9B:6AFB569C
html-safe-nonce6c3b938c960b87d04d259a1b0935d5d569e9af0774dea61c2a5539731547c637
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCREM4OjI2NzcxOTpDMzc3QjE6MTBCRkQ5Qjo2QUZCNTY5QyIsInZpc2l0b3JfaWQiOiI2OTc3OTEyMzMxMTMyNjg4MDI4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac9c11a58178b80baee1bcb49b3555799d1781ce35e64c7c1cd06cc353c307bdbb
hovercard-subject-tagpull_request:4438469394
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/7471/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary Two settings inconsistencies found while auditing the credential-groups pages against the design-system rules. SettingRow now uses the canonical gap-[9px] between label and control, matchi...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None7122bb414b542dba14d71a3f0b9f6fd2abce715b9f5912d082800563e6c806d1
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasecbf66c024bb6d10e6955baa7413c54cf13a201bb
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/7471/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F7471%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F7471%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/7471/files
Reloadhttps://github.com/simstudioai/sim/pull/7471/files
Reloadhttps://github.com/simstudioai/sim/pull/7471/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/settings-ui-consistencyhttps://github.com/simstudioai/sim/tree/fix/settings-ui-consistency
Conversation 8 https://github.com/simstudioai/sim/pull/7471
Commits 1 https://github.com/simstudioai/sim/pull/7471/commits
Checks 32 https://github.com/simstudioai/sim/pull/7471/checks
Files changed https://github.com/simstudioai/sim/pull/7471/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/7471/files
fix(settings): align the ee field rhythm with the canonical field https://github.com/simstudioai/sim/pull/7471/files#top
Show all changes 1 commit https://github.com/simstudioai/sim/pull/7471/files
5771c4f fix(settings): align the ee field rhythm with the canonical field waleedlatif1 Sep 4, 2026 https://github.com/simstudioai/sim/pull/7471/commits/5771c4fbb6b55e5f71bb439d08cacb8e21a2c275
Clear filters https://github.com/simstudioai/sim/pull/7471/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/7471/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/7471/files
setting-row.tsx https://github.com/simstudioai/sim/pull/7471/files#diff-5dee5be56995dd77d938cfd0955de2f49d6c02c1f328cbedb7733c3f7dbbca13
credential-group-detail.tsx https://github.com/simstudioai/sim/pull/7471/files#diff-d46b3bde8e13a2d31e21061956e93d02089d3d9124d8a6371d6a80dfd97aa591
apps/sim/ee/components/setting-row.tsxhttps://github.com/simstudioai/sim/pull/7471/files#diff-5dee5be56995dd77d938cfd0955de2f49d6c02c1f328cbedb7733c3f7dbbca13
View file https://github.com/simstudioai/sim/blob/5771c4fbb6b55e5f71bb439d08cacb8e21a2c275/apps/sim/ee/components/setting-row.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/7471/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/7471/files#diff-5dee5be56995dd77d938cfd0955de2f49d6c02c1f328cbedb7733c3f7dbbca13
https://github.com/simstudioai/sim/pull/7471/files#diff-5dee5be56995dd77d938cfd0955de2f49d6c02c1f328cbedb7733c3f7dbbca13
apps/sim/ee/credential-groups/components/credential-group-detail.tsxhttps://github.com/simstudioai/sim/pull/7471/files#diff-d46b3bde8e13a2d31e21061956e93d02089d3d9124d8a6371d6a80dfd97aa591
View file https://github.com/simstudioai/sim/blob/5771c4fbb6b55e5f71bb439d08cacb8e21a2c275/apps/sim/ee/credential-groups/components/credential-group-detail.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/7471/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/7471/files#diff-d46b3bde8e13a2d31e21061956e93d02089d3d9124d8a6371d6a80dfd97aa591
https://github.com/simstudioai/sim/pull/7471/files#diff-d46b3bde8e13a2d31e21061956e93d02089d3d9124d8a6371d6a80dfd97aa591
Please reload this pagehttps://github.com/simstudioai/sim/pull/7471/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.