Title: fix(settings): align the ee field rhythm with the canonical field by waleedlatif1 · Pull Request #7471 · simstudioai/sim · GitHub
Open Graph Title: fix(settings): align the ee field rhythm with the canonical field by waleedlatif1 · Pull Request #7471 · simstudioai/sim
X Title: fix(settings): align the ee field rhythm with the canonical field by waleedlatif1 · Pull Request #7471 · simstudioai/sim
Description: Summary Two settings inconsistencies found while auditing the credential-groups pages against the design-system rules. SettingRow now uses the canonical gap-[9px] between label and control, matching ChipModalField The credential group detail header no longer duplicates the group description that its own editable field shows Field rhythm .claude/rules/sim-styling.md pins the standalone labeled field to "flex flex-col gap-[9px], muted label, ChipInput/ChipTextarea control", which is what ChipModalField renders. SettingRow used gap-1.5 (6px), so every field on the ee/ settings pages sat 3px tighter than the same field inside a modal — visible against SettingsSection's own mt-[9px] divider rhythm on the same page. One class, 94 call sites across credential groups, SSO, data drains, access control, custom blocks, whitelabeling and verified domains. 85 of them are label → control (→ error), exactly ChipModalField's shape. The 9 that also pass a description keep it grouped between label and control, uniformly 9px on both sides rather than 6px. The label↔info-icon gap beside the label is a different measurement and is unchanged. Duplicated description The group detail passed description={credentialGroup?.description} to SettingsPanel, so the description rendered as the page subtitle while the same value sat in an editable ChipTextarea a few hundred pixels below. The two disagreed whenever the field was dirty — the header showed the persisted value, the field the draft — and the subtitle appeared only after the data loaded, shifting the body down. sim-settings-pages.md reserves title/description for a detail sub-view that needs a different heading, and says a page's header identity must stay stable while its data loads. Nothing is lost: the list row already renders the description as its subtitle and searches on it, and the Details tab still edits it. Considered and rejected An audit also flagged the three render-time throws in CredentialGroupAccess (workflows, allowedWorkflowIds, revision) for conversion to a SettingsEmptyState tone='error', on the grounds that the props are typed | null so the states are reachable. They are not reachable. Tracing the single caller against React Query 5.90.8: reaching those guards requires loadError falsy and isPending falsy, but isPending is access.isPending && !access.data, and RQ reports status: 'pending' whenever there is no data and no error — including a disabled query. Either access.data exists, in which case all three props are non-null, or the component has already returned. So they are invariant assertions, not error states, and they were left alone. Converting them would have removed the SettingsSectionError boundary's createLogger(...).error(...) report in exchange for a muted message — and on an access-control surface, "couldn't load workflow access" reads uncomfortably close to "no workflows have access." Type of Change Bug fix Testing Existing credential-groups, access-control and SSO suites pass — those are the surfaces the SettingRow change touches. Full suite, bun run check:audits, bunx turbo run type-check, bun run lint, bun run docs-manifest:check. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)
Open Graph Description: Summary Two settings inconsistencies found while auditing the credential-groups pages against the design-system rules. SettingRow now uses the canonical gap-[9px] between label and control, matchi...
X Description: Summary Two settings inconsistencies found while auditing the credential-groups pages against the design-system rules. SettingRow now uses the canonical gap-[9px] between label and control, matchi...
Opengraph URL: https://github.com/simstudioai/sim/pull/7471
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:2d540d41-e6dc-1691-5431-59e6a8fd95f7 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | BDC8:267719:C377B1:10BFD9B:6AFB569C |
| html-safe-nonce | 6c3b938c960b87d04d259a1b0935d5d569e9af0774dea61c2a5539731547c637 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCREM4OjI2NzcxOTpDMzc3QjE6MTBCRkQ5Qjo2QUZCNTY5QyIsInZpc2l0b3JfaWQiOiI2OTc3OTEyMzMxMTMyNjg4MDI4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 9c11a58178b80baee1bcb49b3555799d1781ce35e64c7c1cd06cc353c307bdbb |
| hovercard-subject-tag | pull_request:4438469394 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/7471/files |
| twitter:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| og:image:alt | Summary Two settings inconsistencies found while auditing the credential-groups pages against the design-system rules. SettingRow now uses the canonical gap-[9px] between label and control, matchi... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 7122bb414b542dba14d71a3f0b9f6fd2abce715b9f5912d082800563e6c806d1 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/simstudioai/sim git https://github.com/simstudioai/sim.git |
| octolytics-dimension-user_id | 199344406 |
| octolytics-dimension-user_login | simstudioai |
| octolytics-dimension-repository_id | 912559512 |
| octolytics-dimension-repository_nwo | simstudioai/sim |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 912559512 |
| octolytics-dimension-repository_network_root_nwo | simstudioai/sim |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | cbf66c024bb6d10e6955baa7413c54cf13a201bb |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width