René's URL Explorer Experiment


Title: fix(emcn): keep the segmented control hugging its segments by waleedlatif1 · Pull Request #7470 · simstudioai/sim · GitHub

Open Graph Title: fix(emcn): keep the segmented control hugging its segments by waleedlatif1 · Pull Request #7470 · simstudioai/sim

X Title: fix(emcn): keep the segmented control hugging its segments by waleedlatif1 · Pull Request #7470 · simstudioai/sim

Description: Summary The segmented control now always hugs its segments, instead of stretching edge to edge wherever it sits in a flex column Credential groups: dropped (optional) from the Description label, restored search on the People tab, and switched the People rows to the same member avatar the Teammates and Organization rosters use The segmented control ChipSwitch was inline-flex, which does not survive a flex column — align-items: stretch blockifies the trough and pulls it edge to edge. ChipModalTabs had already hit this and pinned w-fit on its own copy, so tabbed modals looked right while every other caller did not. The fix moves w-fit onto ChipSwitch and deletes the workaround from ChipModalTabs, so one component owns the rule. A caller-supplied width still wins through cn, which a test pins. This is safe at every call site for a reason worth stating: the segments carry no flex-1, so a stretched trough rendered its buttons clustered left against empty fill. A full-width segmented control was never achievable — a stretched trough was always a defect, never a layout a caller could have wanted. Of the nine call sites, five were stretching (retention PII stages, SSO, both fork-sync switches, the upgrade comparison table, the docs block inspector) and now hug; four were already in centered or justify-between rows and are untouched. Credential groups (optional) removed from the Description label on the group detail. The optional prop stays — SSO still uses it in ten places. People tab search — the panel's search box was wired for the Details tab only, so switching to People left no way to filter. It now takes a credential-group-people param alongside the existing provider filter, reset on the same open/close transitions so a term never follows the user into the next group. People row avatar — was a generic User glyph in a 36px tile; now MemberAvatar, the same component member-list and the access-control group detail use, through iconVariant='custom' so the row keeps the gap-2.5 those rosters pair it with. The enrollment list is cursor-paginated with no server-side search term, so the filter applies to loaded pages only. The section label reports that honestly — People (2 of 40+) while filtering, so the + keeps meaning "more people exist" rather than "more matches exist" — and Load more stays reachable when a filter matches nothing. Also fixed, from a design-system audit of these pages Two ChipConfirmModals on the group detail had defaultAction='confirm'. One of them says its own action revokes existing OAuth grants, so a stray Enter committed an irreversible change. Both now fail safe on dismiss, per the emcn rule. The Access section's Add workflow chip was variant='primary' while the header already renders the primary Save chip. Type of Change Bug fix Testing New chip-switch.test.tsx: pins w-fit, that a caller width class evicts it, and the active-segment state. Verified it fails without the fix. Full suite, bun run check:audits, bunx turbo run type-check, bun run lint, bun run docs-manifest:check. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary The segmented control now always hugs its segments, instead of stretching edge to edge wherever it sits in a flex column Credential groups: dropped (optional) from the Description label, r...

X Description: Summary The segmented control now always hugs its segments, instead of stretching edge to edge wherever it sits in a flex column Credential groups: dropped (optional) from the Description label, r...

Opengraph URL: https://github.com/simstudioai/sim/pull/7470

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:e5269502-94c7-6c37-6437-0a2abcfaecbb
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC54A:15DF38:B217DE:F2F389:6AFB50D7
html-safe-nonce8d764aab8fe0a7922c3e8d8c9e2e2748bf77118cab4196391cd63ef0ad933b96
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNTRBOjE1REYzODpCMjE3REU6RjJGMzg5OjZBRkI1MEQ3IiwidmlzaXRvcl9pZCI6IjQxODkyNjk4ODM1MTIxMTU0MTUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacb7f187d835e9ba02207cf98818367b9bd8155db9ed07da73651426f44a1a71eb
hovercard-subject-tagpull_request:4438393871
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/7470/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary The segmented control now always hugs its segments, instead of stretching edge to edge wherever it sits in a flex column Credential groups: dropped (optional) from the Description label, r...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None7122bb414b542dba14d71a3f0b9f6fd2abce715b9f5912d082800563e6c806d1
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasecbf66c024bb6d10e6955baa7413c54cf13a201bb
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/7470/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F7470%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F7470%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/7470/files
Reloadhttps://github.com/simstudioai/sim/pull/7470/files
Reloadhttps://github.com/simstudioai/sim/pull/7470/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/segmented-control-and-people-tabhttps://github.com/simstudioai/sim/tree/fix/segmented-control-and-people-tab
Conversation 5 https://github.com/simstudioai/sim/pull/7470
Commits 1 https://github.com/simstudioai/sim/pull/7470/commits
Checks 31 https://github.com/simstudioai/sim/pull/7470/checks
Files changed https://github.com/simstudioai/sim/pull/7470/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/7470/files
fix(emcn): keep the segmented control hugging its segments https://github.com/simstudioai/sim/pull/7470/files#top
Show all changes 1 commit https://github.com/simstudioai/sim/pull/7470/files
4cc9256 fix(emcn): keep the segmented control hugging its segments waleedlatif1 Sep 4, 2026 https://github.com/simstudioai/sim/pull/7470/commits/4cc9256c19d8513560b8c309f2927668645bad4d
Clear filters https://github.com/simstudioai/sim/pull/7470/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/7470/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/7470/files
search-params.ts https://github.com/simstudioai/sim/pull/7470/files#diff-8d429d954672f4c54dc0e810fe8ddb535924dfe6cc6b12926580c7b0808fe037
credential-group-access.tsx https://github.com/simstudioai/sim/pull/7470/files#diff-3034981f2ff3f6891f854c2722c65d88816260e600b0d1c50f53d5d451073d28
credential-group-detail.tsx https://github.com/simstudioai/sim/pull/7470/files#diff-d46b3bde8e13a2d31e21061956e93d02089d3d9124d8a6371d6a80dfd97aa591
credential-group-details.tsx https://github.com/simstudioai/sim/pull/7470/files#diff-334c44b93af8a8b90d6c849d50c8656941ffbe7ccf29b897ac3f4f2881127154
credential-groups-settings.tsx https://github.com/simstudioai/sim/pull/7470/files#diff-de3ea946985c1a562ec99e498ea457ea6802e08a41cdba3314a5add4f56a818c
chip-modal.tsx https://github.com/simstudioai/sim/pull/7470/files#diff-5a9b4f39d866e7b9c8f3be78802e723f27cc7f87c964fbe55e19d16a69b91f54
chip-switch.test.tsx https://github.com/simstudioai/sim/pull/7470/files#diff-6c8da1a0ad042ff04609abfe3e7ae1a36ab6f7baf6a3e1a9520287abf55ebdd1
chip-switch.tsx https://github.com/simstudioai/sim/pull/7470/files#diff-558c4ceea450376debe4e49583ccca23e7e8da38140dbb2904e4ea62db9659fd
apps/sim/app/workspace/[workspaceId]/settings/[section]/search-params.tshttps://github.com/simstudioai/sim/pull/7470/files#diff-8d429d954672f4c54dc0e810fe8ddb535924dfe6cc6b12926580c7b0808fe037
View file https://github.com/simstudioai/sim/blob/4cc9256c19d8513560b8c309f2927668645bad4d/apps/sim/app/workspace/%5BworkspaceId%5D/settings/%5Bsection%5D/search-params.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/7470/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/7470/files#diff-8d429d954672f4c54dc0e810fe8ddb535924dfe6cc6b12926580c7b0808fe037
https://github.com/simstudioai/sim/pull/7470/files#diff-8d429d954672f4c54dc0e810fe8ddb535924dfe6cc6b12926580c7b0808fe037
apps/sim/ee/credential-groups/components/credential-group-access.tsxhttps://github.com/simstudioai/sim/pull/7470/files#diff-3034981f2ff3f6891f854c2722c65d88816260e600b0d1c50f53d5d451073d28
View file https://github.com/simstudioai/sim/blob/4cc9256c19d8513560b8c309f2927668645bad4d/apps/sim/ee/credential-groups/components/credential-group-access.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/7470/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/7470/files#diff-3034981f2ff3f6891f854c2722c65d88816260e600b0d1c50f53d5d451073d28
https://github.com/simstudioai/sim/pull/7470/files#diff-3034981f2ff3f6891f854c2722c65d88816260e600b0d1c50f53d5d451073d28
apps/sim/ee/credential-groups/components/credential-group-detail.tsxhttps://github.com/simstudioai/sim/pull/7470/files#diff-d46b3bde8e13a2d31e21061956e93d02089d3d9124d8a6371d6a80dfd97aa591
View file https://github.com/simstudioai/sim/blob/4cc9256c19d8513560b8c309f2927668645bad4d/apps/sim/ee/credential-groups/components/credential-group-detail.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/7470/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/7470/files#diff-d46b3bde8e13a2d31e21061956e93d02089d3d9124d8a6371d6a80dfd97aa591
https://github.com/simstudioai/sim/pull/7470/files#diff-d46b3bde8e13a2d31e21061956e93d02089d3d9124d8a6371d6a80dfd97aa591
https://github.com/simstudioai/sim/pull/7470/files#diff-d46b3bde8e13a2d31e21061956e93d02089d3d9124d8a6371d6a80dfd97aa591
https://github.com/simstudioai/sim/pull/7470/files#diff-d46b3bde8e13a2d31e21061956e93d02089d3d9124d8a6371d6a80dfd97aa591
https://github.com/simstudioai/sim/pull/7470/files#diff-d46b3bde8e13a2d31e21061956e93d02089d3d9124d8a6371d6a80dfd97aa591
https://github.com/simstudioai/sim/pull/7470/files#diff-d46b3bde8e13a2d31e21061956e93d02089d3d9124d8a6371d6a80dfd97aa591
https://github.com/simstudioai/sim/pull/7470/files#diff-d46b3bde8e13a2d31e21061956e93d02089d3d9124d8a6371d6a80dfd97aa591
https://github.com/simstudioai/sim/pull/7470/files#diff-d46b3bde8e13a2d31e21061956e93d02089d3d9124d8a6371d6a80dfd97aa591
https://github.com/simstudioai/sim/pull/7470/files#diff-d46b3bde8e13a2d31e21061956e93d02089d3d9124d8a6371d6a80dfd97aa591
https://github.com/simstudioai/sim/pull/7470/files#diff-d46b3bde8e13a2d31e21061956e93d02089d3d9124d8a6371d6a80dfd97aa591
apps/sim/ee/credential-groups/components/credential-group-details.tsxhttps://github.com/simstudioai/sim/pull/7470/files#diff-334c44b93af8a8b90d6c849d50c8656941ffbe7ccf29b897ac3f4f2881127154
View file https://github.com/simstudioai/sim/blob/4cc9256c19d8513560b8c309f2927668645bad4d/apps/sim/ee/credential-groups/components/credential-group-details.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/7470/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/7470/files#diff-334c44b93af8a8b90d6c849d50c8656941ffbe7ccf29b897ac3f4f2881127154
https://github.com/simstudioai/sim/pull/7470/files#diff-334c44b93af8a8b90d6c849d50c8656941ffbe7ccf29b897ac3f4f2881127154
https://github.com/simstudioai/sim/pull/7470/files#diff-334c44b93af8a8b90d6c849d50c8656941ffbe7ccf29b897ac3f4f2881127154
https://github.com/simstudioai/sim/pull/7470/files#diff-334c44b93af8a8b90d6c849d50c8656941ffbe7ccf29b897ac3f4f2881127154
https://github.com/simstudioai/sim/pull/7470/files#diff-334c44b93af8a8b90d6c849d50c8656941ffbe7ccf29b897ac3f4f2881127154
apps/sim/ee/credential-groups/components/credential-groups-settings.tsxhttps://github.com/simstudioai/sim/pull/7470/files#diff-de3ea946985c1a562ec99e498ea457ea6802e08a41cdba3314a5add4f56a818c
View file https://github.com/simstudioai/sim/blob/4cc9256c19d8513560b8c309f2927668645bad4d/apps/sim/ee/credential-groups/components/credential-groups-settings.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/7470/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/7470/files#diff-de3ea946985c1a562ec99e498ea457ea6802e08a41cdba3314a5add4f56a818c
https://github.com/simstudioai/sim/pull/7470/files#diff-de3ea946985c1a562ec99e498ea457ea6802e08a41cdba3314a5add4f56a818c
https://github.com/simstudioai/sim/pull/7470/files#diff-de3ea946985c1a562ec99e498ea457ea6802e08a41cdba3314a5add4f56a818c
https://github.com/simstudioai/sim/pull/7470/files#diff-de3ea946985c1a562ec99e498ea457ea6802e08a41cdba3314a5add4f56a818c
packages/emcn/src/components/chip-modal/chip-modal.tsxhttps://github.com/simstudioai/sim/pull/7470/files#diff-5a9b4f39d866e7b9c8f3be78802e723f27cc7f87c964fbe55e19d16a69b91f54
View file https://github.com/simstudioai/sim/blob/4cc9256c19d8513560b8c309f2927668645bad4d/packages/emcn/src/components/chip-modal/chip-modal.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/7470/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/7470/files#diff-5a9b4f39d866e7b9c8f3be78802e723f27cc7f87c964fbe55e19d16a69b91f54
https://github.com/simstudioai/sim/pull/7470/files#diff-5a9b4f39d866e7b9c8f3be78802e723f27cc7f87c964fbe55e19d16a69b91f54
https://github.com/simstudioai/sim/pull/7470/files#diff-5a9b4f39d866e7b9c8f3be78802e723f27cc7f87c964fbe55e19d16a69b91f54
packages/emcn/src/components/chip-switch/chip-switch.test.tsxhttps://github.com/simstudioai/sim/pull/7470/files#diff-6c8da1a0ad042ff04609abfe3e7ae1a36ab6f7baf6a3e1a9520287abf55ebdd1
View file https://github.com/simstudioai/sim/blob/4cc9256c19d8513560b8c309f2927668645bad4d/packages/emcn/src/components/chip-switch/chip-switch.test.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/7470/{{ revealButtonHref }}
packages/emcn/src/components/chip-switch/chip-switch.tsxhttps://github.com/simstudioai/sim/pull/7470/files#diff-558c4ceea450376debe4e49583ccca23e7e8da38140dbb2904e4ea62db9659fd
View file https://github.com/simstudioai/sim/blob/4cc9256c19d8513560b8c309f2927668645bad4d/packages/emcn/src/components/chip-switch/chip-switch.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/7470/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/7470/files#diff-558c4ceea450376debe4e49583ccca23e7e8da38140dbb2904e4ea62db9659fd
https://github.com/simstudioai/sim/pull/7470/files#diff-558c4ceea450376debe4e49583ccca23e7e8da38140dbb2904e4ea62db9659fd
https://github.com/simstudioai/sim/pull/7470/files#diff-558c4ceea450376debe4e49583ccca23e7e8da38140dbb2904e4ea62db9659fd
Please reload this pagehttps://github.com/simstudioai/sim/pull/7470/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.