Title: fix(modal): restore floating control dismissal by waleedlatif1 · Pull Request #7467 · simstudioai/sim · GitHub
Open Graph Title: fix(modal): restore floating control dismissal by waleedlatif1 · Pull Request #7467 · simstudioai/sim
X Title: fix(modal): restore floating control dismissal by waleedlatif1 · Pull Request #7467 · simstudioai/sim
Description: Summary Restore modal dropdown dismissal by letting pointer events reach Radix's outside-interaction handlers. Align the shared dismissable-layer dependency with the installed dialog, popover, and menu primitives so Escape, pointer locks, and portaled submenu branches use one stack. Keep existing modal dropdown semantics: an outside click dismisses the open dropdown before another control can open. No styling, portal placement, or connector-specific state changes. Type of Change Bug fix Testing 197 EMCN tests passed, including 12 new interaction regressions. Restoring the old pointer handlers fails five of the new cases. Full repository test rerun passed, including 40,917 app tests and 1,471 desktop tests. An unchanged asynchronous desktop-download test failed on the initial run, then passed both isolated and in the full rerun; no unrelated code was changed. Browser-tested real EMCN components in an isolated harness: sibling dismissal, search, pointer and keyboard selection, wheel/scrollbar interaction, and layered Escape dismissal. Modal dropdowns consume the first outside click; this does not restore the historical non-modal one-click switching behavior. Cleanup, changed-file React Doctor, lint, repository type checks, all CI audits (including API validation), block-registry validation, and docs-manifest verification passed. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)
Open Graph Description: Summary Restore modal dropdown dismissal by letting pointer events reach Radix's outside-interaction handlers. Align the shared dismissable-layer dependency with the installed dialog, popover,...
X Description: Summary Restore modal dropdown dismissal by letting pointer events reach Radix's outside-interaction handlers. Align the shared dismissable-layer dependency with the installed dialog, popo...
Opengraph URL: https://github.com/simstudioai/sim/pull/7467
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:8416d00f-bb65-4c0b-b0b2-ac8a702e4e84 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | A7BA:243AE6:71F868:A1CBD1:6AFB4929 |
| html-safe-nonce | 0e2e50d30a322d084e405df92bf1a259d02d5269d44bafc018520adc4c1d7eaf |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBN0JBOjI0M0FFNjo3MUY4Njg6QTFDQkQxOjZBRkI0OTI5IiwidmlzaXRvcl9pZCI6IjU3NTgwODI4NTk2MjExMDgwMDkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 4cce277e15ff62ed326ca0f594a52b678cfcd1778fd513ead2c4f588f96be06b |
| hovercard-subject-tag | pull_request:4438171118 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/7467/files |
| twitter:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| og:image:alt | Summary Restore modal dropdown dismissal by letting pointer events reach Radix's outside-interaction handlers. Align the shared dismissable-layer dependency with the installed dialog, popover,... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | acf7616d06cc051644705b379878c9bb13dc5e70ecf4ffd9b34140f8ac01d7e1 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/simstudioai/sim git https://github.com/simstudioai/sim.git |
| octolytics-dimension-user_id | 199344406 |
| octolytics-dimension-user_login | simstudioai |
| octolytics-dimension-repository_id | 912559512 |
| octolytics-dimension-repository_nwo | simstudioai/sim |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 912559512 |
| octolytics-dimension-repository_network_root_nwo | simstudioai/sim |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 26504db649b58525278f77a52b80ba5f10d5f4de |
| ui-target | canary-1 |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width