René's URL Explorer Experiment


Title: fix(modal): restore floating control dismissal by waleedlatif1 · Pull Request #7467 · simstudioai/sim · GitHub

Open Graph Title: fix(modal): restore floating control dismissal by waleedlatif1 · Pull Request #7467 · simstudioai/sim

X Title: fix(modal): restore floating control dismissal by waleedlatif1 · Pull Request #7467 · simstudioai/sim

Description: Summary Restore modal dropdown dismissal by letting pointer events reach Radix's outside-interaction handlers. Align the shared dismissable-layer dependency with the installed dialog, popover, and menu primitives so Escape, pointer locks, and portaled submenu branches use one stack. Keep existing modal dropdown semantics: an outside click dismisses the open dropdown before another control can open. No styling, portal placement, or connector-specific state changes. Type of Change Bug fix Testing 197 EMCN tests passed, including 12 new interaction regressions. Restoring the old pointer handlers fails five of the new cases. Full repository test rerun passed, including 40,917 app tests and 1,471 desktop tests. An unchanged asynchronous desktop-download test failed on the initial run, then passed both isolated and in the full rerun; no unrelated code was changed. Browser-tested real EMCN components in an isolated harness: sibling dismissal, search, pointer and keyboard selection, wheel/scrollbar interaction, and layered Escape dismissal. Modal dropdowns consume the first outside click; this does not restore the historical non-modal one-click switching behavior. Cleanup, changed-file React Doctor, lint, repository type checks, all CI audits (including API validation), block-registry validation, and docs-manifest verification passed. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary Restore modal dropdown dismissal by letting pointer events reach Radix's outside-interaction handlers. Align the shared dismissable-layer dependency with the installed dialog, popover,...

X Description: Summary Restore modal dropdown dismissal by letting pointer events reach Radix's outside-interaction handlers. Align the shared dismissable-layer dependency with the installed dialog, popo...

Opengraph URL: https://github.com/simstudioai/sim/pull/7467

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:8416d00f-bb65-4c0b-b0b2-ac8a702e4e84
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA7BA:243AE6:71F868:A1CBD1:6AFB4929
html-safe-nonce0e2e50d30a322d084e405df92bf1a259d02d5269d44bafc018520adc4c1d7eaf
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBN0JBOjI0M0FFNjo3MUY4Njg6QTFDQkQxOjZBRkI0OTI5IiwidmlzaXRvcl9pZCI6IjU3NTgwODI4NTk2MjExMDgwMDkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac4cce277e15ff62ed326ca0f594a52b678cfcd1778fd513ead2c4f588f96be06b
hovercard-subject-tagpull_request:4438171118
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/7467/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary Restore modal dropdown dismissal by letting pointer events reach Radix's outside-interaction handlers. Align the shared dismissable-layer dependency with the installed dialog, popover,...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneacf7616d06cc051644705b379878c9bb13dc5e70ecf4ffd9b34140f8ac01d7e1
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release26504db649b58525278f77a52b80ba5f10d5f4de
ui-targetcanary-1
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/7467/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F7467%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F7467%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/7467/files
Reloadhttps://github.com/simstudioai/sim/pull/7467/files
Reloadhttps://github.com/simstudioai/sim/pull/7467/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests199 (199)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
codex/fix-modal-dropdown-dismissalhttps://github.com/simstudioai/sim/tree/codex/fix-modal-dropdown-dismissal
Conversation 8 https://github.com/simstudioai/sim/pull/7467
Commits 1 https://github.com/simstudioai/sim/pull/7467/commits
Checks 35 https://github.com/simstudioai/sim/pull/7467/checks
Files changed https://github.com/simstudioai/sim/pull/7467/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/7467/files
fix(modal): restore floating control dismissal https://github.com/simstudioai/sim/pull/7467/files#top
Show all changes 1 commit https://github.com/simstudioai/sim/pull/7467/files
94939af fix(modal): restore floating control dismissal waleedlatif1 Sep 4, 2026 https://github.com/simstudioai/sim/pull/7467/commits/94939af27cdb2c36f33714abc33826b86bb80b62
Clear filters https://github.com/simstudioai/sim/pull/7467/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/7467/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/7467/files
bun.lock https://github.com/simstudioai/sim/pull/7467/files#diff-bfd0ef82a01108fa1e836c2500b98b7de8a92bb1ae352a8efcbd9d6ffcaabd60
package.json https://github.com/simstudioai/sim/pull/7467/files#diff-aab9627c3522cdfebb37f75ec72077cf17eb21a9043825f00123d317bf81d73d
modal-interactions.test.tsx https://github.com/simstudioai/sim/pull/7467/files#diff-7dacbe10731bbdf9090c21458776a9b9bab0d209d51fa8208e6a392e4664a0fa
modal.tsx https://github.com/simstudioai/sim/pull/7467/files#diff-51423e0d7e1b79a1155de6b0ea446557ff5b5d08285cd4cce2b2c79db878165d
Please reload this pagehttps://github.com/simstudioai/sim/pull/7467/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/7467/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.