Title: fix: address review findings from the v0.8.21 release PR by waleedlatif1 · Pull Request #7454 · simstudioai/sim · GitHub
Open Graph Title: fix: address review findings from the v0.8.21 release PR by waleedlatif1 · Pull Request #7454 · simstudioai/sim
X Title: fix: address review findings from the v0.8.21 release PR by waleedlatif1 · Pull Request #7454 · simstudioai/sim
Description: Summary Findings from the review on the v0.8.21 release PR (#7446) that held up when I checked them against the code. Each was verified before fixing — the ones that did not hold up are listed at the bottom rather than silently patched. member-connectors used a concealing error policy on a workspace-scoped route. The route's mapInput forwards only workspaceId and never names a knowledge base, but it used internalKnowledgeErrorPolicies.connectors, which is wrapped in concealKnowledgeBase(...). A caller without workspace access got 404 Knowledge base not found for a resource they never asked about. route-policies.ts already documents this exact rule for list/bulkMove/bulkDelete; this adds the matching workspace-scoped policy. Restoring a queued Build message was undone. The effect at home.tsx:193 forces the composer into Search whenever the query is non-empty and the mode is build. restoreQueuedMode set build without clearing the query, so the mode flipped straight back and the edit was stranded. It now clears through the existing guarded clearSearch helper (hoisted above its new caller), which also avoids a redundant URL write when no search is open. The self-hosting Redis page overstated durability. It said completed work is unaffected by losing the instance. High-volume webhook triggers claim idempotency keys in Redis by default — the service's own docs call this a "narrow durability window" — so a restart can let a provider's retry re-run a finished webhook. Documented, with a pointer to forceStorage: 'database'. Two further findings this branch originally carried — the missing docs-manifest:generate in /ship Phase A, and the missing Yarn tab in the CLI upgrade docs — landed independently as #7450 and #7448 while this was in review. Both are resolved in favour of those, so they no longer appear in this diff. Type of Change Bug fix Testing Added two contract tests on the error policies: the knowledge-base-scoped connector policy still conceals, and the workspace-scoped member-connector policy does not. Verified the second fails against the concealing policy and passes with the fix. bun run lint, bun run check:audits (45 audits), docs-manifest:check, and type-check (0 errors) all pass on the merged tree, along with 174 tests across the touched areas. Ran /simplify and /cleanup over the diff — findings from both applied. Not changed, and why Three findings did not hold up and are deliberately left alone: The chat-sanitize.ts backtick scan is a trade-off the file documents explicitly, and the suggested JSON-aware boundary is what the current constraint deliberately replaced for a stated cost reason. The custom-blocks.mdx FAQ addresses publishers, not consumers — "you" is already correct and consistent with the rest of the page. The v1 document-delete race is inherent check-then-act, and the change it flags added ACL scoping where there was none. One further finding is real but out of scope here: the connector Access field bails for Slack because Slack declares permissionScopedListing yet resolves through the standard-OAuth credential-group path it is not part of. Fixing it means changing which resolver that field uses while preserving Slack's custom-bot validation, which belongs with the Slack per-member work rather than in this PR. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA) 🤖 Generated with Claude Code https://claude.ai/code/session_013e5sXbYST2R4qNzM996GFg
Open Graph Description: Summary Findings from the review on the v0.8.21 release PR (#7446) that held up when I checked them against the code. Each was verified before fixing — the ones that did not hold up are listed at t...
X Description: Summary Findings from the review on the v0.8.21 release PR (#7446) that held up when I checked them against the code. Each was verified before fixing — the ones that did not hold up are listed at t...
Opengraph URL: https://github.com/simstudioai/sim/pull/7454
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:daada921-1693-8284-eb5c-addb015f99c2 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | C4DE:11532:69DD1E:967D36:6AFB46BD |
| html-safe-nonce | c3062cd55f261d89e113f3b19b6cba2a44f9a761eb942d67facf12c3bd7ca38e |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNERFOjExNTMyOjY5REQxRTo5NjdEMzY6NkFGQjQ2QkQiLCJ2aXNpdG9yX2lkIjoiMTA3MDk3OTY2NzkwMjI4NTUwMiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | e38eeea9479e41d12386647b0adcf6714b99ed5511a1b93ac1f9a4052abd1d7d |
| hovercard-subject-tag | pull_request:4436987472 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/7454/files |
| twitter:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| og:image:alt | Summary Findings from the review on the v0.8.21 release PR (#7446) that held up when I checked them against the code. Each was verified before fixing — the ones that did not hold up are listed at t... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | acf7616d06cc051644705b379878c9bb13dc5e70ecf4ffd9b34140f8ac01d7e1 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/simstudioai/sim git https://github.com/simstudioai/sim.git |
| octolytics-dimension-user_id | 199344406 |
| octolytics-dimension-user_login | simstudioai |
| octolytics-dimension-repository_id | 912559512 |
| octolytics-dimension-repository_nwo | simstudioai/sim |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 912559512 |
| octolytics-dimension-repository_network_root_nwo | simstudioai/sim |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 26504db649b58525278f77a52b80ba5f10d5f4de |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width