Title: fix(desktop): manage signing keychain explicitly by waleedlatif1 · Pull Request #7411 · simstudioai/sim · GitHub
Open Graph Title: fix(desktop): manage signing keychain explicitly by waleedlatif1 · Pull Request #7411 · simstudioai/sim
X Title: fix(desktop): manage signing keychain explicitly by waleedlatif1 · Pull Request #7411 · simstudioai/sim
Description: Summary import the Developer ID certificate into an explicit temporary macOS keychain keep the certificate password separate from the generated keychain password, avoiding the electron-builder 26.15.3 set-key-partition-list regression pass only CSC_KEYCHAIN to electron-builder, validate the signing identity before packaging, and always remove temporary signing credentials Type of Change Bug fix Testing signed, non-publishing Desktop Release run: certificate import, universal packaging, Developer ID signing, notarization, credential cleanup, artifact validation, and packaged smoke tests passed exercised certificate import and set-key-partition-list against a disposable .p12 and temporary keychain on macOS actionlint with shellcheck and YAML parsing 1,455 desktop tests monorepo type-check, lint, 45 audits, desktop bridge/IPC checks, block registry validation, and native-binary checksum verification Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)
Open Graph Description: Summary import the Developer ID certificate into an explicit temporary macOS keychain keep the certificate password separate from the generated keychain password, avoiding the electron-builder 26....
X Description: Summary import the Developer ID certificate into an explicit temporary macOS keychain keep the certificate password separate from the generated keychain password, avoiding the electron-builder 26....
Opengraph URL: https://github.com/simstudioai/sim/pull/7411
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:238c2091-cdc0-4c41-f997-967476cfa62f |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | A492:B85F4:6573E3:8C0112:6AFB3F71 |
| html-safe-nonce | 8aa4f34f042153ef15fa32188d56bdd98b4b7df9634f6e579fadccdd1f7ca69b |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNDkyOkI4NUY0OjY1NzNFMzo4QzAxMTI6NkFGQjNGNzEiLCJ2aXNpdG9yX2lkIjoiNTQ4ODk0MTU1NTgxMDc3ODk5MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 83a98296c769fec47637e786aa49c322a4d01b846bb7fb7318c320d08db38465 |
| hovercard-subject-tag | pull_request:4426376853 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/7411/files |
| twitter:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| og:image:alt | Summary import the Developer ID certificate into an explicit temporary macOS keychain keep the certificate password separate from the generated keychain password, avoiding the electron-builder 26.... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 2169b0dfbef67ed6b128074a5ed45bb7d5d1859783b10178b09a7765ad5f3693 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/simstudioai/sim git https://github.com/simstudioai/sim.git |
| octolytics-dimension-user_id | 199344406 |
| octolytics-dimension-user_login | simstudioai |
| octolytics-dimension-repository_id | 912559512 |
| octolytics-dimension-repository_nwo | simstudioai/sim |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 912559512 |
| octolytics-dimension-repository_network_root_nwo | simstudioai/sim |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 3b4fc8df5ef1c6757e733a23e6b81b6725021823 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width