René's URL Explorer Experiment


Title: fix(github): make branch protection usable and wire workflow_id to its endpoint by waleedlatif1 · Pull Request #7308 · simstudioai/sim · GitHub

Open Graph Title: fix(github): make branch protection usable and wire workflow_id to its endpoint by waleedlatif1 · Pull Request #7308 · simstudioai/sim

X Title: fix(github): make branch protection usable and wire workflow_id to its endpoint by waleedlatif1 · Pull Request #7308 · simstudioai/sim

Description: Summary Two verified GitHub defects: an operation that could never run, and a UI field wired to nothing. github_update_branch_protection was unusable PUT /repos/{owner}/{repo}/branches/{branch}/protection documents four body fields as required but nullable — required_status_checks, enforce_admins, required_pull_request_reviews, restrictions, each "Set to null to disable." GitHub's "required" means present in the body, satisfiable by null. Sim's required: true means the user must supply a non-empty value — validateRequiredParametersAfterMerge rejects null, undefined and '' outright, so Sim could not express GitHub's disable case at all. Combined with restrictions having no subBlock anywhere in the block, every call threw Restrictions is required for GitHub Update Branch Protection before reaching the network. All four params → required: false request.body now emits an explicit null for each unset field instead of dropping the key, preserving GitHub's "present but null = disable" contract The body also normalizes the editor's JSON strings to objects and the dropdown's 'true'/'false' to booleans, fixing the type mismatches without touching tools.config.tool New restrictions subBlock, so the operation finally has full param coverage workflow_id rendered but did nothing The block showed a workflow_id field for github_list_workflow_runs, but the tool declared no such param and always hit the repo-wide /actions/runs. GET /repos/{owner}/{repo}/actions/workflows/{workflow_id}/runs exists, takes the identical query set, and returns the identical response schema — so this wires the field rather than deleting a working affordance. The segment is encodeURIComponent-escaped. Design notes Normalization lives in the tool's request.body, not in GITHUB_PARAM_ALIASES. Nothing here needs renaming, and the tool body covers the agent tool-calling path identically while carrying zero cross-operation clobber risk — the alias mapper is scoped by operation precisely because advanced fields serialize without their condition being evaluated. The three pre-existing subBlocks stay mode: 'advanced'. With required: false that is now correct — they are genuinely optional — and flipping them would have changed visibility. updateBranchProtectionV2Tool shares params and request by reference and inherits both fixes; a test asserts it. Backwards compatibility subBlock ids: nothing renamed or removed; one added (restrictions). Subblock-ID stability check passes. required: only ever loosened (true → false), never tightened — no saved workflow can newly fail validation. visibility and mode: unchanged on every existing param. The only behavior change is that an operation which always threw now runs, and a field that was discarded now takes effect. Testing apps/sim/tools/github/branch_protection_and_workflow_runs.test.ts — 41 tests; 151 pass across blocks/blocks/github and tools/github. Verified red-first per guard, reverting each individually: Guard Red required: false on the four params 5 explicit-null body emission 5 JSON-string parsing 2 boolean coercion 1 restrictions subBlock 1 json input types 1 workflow_id param 2 URL endpoint branch 4 encodeURIComponent 1 alias operation scoping 2 alias presence guard 6 parse-error message hardening 3 Two of those tests initially passed with their guard deleted and were rewritten. The presence-guard test used toEqual, which treats an undefined-valued key as absent — so {title: 'v1.0', description: undefined} compared equal to {title: 'v1.0'}. It now asserts on Object.keys, which is the distinction that actually matters when the provider spreads the transform over a model's tool-call arguments. The scoping test used real param names instead of alias source names and was rewritten to use milestone_title / gist_public / fork_name. Includes coverage that a stale advanced value from another operation cannot leak into anything wired here. bun run lint, type-check, check:audits (39 audits), tool-metadata:check, docs:check, integration-catalog:check, deployment-config:check and check-block-registry.ts origin/staging all pass. Regenerated artifacts committed. Deferred: github_check_star Confirmed dead and deliberately left alone. GitHub answers 204 for starred and 404 for not-starred; the shared executor throws on !response.ok before transformResponse runs, so starred: false is unreachable and the ordinary negative answer surfaces as a failure. Three options exist — convert to an internal operation (isolated, but leaves the shared retry/DNS-pinning/size-limit machinery for one trivial GET), add an opt-in like expectedErrorStatuses on ToolConfig.request (generalizes, but sits on the hot path for every tool), or have callers read the status the thrown error already carries. Worth noting for that decision: 13 GitHub tools use the status === 204 pattern, but 12 are mutations where any non-204 genuinely is an error — their false branch is harmless dead code, not a defect. check_star is the only GitHub tool where the non-2xx status carries meaning; the comparable live cases elsewhere are elasticsearch/get_document.ts and delete_document.ts. That makes it a three-tool problem rather than a ten-tool one, which argues against paying for the shared-executor change. Type of Change Bug fix Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary Two verified GitHub defects: an operation that could never run, and a UI field wired to nothing. github_update_branch_protection was unusable PUT /repos/{owner}/{repo}/branches/{branch}/pro...

X Description: Summary Two verified GitHub defects: an operation that could never run, and a UI field wired to nothing. github_update_branch_protection was unusable PUT /repos/{owner}/{repo}/branches/{branch}/pro...

Opengraph URL: https://github.com/simstudioai/sim/pull/7308

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:5c4ac2bc-a7b5-ec75-0e01-6ae15fbbf299
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8B36:14B945:196129:237FED:6AFB2F0E
html-safe-nonce278e0b575ff6477335966d42aacda0eea69081c55f5109f5ce27baea77642009
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4QjM2OjE0Qjk0NToxOTYxMjk6MjM3RkVEOjZBRkIyRjBFIiwidmlzaXRvcl9pZCI6IjUxNjc1NTM2Mjg0MDcwMTcyMzAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmace6a35a4439ac4b148760aedf635c31e482f589b7fa6096492144da7487196493
hovercard-subject-tagpull_request:4406310424
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/7308/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary Two verified GitHub defects: an operation that could never run, and a UI field wired to nothing. github_update_branch_protection was unusable PUT /repos/{owner}/{repo}/branches/{branch}/pro...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneefe184de15c1d8c1107a340cfc27bf7187b458dc07687ee1fa51f035148fb3d1
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasef567cf3af46b50a3211fb5dab569a9d6a7b58025
ui-targetcanary-1
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/7308/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F7308%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F7308%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/7308/files
Reloadhttps://github.com/simstudioai/sim/pull/7308/files
Reloadhttps://github.com/simstudioai/sim/pull/7308/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests198 (198)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/tools-gh2https://github.com/simstudioai/sim/tree/fix/tools-gh2
Conversation 16 https://github.com/simstudioai/sim/pull/7308
Commits 4 https://github.com/simstudioai/sim/pull/7308/commits
Checks 25 https://github.com/simstudioai/sim/pull/7308/checks
Files changed https://github.com/simstudioai/sim/pull/7308/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/7308/files
fix(github): make branch protection usable and wire workflow_id to its endpoint https://github.com/simstudioai/sim/pull/7308/files#top
Show all changes 4 commits https://github.com/simstudioai/sim/pull/7308/files
552ebd1 fix(github): make branch protection usable and wire workflow_id to it… waleedlatif1 Aug 31, 2026 https://github.com/simstudioai/sim/pull/7308/commits/552ebd12b3c10143b393174bf8479aa7d0b0d894
32b606c fix(github): name the branch-protection parse failure without echoing… waleedlatif1 Aug 31, 2026 https://github.com/simstudioai/sim/pull/7308/commits/32b606c25802b63c590d2c65bdaea1194e0d1ea2
41bd963 Merge remote-tracking branch 'origin/staging' into fix/tools-gh2 waleedlatif1 Aug 31, 2026 https://github.com/simstudioai/sim/pull/7308/commits/41bd96387f8a54fa6423914ce9830dfcc019e630
ff56696 Merge remote-tracking branch 'origin/staging' into fix/tools-gh2 waleedlatif1 Aug 31, 2026 https://github.com/simstudioai/sim/pull/7308/commits/ff566960c3ed9a306fb6c5f6c682c6d13114cd37
Clear filters https://github.com/simstudioai/sim/pull/7308/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/7308/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/7308/files
github.mdx https://github.com/simstudioai/sim/pull/7308/files#diff-c74f7e5e52ca115fbe75d16174de6c0a1985945d3684dca0f27ab16b027aadd0
github.ts https://github.com/simstudioai/sim/pull/7308/files#diff-1279851140532dd52cae77961a41817f9a0aac35fd98b1651b3b4d92266cb75e
tool-metadata.ts https://github.com/simstudioai/sim/pull/7308/files#diff-3a953213cad2b14799015043b75c22cd4815397d3a43ccbf138816bedfdfccd7
branch_protection_and_workflow_runs.test.ts https://github.com/simstudioai/sim/pull/7308/files#diff-5381395ebd957fe01a5357f280714baed06dd0e92c590bb4a7d0f17dcd900891
list_workflow_runs.ts https://github.com/simstudioai/sim/pull/7308/files#diff-90e417539eeb8f3ce04711fe883e36795ce168aa19f2ea657f400a3916398faa
types.ts https://github.com/simstudioai/sim/pull/7308/files#diff-346247eccc3e16302eebd13abec013f298eb8a4a2ba12b4a2f5b2c0f0f42a66c
update_branch_protection.ts https://github.com/simstudioai/sim/pull/7308/files#diff-caa2e6ea0e25ebc70d8492317f770320d31361de24a32dbdaa7fe9122682fabd
integrations.json https://github.com/simstudioai/sim/pull/7308/files#diff-3c0cdbab0250ae3bd5869a2c3ce5c3f4f548d896e4fbbbc82a01ffc0f588a8cc
apps/docs/content/docs/integrations/github.mdxhttps://github.com/simstudioai/sim/pull/7308/files#diff-c74f7e5e52ca115fbe75d16174de6c0a1985945d3684dca0f27ab16b027aadd0
View file https://github.com/simstudioai/sim/blob/ff566960c3ed9a306fb6c5f6c682c6d13114cd37/apps/docs/content/docs/integrations/github.mdx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/7308/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/7308/files#diff-c74f7e5e52ca115fbe75d16174de6c0a1985945d3684dca0f27ab16b027aadd0
https://github.com/simstudioai/sim/pull/7308/files#diff-c74f7e5e52ca115fbe75d16174de6c0a1985945d3684dca0f27ab16b027aadd0
https://github.com/simstudioai/sim/pull/7308/files#diff-c74f7e5e52ca115fbe75d16174de6c0a1985945d3684dca0f27ab16b027aadd0
https://github.com/simstudioai/sim/pull/7308/files#diff-c74f7e5e52ca115fbe75d16174de6c0a1985945d3684dca0f27ab16b027aadd0
apps/sim/blocks/blocks/github.tshttps://github.com/simstudioai/sim/pull/7308/files#diff-1279851140532dd52cae77961a41817f9a0aac35fd98b1651b3b4d92266cb75e
View file https://github.com/simstudioai/sim/blob/ff566960c3ed9a306fb6c5f6c682c6d13114cd37/apps/sim/blocks/blocks/github.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/7308/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/7308/files#diff-1279851140532dd52cae77961a41817f9a0aac35fd98b1651b3b4d92266cb75e
https://github.com/simstudioai/sim/pull/7308/files#diff-1279851140532dd52cae77961a41817f9a0aac35fd98b1651b3b4d92266cb75e
https://github.com/simstudioai/sim/pull/7308/files#diff-1279851140532dd52cae77961a41817f9a0aac35fd98b1651b3b4d92266cb75e
https://github.com/simstudioai/sim/pull/7308/files#diff-1279851140532dd52cae77961a41817f9a0aac35fd98b1651b3b4d92266cb75e
apps/sim/tools/generated/tool-metadata.tshttps://github.com/simstudioai/sim/pull/7308/files#diff-3a953213cad2b14799015043b75c22cd4815397d3a43ccbf138816bedfdfccd7
View file https://github.com/simstudioai/sim/blob/ff566960c3ed9a306fb6c5f6c682c6d13114cd37/apps/sim/tools/generated/tool-metadata.ts
Open in desktop https://desktop.github.com
Please reload this pagehttps://github.com/simstudioai/sim/pull/7308/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/7308/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/7308/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.