Title: fix(admin): report a completed workspace move's true source and its credentials by icecrasher321 · Pull Request #7290 · simstudioai/sim · GitHub
Open Graph Title: fix(admin): report a completed workspace move's true source and its credentials by icecrasher321 · Pull Request #7290 · simstudioai/sim
X Title: fix(admin): report a completed workspace move's true source and its credentials by icecrasher321 · Pull Request #7290 · simstudioai/sim
Description: Summary The durable workspace-move payload records sourceOrganizationId as a tri-state: an absent key means the operation predates the field, an explicit null means the workspace came from a personal source. The payload parser collapsed both to null with a ?? null, so every reload or retry of a personal-source move emitted a notice claiming its source organization had failed to persist — the record was complete, there was simply no organization to name. Both consumers now resolve through one helper that reports the origin as unknown only when the payload genuinely can't answer: no record, or a recorded id whose organization has since been deleted. The reload path splits its copy so a deleted organization no longer reads as an unpersisted one. The applied and reloaded responses returned an empty credential summary. Unlike the source impact, those rows are workspace-scoped and travel with the move untouched — collectWorkspaceCredentialSummary already took a DbOrTx executor, so nothing forced the blank. An admin who had just confirmed a move was told the workspace carried no credentials, environment variables, or BYOK keys. All three applied sites now collect it against the pre-move source organization, so backedBySourceOrgMember keeps its meaning. That surfaced a follow-on: the applied path hardcoded credentials: 0 / environmentVariableKeys: 0 in its truncation record, which would now be wrong past the 1,000-row bound. buildAppliedTruncation merges the real counts the way preflight does, so a truncated applied review can't present as a complete one. Type of Change Bug fix Testing 5 new tests in admin-move.test.ts. Reverting the source fix and re-running confirms 4 of them fail against the old code (false notice on a personal source; missing credentials on reload, on confirm, and on retry). The 5th pins the legitimate legacy-payload warning and passes both ways — that path is unchanged. bun run test lib/workspaces/ lib/admin/ — 251 passed. bun run type-check, bun run lint, bun run check:audits (39 audits incl. check:api-validation:strict) all pass. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)
Open Graph Description: Summary The durable workspace-move payload records sourceOrganizationId as a tri-state: an absent key means the operation predates the field, an explicit null means the workspace came from a perso...
X Description: Summary The durable workspace-move payload records sourceOrganizationId as a tri-state: an absent key means the operation predates the field, an explicit null means the workspace came from a perso...
Opengraph URL: https://github.com/simstudioai/sim/pull/7290
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:8d46cfce-d9f1-074d-b47c-894c84269df1 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 91C6:1BB36A:1B9CB0:262498:6AFB2EED |
| html-safe-nonce | 71fe3a7e0ea8cc8491f0552cfe286ad70241f5aa08e664ae7e2de02ed5a14774 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MUM2OjFCQjM2QToxQjlDQjA6MjYyNDk4OjZBRkIyRUVEIiwidmlzaXRvcl9pZCI6IjM0ODkyNDM5NDc1NzM2OTU4MSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 1e561090e82ff87100311696816c892638773dbd5bb049f75133d9a21d99686e |
| hovercard-subject-tag | pull_request:4397774933 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/7290/files |
| twitter:image | https://avatars.githubusercontent.com/u/17950982?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/17950982?s=400&v=4 |
| og:image:alt | Summary The durable workspace-move payload records sourceOrganizationId as a tri-state: an absent key means the operation predates the field, an explicit null means the workspace came from a perso... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 40c7ffe00e8bbb3ca8403c83d7ef110379c9eba2cbc7a7c333b037ffd940d4e4 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/simstudioai/sim git https://github.com/simstudioai/sim.git |
| octolytics-dimension-user_id | 199344406 |
| octolytics-dimension-user_login | simstudioai |
| octolytics-dimension-repository_id | 912559512 |
| octolytics-dimension-repository_nwo | simstudioai/sim |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 912559512 |
| octolytics-dimension-repository_network_root_nwo | simstudioai/sim |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | f494d77c37809e03e18d49c6e9945c57e0b64070 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width