René's URL Explorer Experiment


Title: fix(admin): report a completed workspace move's true source and its credentials by icecrasher321 · Pull Request #7290 · simstudioai/sim · GitHub

Open Graph Title: fix(admin): report a completed workspace move's true source and its credentials by icecrasher321 · Pull Request #7290 · simstudioai/sim

X Title: fix(admin): report a completed workspace move's true source and its credentials by icecrasher321 · Pull Request #7290 · simstudioai/sim

Description: Summary The durable workspace-move payload records sourceOrganizationId as a tri-state: an absent key means the operation predates the field, an explicit null means the workspace came from a personal source. The payload parser collapsed both to null with a ?? null, so every reload or retry of a personal-source move emitted a notice claiming its source organization had failed to persist — the record was complete, there was simply no organization to name. Both consumers now resolve through one helper that reports the origin as unknown only when the payload genuinely can't answer: no record, or a recorded id whose organization has since been deleted. The reload path splits its copy so a deleted organization no longer reads as an unpersisted one. The applied and reloaded responses returned an empty credential summary. Unlike the source impact, those rows are workspace-scoped and travel with the move untouched — collectWorkspaceCredentialSummary already took a DbOrTx executor, so nothing forced the blank. An admin who had just confirmed a move was told the workspace carried no credentials, environment variables, or BYOK keys. All three applied sites now collect it against the pre-move source organization, so backedBySourceOrgMember keeps its meaning. That surfaced a follow-on: the applied path hardcoded credentials: 0 / environmentVariableKeys: 0 in its truncation record, which would now be wrong past the 1,000-row bound. buildAppliedTruncation merges the real counts the way preflight does, so a truncated applied review can't present as a complete one. Type of Change Bug fix Testing 5 new tests in admin-move.test.ts. Reverting the source fix and re-running confirms 4 of them fail against the old code (false notice on a personal source; missing credentials on reload, on confirm, and on retry). The 5th pins the legitimate legacy-payload warning and passes both ways — that path is unchanged. bun run test lib/workspaces/ lib/admin/ — 251 passed. bun run type-check, bun run lint, bun run check:audits (39 audits incl. check:api-validation:strict) all pass. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary The durable workspace-move payload records sourceOrganizationId as a tri-state: an absent key means the operation predates the field, an explicit null means the workspace came from a perso...

X Description: Summary The durable workspace-move payload records sourceOrganizationId as a tri-state: an absent key means the operation predates the field, an explicit null means the workspace came from a perso...

Opengraph URL: https://github.com/simstudioai/sim/pull/7290

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:8d46cfce-d9f1-074d-b47c-894c84269df1
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id91C6:1BB36A:1B9CB0:262498:6AFB2EED
html-safe-nonce71fe3a7e0ea8cc8491f0552cfe286ad70241f5aa08e664ae7e2de02ed5a14774
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MUM2OjFCQjM2QToxQjlDQjA6MjYyNDk4OjZBRkIyRUVEIiwidmlzaXRvcl9pZCI6IjM0ODkyNDM5NDc1NzM2OTU4MSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac1e561090e82ff87100311696816c892638773dbd5bb049f75133d9a21d99686e
hovercard-subject-tagpull_request:4397774933
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/7290/files
twitter:imagehttps://avatars.githubusercontent.com/u/17950982?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/17950982?s=400&v=4
og:image:altSummary The durable workspace-move payload records sourceOrganizationId as a tri-state: an absent key means the operation predates the field, an explicit null means the workspace came from a perso...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None40c7ffe00e8bbb3ca8403c83d7ef110379c9eba2cbc7a7c333b037ffd940d4e4
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasef494d77c37809e03e18d49c6e9945c57e0b64070
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/7290/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F7290%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F7290%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/7290/files
Reloadhttps://github.com/simstudioai/sim/pull/7290/files
Reloadhttps://github.com/simstudioai/sim/pull/7290/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests198 (198)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
icecrasher321https://github.com/icecrasher321
staginghttps://github.com/simstudioai/sim/tree/staging
fix/admin-move-recorded-source-and-credentialshttps://github.com/simstudioai/sim/tree/fix/admin-move-recorded-source-and-credentials
Conversation 10 https://github.com/simstudioai/sim/pull/7290
Commits 2 https://github.com/simstudioai/sim/pull/7290/commits
Checks 27 https://github.com/simstudioai/sim/pull/7290/checks
Files changed https://github.com/simstudioai/sim/pull/7290/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/7290/files
fix(admin): report a completed workspace move's true source and its credentials https://github.com/simstudioai/sim/pull/7290/files#top
Show all changes 2 commits https://github.com/simstudioai/sim/pull/7290/files
dcd24d1 fix(admin): report a completed workspace move's true source and its c… Aug 30, 2026 https://github.com/simstudioai/sim/pull/7290/commits/dcd24d155e7f114e82a88b3662706a4d2f128f52
1ea0b49 test(admin): cover the deleted source organization and truncated cred… Aug 30, 2026 https://github.com/simstudioai/sim/pull/7290/commits/1ea0b49289047f3d3f4500fd929208044f08f9b9
Clear filters https://github.com/simstudioai/sim/pull/7290/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/7290/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/7290/files
admin-move.test.ts https://github.com/simstudioai/sim/pull/7290/files#diff-6b85519a0f0b50bb3a96328ec5d00bab2376c14e12cbd79ed99ae4ff4b76a615
admin-move.ts https://github.com/simstudioai/sim/pull/7290/files#diff-21cb83908e161603e2963824ec195fc05d5b4963f93bdb3353996c4ea6d29a4d
apps/sim/lib/workspaces/admin-move.test.tshttps://github.com/simstudioai/sim/pull/7290/files#diff-6b85519a0f0b50bb3a96328ec5d00bab2376c14e12cbd79ed99ae4ff4b76a615
View file https://github.com/simstudioai/sim/blob/1ea0b49289047f3d3f4500fd929208044f08f9b9/apps/sim/lib/workspaces/admin-move.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/7290/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/7290/files#diff-6b85519a0f0b50bb3a96328ec5d00bab2376c14e12cbd79ed99ae4ff4b76a615
https://github.com/simstudioai/sim/pull/7290/files#diff-6b85519a0f0b50bb3a96328ec5d00bab2376c14e12cbd79ed99ae4ff4b76a615
https://github.com/simstudioai/sim/pull/7290/files#diff-6b85519a0f0b50bb3a96328ec5d00bab2376c14e12cbd79ed99ae4ff4b76a615
https://github.com/simstudioai/sim/pull/7290/files#diff-6b85519a0f0b50bb3a96328ec5d00bab2376c14e12cbd79ed99ae4ff4b76a615
https://github.com/simstudioai/sim/pull/7290/files#diff-6b85519a0f0b50bb3a96328ec5d00bab2376c14e12cbd79ed99ae4ff4b76a615
https://github.com/simstudioai/sim/pull/7290/files#diff-6b85519a0f0b50bb3a96328ec5d00bab2376c14e12cbd79ed99ae4ff4b76a615
https://github.com/simstudioai/sim/pull/7290/files#diff-6b85519a0f0b50bb3a96328ec5d00bab2376c14e12cbd79ed99ae4ff4b76a615
https://github.com/simstudioai/sim/pull/7290/files#diff-6b85519a0f0b50bb3a96328ec5d00bab2376c14e12cbd79ed99ae4ff4b76a615
https://github.com/simstudioai/sim/pull/7290/files#diff-6b85519a0f0b50bb3a96328ec5d00bab2376c14e12cbd79ed99ae4ff4b76a615
https://github.com/simstudioai/sim/pull/7290/files#diff-6b85519a0f0b50bb3a96328ec5d00bab2376c14e12cbd79ed99ae4ff4b76a615
https://github.com/simstudioai/sim/pull/7290/files#diff-6b85519a0f0b50bb3a96328ec5d00bab2376c14e12cbd79ed99ae4ff4b76a615
Please reload this pagehttps://github.com/simstudioai/sim/pull/7290/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/7290/files
https://github.com/simstudioai/sim/pull/7290/files#diff-6b85519a0f0b50bb3a96328ec5d00bab2376c14e12cbd79ed99ae4ff4b76a615
Please reload this pagehttps://github.com/simstudioai/sim/pull/7290/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/7290/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.