René's URL Explorer Experiment


Title: fix(github): wire the block fields whose ids do not match their tool params by waleedlatif1 · Pull Request #7287 · simstudioai/sim · GitHub

Open Graph Title: fix(github): wire the block fields whose ids do not match their tool params by waleedlatif1 · Pull Request #7287 · simstudioai/sim

X Title: fix(github): wire the block fields whose ids do not match their tool params by waleedlatif1 · Pull Request #7287 · simstudioai/sim

Description: Summary Eleven fields in the GitHub block render, accept input, and then arrive at their tool under a name the tool never reads. Three operations are unusable from the canvas as a result; the rest silently discard what the user typed. The block's subBlock ids are the wiring contract — the serializer keys values by subBlock.id (serializer/index.ts:521-612), and GitHubBlock.tools.config declared only tool:, with no params mapper and no canonicalParamId anywhere in the file. So a subBlock named reaction_content can never populate a tool param named content. Broken outright — the call dies before the HTTP request validateRequiredParametersAfterMerge (tools/utils.ts:111-138) throws for any missing required user-or-llm param, so these three fail with an error naming a field that does not exist in the UI: operation tool param block field user sees Create issue reaction content reaction_content Content is required for GitHub Create Issue Reaction Create comment reaction content reaction_content Content is required for GitHub Create Comment Reaction Create milestone title milestone_title Title is required for GitHub Create Milestone Silently inert — no error, the input is just dropped gist_public → public (every gist created secret regardless of the selection), fork_name → name, fork_sort → sort, milestone_title/milestone_description → title/description on update, milestone_state → state, milestone_sort → sort. The fix One tools.config.params mapper, driven by an alias table where each entry names the operations whose tool actually declares its target. GitHubV2Block already forwards config.params (github.ts:2433), so this fixes both block versions in one place. Every assignment is guarded, and that is load-bearing rather than defensive. generic-handler.ts:189-191 merges { ...inputs, ...params(inputs) }, and providers/utils.ts installs this same function as the provider paramsTransform, spreading its result over the model's tool-call arguments. An unconditional write would clobber a model-supplied content/title/sort with undefined — and the agent path is the one path these fields work on today, because an LLM supplies params by their real names. A test asserts a model-supplied value survives the mapper untouched. Every alias is scoped to its operations, and that scoping is load-bearing. shouldSerializeSubBlock (serializer/index.ts:91-93) serializes a non-empty mode: 'advanced' field without evaluating its condition, and seven of the eight sources are advanced. So a milestone_title left behind from Create Milestone is still in params after the user switches to Update PR — an unscoped alias would rewrite it to title and overwrite the PR title the user typed. Scoping also subsumes the collision problem: sort has two sources, and title/description/state share names with other operations' fields. gist_public also needs coercion, not just a rename: it is a dropdown, so it stores the string 'true'/'false' while the tool declares public as a boolean, and the generic handler only JSON-parses json/array-typed inputs (generic-handler.ts:193-200). This follows the established pattern in blocks/blocks/ashby.ts:1083 and blocks/blocks/agentmail.ts:590. Presence is tested rather than truthiness so a deliberate false is not mistaken for an unset field — the block declares this input as boolean, so a writer following that schema stores false rather than the dropdown's 'false', and a truthy check would silently drop one of them. Why not canonicalParamId It looks like the declarative fix and it is the wrong tool here. buildCanonicalIndex (lib/workflows/subblocks/visibility.ts:98-125) groups by canonical id, so two fields renaming to the same target collapse into one group — only the last becomes basicId, and the other's value becomes invisible to the collapse at serializer/index.ts:589-610. fork_sort and milestone_sort both target sort, so exactly that would have happened and the fix would have silently not worked for forks. Verified with a probe against the real functions before choosing the mapper. Renaming the subBlock ids to match was the other candidate, and it would orphan every saved workflow that holds a value under the old id. Scope Deliberately one mechanism: a block field whose id does not match its tool param. A comprehensive audit of this integration turned up several other defect classes, each left for its own PR because they are unrelated mechanisms and bundling them is what makes a diff unreviewable: github_update_branch_protection — restrictions has no subBlock at all, three required params are mode: 'advanced' and unmarked, and two need JSON/boolean coercion. That operation needs redesigning, not rewiring. Pagination — the block has exactly one page subBlock, conditioned on github_list_tags. Twenty-two other list tools declare page and can never receive it. Condition-array gaps — sort covers 1 of 5 search ops, per_page misses 3 ops, labels/assignees miss update_issue, draft/prerelease miss update_release. github_check_star cannot return starred: false — GitHub signals not-starred with 404 and the shared executor throws at tools/index.ts:2838 before transformResponse. Fixing it means either an internal-operation conversion or a shared-executor change affecting ~10 other tools' dead branches. workflow_id renders for github_list_workflow_runs, which declares no such param. operation never reaches a block's params mapper on the agent tool-calling path. providers/utils.ts spreads it in for tool selection (:736-739) but builds the transform's input from block.params alone (:776), so every alias here skips on that path — the same no-op as before this mapper existed, since a model already supplies these params by their real names. All 91 blocks whose mapper branches on params.operation are equally affected, so closing it is a one-line provider-layer change that deserves its own blast-radius review. Backwards compatibility Purely additive. Zero subBlock ids added, removed, or renamed; zero required flips; zero visibility changes — the diff adds a mapper and a test file and touches nothing else. check-block-registry.ts origin/staging passes the subblock-ID stability check. Nothing that currently succeeds starts failing, and no saved state is orphaned. But this is not a no-op, and the distinction is worth stating precisely: Three operations go from throwing to working. Create Issue Reaction, Create Comment Reaction and Create Milestone raise is required today, so nothing can depend on their current behavior. Strictly better, zero risk. Eight fields go from ignored to applied. A workflow that filled one of them will now behave differently — in the direction the user configured it. That is the point of the fix, but it is a real change, not a silent equivalence. The one to read carefully is gist visibility. Selecting "Public" on Create Gist currently produces a secret gist; after this change it produces a public one. Every other alias moves data the user typed into a field that ignored it; this one changes who can see a resource. The three outcomes are pinned by tests: Dropdown state Serialized Before After never opened absent secret secret (unchanged) "Secret" 'false' secret secret (unchanged) "Public" 'true' secret public (changed) Only an explicit "Public" selection changes, and it changes to what the field says it does. An untouched advanced dropdown is not serialized at all (isNonEmptyValue is false for nullish/empty), so the default path is untouched. A stale list filter also cannot leak into a write: milestone_state is scoped to github_list_milestones only, so a leftover value cannot set the state of a milestone being created. The agent tool-calling path is unaffected — guarded assignment leaves model-supplied values alone, and every alias skips there anyway. Testing blocks/blocks/github.param-wiring.test.ts — 84 tests. 194 pass across blocks/blocks/github and tools/github. Covers: every rename reaching its target; every target being a param the tool really declares (asserted against the live registry, not a hardcoded list); the source id not being a tool param; guarded assignment never writing undefined; a model-supplied value surviving; ''/null/undefined treated as not-provided; gist_public coercion including the dropdown's real option ids; that sources sharing a target are condition-disjoint; and that V2 forwards the same mapper. Also covers the stale-value regression directly: a leftover milestone_title must not become github_update_pr's title and must not clobber a title the user typed, swept across all seven advanced sources against unrelated operations; and an absent, undefined, empty or non-string operation emits nothing while leaving model-supplied values intact. Verified red-first at every step: removing the mapper turns 31 red, removing the operation guard turns 10 red, and restoring the truthy gist_public check turns 2 red. bun run lint, bun run type-check (no GitHub diagnostics), bun run check:audits (39 audits), and check-block-registry.ts origin/staging all pass. tool-metadata:generate and generate-docs produce no drift. Type of Change Bug fix Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary Eleven fields in the GitHub block render, accept input, and then arrive at their tool under a name the tool never reads. Three operations are unusable from the canvas as a result; the rest ...

X Description: Summary Eleven fields in the GitHub block render, accept input, and then arrive at their tool under a name the tool never reads. Three operations are unusable from the canvas as a result; the rest ...

Opengraph URL: https://github.com/simstudioai/sim/pull/7287

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:37dd7cf8-227f-2a30-3a3f-3f5346f402a0
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA8BE:3FAE84:60234C:84FC67:6AFB3F67
html-safe-nonce5499b9b7aa3d6714e0f40bb26cc655d11d92ced5d84e5e1fb91bc3c0743985ea
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBOEJFOjNGQUU4NDo2MDIzNEM6ODRGQzY3OjZBRkIzRjY3IiwidmlzaXRvcl9pZCI6IjMxNTEzNDYxNjI2MTU0MDIzNDMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacad5d6483d5d8d7ad6537aaf9c143d6597398a24b25cc21d09cbedf78f2efde95
hovercard-subject-tagpull_request:4397157585
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/7287/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary Eleven fields in the GitHub block render, accept input, and then arrive at their tool under a name the tool never reads. Three operations are unusable from the canvas as a result; the rest ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None2169b0dfbef67ed6b128074a5ed45bb7d5d1859783b10178b09a7765ad5f3693
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release3b4fc8df5ef1c6757e733a23e6b81b6725021823
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/7287/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F7287%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F7287%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/7287/files
Reloadhttps://github.com/simstudioai/sim/pull/7287/files
Reloadhttps://github.com/simstudioai/sim/pull/7287/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests202 (202)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/github-block-param-wiring-v2https://github.com/simstudioai/sim/tree/fix/github-block-param-wiring-v2
Conversation 42 https://github.com/simstudioai/sim/pull/7287
Commits 9 https://github.com/simstudioai/sim/pull/7287/commits
Checks 27 https://github.com/simstudioai/sim/pull/7287/checks
Files changed https://github.com/simstudioai/sim/pull/7287/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/7287/files
fix(github): wire the block fields whose ids do not match their tool params https://github.com/simstudioai/sim/pull/7287/files#top
Show all changes 9 commits https://github.com/simstudioai/sim/pull/7287/files
2901b97 fix(github): wire the block fields whose ids do not match their tool … waleedlatif1 Aug 30, 2026 https://github.com/simstudioai/sim/pull/7287/commits/2901b973d24508230447a9587e46be5054ad4e10
10f9da7 chore(github): use TSDoc for the new wiring comments waleedlatif1 Aug 30, 2026 https://github.com/simstudioai/sim/pull/7287/commits/10f9da7b5956be67b66c281d8af61ea1a77193b4
ff0eb6e fix(github): treat boolean false as an explicit gist visibility choice waleedlatif1 Aug 30, 2026 https://github.com/simstudioai/sim/pull/7287/commits/ff0eb6e4a39798437acf7ce9db973f790acd50c6
99badc4 fix(github): scope each param alias to the operations that declare it waleedlatif1 Aug 30, 2026 https://github.com/simstudioai/sim/pull/7287/commits/99badc433a3719117517d8a4edbd3693cfaba6f3
4a60d17 docs(github): record why an absent operation degrades to a no-op waleedlatif1 Aug 30, 2026 https://github.com/simstudioai/sim/pull/7287/commits/4a60d1725f4624a5cf75d9d6aadf3fc7dd26fd92
5558f6f test(github): pin the gist visibility and list-filter outcomes waleedlatif1 Aug 30, 2026 https://github.com/simstudioai/sim/pull/7287/commits/5558f6f81af17610017e6ba18537d152f9a2e5b8
aa9ca47 test(github): exercise the isSet guard instead of short-circuiting pa… waleedlatif1 Aug 30, 2026 https://github.com/simstudioai/sim/pull/7287/commits/aa9ca471bab159eab3f0960aca2b880e3c6d1581
75ec93a test(github): drive the wiring assertions from the alias table itself waleedlatif1 Aug 31, 2026 https://github.com/simstudioai/sim/pull/7287/commits/75ec93ac7c7ec81c1e02aae8ef587162237ab670
75c249f test(github): remove the param-wiring suite waleedlatif1 Aug 31, 2026 https://github.com/simstudioai/sim/pull/7287/commits/75c249fdf6ea5364174c4d0d9ab52af6ea9622f3
Clear filters https://github.com/simstudioai/sim/pull/7287/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/7287/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/7287/files
apps/sim/blocks/blocks/github.tshttps://github.com/simstudioai/sim/pull/7287/files#diff-1279851140532dd52cae77961a41817f9a0aac35fd98b1651b3b4d92266cb75e
View file https://github.com/simstudioai/sim/blob/75c249fdf6ea5364174c4d0d9ab52af6ea9622f3/apps/sim/blocks/blocks/github.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/7287/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/7287/files#diff-1279851140532dd52cae77961a41817f9a0aac35fd98b1651b3b4d92266cb75e
https://github.com/simstudioai/sim/pull/7287/files#diff-1279851140532dd52cae77961a41817f9a0aac35fd98b1651b3b4d92266cb75e
https://github.com/simstudioai/sim/pull/7287/files#diff-1279851140532dd52cae77961a41817f9a0aac35fd98b1651b3b4d92266cb75e
Please reload this pagehttps://github.com/simstudioai/sim/pull/7287/files
https://github.com/simstudioai/sim/pull/7287/files#diff-1279851140532dd52cae77961a41817f9a0aac35fd98b1651b3b4d92266cb75e
Please reload this pagehttps://github.com/simstudioai/sim/pull/7287/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.