René's URL Explorer Experiment


Title: fix(charts): strip ECharts navigation sinks from .chart documents by waleedlatif1 · Pull Request #7286 · simstudioai/sim · GitHub

Open Graph Title: fix(charts): strip ECharts navigation sinks from .chart documents by waleedlatif1 · Pull Request #7286 · simstudioai/sim

X Title: fix(charts): strip ECharts navigation sinks from .chart documents by waleedlatif1 · Pull Request #7286 · simstudioai/sim

Description: Summary confineOptionToCanvas closed the ECharts DOM sinks (tooltip innerHTML, toolbox dataView/saveAsImage) but left the navigation ones open — title.link, title.sublink, and a link on a treemap or sunburst data item each reach windowOpen, which assigns the URL to location.href A .chart document is author-controlled and rendered with setOption() straight into the app document (unsandboxed, unlike the HTML preview alongside it), including on the anonymous /f/ share route — so a javascript: URL in one executed script on the app origin on a single click Drop link/sublink everywhere in the walk alongside toolbox. A chart has no reason to navigate its viewer, so they're stripped rather than scheme-checked, which would still leave an open redirect on an authenticated origin target/subtarget are left alone — all four call sites are guarded on a truthy link, so removing the link is sufficient and avoids collateral on any unrelated target key Type of Change Bug fix Testing apps/sim/lib/charts/spec.test.ts — 23/23 passing; the two new tests were confirmed red against the unpatched sanitizer first One test pins the sanitizer output (title link/sublink plus treemap and sunburst item links, including under baseOption and media); the other renders through real echarts and asserts the title component resolves no link/sublink to hand to windowOpen bun run lint, bun run check:audits (39/39), check-block-registry all pass Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary confineOptionToCanvas closed the ECharts DOM sinks (tooltip innerHTML, toolbox dataView/saveAsImage) but left the navigation ones open — title.link, title.sublink, and a link on a treemap ...

X Description: Summary confineOptionToCanvas closed the ECharts DOM sinks (tooltip innerHTML, toolbox dataView/saveAsImage) but left the navigation ones open — title.link, title.sublink, and a link on a treemap ...

Opengraph URL: https://github.com/simstudioai/sim/pull/7286

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:7656c987-25e0-cd96-4477-97282ff1d6fd
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC4A0:870C9:CAF21:125311:6AFB2E77
html-safe-nonceba4c174a5ae0c9dd156ecbbaf522af1e94cbbcf172ec38a583f1c1c953acf821
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNEEwOjg3MEM5OkNBRjIxOjEyNTMxMTo2QUZCMkU3NyIsInZpc2l0b3JfaWQiOiIzOTg4Nzc4NzYxNDM1NDI2NDIzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacb4b4eb5af3d379dba154c5c7c8e940d7928b87f39a6c81cc44900b0936b61868
hovercard-subject-tagpull_request:4397149476
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/7286/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary confineOptionToCanvas closed the ECharts DOM sinks (tooltip innerHTML, toolbox dataView/saveAsImage) but left the navigation ones open — title.link, title.sublink, and a link on a treemap ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None40c7ffe00e8bbb3ca8403c83d7ef110379c9eba2cbc7a7c333b037ffd940d4e4
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasef494d77c37809e03e18d49c6e9945c57e0b64070
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/7286/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F7286%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F7286%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/7286/files
Reloadhttps://github.com/simstudioai/sim/pull/7286/files
Reloadhttps://github.com/simstudioai/sim/pull/7286/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests198 (198)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
chart-xss-investigatehttps://github.com/simstudioai/sim/tree/chart-xss-investigate
Conversation 2 https://github.com/simstudioai/sim/pull/7286
Commits 1 https://github.com/simstudioai/sim/pull/7286/commits
Checks 27 https://github.com/simstudioai/sim/pull/7286/checks
Files changed https://github.com/simstudioai/sim/pull/7286/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/7286/files
fix(charts): strip ECharts navigation sinks from .chart documents https://github.com/simstudioai/sim/pull/7286/files#top
Show all changes 1 commit https://github.com/simstudioai/sim/pull/7286/files
67de816 fix(charts): strip ECharts navigation sinks from .chart documents waleedlatif1 Aug 30, 2026 https://github.com/simstudioai/sim/pull/7286/commits/67de8166dbaf080b037b8091c2e8e6b346a0d3b1
Clear filters https://github.com/simstudioai/sim/pull/7286/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/7286/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/7286/files
spec.test.ts https://github.com/simstudioai/sim/pull/7286/files#diff-6d458e046aad6866554b57da44aa80a17b38e2aa214a7ace9f7d30c74678bdde
spec.ts https://github.com/simstudioai/sim/pull/7286/files#diff-971fc45f1f3b79a59ef01fb9e52eb6d171c4c87cd332d336e8df318c9b8cce7d
apps/sim/lib/charts/spec.test.tshttps://github.com/simstudioai/sim/pull/7286/files#diff-6d458e046aad6866554b57da44aa80a17b38e2aa214a7ace9f7d30c74678bdde
View file https://github.com/simstudioai/sim/blob/67de8166dbaf080b037b8091c2e8e6b346a0d3b1/apps/sim/lib/charts/spec.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/7286/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/7286/files#diff-6d458e046aad6866554b57da44aa80a17b38e2aa214a7ace9f7d30c74678bdde
https://github.com/simstudioai/sim/pull/7286/files#diff-6d458e046aad6866554b57da44aa80a17b38e2aa214a7ace9f7d30c74678bdde
https://github.com/simstudioai/sim/pull/7286/files#diff-6d458e046aad6866554b57da44aa80a17b38e2aa214a7ace9f7d30c74678bdde
https://github.com/simstudioai/sim/pull/7286/files#diff-6d458e046aad6866554b57da44aa80a17b38e2aa214a7ace9f7d30c74678bdde
https://github.com/simstudioai/sim/pull/7286/files#diff-6d458e046aad6866554b57da44aa80a17b38e2aa214a7ace9f7d30c74678bdde
https://github.com/simstudioai/sim/pull/7286/files#diff-6d458e046aad6866554b57da44aa80a17b38e2aa214a7ace9f7d30c74678bdde
https://github.com/simstudioai/sim/pull/7286/files#diff-6d458e046aad6866554b57da44aa80a17b38e2aa214a7ace9f7d30c74678bdde
apps/sim/lib/charts/spec.tshttps://github.com/simstudioai/sim/pull/7286/files#diff-971fc45f1f3b79a59ef01fb9e52eb6d171c4c87cd332d336e8df318c9b8cce7d
View file https://github.com/simstudioai/sim/blob/67de8166dbaf080b037b8091c2e8e6b346a0d3b1/apps/sim/lib/charts/spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/7286/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/7286/files#diff-971fc45f1f3b79a59ef01fb9e52eb6d171c4c87cd332d336e8df318c9b8cce7d
https://github.com/simstudioai/sim/pull/7286/files#diff-971fc45f1f3b79a59ef01fb9e52eb6d171c4c87cd332d336e8df318c9b8cce7d
https://github.com/simstudioai/sim/pull/7286/files#diff-971fc45f1f3b79a59ef01fb9e52eb6d171c4c87cd332d336e8df318c9b8cce7d
https://github.com/simstudioai/sim/pull/7286/files#diff-971fc45f1f3b79a59ef01fb9e52eb6d171c4c87cd332d336e8df318c9b8cce7d
Please reload this pagehttps://github.com/simstudioai/sim/pull/7286/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.