Title: fix(helm): bump chart appVersion to the release it ships with by waleedlatif1 · Pull Request #7285 · simstudioai/sim · GitHub
Open Graph Title: fix(helm): bump chart appVersion to the release it ships with by waleedlatif1 · Pull Request #7285 · simstudioai/sim
X Title: fix(helm): bump chart appVersion to the release it ships with by waleedlatif1 · Pull Request #7285 · simstudioai/sim
Description: Closes the one helm finding on the v0.8.18 release PR (#7283). The defect helm/sim/Chart.yaml has carried appVersion: "v0.7.44" since chart 1.2.0, through forty-odd application releases. appVersion is not decoration — sim.image uses it as the default tag whenever image.tag and image.digest are both unset, which is the case for every first-party image in the shipped values.yaml: app.image.tag: "" -> simstudio:v0.7.44 realtime.image.tag: "" -> realtime:v0.7.44 migrations.image.tag: "" -> migrations:v0.7.44 pii.image.tag: "" -> pii:v0.7.44 copilot.server.image.tag: "" / copilot.migrations.image.tag: "" So helm install sim helm/sim without pinning a tag deploys a v0.7.44 application from a chart that ships v0.8.18 features. The second-order effect is worse than the version skew: every values key added by a newer chart is silently inert, because the image being deployed has no code that reads it. A key documented in values.yaml appears to be set, the pod starts clean, and nothing happens. packages/sim-setup already names this failure mode in a troubleshooting hint — "ImagePullBackOff on ghcr.io/simstudioai/ usually means the chart appVersion tag was never published — check Chart.yaml against ghcr"*. Why it stayed frozen for four minor versions The chart CI's kind install test runs the default configuration, so it resolved its images through appVersion too. Version tags are cut by detect-version in ci.yml, which matches ^(vX.Y.Z): against the main-branch merge commit message — so on the very PR that raises appVersion, the tag it now names does not exist yet, and helm install --wait sits in ImagePullBackOff until the 15-minute timeout. Bumping appVersion was self-failing, and it silently stopped being bumped. That circularity is fixed here, not worked around: ci/kind-values.yaml pins the three first-party images to the published :latest. The job asks whether the chart installs, not which application build it installs, so any published image answers it — and the answer no longer depends on an unpublished tag. Changes appVersion → v0.8.18, version 1.6.3 → 1.6.4 (required by the chart's own version-bump gate). ci/kind-values.yaml pins app/realtime/migrations to :latest, with the reasoning in a comment so the next person does not re-couple them. README.md gains an "Upgrading to 1.6.4" entry, matching the existing per-version convention — an unpinned release rolls every first-party pod on upgrade, so it is a documented behavior change. The stale e.g. "v0.7.44" in the values.yaml example comment moves with it. Verification helm lint --values ci/default-values.yaml — clean helm template against ci/default-values.yaml, ci/full-values.yaml, and every examples/values-*.yaml — all render default install resolves ghcr.io/simstudioai/{simstudio,realtime,migrations}:v0.8.18 with the kind overlay it resolves :latest, as the install job needs scripts/check-cron-parity.ts — 20 jobs match GHCR probe: v0.7.44, v0.8.16, v0.8.17, latest all resolve; v0.8.18 404s until this release merges to main, which is the commit that publishes it No chart test or CI values file asserted the old tag (grep over tests/, ci/, examples/) Nothing in CI enforces that appVersion matches the release being cut — this removes the reason it could not be bumped, not the need to remember. Worth a follow-up if that should be a gate rather than a habit.
Open Graph Description: Closes the one helm finding on the v0.8.18 release PR (#7283). The defect helm/sim/Chart.yaml has carried appVersion: "v0.7.44" since chart 1.2.0, through forty-odd application releases. ...
X Description: Closes the one helm finding on the v0.8.18 release PR (#7283). The defect helm/sim/Chart.yaml has carried appVersion: "v0.7.44" since chart 1.2.0, through forty-odd application re...
Opengraph URL: https://github.com/simstudioai/sim/pull/7285
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:1fd737b7-5913-a9a8-d98c-f0e9652f68b0 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | B9D6:2A2B9E:BE74A:111851:6AFB2E7A |
| html-safe-nonce | 28518583fb43d6eb5c996142c1df7609740eccf0ce2558f84726ef0699abb919 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCOUQ2OjJBMkI5RTpCRTc0QToxMTE4NTE6NkFGQjJFN0EiLCJ2aXNpdG9yX2lkIjoiNDk4MzQ0MjcxNzAyODMzMTEzMCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | b5a2b1fc275e80324cb724bde3db1b5215cb839797cbc46fa03115ed09347740 |
| hovercard-subject-tag | pull_request:4397146366 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/7285/files |
| twitter:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| og:image:alt | Closes the one helm finding on the v0.8.18 release PR (#7283). The defect helm/sim/Chart.yaml has carried appVersion: "v0.7.44" since chart 1.2.0, through forty-odd application releases. ... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | efe184de15c1d8c1107a340cfc27bf7187b458dc07687ee1fa51f035148fb3d1 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/simstudioai/sim git https://github.com/simstudioai/sim.git |
| octolytics-dimension-user_id | 199344406 |
| octolytics-dimension-user_login | simstudioai |
| octolytics-dimension-repository_id | 912559512 |
| octolytics-dimension-repository_nwo | simstudioai/sim |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 912559512 |
| octolytics-dimension-repository_network_root_nwo | simstudioai/sim |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | f567cf3af46b50a3211fb5dab569a9d6a7b58025 |
| ui-target | canary-2 |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width