René's URL Explorer Experiment


Title: fix(ci): treat an unreadable cache size as unstable when settling by waleedlatif1 · Pull Request #7274 · simstudioai/sim · GitHub

Open Graph Title: fix(ci): treat an unreadable cache size as unstable when settling by waleedlatif1 · Pull Request #7274 · simstudioai/sim

X Title: fix(ci): treat an unreadable cache size as unstable when settling by waleedlatif1 · Pull Request #7274 · simstudioai/sim

Description: Summary cubic flagged this on #7273 and it's correct. Verified rather than taken on trust. The settle loop initialises prev='', and since 4795d0426f made total() return empty on failure, two consecutive failed buildctl du reads compare equal and trip the stability counter: du always failing -> loop exited after 2 iterations (of a possible 60) So the loop gives up after ~2s instead of its 120s bound — precisely when du is failing and the prune is most likely still deleting, which is the exact case the wait exists to cover. Handing back early there risks the builder post-step SIGKILLing buildkitd and skipping the sticky disk commit. Why guarding on non-empty is the right fix, with no downside An empty reading can only mean du failed. buildctl prints its Total: line unconditionally — cmd/buildctl/diskusage.go:161, outside any branch: fmt.Fprintf(tw, "Reclaimable:\t%.2f\n", units.Bytes(reclaimable)) fmt.Fprintf(tw, "Total:\t%.2f\n", units.Bytes(total)) So a genuinely empty cache still reports Total: 0B and settles normally. There's no risk of adding 120s to builds with a cold cache — which was the obvious objection to this fix. Confirmed across all three paths: du behaviour iterations before exit always fails 60 (waits the full bound) steady value 3 empty cache (Total: 0B) 3 Severity Lower than P1 in practice: since #7252 the step can't fail a build, so the consequence is a possibly-skipped disk commit — one run's cache lost, not a red build. But the logic is plainly wrong and the fix is one condition, so it's worth taking before promotion. Type of Change Bug fix Testing Reproduced the early exit and verified the fix under the exact shell flags GitHub uses (bash -e -o pipefail), across failing / steady / empty-cache readings. shellcheck clean, actionlint unchanged from baseline (13 pre-existing), bun run lint and all 39 check:audits pass. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary cubic flagged this on #7273 and it's correct. Verified rather than taken on trust. The settle loop initialises prev='', and since 4795d0426f made total() return empty on failure...

X Description: Summary cubic flagged this on #7273 and it's correct. Verified rather than taken on trust. The settle loop initialises prev='', and since 4795d0426f made total() return empt...

Opengraph URL: https://github.com/simstudioai/sim/pull/7274

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:d57a05ec-7dec-10cc-52a4-4eecce4891e6
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAB1E:2FF5E0:1CF63F2:2737B13:6AFB99D1
html-safe-nonce4e0914a2d68d17f574ed38819737e5d1d59af5383dbd9ee3f6d8806bfe67184e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQjFFOjJGRjVFMDoxQ0Y2M0YyOjI3MzdCMTM6NkFGQjk5RDEiLCJ2aXNpdG9yX2lkIjoiNjQ5NjMxMzY5MjU2NzM0NTYxNyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac8a873f40ed086666c9ffe18916f728f9bae0bc9ac99ac9139882e2ea55d68f7e
hovercard-subject-tagpull_request:4390521949
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/7274/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary cubic flagged this on #7273 and it's correct. Verified rather than taken on trust. The settle loop initialises prev='', and since 4795d0426f made total() return empty on failure...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None3cefd19a936819d82cfb5279d50fb56fe79cb9ec30f0f807e04e89b0c58ffae1
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release606800bdb1b81d125fc845bdcc262c9fe063fc8f
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/7274/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F7274%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F7274%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/7274/files
Reloadhttps://github.com/simstudioai/sim/pull/7274/files
Reloadhttps://github.com/simstudioai/sim/pull/7274/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests199 (199)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
ci/settle-loop-treat-empty-du-as-unstablehttps://github.com/simstudioai/sim/tree/ci/settle-loop-treat-empty-du-as-unstable
Conversation 2 https://github.com/simstudioai/sim/pull/7274
Commits 1 https://github.com/simstudioai/sim/pull/7274/commits
Checks 27 https://github.com/simstudioai/sim/pull/7274/checks
Files changed https://github.com/simstudioai/sim/pull/7274/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/7274/files
fix(ci): treat an unreadable cache size as unstable when settling https://github.com/simstudioai/sim/pull/7274/files#top
Show all changes 1 commit https://github.com/simstudioai/sim/pull/7274/files
8cfd307 fix(ci): treat an unreadable cache size as unstable when settling waleedlatif1 Aug 29, 2026 https://github.com/simstudioai/sim/pull/7274/commits/8cfd3078132b25146b31555c65aa8855d19feb58
Clear filters https://github.com/simstudioai/sim/pull/7274/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/7274/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/7274/files
.github/actions/docker-build/action.ymlhttps://github.com/simstudioai/sim/pull/7274/files#diff-f1d084efa26a0f0f45c8ba872e6dc750a73daca60a47dfa42121b28eda7e32b3
View file https://github.com/simstudioai/sim/blob/8cfd3078132b25146b31555c65aa8855d19feb58/.github/actions/docker-build/action.yml
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/7274/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/7274/files#diff-f1d084efa26a0f0f45c8ba872e6dc750a73daca60a47dfa42121b28eda7e32b3
https://github.com/simstudioai/sim/pull/7274/files#diff-f1d084efa26a0f0f45c8ba872e6dc750a73daca60a47dfa42121b28eda7e32b3
Please reload this pagehttps://github.com/simstudioai/sim/pull/7274/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.