René's URL Explorer Experiment


Title: test(tools): type the path-safety harnesses instead of erasing with any by waleedlatif1 · Pull Request #7270 · simstudioai/sim · GitHub

Open Graph Title: test(tools): type the path-safety harnesses instead of erasing with any by waleedlatif1 · Pull Request #7270 · simstudioai/sim

X Title: test(tools): type the path-safety harnesses instead of erasing with any by waleedlatif1 · Pull Request #7270 · simstudioai/sim

Description: These two files are the template every service copied during the path-hardening sweep, and both open with: type AnyTool = ToolConfig // ... return new URL(url(buildParams(tool, value) as any)).pathname CLAUDE.md forbids any outright ("No any — use proper types or unknown with type guards"). Because these are the template, the violation propagated into ten in-flight PRs before review caught it there. Fixing the source stops the next copy inheriting it. Why the obvious repair doesn't compile Swapping in ToolConfig, ToolResponse> on its own fails across the whole barrel union: Type '(params: VercelAddProjectDomainParams) => string' is not assignable to type '(params: Record) => string' ToolConfig takes its param type in the contravariant position of request.url, so no concrete member is assignable to the widened alias. And filter's type-predicate overload intersects rather than replaces, so filtering the union directly leaves the mismatch standing. Seeding the enumeration as Object.values(...) makes the existing isVercelTool / isDaytonaTool predicate the single narrowing point — the unknown-plus-type-guard form the guidelines actually prescribe — and removes the need for a cast at the call site entirely. These files have no type coverage in CI Worth recording, because it is why the pattern survived: apps/sim/tsconfig.json excludes **/*.test.ts, and vitest does not typecheck. So neither direction would have flagged this. I verified with a temporary tsconfig lifting the exclusion, and confirmed via --listFiles that both files were genuinely in the program — an empty program also reports zero errors, which is an easy way to fool yourself here. Zero errors in both. That config was not committed. Checks vitest run tools/vercel tools/daytona — 1129 pass, identical to before (pure typing change, no behavioural effect) bun run lint — clean bun run check:audits — 39/39 check-block-registry.ts origin/staging — pass Type-check with the test exclusion lifted — zero errors in both harnesses

Open Graph Description: These two files are the template every service copied during the path-hardening sweep, and both open with: type AnyTool = ToolConfig<any, any> // ... return new URL(url(buildParams(tool, valu...

X Description: These two files are the template every service copied during the path-hardening sweep, and both open with: type AnyTool = ToolConfig&lt;any, any&gt; // ... return new URL(url(buildParams(to...

Opengraph URL: https://github.com/simstudioai/sim/pull/7270

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:86537f00-262b-ff4c-6f9e-bd32597bdd13
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD1BC:1C967A:16AAA:1F6EC:6AFB8542
html-safe-noncec5af768d97faa1903509cef3c9b89d0a5acbc1248d34a1ec48e9c29e5e377bfe
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMUJDOjFDOTY3QToxNkFBQToxRjZFQzo2QUZCODU0MiIsInZpc2l0b3JfaWQiOiI4MTY5OTQzNTIwMTc0MTE0MTE0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac37af6dccde87b188393dff51c90b227c1e4f739e01170f657e137bdb868eb11e
hovercard-subject-tagpull_request:4390026988
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/7270/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altThese two files are the template every service copied during the path-hardening sweep, and both open with: type AnyTool = ToolConfig<any, any> // ... return new URL(url(buildParams(tool, valu...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneef32892d4269fb87b55e81cc4ba8d86e0f16aa28446ffbf46cba8be5179ab188
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasebc3703b4dcbe820d1284ef63c88b001c850be25e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/7270/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F7270%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F7270%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/7270/files
Reloadhttps://github.com/simstudioai/sim/pull/7270/files
Reloadhttps://github.com/simstudioai/sim/pull/7270/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests199 (199)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/path-safety-harness-typinghttps://github.com/simstudioai/sim/tree/fix/path-safety-harness-typing
Conversation 2 https://github.com/simstudioai/sim/pull/7270
Commits 1 https://github.com/simstudioai/sim/pull/7270/commits
Checks 27 https://github.com/simstudioai/sim/pull/7270/checks
Files changed https://github.com/simstudioai/sim/pull/7270/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/7270/files
test(tools): type the path-safety harnesses instead of erasing with any https://github.com/simstudioai/sim/pull/7270/files#top
Show all changes 1 commit https://github.com/simstudioai/sim/pull/7270/files
a585174 test(tools): type the path-safety harnesses instead of erasing with any waleedlatif1 Aug 29, 2026 https://github.com/simstudioai/sim/pull/7270/commits/a5851741cfd502496437cfb8ffc831b133769246
Clear filters https://github.com/simstudioai/sim/pull/7270/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/7270/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/7270/files
sandbox_path_safety.test.ts https://github.com/simstudioai/sim/pull/7270/files#diff-5506fe2ba4a06f446d7a831efd9260268cb2405f55fab1c16ef27851e7bf2377
edge_config_path_safety.test.ts https://github.com/simstudioai/sim/pull/7270/files#diff-784354f5e4ab9a3a1fdde8b29aec547f3f807ead83bd7a7ae046bd8dbf787d74
apps/sim/tools/daytona/sandbox_path_safety.test.tshttps://github.com/simstudioai/sim/pull/7270/files#diff-5506fe2ba4a06f446d7a831efd9260268cb2405f55fab1c16ef27851e7bf2377
View file https://github.com/simstudioai/sim/blob/a5851741cfd502496437cfb8ffc831b133769246/apps/sim/tools/daytona/sandbox_path_safety.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/7270/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/7270/files#diff-5506fe2ba4a06f446d7a831efd9260268cb2405f55fab1c16ef27851e7bf2377
https://github.com/simstudioai/sim/pull/7270/files#diff-5506fe2ba4a06f446d7a831efd9260268cb2405f55fab1c16ef27851e7bf2377
https://github.com/simstudioai/sim/pull/7270/files#diff-5506fe2ba4a06f446d7a831efd9260268cb2405f55fab1c16ef27851e7bf2377
https://github.com/simstudioai/sim/pull/7270/files#diff-5506fe2ba4a06f446d7a831efd9260268cb2405f55fab1c16ef27851e7bf2377
https://github.com/simstudioai/sim/pull/7270/files#diff-5506fe2ba4a06f446d7a831efd9260268cb2405f55fab1c16ef27851e7bf2377
https://github.com/simstudioai/sim/pull/7270/files#diff-5506fe2ba4a06f446d7a831efd9260268cb2405f55fab1c16ef27851e7bf2377
apps/sim/tools/vercel/edge_config_path_safety.test.tshttps://github.com/simstudioai/sim/pull/7270/files#diff-784354f5e4ab9a3a1fdde8b29aec547f3f807ead83bd7a7ae046bd8dbf787d74
View file https://github.com/simstudioai/sim/blob/a5851741cfd502496437cfb8ffc831b133769246/apps/sim/tools/vercel/edge_config_path_safety.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/7270/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/7270/files#diff-784354f5e4ab9a3a1fdde8b29aec547f3f807ead83bd7a7ae046bd8dbf787d74
https://github.com/simstudioai/sim/pull/7270/files#diff-784354f5e4ab9a3a1fdde8b29aec547f3f807ead83bd7a7ae046bd8dbf787d74
https://github.com/simstudioai/sim/pull/7270/files#diff-784354f5e4ab9a3a1fdde8b29aec547f3f807ead83bd7a7ae046bd8dbf787d74
https://github.com/simstudioai/sim/pull/7270/files#diff-784354f5e4ab9a3a1fdde8b29aec547f3f807ead83bd7a7ae046bd8dbf787d74
https://github.com/simstudioai/sim/pull/7270/files#diff-784354f5e4ab9a3a1fdde8b29aec547f3f807ead83bd7a7ae046bd8dbf787d74
https://github.com/simstudioai/sim/pull/7270/files#diff-784354f5e4ab9a3a1fdde8b29aec547f3f807ead83bd7a7ae046bd8dbf787d74
Please reload this pagehttps://github.com/simstudioai/sim/pull/7270/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.