René's URL Explorer Experiment


Title: fix(browser): harden desktop tool lifecycle by waleedlatif1 · Pull Request #7253 · simstudioai/sim · GitHub

Open Graph Title: fix(browser): harden desktop tool lifecycle by waleedlatif1 · Pull Request #7253 · simstudioai/sim

X Title: fix(browser): harden desktop tool lifecycle by waleedlatif1 · Pull Request #7253 · simstudioai/sim

Description: Summary harden desktop browser authorization, exact cancellation, wait-budget consistency, and current-versus-retired tool boundaries preserve known native outcomes across renderer unloads with compact beacon and keepalive delivery while marking genuinely indeterminate actions as unsafe to retry add privacy-safe queue/execution observability and remove an extra screenshot viewport round trip expand focused coverage for lifecycle races, authorization stalls, protocol drift, cross-frame effects, invalid input, and unload delivery Type of Change Bug fix New feature Breaking change Documentation Other: ___________ Testing bun run lint and bun run lint:check bun run check:audits (39 audits) Sim focused Vitest suite: 8 files, 200 tests Desktop focused Vitest suite: 3 files, 193 tests TypeScript: @sim/app, @sim/desktop, @sim/browser-protocol, @sim/desktop-bridge Desktop bridge compatibility audit git diff --check Review focus: native execution versus confirmation-delivery lifecycle, exact cancellation scoping, timeout hierarchy, and current/retired browser tool classification. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA) Screenshots/Videos N/A — no UI changes.

Open Graph Description: Summary harden desktop browser authorization, exact cancellation, wait-budget consistency, and current-versus-retired tool boundaries preserve known native outcomes across renderer unloads with co...

X Description: Summary harden desktop browser authorization, exact cancellation, wait-budget consistency, and current-versus-retired tool boundaries preserve known native outcomes across renderer unloads with co...

Opengraph URL: https://github.com/simstudioai/sim/pull/7253

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:96f6148b-3500-b8d7-133f-a12b180463c5
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC8BA:345450:1614BCF:1E5074C:6AFB8178
html-safe-nonce877f80d6978fdcd4b28ae1ffb5466ab2581d57d6715946a6683395b5d15dd6f4
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDOEJBOjM0NTQ1MDoxNjE0QkNGOjFFNTA3NEM6NkFGQjgxNzgiLCJ2aXNpdG9yX2lkIjoiNTIxNzIwODQ3MTE2NTU2NzM1MiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac9c0e4c29c4f4a901aaa2c64a140fb038e239c509f591ea887adecaad00677a78
hovercard-subject-tagpull_request:4389549822
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/7253/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary harden desktop browser authorization, exact cancellation, wait-budget consistency, and current-versus-retired tool boundaries preserve known native outcomes across renderer unloads with co...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneef32892d4269fb87b55e81cc4ba8d86e0f16aa28446ffbf46cba8be5179ab188
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasebc3703b4dcbe820d1284ef63c88b001c850be25e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/7253/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F7253%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F7253%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/7253/files
Reloadhttps://github.com/simstudioai/sim/pull/7253/files
Reloadhttps://github.com/simstudioai/sim/pull/7253/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests199 (199)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
codex/desktop-browser-reliabilityhttps://github.com/simstudioai/sim/tree/codex/desktop-browser-reliability
Conversation 40 https://github.com/simstudioai/sim/pull/7253
Commits 5 https://github.com/simstudioai/sim/pull/7253/commits
Checks 30 https://github.com/simstudioai/sim/pull/7253/checks
Files changed https://github.com/simstudioai/sim/pull/7253/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/7253/files
fix(browser): harden desktop tool lifecycle https://github.com/simstudioai/sim/pull/7253/files#top
Show all changes 5 commits https://github.com/simstudioai/sim/pull/7253/files
6559c3b fix(browser): harden desktop tool lifecycle waleedlatif1 Aug 29, 2026 https://github.com/simstudioai/sim/pull/7253/commits/6559c3b03865d21470adc6bf43c3386377688455
bd911ae fix(browser): preserve screenshot coordinate contract waleedlatif1 Aug 29, 2026 https://github.com/simstudioai/sim/pull/7253/commits/bd911ae4621a39a5f6e1d8868e7d32e579c08809
7ce00c9 fix(browser): close native execution races waleedlatif1 Aug 29, 2026 https://github.com/simstudioai/sim/pull/7253/commits/7ce00c9e0dbd4f0a215f85f9c5ca2fbce31c9c32
5db71b8 fix(browser): reconcile native unload claims waleedlatif1 Aug 29, 2026 https://github.com/simstudioai/sim/pull/7253/commits/5db71b89e40131cc8e1b54d5c18c3fbae57f0edc
b1aabef fix(copilot): interrupt pending tool waits on stop waleedlatif1 Aug 29, 2026 https://github.com/simstudioai/sim/pull/7253/commits/b1aabef30d8ff73bcf2f17b73329dd89ab1c63d9
Clear filters https://github.com/simstudioai/sim/pull/7253/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/7253/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/7253/files
cdp.test.ts https://github.com/simstudioai/sim/pull/7253/files#diff-5c99463d5fbb5f5a8d4c7d7b2b621e8fd2ef38db866cff2a75a92fd65859a5c6
cdp.ts https://github.com/simstudioai/sim/pull/7253/files#diff-20197f234b92c7c1c2b522668174347c28d21a740fb487409f3b3637a423473c
driver.test.ts https://github.com/simstudioai/sim/pull/7253/files#diff-e3f3e254574c9ace38cf400e9ef8600989b25e602629bb7e6c7e4927a27830c5
driver.ts https://github.com/simstudioai/sim/pull/7253/files#diff-515694ac7beaa3b13cb8b2224e3c5ec946ddc589bf9d8c294986e76a8c270ed6
ipc.test.ts https://github.com/simstudioai/sim/pull/7253/files#diff-99b75f363352285b31a5126e14f02639f69bec3d740d21e1a5f2a25d400618d3
ipc.ts https://github.com/simstudioai/sim/pull/7253/files#diff-a471b27e653d39114f9a737b0741f68dc1a6f36f3830e9454fd4e00704e24727
route.test.ts https://github.com/simstudioai/sim/pull/7253/files#diff-d4266de90811526cac807b27cb5287d59701900fcf22945eb3ea39f03dda6ddd
route.ts https://github.com/simstudioai/sim/pull/7253/files#diff-313c8d66f5de9ec050dacd52e247241e4acb4f0163d8ca50bd009f7b3ecc29fc
route.test.ts https://github.com/simstudioai/sim/pull/7253/files#diff-9b0cb9be4bd64f7aeef0a96cf22bfd26cd4ead9e4965d11bf2aa94ef9e718232
route.ts https://github.com/simstudioai/sim/pull/7253/files#diff-c0a963b3b1c2ea48a43bd00264d2615204d133fc0936ac88cef8f89e2e3abdfa
handle-tool-event.ts https://github.com/simstudioai/sim/pull/7253/files#diff-29efcffd44cdd85babf6f9011ba407877c63779e3769d5b299aace99bd2e0627
use-chat.ts https://github.com/simstudioai/sim/pull/7253/files#diff-1a0584ccf9cc4bacd55ce19aeeea8d807c39f36c365fa5b6638587aad38c700d
transport.test.ts https://github.com/simstudioai/sim/pull/7253/files#diff-6322334dd92b325e071419833d12721ddec33fabf43102c176f166bbe69dc133
transport.ts https://github.com/simstudioai/sim/pull/7253/files#diff-44d25214597d119db0a51cd817d492f024773b0b91cc31f39912a60ff781c5d7
lifecycle.ts https://github.com/simstudioai/sim/pull/7253/files#diff-fe47fafc0ccd0e11f25aec293e470243026a357d078dee0f7ece4701c40ab5c7
repository.test.ts https://github.com/simstudioai/sim/pull/7253/files#diff-3009f183ec816a38c161a9bd571fc89e80ca17d0f9ccb733c65c1b9ede622978
repository.ts https://github.com/simstudioai/sim/pull/7253/files#diff-4a565dc785c6c225203feb6a7de3e996ef7cc054cd0a2e7b7505552e3f6f9bda
handlers.test.ts https://github.com/simstudioai/sim/pull/7253/files#diff-427b9c6830a8d4e75f56c36707391bc74cdf9e673017a5f6a93585c244db46ae
tool.ts https://github.com/simstudioai/sim/pull/7253/files#diff-107038219f6fe0643c3b3d6b65aef176242e7ae24989bcac88cd8a64974c6315
run.test.ts https://github.com/simstudioai/sim/pull/7253/files#diff-457fd9a841c4f02b4b712db89e28cbbae24e4cbed618531fb24f11e557aee857
run.ts https://github.com/simstudioai/sim/pull/7253/files#diff-8f9401002646f526b4435f2f4c8c1ad3cc2a433c924658ec60ada947d95fc1c5
executor.test.ts https://github.com/simstudioai/sim/pull/7253/files#diff-7539d2e1e1a23e035c0b4aada8a99a35520a8afe81c7a358f94c7fb69cf96185
executor.ts https://github.com/simstudioai/sim/pull/7253/files#diff-055301ea08ccdebe72fc75f6a483db681d15088e4f77e56358000f3575e065d6
browser-protocol-contract.test.ts https://github.com/simstudioai/sim/pull/7253/files#diff-6de2645a39f5898beeac45e92b16ef2835e344989a989c076a61901a01b399ba
browser-tool-execution.test.ts https://github.com/simstudioai/sim/pull/7253/files#diff-3271206242afa804a428f4501c756fce54c2bb3d9767889c490b96c26167ecd2
browser-tool-execution.ts https://github.com/simstudioai/sim/pull/7253/files#diff-a6e4f0215cd5bfde0ac2788c416fcf9bdd3b8483b3441d94182af52e23530ea6
completion.test.ts https://github.com/simstudioai/sim/pull/7253/files#diff-af6dfdb620afdc9bb9da3e6ab8c8600f2545bd39b44284b66d3c5cd1861c7d18
completion.ts https://github.com/simstudioai/sim/pull/7253/files#diff-99625df660d1826fc6235df02e2540d752b8bb10970f96ed6f683bbc52c83d1a
terminal-tool-execution.test.ts https://github.com/simstudioai/sim/pull/7253/files#diff-4a99f998a605c49bb7a5014d791dfc1ea5c0777d8b90d2d72133ea85f9fb4cd1
terminal-tool-execution.ts https://github.com/simstudioai/sim/pull/7253/files#diff-651af5c78e1db300adcd2cd9e23c60c8354ea7a763a1a843695e9fcdc2a6db4e
index.ts https://github.com/simstudioai/sim/pull/7253/files#diff-7bf024cc51a5498c6b4d087358740c2011c9d5ea86c03391bd1d4623026224d3
contract-snapshot.ts https://github.com/simstudioai/sim/pull/7253/files#diff-7cb6f5cdcae75b0465f21435e253b861732a836c066236641d7d8fd626870641
apps/desktop/src/main/browser-agent/cdp.test.tshttps://github.com/simstudioai/sim/pull/7253/files#diff-5c99463d5fbb5f5a8d4c7d7b2b621e8fd2ef38db866cff2a75a92fd65859a5c6
View file https://github.com/simstudioai/sim/blob/b1aabef30d8ff73bcf2f17b73329dd89ab1c63d9/apps/desktop/src/main/browser-agent/cdp.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/7253/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/7253/files#diff-5c99463d5fbb5f5a8d4c7d7b2b621e8fd2ef38db866cff2a75a92fd65859a5c6
https://github.com/simstudioai/sim/pull/7253/files#diff-5c99463d5fbb5f5a8d4c7d7b2b621e8fd2ef38db866cff2a75a92fd65859a5c6
apps/desktop/src/main/browser-agent/cdp.tshttps://github.com/simstudioai/sim/pull/7253/files#diff-20197f234b92c7c1c2b522668174347c28d21a740fb487409f3b3637a423473c
View file https://github.com/simstudioai/sim/blob/b1aabef30d8ff73bcf2f17b73329dd89ab1c63d9/apps/desktop/src/main/browser-agent/cdp.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/7253/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/7253/files#diff-20197f234b92c7c1c2b522668174347c28d21a740fb487409f3b3637a423473c
https://github.com/simstudioai/sim/pull/7253/files#diff-20197f234b92c7c1c2b522668174347c28d21a740fb487409f3b3637a423473c
Please reload this pagehttps://github.com/simstudioai/sim/pull/7253/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/7253/files
https://github.com/simstudioai/sim/pull/7253/files#diff-20197f234b92c7c1c2b522668174347c28d21a740fb487409f3b3637a423473c
Please reload this pagehttps://github.com/simstudioai/sim/pull/7253/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/7253/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.