René's URL Explorer Experiment


Title: fix(ci): stop the layer-cache prune from being able to fail a build by waleedlatif1 · Pull Request #7252 · simstudioai/sim · GitHub

Open Graph Title: fix(ci): stop the layer-cache prune from being able to fail a build by waleedlatif1 · Pull Request #7252 · simstudioai/sim

X Title: fix(ci): stop the layer-cache prune from being able to fail a build by waleedlatif1 · Pull Request #7252 · simstudioai/sim

Description: Summary The settle loop added in 4f651038f3 reads cur="$(total)". Composite steps run under bash -e -o pipefail, where an assignment takes its command substitution's exit status — so any failing buildctl du aborts the step and fails the build. Reproduced directly: set -e -o pipefail total() { false | grep -iE '^total:' | tr -s ' ' ' '; } echo "echo form: $(total)" # survives cur="$(total)" # ABORTS, exit 1 That asymmetry is why it was invisible: the echo "$(total)" calls run first and survive, and only the assignment inside the settle loop trips it. Not hypothetical. Deleting a sticky disk out from under a running job makes buildkitd panic inside cache.(*cacheManager).DiskUsage, and it took a Build AMD64 job down exactly this way: panic: runtime error: invalid memory address or nil pointer dereference github.com/moby/buildkit/cache.(*cacheManager).DiskUsage(...) grep also exits 1 whenever du prints no Total: line, so a genuinely empty cache would have done it too. Fix total() now always returns 0. Cache hygiene must never be able to fail a deploy. The prune's own failure was already handled correctly — it sits in an if condition, and a failing condition does not trip -e. Verification Reproduced the abort and confirmed the fix under the exact shell flags GitHub uses (bash -e -o pipefail): the settle loop now completes with a totally failing du. shellcheck clean; actionlint identical to the staging baseline; bun run lint passes. Type of Change Bug fix Testing Shell-level reproduction of both the failure and the fix, as above. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary The settle loop added in 4f651038f3 reads cur="$(total)". Composite steps run under bash -e -o pipefail, where an assignment takes its command substitution's exit status — so ...

X Description: Summary The settle loop added in 4f651038f3 reads cur="$(total)". Composite steps run under bash -e -o pipefail, where an assignment takes its command substitution's exit ...

Opengraph URL: https://github.com/simstudioai/sim/pull/7252

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:e071324e-c274-6e72-a917-3ec661065999
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAD52:2F2AB3:1987BF2:22CCF4F:6AFB8997
html-safe-nonce3adfa43574be8638ef9096d125077f9640a09be157880d4658c9ac6fd39dda93
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRDUyOjJGMkFCMzoxOTg3QkYyOjIyQ0NGNEY6NkFGQjg5OTciLCJ2aXNpdG9yX2lkIjoiNTMyNTU0MzEwMjc0MjIzNTU0MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmaccbf59cfed72ab9adc60123ccb3838349202b7e4e5721f014fe37545f63c61cfc
hovercard-subject-tagpull_request:4389530646
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/7252/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary The settle loop added in 4f651038f3 reads cur="$(total)". Composite steps run under bash -e -o pipefail, where an assignment takes its command substitution's exit status — so ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None9694464143465782ecae2a97650b2a2b0708d5c31c74f41ee86da57e315e2735
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release05d967182208691fc7f2e6af52e82fa7fabf6bd5
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/7252/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F7252%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F7252%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/7252/files
Reloadhttps://github.com/simstudioai/sim/pull/7252/files
Reloadhttps://github.com/simstudioai/sim/pull/7252/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests198 (198)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
ci/prune-step-must-never-fail-a-buildhttps://github.com/simstudioai/sim/tree/ci/prune-step-must-never-fail-a-build
Conversation 2 https://github.com/simstudioai/sim/pull/7252
Commits 1 https://github.com/simstudioai/sim/pull/7252/commits
Checks 27 https://github.com/simstudioai/sim/pull/7252/checks
Files changed https://github.com/simstudioai/sim/pull/7252/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/7252/files
fix(ci): stop the layer-cache prune from being able to fail a build https://github.com/simstudioai/sim/pull/7252/files#top
Show all changes 1 commit https://github.com/simstudioai/sim/pull/7252/files
a2c3871 fix(ci): stop the layer-cache prune from being able to fail a build waleedlatif1 Aug 29, 2026 https://github.com/simstudioai/sim/pull/7252/commits/a2c387129009c116e7af4901b5d8b1b9328cd7cb
Clear filters https://github.com/simstudioai/sim/pull/7252/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/7252/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/7252/files
.github/actions/docker-build/action.ymlhttps://github.com/simstudioai/sim/pull/7252/files#diff-f1d084efa26a0f0f45c8ba872e6dc750a73daca60a47dfa42121b28eda7e32b3
View file https://github.com/simstudioai/sim/blob/a2c387129009c116e7af4901b5d8b1b9328cd7cb/.github/actions/docker-build/action.yml
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/7252/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/7252/files#diff-f1d084efa26a0f0f45c8ba872e6dc750a73daca60a47dfa42121b28eda7e32b3
https://github.com/simstudioai/sim/pull/7252/files#diff-f1d084efa26a0f0f45c8ba872e6dc750a73daca60a47dfa42121b28eda7e32b3
Please reload this pagehttps://github.com/simstudioai/sim/pull/7252/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.