René's URL Explorer Experiment


Title: fix(execution): release the lease when abort races an undetermined acquisition by waleedlatif1 · Pull Request #7237 · simstudioai/sim · GitHub

Open Graph Title: fix(execution): release the lease when abort races an undetermined acquisition by waleedlatif1 · Pull Request #7237 · simstudioai/sim

X Title: fix(execution): release the lease when abort races an undetermined acquisition by waleedlatif1 · Pull Request #7237 · simstudioai/sim

Description: Summary The cancellation return for an aborted execution ran before releaseLease was declared, so it exited without releasing the distributed owner lease. An undetermined acquisition can still be registered by Redis after the deadline abandons the local wait. Aborting in that window left the member counted against the owner for the whole TTL, denying later executions that had capacity — the same failure the fallback change set out to remove, on the one exit path that missed it. Declared the release before the early returns so every exit path that can leave a registration behind reaches it, and call it on the cancellation path. The over-limit return still skips the release deliberately: the script answers that before its ZADD, so nothing was ever registered. Noted inline so it is not "corrected" later. Type of Change Bug fix Testing vitest run lib/execution/isolated-vm.test.ts — 16 passing, including a new case asserting that an abort racing an undetermined acquisition still issues the release. Verified it fails against the previous behavior while the existing over-limit abort case keeps passing. bun run type-check, bun run lint, and bun run check:audits (39 audits) pass. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary The cancellation return for an aborted execution ran before releaseLease was declared, so it exited without releasing the distributed owner lease. An undetermined acquisition can still be ...

X Description: Summary The cancellation return for an aborted execution ran before releaseLease was declared, so it exited without releasing the distributed owner lease. An undetermined acquisition can still be ...

Opengraph URL: https://github.com/simstudioai/sim/pull/7237

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:55de7be4-a5cf-5ffe-d43c-1d11ddfb37a0
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC6BC:C6293:332DF9:47C516:6AFB719B
html-safe-nonceaf7b4ca5160027bc85e0dc8c16c5e192de9ae928787daf727e7d9a91048e28e4
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNkJDOkM2MjkzOjMzMkRGOTo0N0M1MTY6NkFGQjcxOUIiLCJ2aXNpdG9yX2lkIjoiNDQxNzg3NDYyODg1MjgwNjA0MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac9f4278681092f253efbb436b8ee6f7e29585168e2a7f33060d207d155b1423b3
hovercard-subject-tagpull_request:4388740904
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/7237/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary The cancellation return for an aborted execution ran before releaseLease was declared, so it exited without releasing the distributed owner lease. An undetermined acquisition can still be ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None0e29e7974fdda2feeaf5c891efd4b23b0734b23480232b62c7bdef13f40b5b48
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2e8872b770cc4d5d0cc1f2026afab747a268e2ce
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/7237/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F7237%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F7237%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/7237/files
Reloadhttps://github.com/simstudioai/sim/pull/7237/files
Reloadhttps://github.com/simstudioai/sim/pull/7237/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests199 (199)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/lease-release-on-aborthttps://github.com/simstudioai/sim/tree/fix/lease-release-on-abort
Conversation 8 https://github.com/simstudioai/sim/pull/7237
Commits 2 https://github.com/simstudioai/sim/pull/7237/commits
Checks 27 https://github.com/simstudioai/sim/pull/7237/checks
Files changed https://github.com/simstudioai/sim/pull/7237/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/7237/files
fix(execution): release the lease when abort races an undetermined acquisition https://github.com/simstudioai/sim/pull/7237/files#top
Show all changes 2 commits https://github.com/simstudioai/sim/pull/7237/files
2422e53 fix(execution): release the lease when abort races an undetermined ac… waleedlatif1 Aug 28, 2026 https://github.com/simstudioai/sim/pull/7237/commits/2422e53e451082e93a299b80176e77636623d74a
5a2f0e3 fix(execution): keep the over-limit abort path release-free waleedlatif1 Aug 28, 2026 https://github.com/simstudioai/sim/pull/7237/commits/5a2f0e34880da7611a4e6adcaac75cf402b4cf4b
Clear filters https://github.com/simstudioai/sim/pull/7237/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/7237/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/7237/files
isolated-vm.test.ts https://github.com/simstudioai/sim/pull/7237/files#diff-cca5d4229bd1b25b51748fd0146db9d71a2715d1548afc28ef1de5cb2040e52c
isolated-vm.ts https://github.com/simstudioai/sim/pull/7237/files#diff-5fe160ac7ca1719ee4f36cffcac0c31ca50b0ef42c7f62223414e56ee9aa2626
apps/sim/lib/execution/isolated-vm.test.tshttps://github.com/simstudioai/sim/pull/7237/files#diff-cca5d4229bd1b25b51748fd0146db9d71a2715d1548afc28ef1de5cb2040e52c
View file https://github.com/simstudioai/sim/blob/5a2f0e34880da7611a4e6adcaac75cf402b4cf4b/apps/sim/lib/execution/isolated-vm.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/7237/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/7237/files#diff-cca5d4229bd1b25b51748fd0146db9d71a2715d1548afc28ef1de5cb2040e52c
https://github.com/simstudioai/sim/pull/7237/files#diff-cca5d4229bd1b25b51748fd0146db9d71a2715d1548afc28ef1de5cb2040e52c
https://github.com/simstudioai/sim/pull/7237/files#diff-cca5d4229bd1b25b51748fd0146db9d71a2715d1548afc28ef1de5cb2040e52c
https://github.com/simstudioai/sim/pull/7237/files#diff-cca5d4229bd1b25b51748fd0146db9d71a2715d1548afc28ef1de5cb2040e52c
https://github.com/simstudioai/sim/pull/7237/files#diff-cca5d4229bd1b25b51748fd0146db9d71a2715d1548afc28ef1de5cb2040e52c
apps/sim/lib/execution/isolated-vm.tshttps://github.com/simstudioai/sim/pull/7237/files#diff-5fe160ac7ca1719ee4f36cffcac0c31ca50b0ef42c7f62223414e56ee9aa2626
View file https://github.com/simstudioai/sim/blob/5a2f0e34880da7611a4e6adcaac75cf402b4cf4b/apps/sim/lib/execution/isolated-vm.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/7237/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/7237/files#diff-5fe160ac7ca1719ee4f36cffcac0c31ca50b0ef42c7f62223414e56ee9aa2626
https://github.com/simstudioai/sim/pull/7237/files#diff-5fe160ac7ca1719ee4f36cffcac0c31ca50b0ef42c7f62223414e56ee9aa2626
https://github.com/simstudioai/sim/pull/7237/files#diff-5fe160ac7ca1719ee4f36cffcac0c31ca50b0ef42c7f62223414e56ee9aa2626
https://github.com/simstudioai/sim/pull/7237/files#diff-5fe160ac7ca1719ee4f36cffcac0c31ca50b0ef42c7f62223414e56ee9aa2626
Please reload this pagehttps://github.com/simstudioai/sim/pull/7237/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.