René's URL Explorer Experiment


Title: feat(observability): record Redis connection state on failed slot operations by waleedlatif1 · Pull Request #7194 · simstudioai/sim · GitHub

Open Graph Title: feat(observability): record Redis connection state on failed slot operations by waleedlatif1 · Pull Request #7194 · simstudioai/sim

X Title: feat(observability): record Redis connection state on failed slot operations by waleedlatif1 · Pull Request #7194 · simstudioai/sim

Description: Summary A Redis command that never gets a reply fails identically in three very different situations, and nothing we record distinguishes them: Situation What we'd want to see Connection still being established status: connecting, non-zero queue depth Reconnecting, command parked in the offline queue status: reconnecting, non-zero queue depth Socket silently dead status: ready, queue depth 0 ioredis reports all three as Error: Command timed out with only its own timer frames in the stack — no app frame naming the call, no lifecycle event saying which happened. Today the cause can only be inferred from timing. Adds describeRedisConnection() — client status, connection and ready ages, offline-queue depth, lifecycle counters (connects/reconnects/errors + last error), and whether the configured host is an IP literal or a DNS name. Attaches it to the usage-reservation slot operations. Those are the first Redis calls a queued workflow makes, so an unusable connection surfaces there first. connect and ready now log elapsed-since-construction, making the wait before a connection becomes usable directly measurable. Today that wait is spent inside a command's deadline, where it reads as a command timeout rather than as connection latency. Extends the shared redisConfigMock, which documents that every export of the real module is present. Why these fields status is usually decisive on its own. queuedCommands confirms it: a command parked in the offline queue was waiting on connection setup, whereas one written to a ready socket that never answered means the socket died without anything reporting it. ioredis has no public accessor for the offline queue, so this reads it through a narrow interface with a double-cast-allowed annotation. hostKind rules DNS resolution in or out. No server-side telemetry can see a slow or retrying resolve — not VPC flow logs, not NLB counters, not cache metrics — so without this it stays a permanent unknown. Security REDIS_URL carries the AUTH token and is never logged. Only derived facts (IP vs DNS, TLS on/off, SNI override in play) are emitted. There's a test asserting the snapshot cannot contain the host, and I verified it fails if the URL is leaked into the payload. Type of Change Observability / diagnostics (no behavior change) Testing No behavior change: this adds a read-only snapshot and log fields. No timeouts, retry policy, or control flow were touched. New tests cover no-client, connecting vs ready, offline-queue depth, lifecycle counting, IP vs DNS classification, and the secret-leak guard. Verified each fails for the right reason — forcing status to a constant breaks the discriminator tests, and leaking the URL into the snapshot breaks the secret test. bun run type-check clean in apps/sim and packages/testing. 3149 tests pass across lib/core, lib/billing, lib/execution, background, plus 40 in packages/testing. bun run lint and all 37 audits pass. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary A Redis command that never gets a reply fails identically in three very different situations, and nothing we record distinguishes them: Situation What we'd want to see Connection...

X Description: Summary A Redis command that never gets a reply fails identically in three very different situations, and nothing we record distinguishes them: Situation What we'd want to see Connec...

Opengraph URL: https://github.com/simstudioai/sim/pull/7194

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:470f7cfb-3b31-8187-32e6-a2e8b50d2728
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idEC82:8BAE:31DC93:466832:6AFB714E
html-safe-nonce8c48e0471725d8828e83a5ed4df73d2fd164c33258ebfe5523791fe3f97ee81e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQzgyOjhCQUU6MzFEQzkzOjQ2NjgzMjo2QUZCNzE0RSIsInZpc2l0b3JfaWQiOiI3NDc5NDAyNzQxMzYyMjkxMDIyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac7903642a3b7aeab3ded11bb10a8309aad979f1bcc19a2a2773502f9cc5fe3e56
hovercard-subject-tagpull_request:4381336358
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/7194/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary A Redis command that never gets a reply fails identically in three very different situations, and nothing we record distinguishes them: Situation What we'd want to see Connection...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None0e29e7974fdda2feeaf5c891efd4b23b0734b23480232b62c7bdef13f40b5b48
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2e8872b770cc4d5d0cc1f2026afab747a268e2ce
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/7194/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F7194%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F7194%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/7194/files
Reloadhttps://github.com/simstudioai/sim/pull/7194/files
Reloadhttps://github.com/simstudioai/sim/pull/7194/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests198 (198)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
observability/redis-connection-diagnosticshttps://github.com/simstudioai/sim/tree/observability/redis-connection-diagnostics
Conversation 17 https://github.com/simstudioai/sim/pull/7194
Commits 1 https://github.com/simstudioai/sim/pull/7194/commits
Checks 27 https://github.com/simstudioai/sim/pull/7194/checks
Files changed https://github.com/simstudioai/sim/pull/7194/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/7194/files
feat(observability): record Redis connection state on failed slot operations https://github.com/simstudioai/sim/pull/7194/files#top
Show all changes 1 commit https://github.com/simstudioai/sim/pull/7194/files
2e58e0d feat(observability): record Redis connection state on failed slot ope… waleedlatif1 Aug 28, 2026 https://github.com/simstudioai/sim/pull/7194/commits/2e58e0dc48467b47e62de3aaa9437424f1f54e70
Clear filters https://github.com/simstudioai/sim/pull/7194/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/7194/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/7194/files
usage-reservation.test.ts https://github.com/simstudioai/sim/pull/7194/files#diff-106ada79a84bc56801c9ae6a3bc5239cd5b09a40061f145769957bb0bbee011d
usage-reservation.ts https://github.com/simstudioai/sim/pull/7194/files#diff-c4a346abbf778d4c42f4af5a8ee905400038541d3055e83b56d3c3d635d3d2b8
redis.test.ts https://github.com/simstudioai/sim/pull/7194/files#diff-c6ad185c1c43eadf2b2ccc55086d0ee0bb12266114edc693d20f1bf9b94da3b5
redis.ts https://github.com/simstudioai/sim/pull/7194/files#diff-af191f255d57cc29ed5bf97c929967b6b922d94d754a7d73abcbf88594b4dc7d
redis-config.mock.ts https://github.com/simstudioai/sim/pull/7194/files#diff-5c638bdef5e048b6f8fbff640cf0dc366a6c1d7452ca8dd4dd3ba5566a3427ca
apps/sim/lib/billing/calculations/usage-reservation.test.tshttps://github.com/simstudioai/sim/pull/7194/files#diff-106ada79a84bc56801c9ae6a3bc5239cd5b09a40061f145769957bb0bbee011d
View file https://github.com/simstudioai/sim/blob/2e58e0dc48467b47e62de3aaa9437424f1f54e70/apps/sim/lib/billing/calculations/usage-reservation.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/7194/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/7194/files#diff-106ada79a84bc56801c9ae6a3bc5239cd5b09a40061f145769957bb0bbee011d
https://github.com/simstudioai/sim/pull/7194/files#diff-106ada79a84bc56801c9ae6a3bc5239cd5b09a40061f145769957bb0bbee011d
apps/sim/lib/billing/calculations/usage-reservation.tshttps://github.com/simstudioai/sim/pull/7194/files#diff-c4a346abbf778d4c42f4af5a8ee905400038541d3055e83b56d3c3d635d3d2b8
View file https://github.com/simstudioai/sim/blob/2e58e0dc48467b47e62de3aaa9437424f1f54e70/apps/sim/lib/billing/calculations/usage-reservation.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/7194/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/7194/files#diff-c4a346abbf778d4c42f4af5a8ee905400038541d3055e83b56d3c3d635d3d2b8
https://github.com/simstudioai/sim/pull/7194/files#diff-c4a346abbf778d4c42f4af5a8ee905400038541d3055e83b56d3c3d635d3d2b8
https://github.com/simstudioai/sim/pull/7194/files#diff-c4a346abbf778d4c42f4af5a8ee905400038541d3055e83b56d3c3d635d3d2b8
https://github.com/simstudioai/sim/pull/7194/files#diff-c4a346abbf778d4c42f4af5a8ee905400038541d3055e83b56d3c3d635d3d2b8
https://github.com/simstudioai/sim/pull/7194/files#diff-c4a346abbf778d4c42f4af5a8ee905400038541d3055e83b56d3c3d635d3d2b8
https://github.com/simstudioai/sim/pull/7194/files#diff-c4a346abbf778d4c42f4af5a8ee905400038541d3055e83b56d3c3d635d3d2b8
https://github.com/simstudioai/sim/pull/7194/files#diff-c4a346abbf778d4c42f4af5a8ee905400038541d3055e83b56d3c3d635d3d2b8
https://github.com/simstudioai/sim/pull/7194/files#diff-c4a346abbf778d4c42f4af5a8ee905400038541d3055e83b56d3c3d635d3d2b8
https://github.com/simstudioai/sim/pull/7194/files#diff-c4a346abbf778d4c42f4af5a8ee905400038541d3055e83b56d3c3d635d3d2b8
apps/sim/lib/core/config/redis.test.tshttps://github.com/simstudioai/sim/pull/7194/files#diff-c6ad185c1c43eadf2b2ccc55086d0ee0bb12266114edc693d20f1bf9b94da3b5
View file https://github.com/simstudioai/sim/blob/2e58e0dc48467b47e62de3aaa9437424f1f54e70/apps/sim/lib/core/config/redis.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/7194/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/7194/files#diff-c6ad185c1c43eadf2b2ccc55086d0ee0bb12266114edc693d20f1bf9b94da3b5
https://github.com/simstudioai/sim/pull/7194/files#diff-c6ad185c1c43eadf2b2ccc55086d0ee0bb12266114edc693d20f1bf9b94da3b5
https://github.com/simstudioai/sim/pull/7194/files#diff-c6ad185c1c43eadf2b2ccc55086d0ee0bb12266114edc693d20f1bf9b94da3b5
https://github.com/simstudioai/sim/pull/7194/files#diff-c6ad185c1c43eadf2b2ccc55086d0ee0bb12266114edc693d20f1bf9b94da3b5
https://github.com/simstudioai/sim/pull/7194/files#diff-c6ad185c1c43eadf2b2ccc55086d0ee0bb12266114edc693d20f1bf9b94da3b5
Please reload this pagehttps://github.com/simstudioai/sim/pull/7194/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/7194/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.