Title: feat(observability): record Redis connection state on failed slot operations by waleedlatif1 · Pull Request #7194 · simstudioai/sim · GitHub
Open Graph Title: feat(observability): record Redis connection state on failed slot operations by waleedlatif1 · Pull Request #7194 · simstudioai/sim
X Title: feat(observability): record Redis connection state on failed slot operations by waleedlatif1 · Pull Request #7194 · simstudioai/sim
Description: Summary A Redis command that never gets a reply fails identically in three very different situations, and nothing we record distinguishes them: Situation What we'd want to see Connection still being established status: connecting, non-zero queue depth Reconnecting, command parked in the offline queue status: reconnecting, non-zero queue depth Socket silently dead status: ready, queue depth 0 ioredis reports all three as Error: Command timed out with only its own timer frames in the stack — no app frame naming the call, no lifecycle event saying which happened. Today the cause can only be inferred from timing. Adds describeRedisConnection() — client status, connection and ready ages, offline-queue depth, lifecycle counters (connects/reconnects/errors + last error), and whether the configured host is an IP literal or a DNS name. Attaches it to the usage-reservation slot operations. Those are the first Redis calls a queued workflow makes, so an unusable connection surfaces there first. connect and ready now log elapsed-since-construction, making the wait before a connection becomes usable directly measurable. Today that wait is spent inside a command's deadline, where it reads as a command timeout rather than as connection latency. Extends the shared redisConfigMock, which documents that every export of the real module is present. Why these fields status is usually decisive on its own. queuedCommands confirms it: a command parked in the offline queue was waiting on connection setup, whereas one written to a ready socket that never answered means the socket died without anything reporting it. ioredis has no public accessor for the offline queue, so this reads it through a narrow interface with a double-cast-allowed annotation. hostKind rules DNS resolution in or out. No server-side telemetry can see a slow or retrying resolve — not VPC flow logs, not NLB counters, not cache metrics — so without this it stays a permanent unknown. Security REDIS_URL carries the AUTH token and is never logged. Only derived facts (IP vs DNS, TLS on/off, SNI override in play) are emitted. There's a test asserting the snapshot cannot contain the host, and I verified it fails if the URL is leaked into the payload. Type of Change Observability / diagnostics (no behavior change) Testing No behavior change: this adds a read-only snapshot and log fields. No timeouts, retry policy, or control flow were touched. New tests cover no-client, connecting vs ready, offline-queue depth, lifecycle counting, IP vs DNS classification, and the secret-leak guard. Verified each fails for the right reason — forcing status to a constant breaks the discriminator tests, and leaking the URL into the snapshot breaks the secret test. bun run type-check clean in apps/sim and packages/testing. 3149 tests pass across lib/core, lib/billing, lib/execution, background, plus 40 in packages/testing. bun run lint and all 37 audits pass. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)
Open Graph Description: Summary A Redis command that never gets a reply fails identically in three very different situations, and nothing we record distinguishes them: Situation What we'd want to see Connection...
X Description: Summary A Redis command that never gets a reply fails identically in three very different situations, and nothing we record distinguishes them: Situation What we'd want to see Connec...
Opengraph URL: https://github.com/simstudioai/sim/pull/7194
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:470f7cfb-3b31-8187-32e6-a2e8b50d2728 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | EC82:8BAE:31DC93:466832:6AFB714E |
| html-safe-nonce | 8c48e0471725d8828e83a5ed4df73d2fd164c33258ebfe5523791fe3f97ee81e |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQzgyOjhCQUU6MzFEQzkzOjQ2NjgzMjo2QUZCNzE0RSIsInZpc2l0b3JfaWQiOiI3NDc5NDAyNzQxMzYyMjkxMDIyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 7903642a3b7aeab3ded11bb10a8309aad979f1bcc19a2a2773502f9cc5fe3e56 |
| hovercard-subject-tag | pull_request:4381336358 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/7194/files |
| twitter:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| og:image:alt | Summary A Redis command that never gets a reply fails identically in three very different situations, and nothing we record distinguishes them: Situation What we'd want to see Connection... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 0e29e7974fdda2feeaf5c891efd4b23b0734b23480232b62c7bdef13f40b5b48 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/simstudioai/sim git https://github.com/simstudioai/sim.git |
| octolytics-dimension-user_id | 199344406 |
| octolytics-dimension-user_login | simstudioai |
| octolytics-dimension-repository_id | 912559512 |
| octolytics-dimension-repository_nwo | simstudioai/sim |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 912559512 |
| octolytics-dimension-repository_network_root_nwo | simstudioai/sim |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 2e8872b770cc4d5d0cc1f2026afab747a268e2ce |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width