René's URL Explorer Experiment


Title: fix(provenance): derive final-output provenance instead of declaring it unvouchable by icecrasher321 · Pull Request #7173 · simstudioai/sim · GitHub

Open Graph Title: fix(provenance): derive final-output provenance instead of declaring it unvouchable by icecrasher321 · Pull Request #7173 · simstudioai/sim

X Title: fix(provenance): derive final-output provenance instead of declaring it unvouchable by icecrasher321 · Pull Request #7173 · simstudioai/sim

Description: Summary Fixes the live producer behind the TraceStore — displayProjection stream that is now ~95% of provenance log output (105 of 110 lines post-deploy). Every one of those lines is parts: ["finalOutput"], and the stock is real and growing — 30 distinct executions in under 4 hours — so this was never just a fixed backlog of bug-era rows. Root cause: ExecutionEngine.setFinalOutput stamped { complete: false } whenever the final block's state carried no provenance. But an absent block-state envelope is not a verdict — several state writers legitimately omit one, and a subflow sentinel aggregating iteration results is the common case (a loop that ran no iterations has nothing to merge, so setBlockOutput is called without provenance). The affected production workflows end in a loop block, which is exactly this shape. The cost was user-facing, not just log noise. An incomplete final-output envelope makes the display projection withhold finalOutput, so the workflow's author could not see their own run's output in the execution log — on every view, permanently. Each view then re-derived the same verdict, which is the read-path re-fire dominating the stream. The fix: derive from the run registry against the value being described — precisely what the end-of-run path (ensureFinalOutputProvenance) already did, and what every other consumer of a provenance-less block state does (the trace-store block-output reader falls back to the run registry). The two paths now share one deriveFinalOutputProvenance rather than disagreeing: take the block state's exact envelope as a shortcut when present, derive otherwise. Still fails closed: exportCommittedProvenanceForValue returns an incomplete envelope when the registry itself latched, which is the genuinely unvouchable case. That guard has its own regression test. Type of Change Bug fix Testing Two new engine tests: one pins the derivation (a final block whose state carries no provenance yields a complete envelope naming the secret actually present in the output), one pins fail-closed (a latched registry still exports incomplete). Verified the derivation test fails without the fix and passes with it. 5,071 tests green across executor/, lib/logs/, and lib/workflows/; bun run type-check clean; all 36 audits pass. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary Fixes the live producer behind the TraceStore — displayProjection stream that is now ~95% of provenance log output (105 of 110 lines post-deploy). Every one of those lines is parts: ["...

X Description: Summary Fixes the live producer behind the TraceStore — displayProjection stream that is now ~95% of provenance log output (105 of 110 lines post-deploy). Every one of those lines is parts: [&...

Opengraph URL: https://github.com/simstudioai/sim/pull/7173

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:96649ecb-b1d3-1afb-31ee-12919f3f1b86
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD4A2:323D9C:B8A83:10A1C7:6AFB292E
html-safe-nonce23d673b9948f28d71811b73ec2045801689c89106770dfa44aad3f2c7140603a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENEEyOjMyM0Q5QzpCOEE4MzoxMEExQzc6NkFGQjI5MkUiLCJ2aXNpdG9yX2lkIjoiMjMzOTUxMDUxMjMxNzU3MzQyMiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacb1af881a4e8f63a78191d306a867d53f62ed49cb42b242dee05747eca81f4720
hovercard-subject-tagpull_request:4379463023
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/7173/files
twitter:imagehttps://avatars.githubusercontent.com/u/17950982?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/17950982?s=400&v=4
og:image:altSummary Fixes the live producer behind the TraceStore — displayProjection stream that is now ~95% of provenance log output (105 of 110 lines post-deploy). Every one of those lines is parts: ["...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None40c7ffe00e8bbb3ca8403c83d7ef110379c9eba2cbc7a7c333b037ffd940d4e4
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasef494d77c37809e03e18d49c6e9945c57e0b64070
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/7173/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F7173%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F7173%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/7173/files
Reloadhttps://github.com/simstudioai/sim/pull/7173/files
Reloadhttps://github.com/simstudioai/sim/pull/7173/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests198 (198)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
icecrasher321https://github.com/icecrasher321
staginghttps://github.com/simstudioai/sim/tree/staging
provenance-finaloutput-producerhttps://github.com/simstudioai/sim/tree/provenance-finaloutput-producer
Conversation 2 https://github.com/simstudioai/sim/pull/7173
Commits 1 https://github.com/simstudioai/sim/pull/7173/commits
Checks 30 https://github.com/simstudioai/sim/pull/7173/checks
Files changed https://github.com/simstudioai/sim/pull/7173/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/7173/files
fix(provenance): derive final-output provenance instead of declaring it unvouchable https://github.com/simstudioai/sim/pull/7173/files#top
Show all changes 1 commit https://github.com/simstudioai/sim/pull/7173/files
6e54c1b fix(provenance): derive final-output provenance instead of declaring … Aug 27, 2026 https://github.com/simstudioai/sim/pull/7173/commits/6e54c1b6469403d4334a3222f15d6932232100d8
Clear filters https://github.com/simstudioai/sim/pull/7173/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/7173/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/7173/files
engine.test.ts https://github.com/simstudioai/sim/pull/7173/files#diff-8a7dc7d2027ef09942b6480f995b1175f4f22ecbd015133850cb9f2dbc3df51e
engine.ts https://github.com/simstudioai/sim/pull/7173/files#diff-8fc33da0f336e4f8e9c4cef6bdcb2297ffb3bc693d739245b28cde225130de22
apps/sim/executor/execution/engine.test.tshttps://github.com/simstudioai/sim/pull/7173/files#diff-8a7dc7d2027ef09942b6480f995b1175f4f22ecbd015133850cb9f2dbc3df51e
View file https://github.com/simstudioai/sim/blob/6e54c1b6469403d4334a3222f15d6932232100d8/apps/sim/executor/execution/engine.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/7173/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/7173/files#diff-8a7dc7d2027ef09942b6480f995b1175f4f22ecbd015133850cb9f2dbc3df51e
https://github.com/simstudioai/sim/pull/7173/files#diff-8a7dc7d2027ef09942b6480f995b1175f4f22ecbd015133850cb9f2dbc3df51e
apps/sim/executor/execution/engine.tshttps://github.com/simstudioai/sim/pull/7173/files#diff-8fc33da0f336e4f8e9c4cef6bdcb2297ffb3bc693d739245b28cde225130de22
View file https://github.com/simstudioai/sim/blob/6e54c1b6469403d4334a3222f15d6932232100d8/apps/sim/executor/execution/engine.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/7173/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/7173/files#diff-8fc33da0f336e4f8e9c4cef6bdcb2297ffb3bc693d739245b28cde225130de22
https://github.com/simstudioai/sim/pull/7173/files#diff-8fc33da0f336e4f8e9c4cef6bdcb2297ffb3bc693d739245b28cde225130de22
Please reload this pagehttps://github.com/simstudioai/sim/pull/7173/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.