René's URL Explorer Experiment


Title: improvement(tools): state every pinned param, not just the credential by waleedlatif1 · Pull Request #7170 · simstudioai/sim · GitHub

Open Graph Title: improvement(tools): state every pinned param, not just the credential by waleedlatif1 · Pull Request #7170 · simstudioai/sim

X Title: improvement(tools): state every pinned param, not just the credential by waleedlatif1 · Pull Request #7170 · simstudioai/sim

Description: Summary Reported case: an agent with two Gmail read tools on the same account but different labels couldn't route between them. Every param a user fills is stripped from the schema the model sees (createLLMToolSchema), and #7079 only ever named the credential — so the two tools arrived byte-identical, and the shared credential was correctly suppressed as non-discriminating, leaving nothing at all. Each tool now states the values the workflow pinned on it. Opaque resource ids (credential, knowledge base, workflow) still resolve to a display name; plain values like a label, a row limit or a toggle need no lookup and are stated directly. Now runs for every tool with pinned params, not only duplicates. A lone tool pinned to INBOX can otherwise promise a caller it will search SENT — the model has no way to know the field is fixed. Duplicates additionally get a sentence saying the copies differ. Secrets are never stated: a subblock marked password, a hidden subblock, a secret-named param, and — for a tool whose params resolved an environment variable — every literal value. Resource names are still stated there, since a looked-up name cannot carry the secret. Renamed tool-binding-labels.ts to tool-pinned-params.ts to match what it now does. Type of Change Improvement Testing 31 unit tests, including the exact reported case (same credential, different folder). Verified the guards fail when removed: deleting the password/hidden skip, and deleting the secret-withholding branch, each turn the relevant tests red. Full suite green: 3,953 tests, tsc clean, all 36 audits pass, lint clean. Behaviour change worth noting for review: descriptions now change for every existing agent that pins any param, not just ones with duplicate tools, and credential lookups now run for every OAuth tool rather than only duplicates. Lookups are deduped per request and memoized for the run, so a credential shared across tools costs one read. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary Reported case: an agent with two Gmail read tools on the same account but different labels couldn't route between them. Every param a user fills is stripped from the schema the model s...

X Description: Summary Reported case: an agent with two Gmail read tools on the same account but different labels couldn't route between them. Every param a user fills is stripped from the schema the mod...

Opengraph URL: https://github.com/simstudioai/sim/pull/7170

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:c5e2fe0e-f628-45da-76ef-d66cbda18f4d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA464:2FF5E0:E074DC:133BE52:6AFB5D86
html-safe-nonce8c258ecd31343629249f60493b0736eaf589ec91f3c7d0ff5bdb188229d9df57
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNDY0OjJGRjVFMDpFMDc0REM6MTMzQkU1Mjo2QUZCNUQ4NiIsInZpc2l0b3JfaWQiOiIzOTAxOTMxODM4MzU1NzU4NDcwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac4d6253d699eb28470088c43bed5b54479e01aa98aa26591f4b621b66623d3589
hovercard-subject-tagpull_request:4378709050
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/7170/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary Reported case: an agent with two Gmail read tools on the same account but different labels couldn't route between them. Every param a user fills is stripped from the schema the model s...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneea33d13c96d0ff66bd8fa906b193d2213536b78cb06b0c50a4632c58b1418f94
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release59ef97164c52cf59bd10558ddec9c4f482763988
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/7170/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F7170%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F7170%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/7170/files
Reloadhttps://github.com/simstudioai/sim/pull/7170/files
Reloadhttps://github.com/simstudioai/sim/pull/7170/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
feat/discriminate-prefilled-paramshttps://github.com/simstudioai/sim/tree/feat/discriminate-prefilled-params
Conversation 12 https://github.com/simstudioai/sim/pull/7170
Commits 5 https://github.com/simstudioai/sim/pull/7170/commits
Checks 28 https://github.com/simstudioai/sim/pull/7170/checks
Files changed https://github.com/simstudioai/sim/pull/7170/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/7170/files
improvement(tools): state every pinned param, not just the credential https://github.com/simstudioai/sim/pull/7170/files#top
Show all changes 5 commits https://github.com/simstudioai/sim/pull/7170/files
6916aa4 improvement(tools): state every pinned param, not just the credential waleedlatif1 Aug 27, 2026 https://github.com/simstudioai/sim/pull/7170/commits/6916aa4fa0067dcb5124ca297fa8648ec8b7e9fa
fc74117 improvement(tools): scope pinned params to the selected tool and trim… waleedlatif1 Aug 27, 2026 https://github.com/simstudioai/sim/pull/7170/commits/fc7411715c6c80d3eab9090e46cae76e5bcb3b45
53f4dde improvement(tools): stop the secret guard from faking a difference be… waleedlatif1 Aug 27, 2026 https://github.com/simstudioai/sim/pull/7170/commits/53f4ddecf119e5ad246c3c5d6eeea5ab32a1d229
31a8f8e fix(tools): stop MCP pinned params from stating the server's identity waleedlatif1 Aug 27, 2026 https://github.com/simstudioai/sim/pull/7170/commits/31a8f8e8841d6b723ffffa94035c2f118b0e9b40
f00a99a improvement(tools): decide pinned fields by subblock condition, not p… waleedlatif1 Aug 28, 2026 https://github.com/simstudioai/sim/pull/7170/commits/f00a99a8e80cba2fd2fb4bd7fe5f32f86db60fe7
Clear filters https://github.com/simstudioai/sim/pull/7170/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/7170/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/7170/files
agent-handler.ts https://github.com/simstudioai/sim/pull/7170/files#diff-99cbd7f57b71719ca1561f15e7aecdc9f7a969ae5ea3589aee9fa64b3c9bf614
sim-tools.ts https://github.com/simstudioai/sim/pull/7170/files#diff-19a23829ad3d6520c18f0c42c63422d9723db781541a75b61991316d0e4d4c5a
tool-binding-labels.test.ts https://github.com/simstudioai/sim/pull/7170/files#diff-6f6b221e710cef427bdaaedd42aed76709c277a5fa32b23e4521d2cceda2c312
tool-binding-labels.ts https://github.com/simstudioai/sim/pull/7170/files#diff-813878ba7dc9de23627b09ca35608962093878b2f6ba71e41d5819cce064ed65
tool-pinned-params.test.ts https://github.com/simstudioai/sim/pull/7170/files#diff-e63ab1045f6bf62f0ccf87239a489f953f5fe59af8b5446b20a8bf7b071f6e4e
tool-pinned-params.ts https://github.com/simstudioai/sim/pull/7170/files#diff-83ad3aaa808428a2f1bc3f628f6996c465b3af84594b42a7a183eccbb5c4607a
tool-binding.test.ts https://github.com/simstudioai/sim/pull/7170/files#diff-7adbe7f26860e6167a66ecdc3bd24106e99a09d66578e95a9ac3e52089404ed2
tool-binding.ts https://github.com/simstudioai/sim/pull/7170/files#diff-b632cb09294157fcf213d3c0c7c595096f16284e719b2d0c78956a51ef0974e1
utils.ts https://github.com/simstudioai/sim/pull/7170/files#diff-e5a8ed3fe51b6470c7acddd9beac4eecb4c915cacc23d40b68b566a998ac121e
apps/sim/executor/handlers/agent/agent-handler.tshttps://github.com/simstudioai/sim/pull/7170/files#diff-99cbd7f57b71719ca1561f15e7aecdc9f7a969ae5ea3589aee9fa64b3c9bf614
View file https://github.com/simstudioai/sim/blob/f00a99a8e80cba2fd2fb4bd7fe5f32f86db60fe7/apps/sim/executor/handlers/agent/agent-handler.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/7170/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/7170/files#diff-99cbd7f57b71719ca1561f15e7aecdc9f7a969ae5ea3589aee9fa64b3c9bf614
https://github.com/simstudioai/sim/pull/7170/files#diff-99cbd7f57b71719ca1561f15e7aecdc9f7a969ae5ea3589aee9fa64b3c9bf614
https://github.com/simstudioai/sim/pull/7170/files#diff-99cbd7f57b71719ca1561f15e7aecdc9f7a969ae5ea3589aee9fa64b3c9bf614
https://github.com/simstudioai/sim/pull/7170/files#diff-99cbd7f57b71719ca1561f15e7aecdc9f7a969ae5ea3589aee9fa64b3c9bf614
https://github.com/simstudioai/sim/pull/7170/files#diff-99cbd7f57b71719ca1561f15e7aecdc9f7a969ae5ea3589aee9fa64b3c9bf614
https://github.com/simstudioai/sim/pull/7170/files#diff-99cbd7f57b71719ca1561f15e7aecdc9f7a969ae5ea3589aee9fa64b3c9bf614
https://github.com/simstudioai/sim/pull/7170/files#diff-99cbd7f57b71719ca1561f15e7aecdc9f7a969ae5ea3589aee9fa64b3c9bf614
https://github.com/simstudioai/sim/pull/7170/files#diff-99cbd7f57b71719ca1561f15e7aecdc9f7a969ae5ea3589aee9fa64b3c9bf614
https://github.com/simstudioai/sim/pull/7170/files#diff-99cbd7f57b71719ca1561f15e7aecdc9f7a969ae5ea3589aee9fa64b3c9bf614
https://github.com/simstudioai/sim/pull/7170/files#diff-99cbd7f57b71719ca1561f15e7aecdc9f7a969ae5ea3589aee9fa64b3c9bf614
https://github.com/simstudioai/sim/pull/7170/files#diff-99cbd7f57b71719ca1561f15e7aecdc9f7a969ae5ea3589aee9fa64b3c9bf614
https://github.com/simstudioai/sim/pull/7170/files#diff-99cbd7f57b71719ca1561f15e7aecdc9f7a969ae5ea3589aee9fa64b3c9bf614
apps/sim/executor/handlers/pi/local/sim-tools.tshttps://github.com/simstudioai/sim/pull/7170/files#diff-19a23829ad3d6520c18f0c42c63422d9723db781541a75b61991316d0e4d4c5a
View file https://github.com/simstudioai/sim/blob/f00a99a8e80cba2fd2fb4bd7fe5f32f86db60fe7/apps/sim/executor/handlers/pi/local/sim-tools.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/7170/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/7170/files#diff-19a23829ad3d6520c18f0c42c63422d9723db781541a75b61991316d0e4d4c5a
https://github.com/simstudioai/sim/pull/7170/files#diff-19a23829ad3d6520c18f0c42c63422d9723db781541a75b61991316d0e4d4c5a
https://github.com/simstudioai/sim/pull/7170/files#diff-19a23829ad3d6520c18f0c42c63422d9723db781541a75b61991316d0e4d4c5a
https://github.com/simstudioai/sim/pull/7170/files#diff-19a23829ad3d6520c18f0c42c63422d9723db781541a75b61991316d0e4d4c5a
apps/sim/executor/utils/tool-binding-labels.test.tshttps://github.com/simstudioai/sim/pull/7170/files#diff-6f6b221e710cef427bdaaedd42aed76709c277a5fa32b23e4521d2cceda2c312
View file https://github.com/simstudioai/sim/blob/27959221771fdbd51324a96b658deee278162799/apps/sim/executor/utils/tool-binding-labels.test.ts
Open in desktop https://desktop.github.com
Please reload this pagehttps://github.com/simstudioai/sim/pull/7170/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/7170/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/7170/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.