Title: fix(chat): conceal a missing deployment the way an unreachable one is by waleedlatif1 · Pull Request #7100 · simstudioai/sim · GitHub
Open Graph Title: fix(chat): conceal a missing deployment the way an unreachable one is by waleedlatif1 · Pull Request #7100 · simstudioai/sim
X Title: fix(chat): conceal a missing deployment the way an unreachable one is by waleedlatif1 · Pull Request #7100 · simstudioai/sim
Description: Summary From the v0.8.12 release review (#7090). The internal chat error policy documents that a missing deployment and one in an unreachable workspace "must stay indistinguishable" — and they were not. The policy rewrites a cross-tenant authorization failure to Chat not found or access denied, but the domain answers an absent deployment with its own Chat deployment not found, which the projection passed straight through. Two 404s a caller can tell apart is exactly the existence oracle the concealment exists to close. The legacy code is derived from the message (legacyCode), so the difference leaked on both the error and code fields. Every not_found reachable through this policy means the same thing — the deployment is not available to this caller — so all of them now render as the concealed message. None of the alternatives (context.ts, update-chat-deployment.ts, the two undeploy paths) carries a distinction worth preserving at the cost of the one they must not make. Type of Change Bug fix Testing The two existing 404 tests asserted only response.status, which is how the bodies drifted apart unnoticed. The new test compares the two responses directly and asserts the concealed wording; it goes red against the unfixed policy. Full apps/sim suite green: 34,539 tests. bun run lint, all 33 audits (check:audits), and type-check pass. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)
Open Graph Description: Summary From the v0.8.12 release review (#7090). The internal chat error policy documents that a missing deployment and one in an unreachable workspace "must stay indistinguishable" — and...
X Description: Summary From the v0.8.12 release review (#7090). The internal chat error policy documents that a missing deployment and one in an unreachable workspace "must stay indistinguishable&quo...
Opengraph URL: https://github.com/simstudioai/sim/pull/7100
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:d5b98573-004a-3f46-3b4a-a2d35b0cc52d |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | BDAA:D16D6:AEA486:F06A88:6AFB5444 |
| html-safe-nonce | 8c2cf2f06e249bc718a5d849b0ef3ceae1d376d7affd8b5f357c6b930e3f9431 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCREFBOkQxNkQ2OkFFQTQ4NjpGMDZBODg6NkFGQjU0NDQiLCJ2aXNpdG9yX2lkIjoiOTE1NjU2NzA0Nzg4MDc5MTEwOCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 7a182a671840a782f2c2031d89bf071ce6a89afce0c0ae6d216e8da7f8ad699c |
| hovercard-subject-tag | pull_request:4363898032 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/7100/files |
| twitter:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| og:image:alt | Summary From the v0.8.12 release review (#7090). The internal chat error policy documents that a missing deployment and one in an unreachable workspace "must stay indistinguishable" — and... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 7122bb414b542dba14d71a3f0b9f6fd2abce715b9f5912d082800563e6c806d1 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/simstudioai/sim git https://github.com/simstudioai/sim.git |
| octolytics-dimension-user_id | 199344406 |
| octolytics-dimension-user_login | simstudioai |
| octolytics-dimension-repository_id | 912559512 |
| octolytics-dimension-repository_nwo | simstudioai/sim |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 912559512 |
| octolytics-dimension-repository_network_root_nwo | simstudioai/sim |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | cbf66c024bb6d10e6955baa7413c54cf13a201bb |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width