René's URL Explorer Experiment


Title: fix(chat): conceal a missing deployment the way an unreachable one is by waleedlatif1 · Pull Request #7100 · simstudioai/sim · GitHub

Open Graph Title: fix(chat): conceal a missing deployment the way an unreachable one is by waleedlatif1 · Pull Request #7100 · simstudioai/sim

X Title: fix(chat): conceal a missing deployment the way an unreachable one is by waleedlatif1 · Pull Request #7100 · simstudioai/sim

Description: Summary From the v0.8.12 release review (#7090). The internal chat error policy documents that a missing deployment and one in an unreachable workspace "must stay indistinguishable" — and they were not. The policy rewrites a cross-tenant authorization failure to Chat not found or access denied, but the domain answers an absent deployment with its own Chat deployment not found, which the projection passed straight through. Two 404s a caller can tell apart is exactly the existence oracle the concealment exists to close. The legacy code is derived from the message (legacyCode), so the difference leaked on both the error and code fields. Every not_found reachable through this policy means the same thing — the deployment is not available to this caller — so all of them now render as the concealed message. None of the alternatives (context.ts, update-chat-deployment.ts, the two undeploy paths) carries a distinction worth preserving at the cost of the one they must not make. Type of Change Bug fix Testing The two existing 404 tests asserted only response.status, which is how the bodies drifted apart unnoticed. The new test compares the two responses directly and asserts the concealed wording; it goes red against the unfixed policy. Full apps/sim suite green: 34,539 tests. bun run lint, all 33 audits (check:audits), and type-check pass. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary From the v0.8.12 release review (#7090). The internal chat error policy documents that a missing deployment and one in an unreachable workspace "must stay indistinguishable" — and...

X Description: Summary From the v0.8.12 release review (#7090). The internal chat error policy documents that a missing deployment and one in an unreachable workspace "must stay indistinguishable&quo...

Opengraph URL: https://github.com/simstudioai/sim/pull/7100

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:d5b98573-004a-3f46-3b4a-a2d35b0cc52d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBDAA:D16D6:AEA486:F06A88:6AFB5444
html-safe-nonce8c2cf2f06e249bc718a5d849b0ef3ceae1d376d7affd8b5f357c6b930e3f9431
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCREFBOkQxNkQ2OkFFQTQ4NjpGMDZBODg6NkFGQjU0NDQiLCJ2aXNpdG9yX2lkIjoiOTE1NjU2NzA0Nzg4MDc5MTEwOCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac7a182a671840a782f2c2031d89bf071ce6a89afce0c0ae6d216e8da7f8ad699c
hovercard-subject-tagpull_request:4363898032
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/7100/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary From the v0.8.12 release review (#7090). The internal chat error policy documents that a missing deployment and one in an unreachable workspace "must stay indistinguishable" — and...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None7122bb414b542dba14d71a3f0b9f6fd2abce715b9f5912d082800563e6c806d1
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasecbf66c024bb6d10e6955baa7413c54cf13a201bb
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/7100/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F7100%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F7100%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/7100/files
Reloadhttps://github.com/simstudioai/sim/pull/7100/files
Reloadhttps://github.com/simstudioai/sim/pull/7100/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/chat-notfound-concealmenthttps://github.com/simstudioai/sim/tree/fix/chat-notfound-concealment
Conversation 2 https://github.com/simstudioai/sim/pull/7100
Commits 1 https://github.com/simstudioai/sim/pull/7100/commits
Checks 30 https://github.com/simstudioai/sim/pull/7100/checks
Files changed https://github.com/simstudioai/sim/pull/7100/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/7100/files
fix(chat): conceal a missing deployment the way an unreachable one is https://github.com/simstudioai/sim/pull/7100/files#top
Show all changes 1 commit https://github.com/simstudioai/sim/pull/7100/files
bffc8b3 fix(chat): conceal a missing deployment the way an unreachable one is waleedlatif1 Aug 26, 2026 https://github.com/simstudioai/sim/pull/7100/commits/bffc8b3d1f3247440097f249000e2a420490d55f
Clear filters https://github.com/simstudioai/sim/pull/7100/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/7100/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/7100/files
error-policy.ts https://github.com/simstudioai/sim/pull/7100/files#diff-312ae709b689865bae5d2a59cae020fcd4f0a1b2131f3ebb5f83271e92c9c0d5
route.test.ts https://github.com/simstudioai/sim/pull/7100/files#diff-0e04be9d6afac8946da999ce0d5829c5a6bf3d13d1824803f8696fd45184a988
apps/sim/app/api/chat/error-policy.tshttps://github.com/simstudioai/sim/pull/7100/files#diff-312ae709b689865bae5d2a59cae020fcd4f0a1b2131f3ebb5f83271e92c9c0d5
View file https://github.com/simstudioai/sim/blob/bffc8b3d1f3247440097f249000e2a420490d55f/apps/sim/app/api/chat/error-policy.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/7100/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/7100/files#diff-312ae709b689865bae5d2a59cae020fcd4f0a1b2131f3ebb5f83271e92c9c0d5
https://github.com/simstudioai/sim/pull/7100/files#diff-312ae709b689865bae5d2a59cae020fcd4f0a1b2131f3ebb5f83271e92c9c0d5
apps/sim/app/api/chat/manage/[id]/route.test.tshttps://github.com/simstudioai/sim/pull/7100/files#diff-0e04be9d6afac8946da999ce0d5829c5a6bf3d13d1824803f8696fd45184a988
View file https://github.com/simstudioai/sim/blob/bffc8b3d1f3247440097f249000e2a420490d55f/apps/sim/app/api/chat/manage/%5Bid%5D/route.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/7100/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/7100/files#diff-0e04be9d6afac8946da999ce0d5829c5a6bf3d13d1824803f8696fd45184a988
https://github.com/simstudioai/sim/pull/7100/files#diff-0e04be9d6afac8946da999ce0d5829c5a6bf3d13d1824803f8696fd45184a988
Please reload this pagehttps://github.com/simstudioai/sim/pull/7100/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.