René's URL Explorer Experiment


Title: docs: correct two statements that contradict what they describe by waleedlatif1 · Pull Request #7092 · simstudioai/sim · GitHub

Open Graph Title: docs: correct two statements that contradict what they describe by waleedlatif1 · Pull Request #7092 · simstudioai/sim

X Title: docs: correct two statements that contradict what they describe by waleedlatif1 · Pull Request #7092 · simstudioai/sim

Description: Follow-up to the 26 unresolved cubic threads on the v0.8.12 release PR (#7090). None of the 26 are on code the recent de-slop work touched (#7060, #7062, #7063, #7082). I evaluated all of them by content rather than by path, since a finding can be relevant without landing on a changed line. Two are the same defect class that work was already correcting — documentation asserting something the code does not do — so they're fixed here. Two more looked like that class and turned out not to be; reasoning below so they aren't re-raised. Fixed 1. v2/knowledge/[knowledgeBaseId]/documents/route.ts — JSDoc contradicts the code and its own inline comment The JSDoc said workspaceId "is dropped for the same reason as on the sibling chunk list." The sibling genuinely drops it — its query type doesn't even carry the field. This list keeps it, and an inline comment five lines below the binding says so explicitly, with the reason: dropping it changes the cursor fingerprint, so every cursor minted before the change would be refused with a message telling the caller they altered a filter they never sent. Reworded to state the retention and defer to that note. The reasoning about why it's asserted scope rather than a filter was correct and is kept. 2. .agents/skills/v2-api-conventions/SKILL.md — stale hard-coded count "Fifteen lists take the pair." Parsing CURSOR_BINDINGS in contracts/v2/__tests__/list-pagination.test.ts gives 19 of 27 paged lists binding both sortBy and sortOrder. cubic's deeper point is the right one: a hard-coded count drifts every time a list gains sorting, which is exactly how this went stale. Now points at the test as the authoritative set instead of restating a number. Evaluated and declined docs/en/cli/files.mdx — --recursive "no longer lists any spellings" — false positive at the layer proposed. The sentence traces to .describe() on contracts/v2/files.ts:341, where the param is z.stringbool({ case: 'sensitive' }) carrying .meta({ enum: [...V2_TRUE_VALUES, ...V2_FALSE_VALUES] }) — 12 published, case-sensitive spellings. The sentence is true for the HTTP param. What's actually happening is the CLI doc renderer flattens a stringbool to a bare --recursive flag and drops the enum, so the sentence references a list the CLI table doesn't print. Deleting a true sentence from the shared contract would degrade the API reference to patch a renderer gap. If anything, the fix belongs in generate-cli-docs.ts. docs/en/cli/credentials.mdx — "Credential to update or disconnect." on delete — real imprecision, disproportionate fix. It comes from v2CredentialParamsSchema, a single .describe() deliberately shared by both the update and delete contracts. Splitting it means a second schema plus regenerating a 13k-line generated v2-api.ts and its mdx, for a P3 where the current wording is imprecise rather than wrong. Not ours The remaining 22 are unrelated to this work — v1 admin billing upsert, the Microsoft Word lost-update races, v2 pagination/presenter/HEAD findings, chat error-policy disclosure, the webhook Slack fan-out ordering, cron lease renewal, settings/navigation.ts hardcoding customBlocks: true, and the docs/de nav entries. Several are P1/P2 and worth someone's attention — particularly the settings/navigation.ts one, which describes a nav-vs-server disagreement the surrounding doc comment says the table exists to prevent. One note on adjacency: #7063 removed a stale vi.mock('@/app/api/webhooks/utils', ...) from the webhook trigger route test. I re-verified that module still doesn't exist, so the mock was inert and no coverage was lost. Separately, validateSlackSignature (lib/webhooks/providers/slack.ts:465) has zero test coverage — pre-existing, not caused by that removal, but worth recording. Verification bun run type-check clean, all 33 audits pass, 159 tests across list-pagination and app/api/v2/knowledge green. Both changes are comment/markdown only — no behavior change.

Open Graph Description: Follow-up to the 26 unresolved cubic threads on the v0.8.12 release PR (#7090). None of the 26 are on code the recent de-slop work touched (#7060, #7062, #7063, #7082). I evaluated all of them by c...

X Description: Follow-up to the 26 unresolved cubic threads on the v0.8.12 release PR (#7090). None of the 26 are on code the recent de-slop work touched (#7060, #7062, #7063, #7082). I evaluated all of them by c...

Opengraph URL: https://github.com/simstudioai/sim/pull/7092

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:57814713-eb9e-2460-9f7e-0689b7a5087d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8950:858A:BA5C61:107C0B6:6AFB5DDD
html-safe-noncea4ef08327223d9953261e5f70e165b2c9554573ccaa8f9d5314f114f3124869d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4OTUwOjg1OEE6QkE1QzYxOjEwN0MwQjY6NkFGQjVEREQiLCJ2aXNpdG9yX2lkIjoiNTg2NDY4NDQzMzIzOTEzNzc1NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac0ec0f6f49076bc871dc126882a86fafd4b30839401d0cdf1c6c12e55046144df
hovercard-subject-tagpull_request:4363384378
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/7092/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altFollow-up to the 26 unresolved cubic threads on the v0.8.12 release PR (#7090). None of the 26 are on code the recent de-slop work touched (#7060, #7062, #7063, #7082). I evaluated all of them by c...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneea33d13c96d0ff66bd8fa906b193d2213536b78cb06b0c50a4632c58b1418f94
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release59ef97164c52cf59bd10558ddec9c4f482763988
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/7092/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F7092%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F7092%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/7092/files
Reloadhttps://github.com/simstudioai/sim/pull/7092/files
Reloadhttps://github.com/simstudioai/sim/pull/7092/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
deslop-7090-followuphttps://github.com/simstudioai/sim/tree/deslop-7090-followup
Conversation 5 https://github.com/simstudioai/sim/pull/7092
Commits 1 https://github.com/simstudioai/sim/pull/7092/commits
Checks 30 https://github.com/simstudioai/sim/pull/7092/checks
Files changed https://github.com/simstudioai/sim/pull/7092/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/7092/files
docs: correct two statements that contradict what they describe https://github.com/simstudioai/sim/pull/7092/files#top
Show all changes 1 commit https://github.com/simstudioai/sim/pull/7092/files
5f5230d docs: correct two statements that contradict what they describe waleedlatif1 Aug 26, 2026 https://github.com/simstudioai/sim/pull/7092/commits/5f5230dd8baed08d6d2094dfdcc6330bc36b277f
Clear filters https://github.com/simstudioai/sim/pull/7092/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/7092/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/7092/files
SKILL.md https://github.com/simstudioai/sim/pull/7092/files#diff-8ece2aa9a15122239fc217eb94d684ef57b385916b95bed160ad4b424543edc5
route.ts https://github.com/simstudioai/sim/pull/7092/files#diff-1f471c29f0a5f3252d330e865a037294618e7c30f2682a2d797dc553773a8d6c
.agents/skills/v2-api-conventions/SKILL.mdhttps://github.com/simstudioai/sim/pull/7092/files#diff-8ece2aa9a15122239fc217eb94d684ef57b385916b95bed160ad4b424543edc5
View file https://github.com/simstudioai/sim/blob/5f5230dd8baed08d6d2094dfdcc6330bc36b277f/.agents/skills/v2-api-conventions/SKILL.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/7092/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/7092/files#diff-8ece2aa9a15122239fc217eb94d684ef57b385916b95bed160ad4b424543edc5
https://github.com/simstudioai/sim/pull/7092/files#diff-8ece2aa9a15122239fc217eb94d684ef57b385916b95bed160ad4b424543edc5
apps/sim/app/api/v2/knowledge/[knowledgeBaseId]/documents/route.tshttps://github.com/simstudioai/sim/pull/7092/files#diff-1f471c29f0a5f3252d330e865a037294618e7c30f2682a2d797dc553773a8d6c
View file https://github.com/simstudioai/sim/blob/5f5230dd8baed08d6d2094dfdcc6330bc36b277f/apps/sim/app/api/v2/knowledge/%5BknowledgeBaseId%5D/documents/route.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/7092/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/7092/files#diff-1f471c29f0a5f3252d330e865a037294618e7c30f2682a2d797dc553773a8d6c
https://github.com/simstudioai/sim/pull/7092/files#diff-1f471c29f0a5f3252d330e865a037294618e7c30f2682a2d797dc553773a8d6c
Please reload this pagehttps://github.com/simstudioai/sim/pull/7092/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.