René's URL Explorer Experiment


Title: fix(provenance): classify a latched-but-empty registry's file writes as unrecorded by icecrasher321 · Pull Request #7084 · simstudioai/sim · GitHub

Open Graph Title: fix(provenance): classify a latched-but-empty registry's file writes as unrecorded by icecrasher321 · Pull Request #7084 · simstudioai/sim

X Title: fix(provenance): classify a latched-but-empty registry's file writes as unrecorded by icecrasher321 · Pull Request #7084 · simstudioai/sim

Description: Summary Fixes the hard failure the log monitoring surfaced today: a Mothership chat generating a document and immediately rendering it back failed with "This file result cannot be shared safely because its secret provenance is unavailable" — a file that, per its terminal sidecar in production, carries zero secret entries. Root cause is a causal chain between two of today's log signals: a copilot workflow run that fails before exporting provenance crosses as value-provenance-absent and latches the chat's registry (importCrossingProvenance is path-less, so the latch is whole-registry). Every file that chat later writes hits the write decision's export-incomplete branch → safe: false → sidecar stamped unknown — the taint, which no policy relaxes — so the chat's own follow-up read is refused until a later clean turn rewrites the sidecar. Verified in prod: the refused file healed to exact-empty 46 seconds after the last refusal; fleet-wide, zero files are currently stuck (the only 4 standing unknown sidecars are pre-#6986 relics with demoted versions that read as untracked and refuse nothing). The fix applies the surface's own absence/taint dichotomy at the write decision: a latched registry holding no active entries is an absence — no secret plaintext was resolved or imported in that context, so none can be in the bytes; the only fact is that content of unrecorded history crossed, which is exactly what unrecorded states. Such writes now stamp unrecorded (readable under the fail-open policy, audit entry naming the surface) instead of taint. Taint stays for a latched registry that holds plaintext it cannot map to the output, for an incomplete export with no diagnostics to vouch with, and for every structural refusal below (scope incompatibility, incomplete derived representations, encryption failure). Also adds the fault kind as a structured fault field on the trace-store display-read lines, so log tooling can group by kind without parsing messages. Type of Change Bug fix Testing Three new tests pin the decision: latched + zero active entries → unrecorded; latched + plaintext in scope → taint; incomplete export with no diagnostics → taint. One existing test's stub registry gained the diagnostics method its real counterpart has (its intent — taint for unavailable lineage — is preserved with an active entry). 2,981 tests green across lib/uploads, lib/copilot, lib/logs, and the registry suite; bun run type-check clean; all 33 audits pass. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary Fixes the hard failure the log monitoring surfaced today: a Mothership chat generating a document and immediately rendering it back failed with "This file result cannot be shared safe...

X Description: Summary Fixes the hard failure the log monitoring surfaced today: a Mothership chat generating a document and immediately rendering it back failed with "This file result cannot be shared ...

Opengraph URL: https://github.com/simstudioai/sim/pull/7084

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:7a2ddea8-637d-86c9-1f26-23e02079cdcb
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBFB2:19FA2E:94C37A:D2DE66:6AFB51AB
html-safe-nonce8d45d027a1775840a1a75e471ba967cde4de98bfcaf010cfcdd5443ce4126de2
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCRkIyOjE5RkEyRTo5NEMzN0E6RDJERTY2OjZBRkI1MUFCIiwidmlzaXRvcl9pZCI6IjU3NjI4NTI0MTIyMTMzODM1OTUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac4d58d95bb99e964d4e7d6d1705c89381fb12af3bb322221ee291676453641410
hovercard-subject-tagpull_request:4362369622
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/7084/files
twitter:imagehttps://avatars.githubusercontent.com/u/17950982?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/17950982?s=400&v=4
og:image:altSummary Fixes the hard failure the log monitoring surfaced today: a Mothership chat generating a document and immediately rendering it back failed with "This file result cannot be shared safe...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None7122bb414b542dba14d71a3f0b9f6fd2abce715b9f5912d082800563e6c806d1
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasecbf66c024bb6d10e6955baa7413c54cf13a201bb
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/7084/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F7084%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F7084%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/7084/files
Reloadhttps://github.com/simstudioai/sim/pull/7084/files
Reloadhttps://github.com/simstudioai/sim/pull/7084/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
icecrasher321https://github.com/icecrasher321
staginghttps://github.com/simstudioai/sim/tree/staging
provenance-log-triagehttps://github.com/simstudioai/sim/tree/provenance-log-triage
Conversation 16 https://github.com/simstudioai/sim/pull/7084
Commits 3 https://github.com/simstudioai/sim/pull/7084/commits
Checks 30 https://github.com/simstudioai/sim/pull/7084/checks
Files changed https://github.com/simstudioai/sim/pull/7084/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/7084/files
fix(provenance): classify a latched-but-empty registry's file writes as unrecorded https://github.com/simstudioai/sim/pull/7084/files#top
Show all changes 3 commits https://github.com/simstudioai/sim/pull/7084/files
34e7459 fix(provenance): classify a latched-but-empty registry's file writes … Aug 25, 2026 https://github.com/simstudioai/sim/pull/7084/commits/34e74592f8fcda557c94099e5099f76fbd90b1f6
63648ba fix(provenance): relax a latch to unrecorded only when no fault is on… Aug 25, 2026 https://github.com/simstudioai/sim/pull/7084/commits/63648ba12a1233faaaefed2361ca32ff11e1bdad
dc0d1fd fix(provenance): relax to unrecorded only for the dedicated absence r… Aug 25, 2026 https://github.com/simstudioai/sim/pull/7084/commits/dc0d1fd8d411206fc67258dfec1f4b999838bbd2
Clear filters https://github.com/simstudioai/sim/pull/7084/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/7084/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/7084/files
resolved-secret-trace-registry.test.ts https://github.com/simstudioai/sim/pull/7084/files#diff-6a951339566d1c8718b8d7e4776e3b8babd34c01fbbf1e095c2d7e1062abd39d
resolved-secret-trace-registry.ts https://github.com/simstudioai/sim/pull/7084/files#diff-2174fa12ceaf7c6220eeeb43e2c3a89f7716e471bbe9504b3a69996bbb96952a
files.test.ts https://github.com/simstudioai/sim/pull/7084/files#diff-f1bbe8402856087d9cd6d32aeba5e98ad0d208d6cc43d84bc9a8e3ee05d41d97
trace-store.ts https://github.com/simstudioai/sim/pull/7084/files#diff-fe3d0a8f11d559b284e0858ee61cbe42773223d4637adb2ddcb1a8b56a85c06f
workspace-file-secret-provenance.test.ts https://github.com/simstudioai/sim/pull/7084/files#diff-a135e689defc3929a9b013c97cea9f63ba19913b4bba84a760d2ea5399dcd920
workspace-file-secret-provenance.ts https://github.com/simstudioai/sim/pull/7084/files#diff-dc9f5d8bcbc26f92094970ec14aa86da31ab479567fc6c6997b5ba3bd839c998
apps/sim/executor/utils/resolved-secret-trace-registry.test.tshttps://github.com/simstudioai/sim/pull/7084/files#diff-6a951339566d1c8718b8d7e4776e3b8babd34c01fbbf1e095c2d7e1062abd39d
View file https://github.com/simstudioai/sim/blob/dc0d1fd8d411206fc67258dfec1f4b999838bbd2/apps/sim/executor/utils/resolved-secret-trace-registry.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/7084/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/7084/files#diff-6a951339566d1c8718b8d7e4776e3b8babd34c01fbbf1e095c2d7e1062abd39d
https://github.com/simstudioai/sim/pull/7084/files#diff-6a951339566d1c8718b8d7e4776e3b8babd34c01fbbf1e095c2d7e1062abd39d
apps/sim/executor/utils/resolved-secret-trace-registry.tshttps://github.com/simstudioai/sim/pull/7084/files#diff-2174fa12ceaf7c6220eeeb43e2c3a89f7716e471bbe9504b3a69996bbb96952a
View file https://github.com/simstudioai/sim/blob/dc0d1fd8d411206fc67258dfec1f4b999838bbd2/apps/sim/executor/utils/resolved-secret-trace-registry.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/7084/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/7084/files#diff-2174fa12ceaf7c6220eeeb43e2c3a89f7716e471bbe9504b3a69996bbb96952a
https://github.com/simstudioai/sim/pull/7084/files#diff-2174fa12ceaf7c6220eeeb43e2c3a89f7716e471bbe9504b3a69996bbb96952a
apps/sim/lib/copilot/request/tools/files.test.tshttps://github.com/simstudioai/sim/pull/7084/files#diff-f1bbe8402856087d9cd6d32aeba5e98ad0d208d6cc43d84bc9a8e3ee05d41d97
View file https://github.com/simstudioai/sim/blob/dc0d1fd8d411206fc67258dfec1f4b999838bbd2/apps/sim/lib/copilot/request/tools/files.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/7084/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/7084/files#diff-f1bbe8402856087d9cd6d32aeba5e98ad0d208d6cc43d84bc9a8e3ee05d41d97
https://github.com/simstudioai/sim/pull/7084/files#diff-f1bbe8402856087d9cd6d32aeba5e98ad0d208d6cc43d84bc9a8e3ee05d41d97
apps/sim/lib/logs/execution/trace-store.tshttps://github.com/simstudioai/sim/pull/7084/files#diff-fe3d0a8f11d559b284e0858ee61cbe42773223d4637adb2ddcb1a8b56a85c06f
View file https://github.com/simstudioai/sim/blob/dc0d1fd8d411206fc67258dfec1f4b999838bbd2/apps/sim/lib/logs/execution/trace-store.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/7084/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/7084/files#diff-fe3d0a8f11d559b284e0858ee61cbe42773223d4637adb2ddcb1a8b56a85c06f
https://github.com/simstudioai/sim/pull/7084/files#diff-fe3d0a8f11d559b284e0858ee61cbe42773223d4637adb2ddcb1a8b56a85c06f
apps/sim/lib/uploads/contexts/workspace/workspace-file-secret-provenance.test.tshttps://github.com/simstudioai/sim/pull/7084/files#diff-a135e689defc3929a9b013c97cea9f63ba19913b4bba84a760d2ea5399dcd920
View file https://github.com/simstudioai/sim/blob/dc0d1fd8d411206fc67258dfec1f4b999838bbd2/apps/sim/lib/uploads/contexts/workspace/workspace-file-secret-provenance.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/7084/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/7084/files#diff-a135e689defc3929a9b013c97cea9f63ba19913b4bba84a760d2ea5399dcd920
https://github.com/simstudioai/sim/pull/7084/files#diff-a135e689defc3929a9b013c97cea9f63ba19913b4bba84a760d2ea5399dcd920
https://github.com/simstudioai/sim/pull/7084/files#diff-a135e689defc3929a9b013c97cea9f63ba19913b4bba84a760d2ea5399dcd920
apps/sim/lib/uploads/contexts/workspace/workspace-file-secret-provenance.tshttps://github.com/simstudioai/sim/pull/7084/files#diff-dc9f5d8bcbc26f92094970ec14aa86da31ab479567fc6c6997b5ba3bd839c998
View file https://github.com/simstudioai/sim/blob/dc0d1fd8d411206fc67258dfec1f4b999838bbd2/apps/sim/lib/uploads/contexts/workspace/workspace-file-secret-provenance.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/7084/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/7084/files#diff-dc9f5d8bcbc26f92094970ec14aa86da31ab479567fc6c6997b5ba3bd839c998
https://github.com/simstudioai/sim/pull/7084/files#diff-dc9f5d8bcbc26f92094970ec14aa86da31ab479567fc6c6997b5ba3bd839c998
https://github.com/simstudioai/sim/pull/7084/files#diff-dc9f5d8bcbc26f92094970ec14aa86da31ab479567fc6c6997b5ba3bd839c998
https://github.com/simstudioai/sim/pull/7084/files#diff-dc9f5d8bcbc26f92094970ec14aa86da31ab479567fc6c6997b5ba3bd839c998
Please reload this pagehttps://github.com/simstudioai/sim/pull/7084/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.