René's URL Explorer Experiment


Title: fix(timezone): consolidate table wall-clock conversion by j15z · Pull Request #7072 · simstudioai/sim · GitHub

Open Graph Title: fix(timezone): consolidate table wall-clock conversion by j15z · Pull Request #7072 · simstudioai/sim

X Title: fix(timezone): consolidate table wall-clock conversion by j15z · Pull Request #7072 · simstudioai/sim

Description: Summary Date and Expiration cells now share one wall-clock conversion path, so workspace and browser timezone changes cannot silently shift the stored instant. Invalid calendar rollovers are rejected. Nonexistent spring-forward wall times keep the existing scheduled-task and reporting behavior: they move forward by the DST gap, so 2:30 AM in New York becomes the real 3:30 AM instant. Expiration uses the later instant when a fall-back wall time occurs twice, while ordinary Date cells preserve their earlier-instant behavior. The row editor waits for the resolved timezone and freezes it for the open edit, preventing a settings refresh from changing the committed instant. This asymmetry prevents a row from being deleted before the local time the user selected. This is PR 3 of 4 in the row-expiration stack. It builds on the feature and global flag in PR #7071; PR #7161 adds row-delete triggers above it. Type of Change Bug fix New feature Breaking change Documentation Other: ___________ Testing The timezone/date/Expiration matrix runs under UTC, America/Los_Angeles, America/New_York, and Asia/Tokyo process timezones. Coverage includes New York, Berlin, and Lord Howe gaps and folds; Kathmandu and Lord Howe fractional-hour offsets; workspace timezone changes; browser fallback; localized input; invalid dates; and epoch round trips. Row-editor coverage proves submission waits for the saved timezone, keeps that timezone stable during an edit, and chooses the later repeated-hour instant for Expiration. At the restacked stack tip, 29 focused test files pass with 453 tests. bun run type-check, bun run lint:check, bun run check:api-validation, and bun run check:migrations origin/staging pass. Review focus: Expiration must choose the safe later instant for ambiguous times without changing existing Date semantics. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA) Screenshots/Videos No screenshots captured. Component tests cover the timezone-loading state and verify that editing waits for the resolved workspace or browser timezone. Post-Deploy Monitoring & Validation Logs/signals: Watch table-row validation failures and support reports that Date or Expiration values shifted after save, especially around DST transitions. Healthy: Saved values round-trip to the selected wall time, and the editor remains disabled until the workspace or browser timezone is ready. Failure: A reproducible hour shift, an early Expiration instant, or submission while timezone state is unresolved. Mitigation: Roll back this PR; disable row TTL if the failure can cause early deletion. Window and owner: Monitor for 24 hours after deployment and during the next DST-boundary validation; owner is the Tables feature owner.

Open Graph Description: Summary Date and Expiration cells now share one wall-clock conversion path, so workspace and browser timezone changes cannot silently shift the stored instant. Invalid calendar rollovers are reject...

X Description: Summary Date and Expiration cells now share one wall-clock conversion path, so workspace and browser timezone changes cannot silently shift the stored instant. Invalid calendar rollovers are reject...

Opengraph URL: https://github.com/simstudioai/sim/pull/7072

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:7a68a15b-c252-eebc-d575-1535dbb33b23
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAE36:283A10:1FD674:2DB66A:6AFB33E4
html-safe-noncedd5d3938e18257e7176ab9f9a7da0988d285bc7bc6a995c36921520fc9d549fd
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRTM2OjI4M0ExMDoxRkQ2NzQ6MkRCNjZBOjZBRkIzM0U0IiwidmlzaXRvcl9pZCI6IjgwMjQ3MDI2Njg0MTQ1OTYwNjkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac33240f344c52b718ce6ab003d7cffb82c105f4f070931375ad56e6de8c2fa4fc
hovercard-subject-tagpull_request:4360814824
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/7072/files
twitter:imagehttps://avatars.githubusercontent.com/u/96924014?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/96924014?s=400&v=4
og:image:altSummary Date and Expiration cells now share one wall-clock conversion path, so workspace and browser timezone changes cannot silently shift the stored instant. Invalid calendar rollovers are reject...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneefe184de15c1d8c1107a340cfc27bf7187b458dc07687ee1fa51f035148fb3d1
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasef567cf3af46b50a3211fb5dab569a9d6a7b58025
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/7072/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F7072%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F7072%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/7072/files
Reloadhttps://github.com/simstudioai/sim/pull/7072/files
Reloadhttps://github.com/simstudioai/sim/pull/7072/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests198 (198)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
j15zhttps://github.com/j15z
feat/table-row-ttlhttps://github.com/simstudioai/sim/tree/feat/table-row-ttl
refactor/consolidate-timezone-mathhttps://github.com/simstudioai/sim/tree/refactor/consolidate-timezone-math
Conversation 6 https://github.com/simstudioai/sim/pull/7072
Commits 7 https://github.com/simstudioai/sim/pull/7072/commits
Checks 48 https://github.com/simstudioai/sim/pull/7072/checks
Files changed https://github.com/simstudioai/sim/pull/7072/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/7072/files
fix(timezone): consolidate table wall-clock conversion https://github.com/simstudioai/sim/pull/7072/files#top
Show all changes 7 commits https://github.com/simstudioai/sim/pull/7072/files
3122ac3 fix(timezone): consolidate table wall-clock conversion j15z Aug 25, 2026 https://github.com/simstudioai/sim/pull/7072/commits/3122ac38d57bdbf79a378fbaeecba40770146cad
83f3da0 fix(timezone): preserve ambiguous date semantics j15z Aug 25, 2026 https://github.com/simstudioai/sim/pull/7072/commits/83f3da0273ac507048ed15195fe5b7ed1c5d0798
94ce6ba fix(tables): prevent early TTL expiration j15z Aug 27, 2026 https://github.com/simstudioai/sim/pull/7072/commits/94ce6ba5906bff68c1aa01c1bc0b3e2cd7571be1
81a0f87 fix(tables): wait for timezone before TTL edits j15z Aug 27, 2026 https://github.com/simstudioai/sim/pull/7072/commits/81a0f87c71506ec270220d8bda19315b7828e523
31cbcd9 improvement(tables): improve timezone loading state j15z Aug 27, 2026 https://github.com/simstudioai/sim/pull/7072/commits/31cbcd991b76dc8079dcb5f5d418186afdc1f635
d50fc5d test(tables): preserve editor timezone during edits j15z Aug 28, 2026 https://github.com/simstudioai/sim/pull/7072/commits/d50fc5d188b5b6287189b2d9c94019b7b94bacf0
e4bc00c fix(tables): guard row modal timezone edits j15z Aug 28, 2026 https://github.com/simstudioai/sim/pull/7072/commits/e4bc00cfb53a918f0ba5f95603a73774ad092b05
Clear filters https://github.com/simstudioai/sim/pull/7072/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/7072/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/7072/files
route.test.ts https://github.com/simstudioai/sim/pull/7072/files#diff-7465c9f203eb58fe2ba5902c5bc34827e9706639063cc3f4260ae44eba20fcb3
row-modal.test.tsx https://github.com/simstudioai/sim/pull/7072/files#diff-aa6ee345b22df305a938ce2b004ab0503cc63fb702c649b2b310c4203004d559
row-modal.tsx https://github.com/simstudioai/sim/pull/7072/files#diff-9986b620bc5f8be1944a82484bf46df8d123d4540fbfa93fbdf62354e42981af
inline-editors.test.ts https://github.com/simstudioai/sim/pull/7072/files#diff-f0f1706b238e8afadb65d1d3d6274fafa497d0080221d8ee38270f25c19a86d5
inline-editors.tsx https://github.com/simstudioai/sim/pull/7072/files#diff-71977816ed06f4cfda658b1747bf82f9524669ee7e3145b5d3945f651415f440
utils.test.ts https://github.com/simstudioai/sim/pull/7072/files#diff-0bd307c09a603056936092ca595b9a9c098bb334533bb56be4e27c1e82e05fc7
utils.ts https://github.com/simstudioai/sim/pull/7072/files#diff-939936b62a3584ab6f17b7d849abcb3f306e8fd2bce9ac0981b808040098dcd6
cleanup-table-row-ttl.test.ts https://github.com/simstudioai/sim/pull/7072/files#diff-6a3f65e8bc9c8a0a87bfbe4ab994f4a5b2e519d96eee63c106033202bc78770f
general-settings.test.ts https://github.com/simstudioai/sim/pull/7072/files#diff-da69c5e2b2b757efb137d7126fa5d74e7c42ff6376a973e1a6bb325ced67950a
general-settings.ts https://github.com/simstudioai/sim/pull/7072/files#diff-c2a8b3f8c395c761de7cc46262d31bf26dcde16bdb20cffbb3cc76d2847bfd04
timezone.test.ts https://github.com/simstudioai/sim/pull/7072/files#diff-bd7bf5132979f6f832376f290d443d91e80523df501fd32aa1787371b0335eac
timezone.ts https://github.com/simstudioai/sim/pull/7072/files#diff-a1ca09e725142895ca59a611aa7431f1126ab274a1d9660e1949d79f2fddd26f
column-type-registry.test.ts https://github.com/simstudioai/sim/pull/7072/files#diff-c6c5b12d8319fe12765c9cad013be69af49a552ada96bb3f42f8168f8ad1c626
ttl.test.ts https://github.com/simstudioai/sim/pull/7072/files#diff-852db68023063436024bfc60efd48fc28725e49c47ef1a335e7c5fbf51e9182c
ttl.ts https://github.com/simstudioai/sim/pull/7072/files#diff-bf0540abc25b782242c55b5893b500b5f17d3d723a109ac29543ac95eadbe94b
dates.test.ts https://github.com/simstudioai/sim/pull/7072/files#diff-71675f4d0ea9040c02b9b424d7a029556b17859b65d6da668b49f9a16bf3e401
dates.ts https://github.com/simstudioai/sim/pull/7072/files#diff-c6716a9dc0a3822fe93f10cea3a3a360f48bafca4b81bf52f02931b257e1af60
import.test.ts https://github.com/simstudioai/sim/pull/7072/files#diff-0ee513c4fdfad36c9fddadd81bf3712e6f29da25c25687e9d69cc71361f5bcdd
apps/sim/app/api/cron/cleanup-table-row-ttl/route.test.tshttps://github.com/simstudioai/sim/pull/7072/files#diff-7465c9f203eb58fe2ba5902c5bc34827e9706639063cc3f4260ae44eba20fcb3
View file https://github.com/simstudioai/sim/blob/e4bc00cfb53a918f0ba5f95603a73774ad092b05/apps/sim/app/api/cron/cleanup-table-row-ttl/route.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/7072/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/7072/files#diff-7465c9f203eb58fe2ba5902c5bc34827e9706639063cc3f4260ae44eba20fcb3
https://github.com/simstudioai/sim/pull/7072/files#diff-7465c9f203eb58fe2ba5902c5bc34827e9706639063cc3f4260ae44eba20fcb3
.../sim/app/workspace/[workspaceId]/tables/[tableId]/components/row-modal/row-modal.test.tsxhttps://github.com/simstudioai/sim/pull/7072/files#diff-aa6ee345b22df305a938ce2b004ab0503cc63fb702c649b2b310c4203004d559
View file https://github.com/simstudioai/sim/blob/e4bc00cfb53a918f0ba5f95603a73774ad092b05/apps/sim/app/workspace/%5BworkspaceId%5D/tables/%5BtableId%5D/components/row-modal/row-modal.test.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/7072/{{ revealButtonHref }}
apps/sim/app/workspace/[workspaceId]/tables/[tableId]/components/row-modal/row-modal.tsxhttps://github.com/simstudioai/sim/pull/7072/files#diff-9986b620bc5f8be1944a82484bf46df8d123d4540fbfa93fbdf62354e42981af
View file https://github.com/simstudioai/sim/blob/e4bc00cfb53a918f0ba5f95603a73774ad092b05/apps/sim/app/workspace/%5BworkspaceId%5D/tables/%5BtableId%5D/components/row-modal/row-modal.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/7072/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/7072/files#diff-9986b620bc5f8be1944a82484bf46df8d123d4540fbfa93fbdf62354e42981af
https://github.com/simstudioai/sim/pull/7072/files#diff-9986b620bc5f8be1944a82484bf46df8d123d4540fbfa93fbdf62354e42981af
https://github.com/simstudioai/sim/pull/7072/files#diff-9986b620bc5f8be1944a82484bf46df8d123d4540fbfa93fbdf62354e42981af
https://github.com/simstudioai/sim/pull/7072/files#diff-9986b620bc5f8be1944a82484bf46df8d123d4540fbfa93fbdf62354e42981af
https://github.com/simstudioai/sim/pull/7072/files#diff-9986b620bc5f8be1944a82484bf46df8d123d4540fbfa93fbdf62354e42981af
https://github.com/simstudioai/sim/pull/7072/files#diff-9986b620bc5f8be1944a82484bf46df8d123d4540fbfa93fbdf62354e42981af
https://github.com/simstudioai/sim/pull/7072/files#diff-9986b620bc5f8be1944a82484bf46df8d123d4540fbfa93fbdf62354e42981af
https://github.com/simstudioai/sim/pull/7072/files#diff-9986b620bc5f8be1944a82484bf46df8d123d4540fbfa93fbdf62354e42981af
https://github.com/simstudioai/sim/pull/7072/files#diff-9986b620bc5f8be1944a82484bf46df8d123d4540fbfa93fbdf62354e42981af
https://github.com/simstudioai/sim/pull/7072/files#diff-9986b620bc5f8be1944a82484bf46df8d123d4540fbfa93fbdf62354e42981af
https://github.com/simstudioai/sim/pull/7072/files#diff-9986b620bc5f8be1944a82484bf46df8d123d4540fbfa93fbdf62354e42981af
Please reload this pagehttps://github.com/simstudioai/sim/pull/7072/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/7072/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.